corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

247 Commits

Author SHA1 Message Date
Nika Layzell
b14d1318e0 Bug 1772006 - Part 4: Simplify and move the string comparison APIs from ns[T]StringObsolete, r=xpcom-reviewers,necko-reviewers,dragana,barret 
This patch moves EqualsIgnoreCase to ns[T]StringObsolete, and removes
the aCount argument, instead migrating callers to use `StringBeginsWith`
with a case-insensitive comparator.

In addition, nsTStringRepr::Compare was removed and replaced with either
calls to methods like `StringBeginsWith` or the global `Compare` method.

These changes required some modifications at call-sites but should make
the behaviour less surprising and more consistent.

Differential Revision: https://phabricator.services.mozilla.com/D148299
 2022-07-30 00:12:48 +00:00
Daisuke Akatsuka
930fb4e804 Bug 1749900: Refresh nsNavHistoryQueryResultNode when updating the dateAdded/lastModified. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D135824
 2022-01-13 11:04:05 +00:00
Daisuke Akatsuka
fc678d09d5 Bug 1746814: Refresh nsNavHistoryQueryResultNode when chaging the title. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D135322
 2022-01-12 00:33:21 +00:00
Daisuke Akatsuka
9e996b7457 Bug 1678607: Apply bookmark-tags-changed event. r=mak 
Depends on D128326

Differential Revision: https://phabricator.services.mozilla.com/D128327
 2021-10-18 04:43:44 +00:00
Alexandru Michis
6c614ebe26 Backed out 3 changesets (bug 1678607) for causing bc failures in browser_bookmark_add_tags.js 
Backed out changeset bf20be578758 (bug 1678607)
Backed out changeset fd3fbf15e95d (bug 1678607)
Backed out changeset 2688fa3d2bc2 (bug 1678607)
 2021-10-18 03:10:58 +03:00
Daisuke Akatsuka
7de5abf75b Bug 1678607: Apply bookmark-tags-changed event. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D128327
 2021-10-17 22:47:37 +00:00
Daisuke Akatsuka
859a723558 Bug 1678627: Apply bookmark-time-changed event. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D125925
 2021-10-07 22:10:20 +00:00
Daisuke Akatsuka
48273c63f4 Bug 1678624: Apply bookmark-url-changed event. r=mak 
Depends on D103883

Differential Revision: https://phabricator.services.mozilla.com/D103884
 2021-10-05 00:53:45 +00:00
Daisuke Akatsuka
d879fcb087 Bug 1678623: Apply bookmark-title-changed event. r=mak 
Depends on D103147

Differential Revision: https://phabricator.services.mozilla.com/D103148
 2021-10-01 12:01:29 +00:00
Greg Tatum
b8ffceebd3 Bug 1719550 - Unify collation in nsNavHistory.cpp; r=platform-i18n-reviewers,nordzilla 
This patch swaps out the nsCollation for the mozilla::intl::Collator. Note how
the options bag is now opinionated towards ECMA-402's Intl.Collator.

Differential Revision: https://phabricator.services.mozilla.com/D120526
 2021-08-10 16:01:16 +00:00
Narcis Beleuzu
58b02874e5 Backed out 12 changesets (bug 1719550) for bustages on TestCollator.cpp . CLOSED TREE 
Backed out changeset 3b2735a29138 (bug 1719550)
Backed out changeset 5e2019335244 (bug 1719550)
Backed out changeset 105676dd2d6f (bug 1719550)
Backed out changeset b4b0d58778e9 (bug 1719550)
Backed out changeset 3ef5792020bb (bug 1719550)
Backed out changeset 389a77da6ddc (bug 1719550)
Backed out changeset 48f39b5ef77f (bug 1719550)
Backed out changeset bd125cc5b9b4 (bug 1719550)
Backed out changeset a8b778ca2375 (bug 1719550)
Backed out changeset b14702168fb9 (bug 1719550)
Backed out changeset 7b46b5cc7424 (bug 1719550)
Backed out changeset 6b04162618a1 (bug 1719550)
 2021-08-10 17:46:34 +03:00
Greg Tatum
76a89aa829 Bug 1719550 - Unify collation in nsNavHistory.cpp; r=platform-i18n-reviewers,nordzilla 
This patch swaps out the nsCollation for the mozilla::intl::Collator. Note how
the options bag is now opinionated towards ECMA-402's Intl.Collator.

Differential Revision: https://phabricator.services.mozilla.com/D120526
 2021-08-10 11:46:36 +00:00
Daisuke Akatsuka
e17f7bc3a8 Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak 
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
 2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
9dd25c8501 Bug 1511062: Apply bookmark-moved event. r=mak 
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
 2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
d117f59c8f Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D102572
 2021-05-06 04:24:34 +00:00
Csoregi Natalia
ce52bc5e1a Backed out 4 changesets (bug 1511062) for causing bustage on nsNavHistoryResult.cpp. CLOSED TREE 
Backed out changeset ed9ac8c3097b (bug 1511062)
Backed out changeset dc8c9488cf1a (bug 1511062)
Backed out changeset 2cf6fca33bf3 (bug 1511062)
Backed out changeset 87b0bbbcb0e6 (bug 1511062)
 2021-05-06 05:53:12 +03:00
Daisuke Akatsuka
28b00086fd Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak 
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
 2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
cf9542ed5b Bug 1511062: Apply bookmark-moved event. r=mak 
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
 2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
43e96443cc Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D102572
 2021-05-06 02:29:43 +00:00
Daisuke Akatsuka
1ddf2461c7 Bug 1703332: Remove purge_caches listener before unlinking mRootNode.r=mak 
Until now, we have removed the listener for `purge_caches` on the destructor.
https://searchfox.org/mozilla-central/rev/ee9dab6aa95f167a34cb178960f7375210a0bba4/toolkit/components/places/nsNavHistoryResult.cpp#3482-3484
But, when closing, since  NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN will be called before calling the destructor, even if `mRootNode` is unlinked, might capture the `purge_caches` event.
https://searchfox.org/mozilla-central/rev/ee9dab6aa95f167a34cb178960f7375210a0bba4/toolkit/components/places/nsNavHistoryResult.cpp#3411
And in the case, it will crash due to touch the null object.
In this change, remove the listener before unlinking the `mRootNode` explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D111039
 2021-04-08 22:06:18 +00:00
Simon Giesecke
9e995a79e8 Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D108587
 2021-03-24 17:56:49 +00:00
Daisuke Akatsuka
e7392bea24 Bug 1694818: Handle plural batch processes properly. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D106586
 2021-03-01 00:34:55 +00:00
Simon Giesecke
95c38cc6b8 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika 
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
 2021-02-26 09:11:46 +00:00
Daisuke Akatsuka
dd7b0db1ba Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D105441
 2021-02-25 01:58:24 +00:00
Daisuke Akatsuka
c8e290bd3b Bug 897954: Implement and apply purge-caches mechanism. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D105440
 2021-02-25 01:58:23 +00:00
smolnar
34fc339425 Backed out 3 changesets (bug 897954) for causing node test failures in PlacesFeed. CLOSED TREE 
Backed out changeset 0a60eb3f7ba8 (bug 897954)
Backed out changeset 9443814d173b (bug 897954)
Backed out changeset 2e558ac8e419 (bug 897954)
 2021-02-25 03:21:58 +02:00
Daisuke Akatsuka
75041c3461 Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D105441
 2021-02-25 00:12:40 +00:00
Daisuke Akatsuka
0d58e35bd7 Bug 897954: Implement and apply purge-caches mechanism. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D105440
 2021-02-25 00:12:40 +00:00
Daisuke Akatsuka
dcf4ac9f01 Bug 1678618: Remove onDeleteURI and onDeleteVisits from nsINavHistoryObserver. r=mak 
Depends on D101115

Differential Revision: https://phabricator.services.mozilla.com/D101118
 2021-02-15 08:04:15 +00:00
Daisuke Akatsuka
46c5bd7203 Bug 1678618: Apply page-removed event. r=mak 
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
 2021-02-15 08:04:15 +00:00
Csoregi Natalia
9ef5ee3b2c Backed out 4 changesets (bug 1678618) for node failures. CLOSED TREE 
Backed out changeset e714440f6c0d (bug 1678618)
Backed out changeset ae83fda183dd (bug 1678618)
Backed out changeset bef0ea72ded8 (bug 1678618)
Backed out changeset ec96259a3f81 (bug 1678618)
 2021-02-15 05:49:54 +02:00
Daisuke Akatsuka
51d2022a23 Bug 1678618: Remove onDeleteURI and onDeleteVisits from nsINavHistoryObserver. r=mak 
Depends on D101115

Differential Revision: https://phabricator.services.mozilla.com/D101118
 2021-02-15 02:47:39 +00:00
Daisuke Akatsuka
62240408ac Bug 1678618: Apply page-removed event. r=mak 
Depends on D101114

Differential Revision: https://phabricator.services.mozilla.com/D101115
 2021-02-15 02:47:38 +00:00
Daisuke Akatsuka
35ef1884aa Bug 1678619: Remove onManyFrecenciesChanged interface from nsINavHistoryService. r=mak 
Depends on D100460

Differential Revision: https://phabricator.services.mozilla.com/D100461
 2021-01-21 15:51:03 +00:00
Daisuke Akatsuka
f9570663ae Bug 1678619: Remove onFrecencyChanged interface from nsINavHistoryService. r=mak 
Depends on D100457

Differential Revision: https://phabricator.services.mozilla.com/D100458
 2021-01-21 15:51:02 +00:00
smolnar
31e98dcbe5 Backed out 6 changesets (bug 1678619) on suspicion of causing crashes (bug 1687914). a=backout DONTBUILD 
Backed out changeset c8b691b8e793 (bug 1678619)
Backed out changeset 37b2f438bd2b (bug 1678619)
Backed out changeset 0a92dfd99dac (bug 1678619)
Backed out changeset 2043a28e668e (bug 1678619)
Backed out changeset 53e385030d67 (bug 1678619)
Backed out changeset 9a1d599b4060 (bug 1678619)
 2021-01-21 17:25:23 +02:00
Daisuke Akatsuka
282589d38e Bug 1678619: Remove onManyFrecenciesChanged interface from nsINavHistoryService. r=mak 
Depends on D100460

Differential Revision: https://phabricator.services.mozilla.com/D100461
 2021-01-19 06:03:07 +00:00
Daisuke Akatsuka
44bd319739 Bug 1678619: Remove onFrecencyChanged interface from nsINavHistoryService. r=mak 
Depends on D100457

Differential Revision: https://phabricator.services.mozilla.com/D100458
 2021-01-15 11:00:22 +00:00
Butkovits Atila
eea2b43ef3 Backed out 5 changesets (bug 1678619) for causing memory leaks. CLOSED TREE 
Backed out changeset 64be4bea09dd (bug 1678619)
Backed out changeset 308fda30c166 (bug 1678619)
Backed out changeset efb9bdef89b8 (bug 1678619)
Backed out changeset d26f45eac0b9 (bug 1678619)
Backed out changeset b2f22d6d2725 (bug 1678619)
 2021-01-15 12:56:01 +02:00
Daisuke Akatsuka
159a03d119 Bug 1678619: Remove onManyFrecenciesChanged interface from nsINavHistoryService. r=mak 
Depends on D100460

Differential Revision: https://phabricator.services.mozilla.com/D100461
 2021-01-15 00:00:34 +00:00
Daisuke Akatsuka
be8b6cc205 Bug 1678619: Remove onFrecencyChanged interface from nsINavHistoryService. r=mak 
Depends on D100457

Differential Revision: https://phabricator.services.mozilla.com/D100458
 2021-01-12 10:45:50 +00:00
Daisuke Akatsuka
e540566098 Bug 1678606: Remove onClearHistory interface from nsINavHistoryService. r=mixedpuppy,mak 
Depends on D99751

Differential Revision: https://phabricator.services.mozilla.com/D99752
 2020-12-23 11:15:20 +00:00
Daisuke Akatsuka
0675b8e87e Bug 1678606: Apply history-cleared event instead of onClearHistory. r=mixedpuppy,mak 
Depends on D99750

Differential Revision: https://phabricator.services.mozilla.com/D99751
 2020-12-23 10:21:54 +00:00
Daisuke Akatsuka
880d92c660 Bug 1678611: Remove onTitleChanged interface from nsINavHistoryService. r=mak,mixedpuppy 
Depends on D98280

Differential Revision: https://phabricator.services.mozilla.com/D98281
 2020-12-18 07:25:49 +00:00
Daisuke Akatsuka
3e263466ee Bug 1678611: Apply page-title-changed event instead of onTitleChanged. r=mak,mixedpuppy 
Depends on D98278

Differential Revision: https://phabricator.services.mozilla.com/D98280
 2020-12-16 08:28:54 +00:00
Marco Bonardo
4afae3b310 Bug 1677408 - Part 7 - Allow the view to opt-out of history details updates. r=Standard8 
In most cases bookmarks views don't need to be notified of history changes.
The only cases where they need that, is when history columns are visible in a
tree view, or the result is sorted by visits or frecency.
Thus, the menu and toolbar views can often save some work by not listening.

Differential Revision: https://phabricator.services.mozilla.com/D97280
 2020-11-23 16:29:54 +00:00
Marco Bonardo
5fee7240ed Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8 
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
 2020-11-23 16:28:04 +00:00
Marco Bonardo
f27614a727 Bug 1677408 - Part 3 - Clean up bookmarks observer tracking in nsNavHistoryResult. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D97276
 2020-11-23 16:26:30 +00:00
Marco Bonardo
c1aa2fcc37 Bug 1677408 - Part 2 - Update consumers of onPageChanged. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D97275
 2020-11-23 16:26:17 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE 
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
 2020-11-23 16:49:31 +02:00