Commit Graph

101 Commits

Author SHA1 Message Date
Barret Rennie
a39aef0e3c Bug 1787944 - Only cleanup the experiment that was enrolled in NimbusTestUtils.enrollmentHelper r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D155885
2022-09-02 19:31:36 +00:00
Sandor Molnar
41f7f7fd1c Backed out changeset 54c8b5fb832f (bug 1773583) for causing browser-chrome failures in browser/components/newtab/test/browser/browser_aboutwelcome_multistage_experimentAPI.js 2022-08-03 20:55:57 +03:00
Charlie Humphreys
2332e40702 Bug 1773583 - remove stub of enrollmentPromise from nimbus' ExperimentFakes r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152926
2022-08-03 16:14:31 +00:00
Marian-Vasile Laza
8fc79a7e47 Backed out changeset d2c5a2aba1d2 (bug 1773583) for causing bc failures on browser_asrouter_remoteimages.js. CLOSED TREE 2022-08-03 02:15:01 +03:00
Charlie Humphreys
2f43f7b47c Bug 1773583 - remove stub of enrollmentPromise from nimbus' ExperimentFakes r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152926
2022-08-02 20:23:58 +00:00
Barret Rennie
d49d4f6987 Bug 1743570 - Remove FeatureAPI.isEnabled r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D150693
2022-07-12 10:04:38 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Mathieu Leplatre
d350d35614 Bug 1772136 - Add option to throw if .get() fails to obtain records r=gbeckley,barret
Differential Revision: https://phabricator.services.mozilla.com/D148637
2022-07-06 07:31:29 +00:00
Barret Rennie
98d08be0a0 Bug 1774022 - Validate features described with FML variables more strictly r=TravisLong
Experimenter now performs the following additional validations:

- FML `int` field types are mapped to `integer` and not `number`; and
- `additionalProperties` is now false;


We now perform the same validation.

Differential Revision: https://phabricator.services.mozilla.com/D149146
2022-06-23 23:44:30 +00:00
criss
1de8f2e94c Backed out changeset e8d5e21007be (bug 1774022) for causing Xpcshell failures on test_RemoteSettingsExperimentLoader_updateRecipes.js. CLOSED TREE 2022-06-21 22:59:14 +03:00
Barret Rennie
ed46037a26 Bug 1774022 - Validate features described with FML variables more strictly r=TravisLong
Experimenter now performs the following additional validations:

- FML `int` field types are mapped to `integer` and not `number`; and
- `additionalProperties` is now false;


We now perform the same validation.

Differential Revision: https://phabricator.services.mozilla.com/D149146
2022-06-21 19:20:43 +00:00
Barret Rennie
e09c453de1 Bug 1746458 - Unenroll from Nimbus experiments and rollouts when disabling telemetry r=emcminn,preferences-reviewers
The telemetry pref (datareporting.healthreport.uploadEnabled) is now required
to be set to enroll in telemetry and if it becomes unset, users will be
unenrolled from all Nimbus experiments and rollouts.

Differential Revision: https://phabricator.services.mozilla.com/D149297
2022-06-20 15:29:14 +00:00
Travis Long
b9fc17fbde Bug 1754527 - Nimbus should call the Glean Experiment API r=chutten,barret
Differential Revision: https://phabricator.services.mozilla.com/D145911
2022-05-17 13:51:55 +00:00
criss
9c35b9b500 Backed out 2 changesets (bug 1754527) for turning Bug 1760130 into permafail on windows. CLOSED TREE
Backed out changeset 24ae57f9c2bb (bug 1754527)
Backed out changeset 93e08f7a934a (bug 1754527)
2022-05-11 23:12:05 +03:00
Travis Long
6e32825e20 Bug 1754527 - Adds test coverage for Glean experiment API to browser_remotesettingsexperimentloader_remote_default.js r=barret
Differential Revision: https://phabricator.services.mozilla.com/D145965
2022-05-10 23:19:16 +00:00
Mathieu Leplatre
9c4746ef13 Bug 1767890 - Prevent packaged dump from being loaded r=robwu
Change tests and snippets in documentation to use `Date.now()` instead of an arbitrary number like `42`.
This way, we make sure the packaged dump isn't loaded on top of the tests data. Indeed, since Bug 1718083 we load the packaged dump if it's newer than local data.

Differential Revision: https://phabricator.services.mozilla.com/D145579
2022-05-10 09:51:50 +00:00
Barret Rennie
c1e132a0a3 Bug 1759039 - Replace Ajv with JsonSchema.jsm in toolkit/components/nimbus/test r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D142876
2022-04-06 17:07:34 +00:00
Barret Rennie
2160cfe2a5 Bug 1762947 - Validate all branches when using variables-only features r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D142863
2022-04-04 18:26:03 +00:00
Gijs Kruitbosch
edda40141b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8 Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
1214ac636b Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
Barret Rennie
ace0a315bf Bug 1761105 - Validate Nimbus features using variables instead of schemas r=emcminn
Not all features are complicated enough to require full on JSON schema to
describe their variables. For these simpler features, we generate (a lax) JSON
schema based on the contents of their `variables` field to validate them. This
way we can re-use the existing validation mechanism and do not have to write a
bespoke validator.

The schema generated is intended to be compatible with the one generated by
Experimenter.

Differential Revision: https://phabricator.services.mozilla.com/D141892
2022-03-28 16:14:05 +00:00
Barret Rennie
6e0406c0f8 Bug 1752665 - Validate experiment features where we have schemas r=andreio
A test that tested featureless experiments has been removed, as the experiment
schema dictates that one of `feature` or `features` is required.

Tests have been updated to match the in-tree schema, as they previously did not
validate.

Differential Revision: https://phabricator.services.mozilla.com/D138928
2022-03-25 00:01:21 +00:00
Barret Rennie
62bcac7009 Bug 1757778 - Update NimbusEnrollment schema based off updated NimbusExperiment schema r=emcminn
The result of ExperimentFakes.recipe() has been updated to match the updated schema.

Some unit tests have been updated to pass with the updated schema.

Differential Revision: https://phabricator.services.mozilla.com/D140760
2022-03-25 00:01:19 +00:00
Andrei Oprea
79b5bb3d6b Bug 1738286 - New schema and enrollment flow for rollouts r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D129835
2021-12-09 17:58:18 +00:00
Andrei Oprea
a3609d96f7 Bug 1733357 - Expose Nimbus API to all platforms r=necko-reviewers,valentin,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D127938
2021-10-21 13:48:04 +00:00
Iulian Moraru
6225146ee9 Backed out changeset 6abb8df4efef (bug 1733357) for causing android gtest failures. CLOSED TREE 2021-10-21 05:18:17 +03:00
Andrei Oprea
74e3d58346 Bug 1733357 - Expose Nimbus API to all platforms r=necko-reviewers,valentin,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D127938
2021-10-20 17:30:59 +00:00
Alexandru Michis
755bfab0bc Backed out changeset eb276ce17c77 (bug 1733357) for causing bustages in nsHttpHandler.cpp
CLOSED TREE
2021-10-20 19:01:36 +03:00
Andrei Oprea
8c782b9ee4 Bug 1733357 - Expose Nimbus API to all platforms r=necko-reviewers,valentin,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D127938
2021-10-20 12:47:34 +00:00
Andrei Oprea
52681e1e34 Bug 1730924 - Upgrade ajv.js from 4.1.1 to 6.12.6 r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D127625
2021-10-12 19:41:05 +00:00
Alexandru Michis
b0d4c86fd7 Backed out changeset 837ba61b9975 (bug 1730924) for causing xpcshell failures in services/sync.
CLOSED TREE
2021-10-12 20:13:05 +03:00
Andrei Oprea
256aaa4763 Bug 1730924 - Upgrade ajv.js from 4.1.1 to 6.12.6 r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D127625
2021-10-12 14:43:02 +00:00
Andrei Oprea
28d88d09f4 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 19:45:17 +00:00
Alexandru Michis
7b49cf4e2e Backed out changeset 5d92bd37605f (bug 1732724) for causing xpcshell failures in test_targeting.js
CLOSED TREE
2021-10-07 21:16:39 +03:00
Andrei Oprea
67bd2df2f9 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 17:10:27 +00:00
Butkovits Atila
ca081ef18a Backed out changeset bbea0c20d7fe (bug 1732724) for causing Xpcshell failures at test_targeting.js. CLOSED TREE 2021-10-07 19:29:34 +03:00
Andrei Oprea
44e77f3182 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 15:31:29 +00:00
Butkovits Atila
ab55bbe571 Backed out changeset 35d10fc51b62 (bug 1732724) for causing failures at test_targeting.js. CLOSED TREE 2021-10-07 17:17:15 +03:00
Andrei Oprea
3b9f764fb8 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 12:42:10 +00:00
Kate Hudson
8b01a6e8b3 Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-13 14:35:15 +00:00
Andrei Oprea
e0eee6b96e Bug 1728990 - Require exposure event description in FeatureManifest r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D124657
2021-09-09 13:43:05 +00:00
Alexandru Michis
3545735fad Backed out changeset 92b9d5110599 (bug 1728843) for causing bc failures in browser_urlbar_telemetry_quicksuggest.js
CLOSED TREE
2021-09-09 04:23:16 +03:00
Kate Hudson
b2443171ec Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Depends on D123763

Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-09 00:20:56 +00:00
Marian-Vasile Laza
05790a73b8 Backed out changeset 47b9c109e74c (bug 1728843) for causing bc failures on browser_urlbar_telemetry_quicksuggest.js. CLOSED TREE 2021-09-07 18:45:09 +03:00
Kate Hudson
baec809c24 Bug 1728843 - Add once option to NimbusFeatures.recordExposureEvent r=andreio
Depends on D123763

Differential Revision: https://phabricator.services.mozilla.com/D124381
2021-09-07 13:49:51 +00:00
Andrei Oprea
8e437b2d9b Bug 1726190 - Implement multi-feature enrollment support for Nimbus r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D123139
2021-09-06 16:04:19 +00:00
Cristian Tuns
de1d067df5 Backed out changeset 7e1711f0f949 (Bug 1726190) for causing mochitest failures on browser_autocomplete_import.js. CLOSED TREE 2021-09-06 11:02:58 -04:00