Commit Graph

373 Commits

Author SHA1 Message Date
Cosmin Sabou
87e3afb738 Backed out changeset d3302226f71f (bug 1790790) for casuing xpcshell failures on test_defaultEngine_experiments.js. CLOSED TREE 2022-09-24 00:01:57 +03:00
Dale Harvey
ee07814dbd Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D157605
2022-09-23 19:15:34 +00:00
Barret Rennie
edef31f33b Bug 1791163 - Allow additional variables when validating features that are variables-only r=jlockhart
Differential Revision: https://phabricator.services.mozilla.com/D157736
2022-09-20 17:06:33 +00:00
Gavin Suntop
ef474996c0 Bug 1789703 - Extra cleanup for old save to pocket code r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157141
2022-09-14 18:44:44 +00:00
Barret Rennie
cc4effe4c1 Bug 1784100 - Override aboutwelcome.templateMR feature with majorRelease 2022 r=pdahiya
I also cleaned up browser_aboutwelcome_multistage_mr.js so that each task is
idempotent and does not pollute the state of other tasks (e.g., by leaving
prefs set).

Differential Revision: https://phabricator.services.mozilla.com/D155886
2022-09-12 20:37:16 +00:00
Ben Hearsum
5f9ef20b27 Bug 1782295: Rename private window separation pref. r=pbz
I don't see any reason to keep this under the same namespace as the other former `privacySegmentation` prefs - but perhaps I'm missing something here.

Depends on D156733

Differential Revision: https://phabricator.services.mozilla.com/D156734
2022-09-08 13:09:11 +00:00
Ben Hearsum
10f8b771ac Bug 1782295: Use Nimbus for Felt Privacy window separation r=dao
We'll be defaulting Felt Privacy features to enabled, and allowing them to be disabled by Nimbus (primarily for a holdback study).

Differential Revision: https://phabricator.services.mozilla.com/D153275
2022-09-08 13:09:10 +00:00
Barret Rennie
a39aef0e3c Bug 1787944 - Only cleanup the experiment that was enrolled in NimbusTestUtils.enrollmentHelper r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D155885
2022-09-02 19:31:36 +00:00
scott
f6f3f62d0c Bug 1788063 - Pocket newtab pref to hide Pocket story descriptions based on region. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D156235
2022-09-02 16:55:40 +00:00
Katherine Patenio
5061ac8cb5 Bug 1767827: Use Nimbus feature (with pref fallback) as the condition for enabling Firefox View r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156004
2022-09-02 15:45:21 +00:00
Barret Rennie
bc3645fa1e Bug 1786913 - Update nimbus-shared to v1.9.0 r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D155510
2022-09-02 15:32:45 +00:00
Barret Rennie
aa84a91121 Bug 1762623 - Vendor nimbus-shared via moz.yaml r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D155509
2022-09-02 15:32:45 +00:00
scott
0bca9c36bf Bug 1787522 - Pocket newtab limit save to Pocket card hover button to specific regions. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155771
2022-08-31 21:45:18 +00:00
Amy Churchwell
a088718bdf Bug 1778362 - Set up holdback study for Colorway Closet. r=dao,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D153120
2022-08-26 18:55:00 +00:00
Cristian Tuns
eb9e313a06 Backed out 3 changesets (bug 1782295) for causing Assertion failures on nsDirectoryService.cpp CLOSED TREE
Backed out changeset b332385ffca4 (bug 1782295)
Backed out changeset 8c36812a12dc (bug 1782295)
Backed out changeset 8016b1f25509 (bug 1782295)
2022-08-26 11:50:40 -04:00
Ben Hearsum
e7a783ab6f Bug 1782295: Use Nimbus for Felt Privacy window separation r=dao
We'll be defaulting Felt Privacy features to enabled, and allowing them to be disabled by Nimbus (primarily for a holdback study).

Differential Revision: https://phabricator.services.mozilla.com/D153275
2022-08-26 14:50:13 +00:00
Paul Zuehlcke
b036de13fc Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
2022-08-25 11:17:39 +00:00
Csoregi Natalia
e3f9334317 Backed out changeset 56c6e1791c69 (bug 1782295) for causing failures on browser_startup_mainthreadio.js. CLOSED TREE 2022-08-24 13:29:08 +03:00
Ben Hearsum
162414ff92 Bug 1782295: Use Nimbus for Felt Privacy window separation r=dao
We will be defaulting Felt Privacy features to enabled, and allowing them to be disabled by Nimbus (primarily for a holdback study).

Differential Revision: https://phabricator.services.mozilla.com/D153275
2022-08-23 15:30:42 +00:00
ahochheiden
e2305a79d3 Bug 1785976 - Make encoding explicitly utf-8 to resolve an issue on Korean Windows r=barret
Differential Revision: https://phabricator.services.mozilla.com/D155100
2022-08-19 20:19:00 +00:00
Drew Willcoxon
97fe6af105 Bug 1785743 - Expose Merino's endpoint to Nimbus. r=nanj
Turns out I added this same `merinoEndpointURL` variable back in D123707 but
removed it from the final version. But I forgot to remove the corresponding test
code [here](https://searchfox.org/mozilla-central/rev/bce4b0be48762f15a1ad2ab52b6bdd42f5b0f0e1/browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_configuration.js#111-120), so this is actually already tested. Apparently
`ExperimentFakes.enrollWithFeatureConfig()` lets you set values for Nimbus
variables that don't exist and it just works.

I forgot to remove the similar `merinoEndpointParamQuery` variable from the test
too, so I've removed that now. It's not declared in FeatureManifest or used
anywhere.

This also updates the Nimbus owner for `urlbar` to the new team email address.

Differential Revision: https://phabricator.services.mozilla.com/D155028
2022-08-18 23:58:25 +00:00
Amy Churchwell
411bbc1fc0 Bug 1783942 - Add empty variables field to MR 2022 feature. r=jlockhart
Differential Revision: https://phabricator.services.mozilla.com/D154672
2022-08-15 18:16:51 +00:00
Nick Alexander
7e987a7e1b Bug 1784117 - Lift default profile targeting to Nimbus in background tasks. r=barret
This was oversight.  In background tasks, I took some care to provide
the snapshot of the default profile's targeting state to the Firefox
Messaging System, but it also needs to be provided to Nimbus to filter
experiments directly.

For expedience, I provide an extra targeting context object to
`ExperimentManager.onStartup`.

The targeting contexts for Nimbus proper and Firefox Messaging System
are somewhat independent; that's why the triggering context remains in
the invocation of `sendTriggerMessage`.

Depends on D154308

Differential Revision: https://phabricator.services.mozilla.com/D154309
2022-08-11 17:39:53 +00:00
Amy Churchwell
6e376b3de9 Bug 1783942 - Add MR 2022 feature to FeatureManifest. r=dao,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154160
2022-08-11 17:18:10 +00:00
Barret Rennie
b190cb5669 Bug 1780618 - Remove fallbackPref overrides from Nimbus features r=emcminn
The fallbackPref was previously supplying both default values (from the default
branch) and override values (from the user branch), which means prefs could
override experiment values. Now the fallbackPref solely supplies fallback
values (from user or default branch).

Differential Revision: https://phabricator.services.mozilla.com/D153131
2022-08-09 17:48:07 +00:00
Barret Rennie
d8aa23c948 Bug 1782136 - Filter Nimbus recipes based on app ID r=emcminn,nalexander
Nimbus features can now specify a list of applications they support (defaulting
to firefox-desktop). Enrollment for a given recipe will only occur if the
application supports all the features listed in the experiment. This allows
Firefox Desktop and the background task service to have different sets of
features, which prevents Firefox from enrolling in backgroundTaskMessage
experiments and the background task service from enrolling in experiments
intended for Firefox Desktop.

Differential Revision: https://phabricator.services.mozilla.com/D153119
2022-08-04 21:43:15 +00:00
Cristian Tuns
bd6ead2fd7 Backed out changeset bb7262356afd (bug 1773583) for causing mochitest failures on browser_aboutwelcome_multistage_experimentAPI.js CLOSED TREE 2022-08-04 16:55:51 -04:00
Charlie Humphreys
f6a0c5024f Bug 1773583 - remove stub of enrollmentPromise from nimbus' ExperimentFakes r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152926
2022-08-04 20:10:01 +00:00
Sandor Molnar
41f7f7fd1c Backed out changeset 54c8b5fb832f (bug 1773583) for causing browser-chrome failures in browser/components/newtab/test/browser/browser_aboutwelcome_multistage_experimentAPI.js 2022-08-03 20:55:57 +03:00
Charlie Humphreys
2332e40702 Bug 1773583 - remove stub of enrollmentPromise from nimbus' ExperimentFakes r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152926
2022-08-03 16:14:31 +00:00
Sammy Khamis
d3364a2b35 Bug 1782155 - Switch sync-after-tab-change to be default on r=markh
Differential Revision: https://phabricator.services.mozilla.com/D153136
2022-08-03 01:31:06 +00:00
Marian-Vasile Laza
8fc79a7e47 Backed out changeset d2c5a2aba1d2 (bug 1773583) for causing bc failures on browser_asrouter_remoteimages.js. CLOSED TREE 2022-08-03 02:15:01 +03:00
Charlie Humphreys
2f43f7b47c Bug 1773583 - remove stub of enrollmentPromise from nimbus' ExperimentFakes r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152926
2022-08-02 20:23:58 +00:00
Nick Alexander
9482d9c43f Bug 1781953 - Send Glean telemetry events used by Nimbus in background-update pings. r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D152946
2022-08-02 17:33:48 +00:00
Joel Maher
0b37b77f65 Bug 1781782 - Run frequent xpcshell parallel failing tests sequential by default. r=ahal,necko-reviewers,extension-reviewers,application-update-reviewers,bytesized,rpl,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D153081
2022-07-30 01:33:28 +00:00
Mark Banner
93c97da63c Bug 1782192 - Fix ESLint no-unused-vars warnings in xpcshell-tests for toolkit. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D153164
2022-07-29 21:54:32 +00:00
Barret Rennie
13c6e5729b Bug 1776326 - Prefetch Remote Images when enrolling in experiments r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D151353
2022-07-27 14:33:43 +00:00
Emily McMinn
4aeb09f42f Bug 1780439 - Update FeatureManifest with team emails where possible r=barret
Differential Revision: https://phabricator.services.mozilla.com/D152784
2022-07-26 16:51:08 +00:00
Nick Alexander
770d26e84e Bug 1776514 - Allow background tasks to enable Nimbus and Firefox Messaging System. r=barret,bytesized
This commit does several things:

1.  It configures a new Nimbus feature and corresponding message group
    `backgroundTaskMessage`.

2.  It configures `Firefox Messaging Experiments` to use the new
    Nimbus feature in background tasks.  The existing Remote Settings
    collection `nimbus-desktop-experiments` continues to be used.

    These configurations are achieved by setting preferences in
    `backgroundtasks_browser.js`, which is applied on top of
    `firefox.js` prefs by the preference service.  These preferences
    apply to every background task.

3.  It implements functions for enabling Nimbus and the Firefox
    Messaging System (and Messaging Experiments) that can be used by
    arbitrary background tasks.

    It is assumed (but not enforced here) that such tasks will use
    non-ephemeral (persistent) profiles, so that Remote Settings
    incremental sync, Nimbus bucketing, and Messaging System message
    limits, function as expected.

4.  It adds a new `message` background task specifically for testing
    background task messages.  Invoke the testing task with command
    lines like `firefox --backgroundtask message ...`.

    To ease testing, the framework accepts `--url about:studies?...`
    arguments from the Experimenter Web UI to explicitly opt-in to
    specific experiment branches.

    This task is complicated because it is intended both for QA to
    manually invoke, but also to be used by automated tests.

Eventually the existing `backgroundupdate` task will use the new
functions, just as the testing `message` task does.

Differential Revision: https://phabricator.services.mozilla.com/D150521
2022-07-22 04:42:13 +00:00
Butkovits Atila
14acd83640 Backed out changeset e6ad35220e23 (bug 1776514) for causing failures at browser_all_files_referenced.js. CLOSED TREE 2022-07-22 07:06:35 +03:00
Nick Alexander
2d3f9c32f8 Bug 1776514 - Allow background tasks to enable Nimbus and Firefox Messaging System. r=barret,bytesized
This commit does several things:

1.  It configures a new Nimbus feature and corresponding message group
    `backgroundTaskMessage`.

2.  It configures `Firefox Messaging Experiments` to use the new
    Nimbus feature in background tasks.  The existing Remote Settings
    collection `nimbus-desktop-experiments` continues to be used.

    These configurations are achieved by setting preferences in
    `backgroundtasks_browser.js`, which is applied on top of
    `firefox.js` prefs by the preference service.  These preferences
    apply to every background task.

3.  It implements functions for enabling Nimbus and the Firefox
    Messaging System (and Messaging Experiments) that can be used by
    arbitrary background tasks.

    It is assumed (but not enforced here) that such tasks will use
    non-ephemeral (persistent) profiles, so that Remote Settings
    incremental sync, Nimbus bucketing, and Messaging System message
    limits, function as expected.

4.  It adds a new `message` background task specifically for testing
    background task messages.  Invoke the testing task with command
    lines like `firefox --backgroundtask message ...`.

    To ease testing, the framework accepts `--url about:studies?...`
    arguments from the Experimenter Web UI to explicitly opt-in to
    specific experiment branches.

    This task is complicated because it is intended both for QA to
    manually invoke, but also to be used by automated tests.

Eventually the existing `backgroundupdate` task will use the new
functions, just as the testing `message` task does.

Differential Revision: https://phabricator.services.mozilla.com/D150521
2022-07-22 03:16:43 +00:00
Barret Rennie
d1c621903b Bug 1780088 - Disable experiment schema validation with a pref r=emcminn
In the event that we ship schemas that fail validation unexpectedly, this gives
a remote kill switch via a Normandy pref rollout.

Differential Revision: https://phabricator.services.mozilla.com/D152342
2022-07-22 02:59:18 +00:00
Butkovits Atila
1aa2668d63 Backed out changeset b083e38b2ed9 (bug 1776514) for causing failure at browser_all_files_referenced.js. CLOSED TREE 2022-07-22 01:49:04 +03:00
Nick Alexander
c455022de9 Bug 1776514 - Allow background tasks to enable Nimbus and Firefox Messaging System. r=barret,bytesized
This commit does several things:

1.  It configures a new Nimbus feature and corresponding message group
    `backgroundTaskMessage`.

2.  It configures `Firefox Messaging Experiments` to use the new
    Nimbus feature in background tasks.  The existing Remote Settings
    collection `nimbus-desktop-experiments` continues to be used.

    These configurations are achieved by setting preferences in
    `backgroundtasks_browser.js`, which is applied on top of
    `firefox.js` prefs by the preference service.  These preferences
    apply to every background task.

3.  It implements functions for enabling Nimbus and the Firefox
    Messaging System (and Messaging Experiments) that can be used by
    arbitrary background tasks.

    It is assumed (but not enforced here) that such tasks will use
    non-ephemeral (persistent) profiles, so that Remote Settings
    incremental sync, Nimbus bucketing, and Messaging System message
    limits, function as expected.

4.  It adds a new `message` background task specifically for testing
    background task messages.  Invoke the testing task with command
    lines like `firefox --backgroundtask message ...`.

    To ease testing, the framework accepts `--url about:studies?...`
    arguments from the Experimenter Web UI to explicitly opt-in to
    specific experiment branches.

    This task is complicated because it is intended both for QA to
    manually invoke, but also to be used by automated tests.

Eventually the existing `backgroundupdate` task will use the new
functions, just as the testing `message` task does.

Differential Revision: https://phabricator.services.mozilla.com/D150521
2022-07-21 21:31:13 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
9e59e52e55 Bug 1780074 - Migrate newtab consumers to use ESM imports directly. r=daleharvey,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152114
2022-07-20 10:36:52 +00:00
Barret Rennie
c3996c0733 Bug 1762652 - Add detailed telemetry around schema validation in Nimbus r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D151195
2022-07-19 21:58:50 +00:00
Kagami Sascha Rosylight
ca146067a4 Bug 1769290 - Part 23: Apply mozilla-js-handle-rooted-typedef against toolkit misc r=extension-reviewers,kmag
Differential Revision: https://phabricator.services.mozilla.com/D151790
2022-07-14 17:00:24 +00:00
Emily McMinn
d8bee1c432 Bug 1737121 - Add owner prop to FeatureManifest r=barret,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D151320
2022-07-12 22:24:54 +00:00
Iulian Moraru
3df8b4fb3f Backed out changeset 033d8825f710 (bug 1762652) for causing multiple failures. CLOSED TREE 2022-07-12 22:21:40 +03:00