corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

69 Commits

Author SHA1 Message Date
Butkovits Atila
d974ae273d Backed out changeset f0bd843698b2 (bug 1765409) for causing failure at browser_creditCard_selected_attribute_does_not_change.js. CLOSED TREE 2022-09-08 22:48:10 +03:00
Tim Giles
1b36ec8c37 Bug 1765409 - Do not change the 'selected' attribute of option elements when autofilling. r=credential-management-reviewers,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D144433
 2022-09-08 15:24:45 +00:00
Dimi
6797aa6bdb Bug 1787162 - Treat form with cc-name and cc-exp field as a valid credit card form r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D155580
 2022-09-05 09:15:40 +00:00
Dimi
f290c944d0 Bug 1788621 - Add an extra rule to determine whether a form with only a cc-number field is a valid cc form r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D156165
 2022-09-02 10:18:24 +00:00
Noemi Erli
4672cb4140 Backed out changeset f3e5a79c5252 (bug 1788621) for causing failures in browser_creditCard_heuristics.js 2022-09-02 06:01:45 +03:00
Dimi
8edd1db6e0 Bug 1788621 - Add an extra rule to determine whether a form with only a cc-number field is a valid cc form r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D156165
 2022-09-01 22:09:07 +00:00
Dimi
d5789e420f Bug 1783129 - P1. Use a higher confidence threshold when determining whether a form with only a credit card number field as a valid cc section r=sgalich 
In nightly and early beta, we still use 0.5 as the threshold so we can collect more data.
In release, use 0.95 as the threshold

Differential Revision: https://phabricator.services.mozilla.com/D155486
 2022-08-29 06:44:32 +00:00
Dimi
ca3d9c21e1 Bug 1782535 - P1. Treat form contains only a credit card number field as a valid credit card form only in nightly and early beta r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D153581
 2022-08-03 15:38:20 +00:00
Dimi
238a7019e3 Bug 1775233 - P1. Consider credit card sections that contain only a credit card number field to be valid cc sections r=sgalich 
Before this patch, we consider credit card sections with only one cc-number
field to be valid sections ONLY IF its cc-number field has
"autocomplete=cc-number". In other words, if we infer the field is
a cc-number field because of our detection heuristic, the section
is considered to be invalid.

In this patch, we remove the "autocomplete=cc-number" constrain, which
means as long as a credit card section has a cc-number field, it is a
valid cc section.

Differential Revision: https://phabricator.services.mozilla.com/D151806
 2022-07-18 07:11:55 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
Mark Banner
55a94e6bc8 Bug 1771173 - Rework FormAutoFill's log creation to make it easier for linters to handle. r=sgalich 
This rewrites the lazy getters, so that the lazy getter is defined at the call point, which makes it
easier for linters to understand what is being defined.
In some cases, the log is not being used, so the definition code is removed.

Differential Revision: https://phabricator.services.mozilla.com/D149716
 2022-06-21 20:42:15 +00:00
Iulian Moraru
ad03aef826 Bug 1774385 - fix lint failures in FormAutofillHandler.jsm. CLOSED TREE r=fix 2022-06-20 12:48:02 +03:00
Anthony Hung
019dcb2f0e Bug 1774385 - Replace multiple ChromeUtils.defineModuleGetter call with one XPCOMUtils.defineLazyModuleGetters in Form Autofill. r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D149427
 2022-06-20 09:07:41 +00:00
Tooru Fujisawa
8dd914a53f Bug 1773829 - Part 8: Stop using lazy getter unnecessarily in toolkit/components/formautofill/. r=sgalich 
Depends on D149016

Differential Revision: https://phabricator.services.mozilla.com/D149017
 2022-06-15 20:56:24 +00:00
Tooru Fujisawa
cf5cf9b573 Bug 1772101 - Part 50: Use plain object for FormAutofill.defineLazyLogGetter in toolkit/components/formautofill/. r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D147991
 2022-06-07 04:31:07 +00:00
Tooru Fujisawa
9c60a283b8 Bug 1772101 - Part 20: Use plain object for lazy getter in toolkit/components/formautofill/. r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D147961
 2022-06-07 04:30:58 +00:00
Sergey Galich
cd8b1906ac Bug 1771841 - use HTMLInputElement.isInstance(field) instead of ChromeUtils.getClassName(field) === "HTMLInputElement". r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D147712
 2022-05-31 12:39:18 +00:00
Tim Giles
4da419b155 Bug 1743629 - Use adjacent label as placeholder format for cc-exp transformer. r=dimi,sgalich 
When there is a label element right before a credit card expiry input, we will try and parse this label
as a placeholder. This allows our autofill to work as expected in cases where
the label is not wrapped around the expiry input.

Differential Revision: https://phabricator.services.mozilla.com/D145026
 2022-05-06 18:00:20 +00:00
Tim Giles
6d906ceed4 Bug 1767130 - Fix default fill format for cc-exp-month input elements to MM. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D145493
 2022-05-06 16:09:01 +00:00
Tim Giles
c3d6a5b3bd Bug 1436793 - Don't autofill disabled fields. r=sgalich,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D144638
 2022-05-05 18:56:02 +00:00
Tim Giles
2d57fd5e09 Bug 1764709 - Always normalize credit card expiration month and year when creating a new record. r=geckoview-reviewers,dimi,sgalich,agi 
Differential Revision: https://phabricator.services.mozilla.com/D144055
 2022-05-02 18:18:39 +00:00
Molnar Sandor
87d5acd030 Backed out changeset 360f31b00167 (bug 1764709) for causing bc failures in browser_creditCard_submission_normalized. CLOSED TREE 2022-04-27 07:46:31 +03:00
Tim Giles
5155eeb268 Bug 1764709 - Always normalize credit card expiration month and year when creating a new record. r=geckoview-reviewers,dimi,sgalich,agi 
Differential Revision: https://phabricator.services.mozilla.com/D144055
 2022-04-26 21:53:17 +00:00
Tim Giles
1716553656 Bug 1748842 - Fix credit card not filling correctly on walmart.com. r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D143373
 2022-04-19 18:01:01 +00:00
Tim Giles
c3f1f5f6ba Bug 1758369 - Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi,sgalich,geckoview-reviewers,agi 
This fixes the cases where a website modifies the credit card number after it has been filled.

Differential Revision: https://phabricator.services.mozilla.com/D140858
 2022-04-05 15:46:02 +00:00
Tim Giles
5d1bbb4885 Bug 1760834 - Add missing cc-exp-month and cc-exp-year to credit card record when captured record contains cc-exp. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D141907
 2022-04-04 14:55:14 +00:00
Tim Giles
61ab42f86f Bug 1752198 - Respect readonly fields when previewing and filling from autofill. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D141669
 2022-04-04 13:57:41 +00:00
Csoregi Natalia
01ba6967fd Backed out changeset 7b32aee78e60 (bug 1758369) for credit card issues. CLOSED TREE 2022-03-24 22:01:49 +02:00
Tim Giles
4de62c6ef4 Bug 1758369 - Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi,sgalich 
This fixes the cases where a website modifies the credit card number after it has been filled.

Differential Revision: https://phabricator.services.mozilla.com/D140858
 2022-03-24 18:19:49 +00:00
Dimi
02ad0a2235 Bug 1757731 - P2. Add cc_form_v2 telemetry event to collect more detailed information r=sgalich,tgiles 
The previous `cc_form` event telemetry lack the following information:
1. Field-specific information.
  * cc-exp, cc-exp-month, and cc-exp-year are all merged to cc-exp
  * no cc-type
2. Clear form action

The `cc_form_v2` event telemetry aims to collect field specific
information so we can know whether we perform particular bad (or good)
on certain fields.

Differential Revision: https://phabricator.services.mozilla.com/D141009
 2022-03-23 09:07:28 +00:00
Dimi
f51ed420cf Bug 1757731 - P1. Move telemetry related function to FormAutofillTelemetryUtils.jsm r=sgalich,tgiles 
This patch adds CreditCardTelemetryUtils object to process credit card related telemetry.
This patches doesn't change the logic regarding how we record telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D141008
 2022-03-23 09:07:28 +00:00
Tim Giles
74a7107ac0 Bug 1740001 - Add cc exp year transformer, send input and change events when resetting select element via clear form. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D139026
 2022-03-16 14:01:57 +00:00
Tim Giles
162063a96d Bug 1753517 - Remove unneeded logging. r=sgalich,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D138044
 2022-02-08 22:23:08 +00:00
Tim Giles
685cd4d006 Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2022-02-08 19:31:58 +00:00
criss
554340009a Backed out changeset 690addca2aaa (bug 1753517) for causing Xpcshell failures 2022-02-08 17:56:39 +02:00
Tim Giles
259ac05f2a Bug 1753517 - Remove unneeded logging. r=sgalich,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D138044
 2022-02-08 14:49:09 +00:00
Iulian Moraru
e13fe3ef05 Backed out 4 changesets (bug 1745248) for causing issues with credit card sync. a=backout 
Backed out changeset 324a6acb8612 (bug 1745248)
Backed out changeset f54ce6b7dd26 (bug 1745248)
Backed out changeset c7212ce535e4 (bug 1745248)
Backed out changeset 06d57e874522 (bug 1745248)
 2022-02-03 00:50:29 +02:00
Tim Giles
c5cbdd8cd4 Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2022-01-26 20:11:41 +00:00
Cosmin Sabou
af66b13655 Backed out 3 changesets (Bug 1745248) for causing issues with FormAutofill.jsm. CLOSED TREE 
Backed out changeset b39b99edef97 (bug 1745248)
Backed out changeset b09a96820c2c (bug 1745248)
Backed out changeset 03dd6cedf996 (bug 1745248)
 2022-01-06 20:56:43 +02:00
Tim Giles
68cc118b29 Bug 1740070 - Reset <select> elements when autofilled form is cleared. r=sgalich,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D133213
 2022-01-05 21:56:50 +00:00
Tim Giles
c07db9e20a Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2021-12-17 21:41:22 +00:00
Sandor Molnar
f00947fe24 Backed out 3 changesets (bug 1745248) for causing bc failures in browser_first_time_use_doorhanger. CLOSED TREE 
Backed out changeset ef2454116a21 (bug 1745248)
Backed out changeset 8aeb5a348950 (bug 1745248)
Backed out changeset b1808ec2fe97 (bug 1745248)
 2021-12-17 21:12:27 +02:00
Tim Giles
c7cf4969d5 Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2021-12-17 18:25:25 +00:00
Tim Giles
3bd9b1ec1a Bug 1740446 - Fix credit card expiry placeholder logic when field is using 'j' to represent year. r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D131167
 2021-11-17 14:53:14 +00:00
Tim Giles
d717e970d4 Bug 1688576: Add workaround for cc-expiry being stored as 'YYYY-MM' when websites expect 'MM/YYYY'. r=dimi 
Changes the presentation format of expiry date to MM/YYYY so that Zalando's payment site doesn't break when we fill expiry dates.

Reorders the credit card transformers so that the expiry date transformer runs before the match select transformer.
This is to ensure the presentation form of expiry date (MM/YYYY) is used to create cached values for possible select element matches, as opposed to the underlying storage format of expiry date (YYYY-MM).

Because the 'profile' used in getAdaptedProfiles becomes a presentation ready form of the stored data, I've written a note explaining why the default test credit card record now has a expiry date format of 'MM/YYYY' as opposed to the old format.

Differential Revision: https://phabricator.services.mozilla.com/D125884
 2021-10-26 14:22:21 +00:00
Tim Giles Jr
08a40c5131 Bug 1735562 - Remove Nightly only gates for multiple cc-number field capture and autofill. r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D128642
 2021-10-18 13:43:49 +00:00
Tim Giles
8e0c611c6e Bug 1688607 - Enable autofill and capturing when there are multiple credit card number fields. r=sgalich 
Enable the feature only in Nightly.

Add functionality for previewing and autofilling into multiple cc-number fields.

Fix test_Lush.js case.

Add logic to handle credit card saving/update when multiple cc-number fields are present.

Add heuristic test for Lufthansa site.

Add test for filling cc-number when there are multiple cc-number fields in a form.

Add test for collecting multiple cc-number fields via collectFormFields.

Add multiple cc-number fields case to onFormSubmitted test.

Add multiple cc-number fields with maxlength=4 case to markAsAutofillField.

Add implementation of the preview and fill test cases for multiple cc-number fields.

Differential Revision: https://phabricator.services.mozilla.com/D127987
 2021-10-14 14:03:38 +00:00