Commit Graph

657 Commits

Author SHA1 Message Date
Luca Greco
60ca8d1f45 Bug 1790115 - allow static theme resources in other extensions also in private browsing windows. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D156986
2022-09-13 23:42:19 +00:00
Shane Caraveo
ef50590a13 Bug 1786564 allow access to static theme resources in extensions r=rpl,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D156618
2022-09-07 20:16:19 +00:00
Luca Greco
845fdf65ba Bug 1785898 - Cache into StartupCache a boolean flag to determine if there is any persisted content script. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D155256
2022-08-24 11:50:51 +00:00
William Durand
b974439308 Bug 1784254 - Make page_action and hidden mutually exclusive. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D154387
2022-08-16 06:59:46 +00:00
Rob Wu
265598bc62 Bug 1780747 - Register DNR schema and permissions r=rpl,geckoview-reviewers,owlish,flod
This patch adds the minimum necessary to register the
declarativeNetRequest API and its permissions, behind prefs.

Tests have been added/updated to verify that the permissions and API
access are enforced correctly (effectiveness of preferences, API
visibility, permission warnings).

Before landing this, we need to register the permission warning in
Android-Components too, as mentioned in the bug (i.e. bug 1671453).

Differential Revision: https://phabricator.services.mozilla.com/D152503
2022-08-09 12:16:34 +00:00
Cristian Tuns
fbb11ed710 Backed out 2 changesets (bug 1780747) for causing xpcshell failures on test_ext_permission_warnings.js CLOSED TREE
Backed out changeset be950e847c33 (bug 1780747)
Backed out changeset b07c7315a02a (bug 1780747)
2022-08-08 19:04:56 -04:00
Rob Wu
ae8baf4117 Bug 1780747 - Register DNR schema and permissions r=rpl,geckoview-reviewers,owlish,flod
This patch adds the minimum necessary to register the
declarativeNetRequest API and its permissions, behind prefs.

Tests have been added/updated to verify that the permissions and API
access are enforced correctly (effectiveness of preferences, API
visibility, permission warnings).

Before landing this, we need to register the permission warning in
Android-Components too, as mentioned in the bug (i.e. bug 1671453).

Differential Revision: https://phabricator.services.mozilla.com/D152503
2022-08-08 22:11:08 +00:00
William Durand
ffce796bdb Bug 1781998 - Make hidden and browser_action or action mutually exclusive. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D153924
2022-08-08 17:09:39 +00:00
William Durand
db8cec58d0 Bug 1751436 - Add support for persistAcrossSessions in scripting.RegisteredContentScript. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D147671
2022-08-04 09:09:07 +00:00
Kagami Sascha Rosylight
59ec59dca2 Bug 1354500 - Part 4: Remove indexedDB permission uses from scripts r=dom-storage-reviewers,rpl,asuth
Differential Revision: https://phabricator.services.mozilla.com/D151419
2022-07-15 01:55:28 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Mark Banner
0410ff3ddf Bug 1771173 - Clean up unused definitions of console in extension modules. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D149785
2022-06-21 20:42:15 +00:00
Luca Greco
c00557d1fd Bug 1773076 - theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D148539
2022-06-10 12:57:08 +00:00
Molnar Sandor
dd6b7dd8b2 Backed out changeset 3ec447f44180 (bug 1773076) for causing xpc failure in test_ext_theme_experiments and lint failure. CLOSED TREE 2022-06-09 20:08:32 +03:00
Luca Greco
8b3cdb4912 Bug 1773076 - theme_experiment should be allowed to addons installed non-temporarily on builds allowing disabled signature checks. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D148539
2022-06-09 16:34:50 +00:00
Magnus Melin
bc6aea545f Bug 1771908 - Make test_ext_schemas_privileged.js, test_ext_activityLog.js, test_ext_networkStatus.js tests succeed for Thunderbird. r=rpl
Thunderbird ships with experiments enabled.

Differential Revision: https://phabricator.services.mozilla.com/D148345
2022-06-08 10:23:18 +00:00
Tooru Fujisawa
18c50f5792 Bug 1772101 - Part 17: Use plain object for lazy getter in toolkit/components/extensions/. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D147958
2022-06-07 04:30:57 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 04:42:09 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 02:49:13 +00:00
Shane Caraveo
8a1c261452 Bug 1739114 Enforce addon privilege during manifest parsing for access to privileged features from temporarily installed addons. r=robwu,mixedpuppy,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D145687
2022-05-30 18:41:37 +00:00
Rob Wu
51fde98370 Bug 1766822 - Decouple WebExtensionPolicy update from BrowserExtensionContent r=willdurand,zombie
This ensures that WebExtensionPolicy is properly initialized even when
ExtensionProcessScript has not instantiated BrowserExtensionContent yet.

Differential Revision: https://phabricator.services.mozilla.com/D147331
2022-05-27 17:02:04 +00:00
Rob Wu
6158a0deca Bug 1766822 - Refactor, introduce updateAllowedOrigins r=willdurand
Introduce common updateAllowedOrigins helper to avoid repetition of
policy.allowedOrigins-updating logic in four places.

While there are no user-visible behavioral changes, the patch does fix a
small issue: previously policy.allowedOrigins could have multiple
MatchPattern instances with exactly the same pattern due to the
implementation in ExtensionChild, now the helper ensures that all
patterns are unique.

Differential Revision: https://phabricator.services.mozilla.com/D147330
2022-05-27 17:02:04 +00:00
Luca Greco
07a8ac1f65 Bug 1739114 - Moved privileged WebExtensions permissions in their own JSONSchema type and added a new custom privileged keyword on each privileged manifest fields. r=robwu,mixedpuppy
This patch includes only the subset of D145687 changes related to the reworked JSONSchema data, plus some minor changes to Schemas.jsm to take the new
JSONSchema type ("PrivilegedPermissions") and the new custom JSONSchema keyword (the boolean "privileged" property used to identify manifest fields
only allowed in privileged extensions).

Besides the changes to the schema data, this patch is not expected to introduce any difference in behavior and so it could also land on its own
if needed (and the rest of the changes landed separately).

Differential Revision: https://phabricator.services.mozilla.com/D146800
2022-05-20 08:55:03 +00:00
Luca Greco
2fab75125b Bug 1759300 - Cancel suspend on idle if the extension EventPage has StreamFilter instances still active. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D145257
2022-05-09 20:33:28 +00:00
Tomislav Jovanovic
2c346360f6 Bug 1745820 - Add controls for optional origins to about:addons permissions tab r=rpl,robwu
Differential Revision: https://phabricator.services.mozilla.com/D144070
2022-04-26 23:48:44 +00:00
Luca Greco
afca978f08 Bug 1748530 - Log a warning in the event page DevTools console panel when terminate on idle is ignored. r=mixedpuppy,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D143520
2022-04-14 19:54:32 +00:00
Shane Caraveo
d47baeee32 Bug 1748558 enforce requirement of id in menus apis for event pages r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D138489
2022-04-04 22:16:55 +00:00
Shane Caraveo
e617aad86f Bug 1753850 implement runtime.onSuspend for non-persistent background r=rpl,robwu
Differential Revision: https://phabricator.services.mozilla.com/D137950
2022-03-28 21:44:48 +00:00
Butkovits Atila
ca0650e33b Backed out changeset 8ca972dfa3d8 (bug 1753850) for causing Android Xpcshell failures. CLOSED TREE 2022-03-28 21:57:06 +03:00
Shane Caraveo
862d1d1f59 Bug 1753850 implement runtime.onSuspend for non-persistent background r=rpl,robwu
Differential Revision: https://phabricator.services.mozilla.com/D137950
2022-03-28 16:46:43 +00:00
Tomislav Jovanovic
5313d83bec Bug 1760526 - Save optional permission changes to sharedData for new processes r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D141566
2022-03-27 17:32:41 +00:00
Rob Wu
2f498cf5d0 Bug 1760146 - Remove XPIProvider.jsm usage from Extension.jsm r=mixedpuppy
Move the remaining uses to new methods of AddonManagerPrivate.

This is a refactor without behavioral changes. To achieve this
non-behavioral change, we use XPIProvider before its fully started,
in AddonManager.jsm + follow-up bugs to remove this potentially
undesired direct dependency on XPIProvider.

Differential Revision: https://phabricator.services.mozilla.com/D141442
2022-03-25 13:16:05 +00:00
Rob Wu
ea0b4c8ebf Bug 1757084 - Rename extension type langpack to locale r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D140049
2022-03-14 15:00:14 +00:00
Tomislav Jovanovic
32a2041243 Bug 1745818 - Treat host permissions as optional in mv3, r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D136225
2022-03-12 20:14:41 +00:00
Iulian Moraru
3250e71ab4 Backed out changeset 53b7b2117588 (bug 1745818) for causing mochitest failures on test_ext_scripting_executeScript.html. CLOSED TREE 2022-03-12 18:49:21 +02:00
Tomislav Jovanovic
5ac83fcb67 Bug 1745818 - Treat host permissions as optional in mv3, r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D136225
2022-03-12 15:51:40 +00:00
Shane Caraveo
a5b36ca82f Bug 1757855 fix background startup and persistent listeners during addon upgrades r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D140154
2022-03-10 01:08:56 +00:00
Butkovits Atila
be3b21fbf2 Backed out changeset c295e6801d39 (bug 1757855) for causing failures at RemoteProcessMonitor. CLOSED TREE 2022-03-09 04:02:34 +02:00
Shane Caraveo
86bde10827 Bug 1757855 fix background startup and persistent listeners during addon upgrades r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D140154
2022-03-09 01:02:50 +00:00
Andreea Pavel
3b5dd4b5b1 Backed out changeset d705f8e9b4ee (bug 1757855) for multiple failures on a CLOSED TREE 2022-03-08 22:36:39 +02:00
Shane Caraveo
7ebf794a14 Bug 1757855 fix background startup and persistent listeners during addon upgrades r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D140154
2022-03-08 18:57:29 +00:00
Rob Wu
ce857ef1bd Bug 1734987 - Part 3.1: Correct isPrivileged during updates r=rpl
During updates, isPrivileged was not set correctly, which resulted in
incorrect error messages (warnings about unsupported permissions) when a
privileged/builtin extension was updated (a variant of bug 1675858).

In the previous patch (part 3), isPrivileged was added to the
ExtensionData constructor, and also passed to BootstrapScope calls,
so we can use that here to.

The unit test here serves two purposes:
1. Primarily: test coverage for the correctness of isPrivileged in the
   update scenario.
2. Test coverage for the existence and order of ExtensionAPI's onUpdate
   calls. There is no unit test for this mechanism right now, only
   indirect tests.

Differential Revision: https://phabricator.services.mozilla.com/D131682
2022-02-27 13:23:57 +00:00
Rob Wu
a58177c8df Bug 1734987 - Part 3: Add isPrivileged to ExtensionData + test r=rpl
See https://bugzilla.mozilla.org/show_bug.cgi?id=1734987#c0 for the
description of the why and how of this patch.

Since isPrivileged is now supported on ExtensionData, this patch also
removes the work-arounds from bug 1675858.

Differential Revision: https://phabricator.services.mozilla.com/D128232
2022-02-27 13:23:57 +00:00
Rob Wu
62127f7c61 Bug 1734987 - Part 1: Replace isPrivileged with ExtensionData check for l10n_resources r=rpl
l10n_resources has bugs that results in errors when enabled for
ExtensionData. In this patch stack we are going to introduce the
isPrivileged property to ExtensionData.

To prevent these errors from being triggered when isPrivileged is added,
replace the `"isPrivileged" in this` check with a check against
`ExtensionData`.

l10n_resources support in ExtensionData will be added in bug 1733466.

Differential Revision: https://phabricator.services.mozilla.com/D128230
2022-02-27 13:23:56 +00:00
Shane Caraveo
e38cc78870 Bug 1753308 fix extension startup in tests, remove delayed startup pref r=rpl,robwu
Differential Revision: https://phabricator.services.mozilla.com/D137699
2022-02-19 15:52:26 +00:00
Shane Caraveo
afbca3636b Bug 1748524 sleep/waken functionality for background, restartable via persistent events r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D135812
2022-01-25 20:49:15 +00:00