Commit Graph

682 Commits

Author SHA1 Message Date
Matt Woodrow
1068719a1b Bug 1589270 - Part 3: Convert nsExternalHelperApp to use BrowsingContext instead of nsIInterfaceRequestor. r=bzbarsky
This also converts MaybeCloseWindowHelper, and results in the window close operations being always run in the parent (even without DocumentChannel).

Differential Revision: https://phabricator.services.mozilla.com/D49528
2019-11-08 04:35:05 +00:00
Peter Van der Beken
d39c3601d1 Bug 1438272 - Part 1: move HistoryID to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D25766
2019-03-05 10:33:42 +01:00
Nika Layzell
c42f4426d0 Bug 1590908 - Part 1: Move parent-only LoadURI method to CanonicalBrowsingContext, r=kmag
These methods are only callable from the parent process, so it doesn't make
sense to have the method available driectly on BrowsingContext.

Differential Revision: https://phabricator.services.mozilla.com/D50854
2019-11-04 15:05:47 +00:00
Kashav Madan
73ab800670 Bug 1590239 - Send a "browsing-context-discarded" notification when detaching, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D50520
2019-10-29 17:15:29 +00:00
Andreas Farre
a737baed0b Bug 1575051 - Part 4: Expose JS stack access check control on FindWithName. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D49286
2019-10-25 15:34:30 +00:00
Andreas Farre
22d88214fc Bug 1575051 - Part 2: Look in chrome browsing context group when docshell is missing. r=kmag
Also some minor cleanup in nsWindowWatcher, as well as a small fix,
where GetWindowByName forgot to addref its return value (as changed in
Part 1).

Differential Revision: https://phabricator.services.mozilla.com/D48976
2019-10-24 14:53:07 +00:00
Andreas Farre
3262edc078 Bug 1575051 - Part 1: Remove nsIDocShellTreeItem.findItemWithName. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-10-24 14:53:07 +00:00
Tom Tung
5753ad84f4 Bug 1583251 - P1 - Propagate the targetAgentClusterId to PostMessageEvent::Run(); r=nika
Differential Revision: https://phabricator.services.mozilla.com/D48347
2019-10-23 07:19:48 +00:00
Kashav Madan
271a90b578 Bug 1589399 - Make BrowsingContext implement nsISupports, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D49786
2019-10-18 18:58:30 +00:00
Razvan Maries
495feee7f1 Backed out 5 changesets (bug 1583251) for rust build bustages. CLOSED TREE
Backed out changeset bfe390ad771b (bug 1583251)
Backed out changeset 0113c698b44d (bug 1583251)
Backed out changeset 248ad59168dd (bug 1583251)
Backed out changeset 5d5e3dc17118 (bug 1583251)
Backed out changeset 9e9eaa78c436 (bug 1583251)
2019-10-18 17:59:20 +03:00
Tom Tung
c8be3733be Bug 1583251 - P1 - Propagate the targetAgentClusterId to PostMessageEvent::Run(); r=nika
Differential Revision: https://phabricator.services.mozilla.com/D48347
2019-10-17 19:29:54 +00:00
Edgar Chen
b2d6793250 Bug 1588720 - Part 2: Track number of popup spam through BrowsingContext; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D49276
2019-10-18 03:04:55 +00:00
Narcis Beleuzu
8b503ffdd0 Backed out 3 changesets (bug 1575051) for bc failures on browser_browsingContext-getWindowByName.js . CLOSED TREE
Backed out changeset 67aaf4a157af (bug 1575051)
Backed out changeset e01256038537 (bug 1575051)
Backed out changeset 0c8f70f9328b (bug 1575051)
2019-10-14 19:19:05 +03:00
Andreas Farre
c48483dcae Bug 1575051 - Part 2: Look in chrome browsing context group when docshell is missing. r=kmag
Also some minor cleanup in nsWindowWatcher, as well as a small fix,
where GetWindowByName forgot to addref its return value (as changed in
Part 1).

Differential Revision: https://phabricator.services.mozilla.com/D48976
2019-10-14 12:32:08 +00:00
Andreas Farre
967275c308 Bug 1575051 - Part 1: Remove nsIDocShellTreeItem.findItemWithName. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-10-14 12:07:14 +00:00
Kris Maglione
3678333d88 Bug 1586887: Return WindowProxyHolder rather than BrowsingContext from Window WebIDL getters. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D48429
2019-10-11 19:32:09 +00:00
Kris Maglione
a401db1ae2 Bug 1586926 - Add necessary caller access checks for cross-process Location navigations. r=nika
We attempt to enforce the same (approximate) access checks to Location-based
navigation that we use for loads that use named targeting (e.g., via
window.open), so that a frame that can't be navigated via, e.g., window.open,
also can't be navigated via, e.g., window.parent[1].location = url. For the
in-process case, this is handled by a somewhat hidden call to
CheckLoadingPermissions() in nsDocShell::InternalLoad, where the former checks
whether the principal of whatever JS context happens to be on the stack
subsumes the principal of the target DocShell or any of its ancestors, and
blocks the load if it doesn't.

Since there is no JS context on the stack when we call into the DocShell
loading code in the cross-process case, the check is simply ignored.

So we need to instead do the check in BrowsingContext::LoadURI, where we
already have an explicit accessor, and can simply use the standard access
checks that we use elsewhere.

Differential Revision: https://phabricator.services.mozilla.com/D48443
2019-10-10 19:36:23 +00:00
Matt Woodrow
c2f9b65aa6 Bug 1578624 - P6: Add LoadURI to BrowsingContext's webidl. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44762
2019-10-11 02:27:14 +00:00
Matt Woodrow
205943b591 Bug 1578624 - P5: Add DisplayLoadError to BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44761
2019-10-11 02:27:07 +00:00
Matt Woodrow
72d26be23d Bug 1578624 - P4: Add an option to set mIsNavigating on the docshell when loading using BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44760
2019-10-11 02:27:05 +00:00
Nika Layzell
0b173c83d8 Bug 1575163 - Dont send PostMessage events to a discarded BrowsingContext, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D48418
2019-10-09 14:20:23 +00:00
Brindusan Cristian
170d6fb93f Backed out 11 changesets (bug 1578624) for build bustages. CLOSED TREE
Backed out changeset b22733eb880f (bug 1578624)
Backed out changeset cb5e15489635 (bug 1578624)
Backed out changeset f1746b2f9dec (bug 1578624)
Backed out changeset d08a099a22ff (bug 1578624)
Backed out changeset 8ebd563c72a8 (bug 1578624)
Backed out changeset d8bfec2dc9b6 (bug 1578624)
Backed out changeset 591664928bce (bug 1578624)
Backed out changeset 63f5a619b9ef (bug 1578624)
Backed out changeset ff67cc13cdf3 (bug 1578624)
Backed out changeset 43556c937a09 (bug 1578624)
Backed out changeset 49065a55694d (bug 1578624)
2019-10-09 11:50:37 +03:00
Matt Woodrow
7360fbed91 Bug 1578624 - P6: Add LoadURI to BrowsingContext's webidl. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44762
2019-10-09 06:37:51 +00:00
Matt Woodrow
accaa04356 Bug 1578624 - P5: Add DisplayLoadError to BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44761
2019-10-09 06:58:34 +00:00
Matt Woodrow
de29a4b06c Bug 1578624 - P4: Add an option to set mIsNavigating on the docshell when loading using BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44760
2019-10-09 06:37:50 +00:00
Narcis Beleuzu
eab5ec4098 Backed out 11 changesets (bug 1578624) for bustages on WindowGlobalChild.h . CLOSED TREE
Backed out changeset 478897956ee0 (bug 1578624)
Backed out changeset ab9c09164df0 (bug 1578624)
Backed out changeset f461f10efa46 (bug 1578624)
Backed out changeset 9b958693a003 (bug 1578624)
Backed out changeset 3b8220a15051 (bug 1578624)
Backed out changeset 180407dc57a8 (bug 1578624)
Backed out changeset bb11892e2171 (bug 1578624)
Backed out changeset 4f5c28244290 (bug 1578624)
Backed out changeset 6c02bbe5c1c5 (bug 1578624)
Backed out changeset 1d762fdce921 (bug 1578624)
Backed out changeset 818bc6e20c7d (bug 1578624)
2019-10-09 08:52:25 +03:00
Matt Woodrow
3ff163e470 Bug 1578624 - P6: Add LoadURI to BrowsingContext's webidl. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44762
2019-10-09 04:34:40 +00:00
Matt Woodrow
201ce8f7dd Bug 1578624 - P5: Add DisplayLoadError to BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44761
2019-10-09 04:34:12 +00:00
Matt Woodrow
378756e2da Bug 1578624 - P4: Add an option to set mIsNavigating on the docshell when loading using BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44760
2019-10-09 04:50:16 +00:00
Kris Maglione
d38c2cdbe4 Bug 1586119: Part 2 - Fix some more tests to almost work under Fission. r=mccr8
These still fail or timeout because of missing platform features, but at least
the tests will pass once those platform features are fixed after this.

Differential Revision: https://phabricator.services.mozilla.com/D48221
2019-10-04 21:50:34 +00:00
shindli
2238702c0a Backed out changeset c211bfbf59b2 (bug 1585747) for causing mochitest permafailures in /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/BrowsingContextGroup CLOSED TREE 2019-10-04 12:02:59 +03:00
Julian Descottes
4ae9605e64 Bug 1585747 - Remove devtools-specific workaround in BrowsingContext.cpp r=nika
Depends on D47963

This workaround was only used by DevTools when using a chrome frame. DevTools toolbox now always uses frame type=content, so the workaround can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D47964
2019-10-04 07:03:49 +00:00
Nika Layzell
c04b4f7187 Bug 1584467 - Don't clear EmbedderInnerWindowId when destroying frame, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D47633
2019-10-01 08:48:25 +00:00
Nika Layzell
ba08b2ed0b Bug 1582237 - Expose embedder inner window ID on BrowsingContext in all processes, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D46802
2019-09-26 16:16:32 +00:00
Brindusan Cristian
8633c6f1f4 Backed out 2 changesets (bug 1582716, bug 1575051) for gv-junit failures, new exception. CLOSED TREE
Backed out changeset b5aa3ac4483e (bug 1582716)
Backed out changeset c385531b4ee3 (bug 1575051)
2019-09-24 19:47:00 +03:00
Andreas Farre
adc8fc7fb5 Bug 1575051 - Remove nsIDocShellTreeItem.findItemWithName. r=kmag
This also allows us to remove TabGroup::FindItemWithName, which is a
big step towards removing TabGroup entirely.

Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-09-24 13:16:26 +00:00
Brindusan Cristian
f52298b70e Backed out changeset 0ebd1612a4ae (bug 1575051) for gv-junit crashes and bc failures on browser_browsingContext-02.js. CLOSED TREE 2019-09-24 15:08:41 +03:00
Andreas Farre
24fa934f6b Bug 1575051 - Remove nsIDocShellTreeItem.findWithName. r=kmag
This also allows us to remove TabGroup::FindItemWithName, which is a
big step towards removing TabGroup entirely.

Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-09-24 10:58:47 +00:00
arthur.iakab
5b1aa0ae65 Merge inbound to mozilla-central. a=merge 2019-09-21 13:00:40 +03:00
Kris Maglione
fdb36a21b5 Bug 1553804: Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45328
2019-09-20 04:43:46 +00:00
Kris Maglione
dbb202a569 Bug 1553804: Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45327
2019-09-20 04:43:39 +00:00
Edgar Chen
d161044379 Bug 1578355 - Part 3: Add the ability to consume transient user activation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45353
2019-09-20 11:10:13 +00:00
Edgar Chen
486c0f7a75 Bug 1578355 - Part 2: Introduce UserActivation::State; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45344
2019-09-20 11:10:13 +00:00
Daniel Varga
0c8477fc87 Backed out 3 changesets (bug 1578355) for build bustage at build/src/dom/base/nsSyncLoadService.h:48:21. On a CLOSED TREE
Backed out changeset d50ad759f129 (bug 1578355)
Backed out changeset 339ab54ca471 (bug 1578355)
Backed out changeset 284299dac42c (bug 1578355)
2019-09-20 14:05:12 +03:00
Edgar Chen
162581b056 Bug 1578355 - Part 3: Add the ability to consume transient user activation; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45353
2019-09-20 10:31:59 +00:00
Edgar Chen
8eb796eeb5 Bug 1578355 - Part 2: Introduce UserActivation::State; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D45344
2019-09-20 10:31:57 +00:00
Daniel Varga
58aaa6e957 Backed out 6 changesets (bug 1553804) for browser-chrome failure at browser/base/content/test/general/browser_fullscreen-window-open.js. On a CLOSED TREE
Backed out changeset 86b3d469b4ff (bug 1553804)
Backed out changeset 301e0d883a5f (bug 1553804)
Backed out changeset acff4a663671 (bug 1553804)
Backed out changeset 1574aecf3177 (bug 1553804)
Backed out changeset 3acf056e792e (bug 1553804)
Backed out changeset 1ed250faeb2e (bug 1553804)
2019-09-20 10:09:54 +03:00
Kris Maglione
f4ed199c1f Bug 1553804: Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45328
2019-09-20 04:43:46 +00:00
Kris Maglione
7770a0ac54 Bug 1553804: Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D45327
2019-09-20 04:43:39 +00:00
Junior Hsu
c2d40549a9 Bug 1579012 - use COOP in top-levl browsing context of opener for iframe r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D45582
2019-09-12 14:44:16 +00:00