Commit Graph

199 Commits

Author SHA1 Message Date
Mark Banner
19b7fb742e Bug 1782659 - Enable ESlint rule no-unused-vars on the global scope for browser/ xpcshell-tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D153433
2022-08-05 08:38:50 +00:00
Shane Hughes
d6138d8943 Bug 1779335 - Add new menu to Synced Tabs sidebar context. r=Gijs,fluent-reviewers
Add an "Open in New Container Tab" menu to the Synced Tabs sidebar
context menu, to match similar menus elsewhere in tab menus.

Differential Revision: https://phabricator.services.mozilla.com/D151777
2022-07-14 22:28:14 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Mark Banner
ccd96039b2 Bug 1771173 - Remove unused imports. r=geckoview-reviewers,arai,owlish
Differential Revision: https://phabricator.services.mozilla.com/D149786
2022-06-21 20:42:16 +00:00
Tooru Fujisawa
612a6d95b1 Bug 1772100 - Part 18: Use plain object for lazy getter in browser/components/syncedtabs/. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D148028
2022-06-06 22:46:25 +00:00
Greg Tatum
53481b7bb8 Bug 1767537 - Remove intl.l10n.pseudo listening from SyncedTabsDeckComponent.js; r=platform-i18n-reviewers,dminor
Differential Revision: https://phabricator.services.mozilla.com/D145373
2022-05-05 16:25:32 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Sammy Khamis
be54278282 Bug 1756252: Collect telemetry on synced tabs usage r=markh
Differential Revision: https://phabricator.services.mozilla.com/D139221
2022-02-23 02:39:26 +00:00
Geoff Brown
a00c449c2d Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal
These tests are excluded from android test runs in moz.build. Including
an explicit annotation in each manifest avoids scheduling confusion.
browser-chrome and plain-chrome tests in browser/ are of no concern,
since those test types are never scheduled on android.

Differential Revision: https://phabricator.services.mozilla.com/D125266
2021-09-13 15:22:27 +00:00
Francesco Lodolo (:flod)
d52c58a671 Bug 1700638 - Remove Sync brand from Sync dialogs and sidebar, App menu and FxA menu, r=mconley,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D110013
2021-03-30 14:30:55 +00:00
Dan Minor
adfd6ae30d Bug 1676137 - Remove intl.uidirection pref; r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D108789
2021-03-29 14:22:52 +00:00
Tim Nguyen
79b7ae3197 Bug 1699074 - Move defaultFavicon.svg to toolkit/themes/shared/icons. r=desktop-theme-reviewers,mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D108757
2021-03-17 15:19:34 +00:00
Dan Minor
e19ee18311 Bug 1673054 - Migrate uses of intl.uidirection to intl.l10n.pseudo; r=Gijs,zbraniecki
This also removes pref overrides from methods like LocaleService::IsLocaleRTL or
IntlService.getLocaleInfo, because it doesn't really make sense to override the
result of checking an arbitrary locale, the relevant use case is overriding the
result for the current app locale.

Removal of the intl.uidirection pref completely will be done in a separate bug.

Differential Revision: https://phabricator.services.mozilla.com/D96235
2020-11-09 15:33:39 +00:00
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Kris Maglione
0720b18caa Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00
Razvan Maries
ef6b72636b Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Kris Maglione
5801b582fd Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Dão Gottwald
b54eac8074 Bug 1626179 - Use the search-textbox custom element in the Synced Tabs sidebar. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D68959
2020-03-31 10:06:16 +00:00
Tim Nguyen
f72438ea6b Bug 1625681 - Clean up synced tabs sidebar searchbox styling. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D68696
2020-03-30 13:38:06 +00:00
Kris Maglione
bcf590f0ac Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609
2020-01-21 21:32:28 +00:00
Mihai Alexandru Michis
22e532856c Backed out changeset 006f4e50e8e5 (bug 1602898) for causing multiple failures.
CLOSED TREE
2020-01-21 22:55:37 +02:00
Kris Maglione
e3f215a868 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609
2020-01-21 18:48:26 +00:00
Cosmin Sabou
8237d004e4 Backed out changeset 4c303f6ec2e6 (bug 1602898) for browser chrome failures on browser_ssb_windowlocation. 2020-01-18 01:06:34 +02:00
Kris Maglione
1d5625e830 Bug 1602898: Rename Window.getWindowGlobalChild() to .windowGlobalChild. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D56609
2020-01-17 21:36:10 +00:00
Geoff Brown
0bada8d818 Bug 1601076 - Fix some broken BUG_COMPONENTS in moz.build files; r=jmaher
Some of these were obvious typos. Others probably reflect once-correct components
that have been combined, split, or otherwise obsoleted; for these I've tried to
use the component associated with the bugs for recent changes to the affected files.

Differential Revision: https://phabricator.services.mozilla.com/D55756
2019-12-04 13:55:45 +00:00
James Jahns
1d5447da43 Bug 1595143 - Port LightweightThemeChild to JSWindowActors r=mconley,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D52555
2019-11-18 22:51:18 +00:00
Tim Nguyen
387bef1d32 Bug 1516091 - Stop using <sidebarheader> as an element. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D51384
2019-11-01 13:22:36 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Edouard Oger
0de109d940 Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D44485
2019-09-10 18:23:31 +00:00
Edouard Oger
56b5f7c138 Bug 1572439 - Don't import browser.css in Synced Tabs sidebar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D44475
2019-09-03 17:32:06 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Yuan Cheng
bb2c758172 Bug 1523761 - Move the syncedTabs strings from browser.dtd to fluent, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D22980
2019-03-28 00:07:48 +00:00
Mark Banner
d5029e0dae Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
shindli
d041182a67 Backed out changeset c0996caf797f (bug 1523761) for bc failures in browser/components/customizableui/test/browser_947914_button_history.js CLOSED TREE 2019-03-18 19:20:56 +02:00
Yuan Cheng
de92d8095d Bug 1523761 - Move the syncedTabs strings from browser.dtd to fluent, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D22980
2019-03-15 18:46:46 +00:00
Edouard Oger
fbcc2b613c Bug 1532514 - Update sinon to v7.2.7. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D22046
2019-03-12 19:32:40 +00:00
Dorel Luca
163580f51c Backed out changeset 4b280518c7b1 (bug 1532514) for Browser-chrome failures in browser/components/syncedtabs/test/browser/browser_sidebar_syncedtabslist.js. CLOSED TREE 2019-03-12 03:59:56 +02:00
Edouard Oger
1afa261c1b Bug 1532514 - Update sinon to v7.2.7. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D22046
2019-03-12 00:18:16 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00