Commit Graph

3187 Commits

Author SHA1 Message Date
Nika Layzell
3ea77b2aa2 Bug 1728332 - Part 1: Predict remote type when inserting restored tabs, r=Gijs
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
2022-03-25 22:25:55 +00:00
Mathew Hodson
df2a53e9ea Bug 1752853 - Stop using a worker to write session store. r=Gijs,Standard8
Remove now unused pref "browser.sessionstore.max_write_failures".
Rename and simplify test_shutdown_cleanup.js to make it more clear that
it is testing the isFinalWrite option.

Differential Revision: https://phabricator.services.mozilla.com/D137930
2022-03-25 19:42:36 +00:00
Cristian Tuns
05d7d28dae Backed out changeset 30fa07c96caa (bug 1728332) for causing mochitest failures on browser_tabs_in_urlbar.js CLOSED TREE 2022-03-21 19:02:16 -04:00
Nika Layzell
3317a3ef3f Bug 1728332 - Predict remote type when inserting restored tabs, r=Gijs
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
2022-03-21 21:44:14 +00:00
Mike Conley
cd2f080722 Bug 1759549 - Persist wireframes to Session Store when wireframe capturing is enabled. r=mossop,farre
Differential Revision: https://phabricator.services.mozilla.com/D141001
2022-03-21 17:54:13 +00:00
Henrik Skupin
d785f8a630 Bug 1759574 - [marionette] Move session store tests to browser/components/sessionstore/test/marionette. r=webdriver-reviewers,dao,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D141082
2022-03-21 17:05:26 +00:00
Butkovits Atila
cd585508ce Backed out changeset 583b98909672 (bug 1759549) for causing failures at browser_sessionHistory.js. 2022-03-21 19:34:29 +02:00
Mike Conley
e85aa9661d Bug 1759549 - Persist wireframes to Session Store when wireframe capturing is enabled. r=mossop,farre
Differential Revision: https://phabricator.services.mozilla.com/D141001
2022-03-21 15:43:15 +00:00
Sean Feng
6f2305a872 Bug 1759499 - Allow recording BFCACHE_COMBO probe in parent process r=smaug
With Fission, BFCache is now being used in the parent process,
updating the probe to collect parent process information.

Differential Revision: https://phabricator.services.mozilla.com/D141260
2022-03-18 01:00:50 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
Barret Rennie
60ddecfcfe Bug 1753369 - Use sync PathUtils directory getters on mainthread in browser/components/sessionstore r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D140133
2022-03-10 15:16:39 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Butkovits Atila
399d5c6e4a Bug 1638958 - disable browser_label_and_icon.js on Linux_64_opt for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D140268
2022-03-04 02:51:29 +00:00
Emilio Cobos Álvarez
20ba7daa1c Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
2022-02-16 12:18:12 +00:00
Emilio Cobos Álvarez
2b4bcbce12 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-16 12:18:12 +00:00
smolnar
ac36389b37 Backed out 6 changesets (bug 1753836) for causing mochitest failures in test_event_screenXY_with_zoom. CLOSED TREE
Backed out changeset a572cbc0fac2 (bug 1753836)
Backed out changeset 371a495ff728 (bug 1753836)
Backed out changeset 774af76be463 (bug 1753836)
Backed out changeset faa8a8f2d40f (bug 1753836)
Backed out changeset 9209832ecffe (bug 1753836)
Backed out changeset db443ce0406d (bug 1753836)
2022-02-16 01:47:51 +02:00
Emilio Cobos Álvarez
314f6c7716 Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
2022-02-15 22:25:05 +00:00
Emilio Cobos Álvarez
1f6fc3a3d9 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-15 22:25:04 +00:00
Sarah Clements
ac27d9d5d6 Bug 1747430 - remove tabIndicatorReplacesIcon in browser tabs css file r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137775
2022-02-11 16:19:52 +00:00
Masatoshi Kimura
e1270852a2 Bug 1728800 - Collect window features from chrome flags. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137948
2022-02-07 21:01:19 +00:00
Barret Rennie
3e6dfbcf31 Bug 1749996 - Ensure CrashMonitor writes sessionstore final checkpoint before IOUtils shuts down r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137797
2022-02-05 20:57:50 +00:00
Masatoshi Kimura
ac445526fc Bug 1753608 - Fix Session Restore fails to restore some features. r=Gijs
* I overlooked that some `window.open` feature names are different from
  barprop names.
* Adding "resizable" will regress the maximize button prblem. But it was
  broken even before bug 1564738 and fixing it requires changes to session
  data. The current session data do not contain enough information to restore
  the maximize button state correctly. I'll file a follow-up bug about this.
* I renamed the test file because it is no longer limited to tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D137838
2022-02-04 19:53:24 +00:00
Butkovits Atila
acc15d025a Backed out changeset da0571b0cff0 (bug 1749996) for causing failures at IOUtils. CLOSED TREE 2022-02-04 18:52:19 +02:00
Barret Rennie
2faa8390f8 Bug 1749996 - Ensure CrashMonitor writes all checkpoints before IOUtils shuts down r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137797
2022-02-04 15:58:57 +00:00
Masatoshi Kimura
ea40dd3de8 Bug 1564738 - Set correct features from the start instead of changing visibity after window creation. r=Gijs
Changing visibiity causes some subtle problems.

Differential Revision: https://phabricator.services.mozilla.com/D137750
2022-02-03 23:10:16 +00:00
Joel Maher
6d769aee7c Bug 1750839 - Enable fission browser-chrome for variants. r=mccr8,releng-reviewers,gbrown
Differential Revision: https://phabricator.services.mozilla.com/D136512
2022-02-01 19:30:34 +00:00
Andreas Farre
917a3407ad Bug 1751156 - Make it more clear when SSWindowState{Ready, Busy} are dispatched. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D136466
2022-01-25 07:59:56 +00:00
Neil Deakin
e284566b55 Bug 1745272, remove soon to expire subframe crash telemetry, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D134187
2021-12-18 11:05:21 +00:00
Barret Rennie
458658fdf3 Bug 1745354 - Remove osfile.jsm from browser/components/sessionstore r=annyG
Differential Revision: https://phabricator.services.mozilla.com/D133466
2021-12-15 01:39:36 +00:00
criss
acbfb645ed Backed out changeset ac839ddcb82f (bug 1745354) for causing failures on browser_backup_recovery.js. CLOSED TREE 2021-12-14 09:12:19 +02:00
Barret Rennie
8a3c38779b Bug 1745354 - Remove osfile.jsm from browser/components/sessionstore r=annyG
Differential Revision: https://phabricator.services.mozilla.com/D133466
2021-12-14 06:29:05 +00:00
Ryan VanderMeulen
31cffbff09 Bug 1271024 - Re-enable browser_purge_shistory.js when SHIP is enabled. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D133116
2021-12-10 13:43:55 +00:00
Florian Quèze
44a0e89282 Bug 1744993 - avoid leaving about:robots open at the end of browser-chrome mochitests, r=Gijs.
Depends on D132055

Differential Revision: https://phabricator.services.mozilla.com/D133205
2021-12-09 11:27:41 +00:00
Narcis Beleuzu
6e9d812757 Backed out 12 changesets (bug 1721217) for bc failures on browser_TopLevelNavigationDelegate.js
Backed out changeset 5fe3c617d521 (bug 1721217)
Backed out changeset c131e4a6d9d5 (bug 1721217)
Backed out changeset a59210a5b400 (bug 1721217)
Backed out changeset 74362b0c39c0 (bug 1721217)
Backed out changeset c8075b91d660 (bug 1721217)
Backed out changeset 46512deaf0e5 (bug 1721217)
Backed out changeset b38bc569d227 (bug 1721217)
Backed out changeset ee9bd012fda8 (bug 1721217)
Backed out changeset 7aa2726a0982 (bug 1721217)
Backed out changeset 885ced5f4bb4 (bug 1721217)
Backed out changeset 7d3f99ca3f44 (bug 1721217)
Backed out changeset 2f5a0164679a (bug 1721217)
2021-12-01 03:38:10 +02:00
Anny Gakhokidze
58756fd2c5 Bug 1721217 - Part 12: Disable browser_scrollPositions.js, r=dao,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D132388
2021-11-30 16:31:38 +00:00
Emilio Cobos Alvarez
d388fbd1f1 Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski
Privileged pages do this automatically via:

  https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/widget/nsXPLookAndFeel.cpp#1179-1183

So this makes everything more consistent. Known exceptions:

 * Pocket panels (as those don't seem to support dark mode)
 * about:reader (because it has its own dark mode handling)

Differential Revision: https://phabricator.services.mozilla.com/D132019
2021-11-25 21:24:43 +00:00
Emma Malysz
de49ee5bff Bug 1649605 - Replace osfile.jsm usage in SessionWorker.jsm. r=Gijs
Add a mutex to prevent simultaneous I/O requests.

Co-authored-by: Mathew Hodson <mathew.hodson@gmail.com>

Differential Revision: https://phabricator.services.mozilla.com/D129367
2021-11-25 10:45:55 +00:00
Christoph Kerschbaumer
c78a87d7c0 Bug 1742351: Update more browser/ tests to be compliant with https-first mode r=extension-reviewers,Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D131773
2021-11-22 14:26:32 +00:00
Iulian Moraru
43773e005d Backed out changeset 7d9cd61d95ce (bug 1742351) for causing bc failures on browser_paste_event_at_middle_click_on_link.js. CLOSED TREE 2021-11-22 14:14:16 +02:00
Christoph Kerschbaumer
5c4ef2e2bd Bug 1742351: Update more browser/ tests to be compliant with https-first mode r=extension-reviewers,Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D131773
2021-11-22 10:49:45 +00:00
Andreea Pavel
3e05087e6d Bug 1732818 - re-enable browser_windowStateContainer.js on all platforms r=cpeterson
Differential Revision: https://phabricator.services.mozilla.com/D130545
2021-11-16 07:40:44 +00:00
OnuohaOluebube
bb734d45c8 Bug 1738246 - Removed OS.File usage from various browser/components/sessionstore/ tests r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D129894
2021-11-11 18:21:21 +00:00
Nils
488a36d979 Bug 1740294: Fix typo "then then" -> "then" r=mhentges
Instances of the typo that have been imported from other repositories have been left unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D130561
2021-11-09 17:36:40 +00:00
Antonin LOUBIERE
cf38ac05ce Bug 1732366 - When closing last tab while having private window, remove the tab from the tabs list . r=Gijs
With session restore and close window on last tab close both enabled, if the last tab is closed while having another private window, move it from the winData.tabs list to the winData._closedTabs list.

Differential Revision: https://phabricator.services.mozilla.com/D126590
2021-11-01 17:09:28 +00:00
Andreea Pavel
200259bb40 Bug 1732818 - disable browser_windowStateContainer.js on linux, mac and win debug r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D129954
2021-10-30 02:41:43 +00:00
OnuohaOluebube
97028c52e9 Bug 1733422 - SessionStore.getClosedWindowData always returns an object r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D129147
2021-10-25 08:18:27 +00:00
Gijs Kruitbosch
ed5f6adc07 Bug 1730021 - fix restoring sessions that closed all tabs, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D128884
2021-10-20 21:26:06 +00:00
Evgenia Kotovich
685e68c48b Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-18 09:26:33 +00:00
Noemi Erli
b1ebbba564 Backed out changeset 2ab6bb03dcc1 (bug 1576768) for causing failures in test_double_submit.html CLOSED TREE 2021-10-18 02:05:57 +03:00