Commit Graph

246 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
aa13814e76 Bug 1765083 - Introduce FocusOptions.focusVisible. r=smaug,pip-reviewers
As per:

 * https://github.com/whatwg/html/issues/7830
 * https://github.com/whatwg/html/pull/8087

Replace the internal preventFocusRing with the new flag.

Differential Revision: https://phabricator.services.mozilla.com/D151326
2022-07-11 22:04:34 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
bf94464e91 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 04:42:08 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
6ed0357d29 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 02:49:12 +00:00
Emilio Cobos Alvarez
d388fbd1f1 Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski
Privileged pages do this automatically via:

  https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/widget/nsXPLookAndFeel.cpp#1179-1183

So this makes everything more consistent. Known exceptions:

 * Pocket panels (as those don't seem to support dark mode)
 * about:reader (because it has its own dark mode handling)

Differential Revision: https://phabricator.services.mozilla.com/D132019
2021-11-25 21:24:43 +00:00
Mike Conley
81b37a519c Bug 1709050 - Suppress the focus ring in the upgrade dialog and some about: pages when they first load. r=Mardak,Gijs
Using autofocus="true" or programmatically calling .focus() when there is no pre-existing focused
element causes the :focus-visible to match.

This patch avoids using autofocus="true" on some of our about: pages, and uses
Element.focus({ preventFocusRing: true }) to avoid that when these pages and dialog
first load. Note that this doesn't prevent the focus ring from _ever_ appear, it just
stops it from appearing on first load.

Differential Revision: https://phabricator.services.mozilla.com/D115062
2021-05-21 18:13:29 +00:00
Mike Conley
2d38d7c0db Bug 1709472 - Change error page favicon from warning.svg to info.svg. r=jaws
This also updates the icon used for the "focus tab by prompting" permission in
the permission panel to use info.svg.

Differential Revision: https://phabricator.services.mozilla.com/D114653
2021-05-17 18:56:01 +00:00
Butkovits Atila
6fd223c2ec Backed out changeset ec36559d6b92 (bug 1709050) for causing failure at browser_aboutNetError.js. CLOSED TREE 2021-05-17 21:49:03 +03:00
Mike Conley
5fea93c5a7 Bug 1709050 - Suppress the focus ring in the upgrade dialog and some about: pages when they first load. r=Mardak,Gijs
Using autofocus="true" or programmatically calling .focus() when there is no pre-existing focused
element causes the :focus-visible to match.

This patch avoids using autofocus="true" on some of our about: pages, and uses
Element.focus({ preventFocusRing: true }) to avoid that when these pages and dialog
first load. Note that this doesn't prevent the focus ring from _ever_ appear, it just
stops it from appearing on first load.

Differential Revision: https://phabricator.services.mozilla.com/D115062
2021-05-17 17:44:09 +00:00
Dorel Luca
9508ff975b Backed out changeset 13b220eff7d8 (bug 1709050) for Browser-chrome failures in browser/base/content/test/about/browser_aboutCertError.js. CLOSED TREE 2021-05-17 18:14:37 +03:00
Mike Conley
56fe4c6298 Bug 1709050 - Suppress the focus ring in the upgrade dialog and some about: pages when they first load. r=Mardak,Gijs
Using autofocus="true" or programmatically calling .focus() when there is no pre-existing focused
element causes the :focus-visible to match.

This patch avoids using autofocus="true" on some of our about: pages, and uses
Element.focus({ preventFocusRing: true }) to avoid that when these pages and dialog
first load. Note that this doesn't prevent the focus ring from _ever_ appear, it just
stops it from appearing on first load.

Differential Revision: https://phabricator.services.mozilla.com/D115062
2021-05-17 13:58:49 +00:00
Brindusan Cristian
6eda1c1956 Backed out changeset 289f6a96b9e4 (bug 1709472) for xpcshell failures in test_bookmarks_html.js. CLOSED TREE 2021-05-14 00:37:24 +03:00
Mike Conley
d7c8ef56aa Bug 1709472 - Change error page favicon from warning.svg to info.svg. r=jaws
This also updates the icon used for the "focus tab by prompting" permission in
the permission panel to use info.svg.

Differential Revision: https://phabricator.services.mozilla.com/D114653
2021-05-13 19:32:00 +00:00
ankur
0b7d4e68ba Bug 1695253 - Replaced DTD/xhtml1-strict.dtd which lead to broken network loads. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D109379
2021-03-24 16:52:06 +00:00
Kris Maglione
0720b18caa Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00
Razvan Maries
ef6b72636b Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Kris Maglione
5801b582fd Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Christoph Kerschbaumer
6dec8a1a75 Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D46950
2019-09-26 16:22:41 +00:00
Alex Vincent
0a4e7a7185 Bug 1508169, Remove performAction* from nsITreeView.idl in mozilla-central. r=peterv, johannh
performAction, performActionOnRow and performActionOnCell are methods of the
nsITreeView interface that are never called.  This is to remove these methods.
A comm-central patch will be along shortly.

Differential Revision: https://phabricator.services.mozilla.com/D39273
2019-08-24 00:49:55 +02:00
Christoph Kerschbaumer
e8a716d084 Bug 1497209: Apply Meta CSP to about:sessionrestore and about:welcomeback. r=Gijs,vporof
Differential Revision: https://phabricator.services.mozilla.com/D38081
2019-07-17 11:22:35 +00:00
Victor Porof
bf2b98e8c1 Bug 1561435 - Fix linting errors for browser/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35950
2019-06-28 20:02:37 +02:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Marco Bonardo
a040dd21a3 Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753
2019-02-28 08:39:33 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Kris Maglione
f498964d86 Bug 1519596: Part 1 - Remove several unnecessary/unused ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16377
2019-01-11 16:59:23 -08:00
Qinghao_Jack_Song
901e57c884 Bug 1507301 - Migrate about:sessionrestore and about:welcomeback to use Fluent for localization r=Gijs,flod,zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D11994
2018-11-19 22:01:58 +00:00
Mike Conley
10584d530d Bug 1492950 - Get rid of tabbrowser.getBrowserIndexForDocument. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D6706
2018-10-02 17:49:35 +00:00
Jonathan Kingston
adaa868721 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
Brindusan Cristian
6c0094d53f Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
52a379b132 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
arthur.iakab
f36e6bf3d0 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
b7aabac2a5 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
Tiberius Oros
75126ef309 Backed out 10 changesets (bug 1485305) for failures at browser/content/browser.js on a CLOSED TREE
Backed out changeset 63c50fd60ae4 (bug 1485305)
Backed out changeset bf0f2adb765e (bug 1485305)
Backed out changeset 721871bb64f1 (bug 1485305)
Backed out changeset e9da73786c5f (bug 1485305)
Backed out changeset e02038177b6b (bug 1485305)
Backed out changeset 35bd32f99f60 (bug 1485305)
Backed out changeset f40900bf8621 (bug 1485305)
Backed out changeset 03632075ac2c (bug 1485305)
Backed out changeset 2fee48378f73 (bug 1485305)
Backed out changeset 6263695b3cb8 (bug 1485305)
2018-09-18 14:46:54 +03:00
Jonathan Kingston
b194222905 Bug 1485305 - browser/ Ensure loadURI always passes a triggeringPrincipal() r=Mossop
Differential Revision: https://phabricator.services.mozilla.com/D4551
2018-08-29 15:43:27 +01:00
Arshad Kazmi
a4a87a4243 Bug 1457784 - Replace warning-16.png with warning.svg. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D5973
2018-09-17 09:55:12 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Jonathan Kingston
07af5c5572 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb r=Gijs
Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046
2018-07-06 15:14:54 +01:00
dvarga
86b7ee6d9f Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)
2018-08-08 22:11:56 +03:00
Jonathan Kingston
0e48203cf4 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: mixedpuppy, reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046
2018-08-08 20:03:55 +03:00
Andreea Pavel
31fb9c007c Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
ea417d37e5 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046
2018-08-06 19:54:47 +03:00
Kris Maglione
e97c582e3f Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL
2018-05-21 16:58:23 -07:00
Kris Maglione
9ba14892f2 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG
2018-05-20 18:10:16 -07:00
Narcis Beleuzu
749f83cc65 Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione
6dcf46ad68 Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL
2018-05-21 16:58:23 -07:00
Kris Maglione
86fbdd6653 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG
2018-05-20 18:10:16 -07:00
Kris Maglione
5df1a30471 Bug 1474139: Part 2 - Move content-sessionStore to a separate JSM. r=mikedeboer
MozReview-Commit-ID: 5weG4B4V1PY
2018-07-07 16:42:28 -07:00
Kris Maglione
c20b07f98c Bug 1474139: Part 1 - Refactor content-sessionSstore to not depend on running in a frame script global. r=mikedeboer
MozReview-Commit-ID: 2uiKk9B8KWy
2018-07-07 16:30:56 -07:00