corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

745 Commits

Author SHA1 Message Date
Sarah Clements
cf7801bb42 Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs 
* Add a helper in sessionstore to rewrite closedId's for all restored tabs
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D157235
 2022-09-14 14:58:07 +00:00
Marian-Vasile Laza
d1e176e9a1 Backed out changeset d057e8cf08cf (bug 1789652) for causing bc failures on browser_closedId.js. 2022-09-14 17:02:14 +03:00
Sarah Clements
34758f53dc Bug 1789652 - Overwrite closedIDs when restoring sessions r=Gijs 
* Add a helper in sessionstore to rewrite closedId's for all restored tabs
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D157235
 2022-09-14 13:08:25 +00:00
Niklas Baumgardner
442a88a9a0 Bug 1784019 - Keep window open when restoring if Firefox View is selected. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D154395
 2022-09-13 17:58:04 +00:00
Gijs Kruitbosch
6e20818109 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-04 08:04:09 +00:00
Iulian Moraru
5282da4259 Backed out changeset b63ab5a39b53 (bug 1787565) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-09-03 14:09:15 +03:00
Gijs Kruitbosch
8f8fa020b4 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-03 09:53:55 +00:00
Niklas Baumgardner
cdfc6ae5e9 Bug 1788002 - Shift selected tab index for Session Store when FxView is used. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156115
 2022-09-02 20:30:49 +00:00
Butkovits Atila
dd9a633a7c Backed out changeset df6d4e6e452c (bug 1787565) for causing failures at browser_ext_browserAction_popup_resize_bottom.js. 2022-09-02 16:26:14 +03:00
Gijs Kruitbosch
2a1088e2f8 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-02 12:32:45 +00:00
Antonin LOUBIERE
aaba160e8b Bug 1781292 - Fix possible TypeError in SessionStore#initSession. r=Gijs 
Fix possible null state, state.windows or state._closedWindows.

Differential Revision: https://phabricator.services.mozilla.com/D152791
 2022-07-26 16:36:40 +00:00
Antonin LOUBIERE
33089e48c2 Bug 1780532 - Fix SessionStore error: "The session file is invalid: TypeError: can't access property \"windows\", state is null". r=Gijs 
Fix possible state.windows with a null state.

Differential Revision: https://phabricator.services.mozilla.com/D152737
 2022-07-26 10:48:45 +00:00
Antonin LOUBIERE
edbd1ca064 Bug 1766669 - When closing last tabs of multiple windows, don't restore them on restart. r=Gijs 
After closing last tabs of multiple windows, only if we don't use session restore we restore them.

Differential Revision: https://phabricator.services.mozilla.com/D145112
 2022-07-18 14:00:01 +00:00
criss
8a86f23681 Backed out changeset 7f034002d8a0 (bug 1766669) for causing failures related to TestSessionStoreEnabledAllWindows.test_close_tabs. CLOSED TREE 2022-07-14 23:47:32 +03:00
Antonin LOUBIERE
ef0599a296 Bug 1766669 - When closing last tabs of multiple windows, don't restore them on restart. r=Gijs 
After closing last tabs of multiple windows, only if we don't use session restore we restore them.

Differential Revision: https://phabricator.services.mozilla.com/D145112
 2022-07-14 17:36:30 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
Dão Gottwald
f453703731 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D149367
 2022-06-17 07:56:26 +00:00
Butkovits Atila
246c21a815 Backed out changeset df17ec7a8095 (bug 1774377) for causing assertion failures at ErrorResult.h. CLOSED TREE 2022-06-16 01:20:24 +03:00
Dão Gottwald
ff2e859367 Bug 1774377 - Add Firefox View menu item to the Tools menu. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D149367
 2022-06-15 21:34:44 +00:00
Tooru Fujisawa
f094b522e1 Bug 1773829 - Part 3: Stop using lazy getter unnecessarily in browser/components/. r=MattN 
Depends on D149011

Differential Revision: https://phabricator.services.mozilla.com/D149012
 2022-06-15 20:56:23 +00:00
Tooru Fujisawa
bf9248c6a6 Bug 1772100 - Part 16: Use plain object for lazy getter in browser/components/sessionstore/. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D148026
 2022-06-06 22:46:25 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 04:42:09 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 02:49:13 +00:00
Sarah Clements
1cfa0525cb Bug 1767473 - Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster 
* add event listener and update list when a tab is closed
* add additional styling, favicon element and keyboard navigation support
* add tests

Differential Revision: https://phabricator.services.mozilla.com/D145906
 2022-05-25 14:26:43 -04:00
Cristian Tuns
b6d246ee8f Backed out changeset b6894cf5a5c7 (bug 1767473) for causing mochitest failures on browser_firefoxview_tab.js CLOSED TREE 2022-05-25 13:27:03 -04:00
Sarah Clements
1a502aadca Bug 1767473 - Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster 
* add event listener and update list when a tab is closed
* add additional styling, favicon element and keyboard navigation support
* add tests

Differential Revision: https://phabricator.services.mozilla.com/D145906
 2022-05-25 14:43:25 +00:00
Dão Gottwald
ce282fd1fd Bug 1770765 - Session Restore should ignore the Firefox View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D147088
 2022-05-24 13:51:35 +00:00
Csoregi Natalia
e7216df734 Backed out changeset a3e657cb7f55 (bug 1770765) for causing failures on browser_firefoxview_tab.js. CLOSED TREE 2022-05-23 21:15:50 +03:00
Cristian Tuns
015cbe386c Backed out changeset 5c914173639f (bug 1767473) for causing mochitest failures(Assertion failures) CLOSED TREE 2022-05-23 12:12:55 -04:00
Sarah Clements
84ae3abdff Bug 1767473 - Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster 
* add event listener and update list when a tab is closed
* add additional styling, favicon element and keyboard navigation support
* add tests

Differential Revision: https://phabricator.services.mozilla.com/D145906
 2022-05-23 15:36:17 +00:00
Dão Gottwald
2ae8a44c32 Bug 1770765 - Session Restore should ignore the Firefox View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D147088
 2022-05-23 15:08:36 +00:00
Nika Layzell
7bcd611177 Bug 1766951 - Avoid setting userTypedValue when restoring tabs, r=Gijs,farre 
This userTypedValue being set was preventing the UrlbarInput from
updating the page proxy state to "valid", and showing the firefox badge
correctly, as the browser thinks the user typed the URL into the urlbar,
rather than it reflecting the currently loaded page.

This patch removes that set which was introduced as a wallpaper fix in
bug 439675 as it should no longer be required for its original purpose
since bug 599909. See bug 1766951 comment 6 for more details about the
reasoning behind removing this assignment.

Differential Revision: https://phabricator.services.mozilla.com/D145389
 2022-05-05 22:55:38 +00:00
criss
78c57f6000 Backed out changeset 37b175d0a9fc (bug 1725701) for causing mochitest failures on browser_ext_tabs_discarded.js. CLOSED TREE 2022-05-05 15:55:42 +03:00
Luca Greco
82947b143e Bug 1725701 - Make sure resetBrowserToLazyState stores userTypedValue in the tabState if the cacheState only includes the isPrivate key. r=Gijs,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D144161
 2022-05-05 09:23:46 +00:00
Andreas Farre
ea19a48880 Bug 1739450 - Part 1: Move ownership of session store scroll and form data to platform. r=peterv 
Differential Revision: https://phabricator.services.mozilla.com/D130389
 2022-04-19 15:19:22 +00:00
Gijs Kruitbosch
1fb46fa941 Bug 1758250 - deal with non-existing url values from session restore so they don't brick other functionality, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D142947
 2022-04-12 10:39:03 +00:00
Luca Greco
74fad3adb6 Bug 1760936 - cache userTypedValue for discarded tab when already navigating or the tab does not have a cached history. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D142372
 2022-04-05 14:53:38 +00:00
Jonathan Watt
c9f14e24cd Bug 1757657. Remove some about:printpreview cruft that was missed in 1702501. r=mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D139993
 2022-04-04 17:19:24 +00:00
Masatoshi Kimura
4544c0d55b Bug 1762228 - Fix typo in SessionStore.jsm. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D142484
 2022-04-01 09:54:18 +00:00
Nika Layzell
3ea77b2aa2 Bug 1728332 - Part 1: Predict remote type when inserting restored tabs, r=Gijs 
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
 2022-03-25 22:25:55 +00:00
Cristian Tuns
05d7d28dae Backed out changeset 30fa07c96caa (bug 1728332) for causing mochitest failures on browser_tabs_in_urlbar.js CLOSED TREE 2022-03-21 19:02:16 -04:00
Nika Layzell
3317a3ef3f Bug 1728332 - Predict remote type when inserting restored tabs, r=Gijs 
This should mostly avoid the issue where newly created pinned tabs when
restoring a session are first created in the shared web process, and
migrated into the correct process upon navigating. I also added
remoteType prediction to the undoCloseTab and duplicateTab codepaths
to avoid unnecessary process changes there as well.

Differential Revision: https://phabricator.services.mozilla.com/D141146
 2022-03-21 21:44:14 +00:00
Emilio Cobos Álvarez
20ba7daa1c Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame 
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
 2022-02-16 12:18:12 +00:00
Emilio Cobos Álvarez
2b4bcbce12 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs 
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
 2022-02-16 12:18:12 +00:00
smolnar
ac36389b37 Backed out 6 changesets (bug 1753836) for causing mochitest failures in test_event_screenXY_with_zoom. CLOSED TREE 
Backed out changeset a572cbc0fac2 (bug 1753836)
Backed out changeset 371a495ff728 (bug 1753836)
Backed out changeset 774af76be463 (bug 1753836)
Backed out changeset faa8a8f2d40f (bug 1753836)
Backed out changeset 9209832ecffe (bug 1753836)
Backed out changeset db443ce0406d (bug 1753836)
 2022-02-16 01:47:51 +02:00
Emilio Cobos Álvarez
314f6c7716 Bug 1753836 - Make window screen and event screen coordinates consistent. r=jfkthame 
This basically undoes bug 1246346. The current behavior is pretty bizarre,
the screenX origin / position doesn't match the mouse event coordinates,
because on windows we return device pixels rather than CSS pixels for the
window coordinates.

This makes behavior consistent with how other browsers report these coordinates
at least on Windows in non-mixed DPI mode, and I think is fine.

In mixed DPI mode, there might indeed be overlapping coordinates, but again I
think that's fine, because the CSS coordinate space of the different monitors
is different.  You need to multiply by the devicePixelRatio if you want
coordinates not to overlap.

Depends on D138039

Differential Revision: https://phabricator.services.mozilla.com/D138130
 2022-02-15 22:25:05 +00:00