Commit Graph

109 Commits

Author SHA1 Message Date
Paul Zuehlcke
b036de13fc Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
2022-08-25 11:17:39 +00:00
Paul Zuehlcke
827061f5ff Bug 1783235 - Update about:privatebrowsing logos. r=Gijs,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D153779
2022-08-10 11:44:08 +00:00
Tooru Fujisawa
15758870e7 Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152429
2022-07-26 02:46:30 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
2022-06-29 23:01:37 +00:00
Jason Prickett
22f6a50c28 Bug 1770067 - Adding link support to private browsing promo button r=pdahiya,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D149571
2022-06-24 23:09:23 +00:00
Dan Mosedale
49b380eaef Bug 1748214 - Remove private browsing Nimbus feature, r=pdahiya,barret
Differential Revision: https://phabricator.services.mozilla.com/D146474
2022-06-15 16:03:17 +00:00
Punam Dahiya
06b2c92c46 Bug 1770061 - Enhance PBM Promo button to support all SpecialMessageActions r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D146751
2022-05-23 22:35:07 +00:00
Punam Dahiya
74fd8b3a3e Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-12 18:24:06 +00:00
Cristian Tuns
9a2ed99397 Backed out changeset eb12cdc5d1e8 (bug 1765907) for causing mochitest failures on browser_privatebrowsing_focus_promo.js CLOSED TREE 2022-05-10 14:38:02 -04:00
Punam Dahiya
daed30958c Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-10 17:12:05 +00:00
Meg Viar
083c4b4030 Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D145015
2022-05-04 13:35:28 +00:00
Meg Viar
48fd34f067 Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142551
2022-04-01 12:36:30 +00:00
Meg Viar
e6efb5e498 Bug 1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D141781
2022-03-23 19:56:59 +00:00
Punam Dahiya
241b77481c Bug 1754832 - Update PBM to support opening spotlight tab modal r=Mardak,mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140565
2022-03-17 06:41:47 +00:00
Punam Dahiya
bbc77f3f6c Bug 1756178 - Open link from the private browsing page in a new tab r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D139900
2022-03-01 18:38:23 +00:00
Dan Mosedale
5e02b224d2 Bug 1749775 - Add user telemetry for 98 VPN promo, r=andreio,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D135874
2022-02-11 16:31:06 +00:00
Andrei Oprea
799b962042 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-04 02:35:30 +00:00
Cosmin Sabou
443f0b25bb Backed out changeset edbc8f7e808f (bug 1748240) for bc failures on browser_privatebrowsing_about_nimbus.js. CLOSED TREE 2022-02-01 05:40:15 +02:00
Andrei Oprea
972606bfa5 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Depends on D134157

Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-01 01:36:28 +00:00
Andrei Oprea
f64147a52f Bug 1746598 - Route MS messages to PB newtab r=dmose,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D134157
2022-01-25 13:02:30 +00:00
Sandor Molnar
3e20f2d917 Backed out changeset ea22083f5525 (bug 1746598) for causing bc failures in browser/components/extensions/test/browser/browser_ext_menus_incognito.js CLOSED TREE 2022-01-24 10:53:24 +02:00
Andrei Oprea
96287321db Bug 1746598 - Route MS messages to PB newtab r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D134157
2022-01-24 07:49:45 +00:00
Punam Dahiya
124c2a8b01 Bug 1729766 - Update about:privatebrowsing with VPN promo r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125206
2021-09-16 15:25:47 +00:00
Sebastian Hengst
cf45139aa7 Backed out changeset 13fa4cea337f (Bug 1724019) on request from emcminn because of change of plans. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D124829

Depends on D124828
2021-09-07 20:41:56 +00:00
Sebastian Hengst
7b76b3b63b Backed out changeset ad063959d7b7 (Bug 1725977) on request by emcminn for change of plans. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D124828
2021-09-07 19:32:35 +00:00
Emily McMinn
7b6981008b Bug 1725977 - Remove the unused markup for the "below search" version of about:privatebrowsing r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D122879
2021-08-17 19:35:36 +00:00
Emily McMinn
927100e126 Bug 1724019 - Update about:privatebrowsing CSS, markup and tests r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D121753
2021-08-16 14:33:31 +00:00
Harry Twyford
58cf2e7f96 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-22 15:46:30 +00:00
Cosmin Sabou
b7f0575fc4 Backed out changeset 5a673b05aea0 (bug 1713827) for bc failures on browser_contentSearchUI_default.js. CLOSED TREE 2021-07-21 01:06:27 +03:00
Harry Twyford
107a1e3766 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-20 21:25:10 +00:00
Andrei Oprea
3fbca1cf31 Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 11:06:58 +00:00
Sandor Molnar
5b2a952c7e Backed out changeset f4ab27bcac2e (bug 1715504) for causing browser-chrome failures in browser_all_files_referenced. CLOSED TREE 2021-06-18 13:38:10 +03:00
Andrei Oprea
4f4f660965 Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 09:50:19 +00:00
Kate Hudson
2e7f27a4e9 Bug 1709344 - Add Nimbus to about:privatebrowsing r=desktop-theme-reviewers,andreio,harry
Differential Revision: https://phabricator.services.mozilla.com/D114268
2021-05-13 01:18:18 +00:00
Harry Twyford
180c0118e8 Bug 1616700 - Part 3 - Update the placeholder string on the handoff input to read "Search with {engine} or enter address" r=fluent-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108266
2021-03-23 22:56:54 +00:00
Harry Twyford
dc0789cef0 Bug 1616700 - Part 2 - Apply a disabled appearance to the handed-off input rather than hiding it. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108826
2021-03-23 22:56:54 +00:00
Alexandru Michis
7472bfb633 Backed out 3 changesets (bug 1616700) for causing failures in browser_privatebrowsing_about.js
Backed out changeset 5e1b8f75fef5 (bug 1616700)
Backed out changeset fdf97a561019 (bug 1616700)
Backed out changeset de3717cc63ef (bug 1616700)
2021-03-20 01:23:39 +02:00
Harry Twyford
7b440baa90 Bug 1616700 - Part 3 - Update the placeholder string on the handoff input to read "Search with {engine} or enter address" r=fluent-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108266
2021-03-19 21:31:13 +00:00
Harry Twyford
656e81ecc6 Bug 1616700 - Part 2 - Apply a disabled appearance to the handed-off input rather than hiding it. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D108826
2021-03-19 21:31:13 +00:00
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Luke Crouch
1b170bc32e Bug 1664360 also use Region.jsm for vpn region restriction r=baku
Differential Revision: https://phabricator.services.mozilla.com/D90287
2020-09-16 12:04:10 +00:00
Luke Crouch
7748bb5e2a Bug 1664360 - introduce browser.privatebrowsing.vpnpromourl r=baku
Use browser.privatebrowsing.vpnpromourl pref to control the display and link
param value of the VPN promo in about:privatebrowsing.

Differential Revision: https://phabricator.services.mozilla.com/D89916
2020-09-14 09:29:44 +00:00
Neil Deakin
568dfb76ca Bug 1614744, convert about:privatebrowsing to JSWindowActor-based remote page manager, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D71023
2020-04-29 23:19:15 +00:00
Jim Porter
1e7acf7903 Bug 1529969 - Only request info about the current engine to the parent; r=adw,Mardak
This patch adds a new ContentSearchHandoffUI class to be used when search
handoff is enabled in the newtab page, avoiding the much more complex
ContentSearchUI. This also reduces the amount of unnecessary information being
sent across processes.

Differential Revision: https://phabricator.services.mozilla.com/D48776
2019-12-17 21:02:52 +00:00
Cosmin Sabou
a9953e7a7d Backed out changeset 6636e1cd0c41 (bug 1529969) for causing node tests newtab failures. CLOSED TREE 2019-12-17 21:55:48 +02:00
Jim Porter
52db4279ce Bug 1529969 - Only request info about the current engine to the parent; r=adw,Mardak
This patch adds a new ContentSearchHandoffUI class to be used when search
handoff is enabled in the newtab page, avoiding the much more complex
ContentSearchUI. This also reduces the amount of unnecessary information being
sent across processes.

Differential Revision: https://phabricator.services.mozilla.com/D48776
2019-12-17 07:06:59 +00:00
Mike de Boer
ba9bb1d4fd Bug 1587817 - Move the default search engine in Private Browsing mode for in-content search access points to be contained in ContentSearch.jsm. r=Mardak,Standard8
This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49559
2019-10-17 13:02:09 +00:00
Mark Banner
52b609654b Bug 1580830 - Add a display to the private browsing page to inform of the new setting for search engines in private mode. r=mikedeboer,fluent-reviewers,flod
This implements the introduction display for the new search engine preference.

The decision for whether or not to display the introduction is handled in AboutPrivateBrowsingHandler.jsm, as we need
to limit it to being displayed once per session.

Differential Revision: https://phabricator.services.mozilla.com/D48722
2019-10-10 20:00:51 +00:00