Commit Graph

94 Commits

Author SHA1 Message Date
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
James Teow
d99404900f Bug 1760637 - Upgrade initPanel in instantEditBookmark.js to async r=mak
In addition to adding async/await, I also added early return statements
when we know initialization is occuring again, or if there is evidence
that it has been uninitialized.

A concrete example of this would be from the Library, where clicking on
on a folder/category on the left will run initPanel at the same time as
the highlighted folder/bookmark on the right changes (also runs initPanel).

Differential Revision: https://phabricator.services.mozilla.com/D141800
2022-05-17 00:32:48 +00:00
Evgenia Kotovich
cd45049954 Bug 1747689: Changed browser_bookmarkProperties_editTagContainer.js to pass with editBookmark.js. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D138986
2022-03-21 15:54:44 +00:00
Evgenia Kotovich
e3f6268b2e Bug 1747689 - Saving bookmarkState and passing to PlaceUIUtils for perform changes. r=mak,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D137234
2022-02-24 10:07:39 +00:00
Evgenia Kotovich
92cf724d6b Bug 1747689 - Adding StateObject to catch current BM state. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D135811
2022-02-24 10:07:39 +00:00
Evgenia Kotovich
6274c6f092 Bug 1747692 - Remove ObserverChanges in editBookmark.js. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D135579
2022-02-02 11:08:20 +00:00
Evgenia Kotovich
2d9bc99735 Bug 1747684 - Clone instantEditBookmark.js to editBookmark.js and connect both. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D134774
2022-01-10 18:40:39 +00:00
Evgenia Kotovich
33a6258c3f Bug 1747684 - Rename editBookmark.js to instantEditBookmark.js. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D134723
2022-01-10 18:40:39 +00:00
Mark Banner
260f6e54b3 Bug 1711726 - Enable ESLint jsdoc validation for browser/components/places/content/editBookmark.js. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D131150
2021-11-16 17:14:08 +00:00
Daisuke Akatsuka
9e996b7457 Bug 1678607: Apply bookmark-tags-changed event. r=mak
Depends on D128326

Differential Revision: https://phabricator.services.mozilla.com/D128327
2021-10-18 04:43:44 +00:00
Alexandru Michis
6c614ebe26 Backed out 3 changesets (bug 1678607) for causing bc failures in browser_bookmark_add_tags.js
Backed out changeset bf20be578758 (bug 1678607)
Backed out changeset fd3fbf15e95d (bug 1678607)
Backed out changeset 2688fa3d2bc2 (bug 1678607)
2021-10-18 03:10:58 +03:00
Daisuke Akatsuka
7de5abf75b Bug 1678607: Apply bookmark-tags-changed event. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D128327
2021-10-17 22:47:37 +00:00
Daisuke Akatsuka
48273c63f4 Bug 1678624: Apply bookmark-url-changed event. r=mak
Depends on D103883

Differential Revision: https://phabricator.services.mozilla.com/D103884
2021-10-05 00:53:45 +00:00
Daisuke Akatsuka
d879fcb087 Bug 1678623: Apply bookmark-title-changed event. r=mak
Depends on D103147

Differential Revision: https://phabricator.services.mozilla.com/D103148
2021-10-01 12:01:29 +00:00
Michael Kohler
de15833f85 Bug 1706143 - Do not show bookmark toolbar when creating/editing bookmark if set to never be shown r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D125096
2021-09-15 15:42:47 +00:00
Michelle Goossens
03efbb72dc Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D116903
2021-06-11 18:14:26 +00:00
Dorel Luca
a209313c07 Backed out 3 changesets (bug 1714349) for Browser-chrome failures in browser/components/places/tests/browser/browser_addBookmarkForFrame.js. CLOSED TREE
Backed out changeset 598f8e7d73ef (bug 1714349)
Backed out changeset cc7365aacdbb (bug 1714349)
Backed out changeset f0f942a93495 (bug 1714349)
2021-06-09 04:48:41 +03:00
Michelle Goossens
eb770bc002 Bug 1714349 - Remove browser.proton.modals.enabled pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D116903
2021-06-08 22:16:33 +00:00
Michelle Goossens
3c5cf97d9b Bug 1714352 - Remove browser.proton.doorhangers.enabled pref r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D117091
2021-06-08 00:41:43 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D115233
2021-05-18 16:27:44 +00:00
Daisuke Akatsuka
e17f7bc3a8 Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
9dd25c8501 Bug 1511062: Apply bookmark-moved event. r=mak
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
2021-05-06 04:24:35 +00:00
Daisuke Akatsuka
d117f59c8f Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D102572
2021-05-06 04:24:34 +00:00
Csoregi Natalia
ce52bc5e1a Backed out 4 changesets (bug 1511062) for causing bustage on nsNavHistoryResult.cpp. CLOSED TREE
Backed out changeset ed9ac8c3097b (bug 1511062)
Backed out changeset dc8c9488cf1a (bug 1511062)
Backed out changeset 2cf6fca33bf3 (bug 1511062)
Backed out changeset 87b0bbbcb0e6 (bug 1511062)
2021-05-06 05:53:12 +03:00
Daisuke Akatsuka
28b00086fd Bug 1511062: Remove onItemMoved from nsINavBookmarkObserver. r=mak
Depends on D102574

Differential Revision: https://phabricator.services.mozilla.com/D102575
2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
cf9542ed5b Bug 1511062: Apply bookmark-moved event. r=mak
Depends on D102573

Differential Revision: https://phabricator.services.mozilla.com/D102574
2021-05-06 02:29:44 +00:00
Daisuke Akatsuka
43e96443cc Bug 1511062: Remove old/new parent id from onItemMoved in nsINavBookmarkObserver. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D102572
2021-05-06 02:29:43 +00:00
Csoregi Natalia
010df0501b Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE 2021-04-28 18:09:01 +03:00
Emma Malysz
91c90b996d Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 03:17:56 +00:00
Butkovits Atila
e3f5ddbc25 Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE 2021-04-28 05:55:14 +03:00
Emma Malysz
75fb2ad086 Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 00:29:45 +00:00
Neil Deakin
9ea279221e Bug 1703002, don't scroll when focusing the textbox in the edit bookmark panel, r=mak
Note that Element.select() always focuses the element without scrolling, so the call to focus()
is redundant, but we'll leave it in anyway in case that changes.

Differential Revision: https://phabricator.services.mozilla.com/D111114
2021-04-08 13:32:45 +00:00
Mike Conley
553db97ffc Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
This updates the styling of the Bookmarks Panel for Proton, and also:

* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec

Depends on D109376

Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 17:51:58 +00:00
Dorel Luca
56872eef65 Backed out 2 changesets (bug 1697507, bug 1697491) for Browser-chrome in browser/components/places/tests/browser/browser_bookmark_remove_tags.js. CLOSED TREE
Backed out changeset 83a561e6c1d0 (bug 1697507)
Backed out changeset 319022b89093 (bug 1697491)
2021-03-30 20:17:13 +03:00
Mike Conley
2699b0b497 Bug 1697507 - Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry
This updates the styling of the Bookmarks Panel for Proton, and also:

* Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
* Makes text input elements in panels be 32px tall, per spec

Differential Revision: https://phabricator.services.mozilla.com/D109638
2021-03-30 16:40:32 +00:00
Micah Tigley
e4dc9471fb Bug 1693139 - Add label captions for tags and keyword fields. r=Gijs,fluent-reviewers
Depends on D108871

Differential Revision: https://phabricator.services.mozilla.com/D108872
2021-03-30 00:56:36 +00:00
Daisuke Akatsuka
dd7b0db1ba Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105441
2021-02-25 01:58:24 +00:00
smolnar
34fc339425 Backed out 3 changesets (bug 897954) for causing node test failures in PlacesFeed. CLOSED TREE
Backed out changeset 0a60eb3f7ba8 (bug 897954)
Backed out changeset 9443814d173b (bug 897954)
Backed out changeset 2e558ac8e419 (bug 897954)
2021-02-25 03:21:58 +02:00
Daisuke Akatsuka
75041c3461 Bug 897954: Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D105441
2021-02-25 00:12:40 +00:00
Marco Bonardo
5fee7240ed Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 16:28:04 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
2020-11-23 16:49:31 +02:00
Marco Bonardo
ae29233b62 Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
2020-11-23 12:56:40 +00:00