corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

525 Commits

Author SHA1 Message Date
Shane Hughes
509e6cf163 Bug 1783207 - Add ellipsis to some menu label strings. r=flod 
The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!

Differential Revision: https://phabricator.services.mozilla.com/D154320
 2022-08-11 17:48:11 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
Mark Banner
b95b1937fa Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 22:34:20 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Mark Banner
3db870a25d Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 15:50:39 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Mark Banner
c9b826a4b1 Bug 1779982 - Use explicit imports in controller.js rather than telling ESLint about imports from modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D152003
 2022-07-20 10:36:49 +00:00
Kagami Sascha Rosylight
4fb733cb3b Bug 1773740 - Part 4: Reapply mach -l eslint --fix with use-isInstance changes r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148939
 2022-06-27 20:31:34 +00:00
Masatoshi Kimura
7b0749ad93 Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 15:51:59 +00:00
Norisz Fay
e7715de615 Backed out changeset bcc49b21bd0e (bug 1754805) for causing multiple failures CLOSED TREE 2022-03-31 17:01:58 +03:00
Masatoshi Kimura
eba22b696e Bug 1754805 - Add "Open in New Container Tab" to places context menu. r=mak,fluent-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D138454
 2022-03-31 13:27:52 +00:00
Lebar
eab036787c Bug 1741603 - Fix Show in Folder context menu item in app menu to open in sidebar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139230
 2022-03-15 17:35:22 +00:00
Evgenia Kotovich
7c2a87cee4 Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-28 07:46:06 +00:00
Evgenia Kotovich
c597e5d1d5 Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-28 07:46:06 +00:00
Lebar
3d36116e67 Bug 1747200 - Added call to ensureRowIsVisible to make sure that selected node is in view after showInFolder. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D135672
 2022-01-27 14:53:43 +00:00
Mark Banner
2649c5fb78 Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D136368
 2022-01-20 14:15:34 +00:00
Cristian Tuns
a6563e6738 Backed out 2 changesets (bug 1725487) for causing mochitest failures on browser_toolbar_drop_bookmarklet.js CLOSED TREE 
Backed out changeset 1564124c0309 (bug 1725487)
Backed out changeset ae5ab5c447c3 (bug 1725487)
 2022-01-13 07:23:29 -05:00
Evgenia Kotovich
6ef5f7142e Bug 1725487 - Don't allow dragging multiple uris if one is javascript:link. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D134395
 2022-01-13 11:05:59 +00:00
Evgenia Kotovich
ce5749f98a Bug 1725487 - Show the Add Bookmark Dialog when dragging javascript url to create a bookmarklet. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D133813
 2022-01-13 11:05:59 +00:00
Paul Zuehlcke
4134ccfa27 Bug 1735122 - Fix esc key accepting the 'forget about this site' confirmation prompt. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D128089
 2021-10-15 15:07:06 +00:00
Lebar
86d6cd4771 Bug 469441 - Added 'Show in Folder' context menu item for bookmark library searches and bookmarks sidebar. r=Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D121040
 2021-10-04 21:07:09 +00:00
Mark Banner
f321dfd6b1 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 12:09:49 +00:00
Noemi Erli
20dee875a7 Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE 
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
 2021-09-10 13:14:12 +03:00
Mark Banner
6a5ffbcc55 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D124838
 2021-09-10 09:38:42 +00:00
Stefan Zabka
a51b55b8f2 Bug 1711759 - Ask user for confirmation in Forget about this site. r=pbz,Standard8,flod 
Differential Revision: https://phabricator.services.mozilla.com/D120363
 2021-09-02 11:55:52 +00:00
Gijs Kruitbosch
e93d5b7bcc Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D124045
 2021-09-01 16:08:50 +00:00
Nicholas Fason
f0a8082876 Bug 1702708 - Hyphenate places context menu attributes r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D121583
 2021-08-03 14:03:03 +00:00
Paul Zuehlcke
8c971e0b12 Bug 1705028 - Update places forget-this-site to clear storage by base domain. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D113495
 2021-05-26 13:49:36 +00:00
Mark Banner
f144cfcf62 Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D115233
 2021-05-18 16:27:44 +00:00
Bernard Igiri
8f33752c03 Bug 1705105 - Update bookmarks folder context menu r=fluent-reviewers,mak,flod 
Changed the text on the edit and delete folder buttons and moved position of the Sort By Name menu item.

Differential Revision: https://phabricator.services.mozilla.com/D112110
 2021-04-16 17:27:00 +00:00
Marco Bonardo
4e88c4821b Bug 1700929 - Restore Open All in tabs in some Places context menus. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110478
 2021-04-02 07:38:51 +00:00
Marco Bonardo
184c593112 Bug 1700929 - Restore Places context menu Delete on mixed selection. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110477
 2021-04-02 07:38:51 +00:00
Marco Bonardo
257ee6452c Bug 1700929 - Introduce an 'hideifsingleclickopens' attribute to show/hide Open in the Places context menu. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110476
 2021-04-02 07:38:51 +00:00
Marco Bonardo
141a43777d Bug 1700929 - Do some renames and cleanup comments a bit in bookmarks context menu code. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D110475
 2021-04-02 07:38:50 +00:00
Micah Tigley
1d1363d4d7 Bug 1693139 - Open bookmarks dialogs with in-window modal, plus some styling to input fields. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D108870
 2021-03-30 00:56:35 +00:00
Erica Wright
a63671ee72 Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D106046
 2021-03-02 15:34:56 +00:00
Butkovits Atila
db896883ba Backed out changeset b3df95f06470 (bug 1692668) for causing failure at browser_bookmark_change_location.js. CLOSED TREE 2021-02-26 23:07:49 +02:00
Erica Wright
b867fe56b5 Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D106046
 2021-02-26 18:38:07 +00:00
Tom Schuster
f7d112c734 Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D103555
 2021-02-01 12:05:12 +00:00
Jared Wein
84ba59a4bb Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 23:00:47 +00:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js 
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
 2020-11-05 22:55:59 +02:00
Jared Wein
76c6dfa789 Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 19:09:18 +00:00
Sonia Singla
30a78c48fc Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D85021
 2020-07-29 11:19:09 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D81594
 2020-07-10 23:58:28 +00:00
Marco Bonardo
5170074e9a Bug 1627361 - Stop examining the clipboard data when updating Places commands. r=Standard8 
We used to read the contents of the clipboard to tell if paste was enabled,
that unfortunately means updating commands was extremely slow for large
clipboard data.
After this change we only check the data flavors. This means paste will be
enabled more often, even for unsupported strings, but commands updating will
be much faster. Places updates commands often, so this is quite useful.

Differential Revision: https://phabricator.services.mozilla.com/D75202
 2020-05-15 14:20:58 +00:00
Ian Moody
0a0d8bf126 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi 
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
 2020-05-05 17:41:36 +00:00
Mark Banner
2020ed2c7e Bug 1622243 - Implement the bookmark pages option in the library window. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D68776
 2020-04-07 12:56:19 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D66128
 2020-03-13 23:38:52 +00:00