gliu20
39abe7b5e3
Bug 1731889 - Remove the 'visibility' property instead of setting it to 'visible' so a11y tools don't read these when their parent is hidden. r=morgan,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D126527
2022-04-14 15:02:56 +00:00
Evgenia Kotovich
dc3de3c6e2
Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D134607
2022-01-20 10:04:52 +00:00
Michael Kohler
87790d1825
Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D127588
2021-10-14 07:51:14 +00:00
Butkovits Atila
4cca62bc4e
Backed out changeset a0d24b8d7d30 (bug 1731889) for causing failures in browser_toolbar_overflow.js. CLOSED TREE
2021-09-27 18:55:46 +03:00
Jared Wein
0a7bcca102
Bug 1731889 - Remove the 'visibility' property instead of setting it to 'visible' so a11y tools don't read these when their parent is hidden. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D126527
2021-09-27 14:28:30 +00:00
Kagami Sascha Rosylight
40b97ae847
Bug 1635018 - Part 2: Replace dragexit with dragleave in browser/ r=Gijs,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D121190
2021-08-05 14:33:39 +00:00
Neil Deakin
51fa0ffa1d
Bug 1717680, manage the last context menu trigger node in places utils rather than using document.popupNode, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D118523
2021-07-09 11:51:15 +00:00
Mark Banner
f144cfcf62
Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D115233
2021-05-18 16:27:44 +00:00
Markus Stange
2444e8909a
Bug 1704948 - Remove onclick handlers from menuitems, because menuitems now dispatch command events even on middle click. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D112046
2021-04-20 17:44:17 +00:00
Narcis Beleuzu
2fd43d5a0b
Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
...
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
4906af56a7
Bug 1704948 - Remove onclick handlers from menuitems, because menuitems now dispatch command events even on middle click. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D112046
2021-04-14 21:23:28 +00:00
Marco Bonardo
257ee6452c
Bug 1700929 - Introduce an 'hideifsingleclickopens' attribute to show/hide Open in the Places context menu. r=adw
...
Differential Revision: https://phabricator.services.mozilla.com/D110476
2021-04-02 07:38:51 +00:00
Erica Wright
a63671ee72
Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-03-02 15:34:56 +00:00
Butkovits Atila
db896883ba
Backed out changeset b3df95f06470 (bug 1692668) for causing failure at browser_bookmark_change_location.js. CLOSED TREE
2021-02-26 23:07:49 +02:00
Erica Wright
b867fe56b5
Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-02-26 18:38:07 +00:00
Micah Tigley
a5ff856247
Bug 1674840 - Add Other Bookmarks folder to toolbar dynamically. r=Gijs,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D99701
2020-12-17 16:52:35 +00:00
Marco Bonardo
c6cc66825a
Bug 1464322 - Intermittent failure in browser_toolbar_overflow.js. r=adw
...
Fix a race condition in _updateNodesVisibilityTimerCallback and skip nodes that
are not effective bookmarks, like the chevron or the other bookmarks button.
Differential Revision: https://phabricator.services.mozilla.com/D99900
2020-12-16 18:06:21 +00:00
Kagami Sascha Rosylight
442b9d5680
Bug 1681592 - Promisify requestAnimationFrame in _rebuild r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D99282
2020-12-11 18:17:52 +00:00
Micah Tigley
04928862eb
Bug 1680732 - Call updateNodesVisibility() from 'Show Other Bookmarks' pref observer. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D98777
2020-12-10 20:42:40 +00:00
Gijs Kruitbosch
f12bbd2265
Bug 1680762 - ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D98995
2020-12-09 19:39:16 +00:00
Csoregi Natalia
3f90c93269
Backed out changeset 82046518530a (bug 1680762) for failures on browser_drag_bookmarks_on_toolbar.js. CLOSED TREE
2020-12-09 18:18:34 +02:00
Gijs Kruitbosch
837ba87d6d
Bug 1680762 - ensure both link clicks and drag/drop into the bookmarks toolbar works, r=jaws,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D98995
2020-12-09 15:08:58 +00:00
Marco Bonardo
4afae3b310
Bug 1677408 - Part 7 - Allow the view to opt-out of history details updates. r=Standard8
...
In most cases bookmarks views don't need to be notified of history changes.
The only cases where they need that, is when history columns are visible in a
tree view, or the result is sorted by visits or frecency.
Thus, the menu and toolbar views can often save some work by not listening.
Differential Revision: https://phabricator.services.mozilla.com/D97280
2020-11-23 16:29:54 +00:00
Butkovits Atila
c08d529090
Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE
...
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
2020-11-23 16:49:31 +02:00
Marco Bonardo
86303d66c6
Bug 1677408 - Part 7 - Allow the view to opt-out of history details updates. r=Standard8
...
In most cases bookmarks views don't need to be notified of history changes.
The only cases where they need that, is when history columns are visible in a
tree view, or the result is sorted by visits or frecency.
Thus, the menu and toolbar views can often save some work by not listening.
Differential Revision: https://phabricator.services.mozilla.com/D97280
2020-11-23 12:59:17 +00:00
Micah Tigley
2218b31ae9
Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D97211
2020-11-19 21:49:26 +00:00
Narcis Beleuzu
016b07dbf6
Backed out 2 changesets (bug 1674539) for bc failures on browser_toolbar_other_bookmarks.js . CLOSED TREE
...
Backed out changeset 63032f8390ea (bug 1674539)
Backed out changeset 36ab7b9324d9 (bug 1674539)
2020-11-19 23:46:02 +02:00
Micah Tigley
afe05f330b
Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D97211
2020-11-19 20:40:04 +00:00
Jared Wein
84ba59a4bb
Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
...
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.
Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 23:00:47 +00:00
Narcis Beleuzu
479647874f
Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
...
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Jared Wein
76c6dfa789
Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
...
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.
Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 19:09:18 +00:00
Micah Tigley
17aa816f05
Bug 1674756 - Use PlacesMenu helper for building the Other Bookmarks menupop. r=jaws,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D95781
2020-11-05 03:03:07 +00:00
Dorel Luca
c86aeda4ee
Backed out 2 changesets (bug 1674801, bug 1674756) for Browse-chrome failures in places/tests/browser/browser_toolbar_other_bookmarks.js. CLOSED TREE
...
Backed out changeset d2697818f40d (bug 1674801)
Backed out changeset cbb47b6c9dc3 (bug 1674756)
2020-11-05 00:09:47 +02:00
Micah Tigley
ba6a0e2b52
Bug 1674756 - Use PlacesMenu helper for building the Other Bookmarks menupop. r=jaws,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D95781
2020-11-04 20:46:15 +00:00
Micah Tigley
a9a0aa5aea
Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D93698
2020-10-28 22:37:51 +00:00
Dorel Luca
b959dcf2b1
Backed out 2 changesets (bug 1664053) for Browser-chrome failures. CLOSED TREE
...
Backed out changeset 7ead316c420d (bug 1664053)
Backed out changeset 7ae93e1c8b86 (bug 1664053)
2020-10-26 20:08:38 +02:00
Micah Tigley
2171053b5c
Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D93698
2020-10-22 02:04:24 +00:00
Jared Wein
b881c15686
Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D93301
2020-10-19 16:52:32 +00:00
Sonia Singla
30a78c48fc
Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D85021
2020-07-29 11:19:09 +00:00
Masatoshi Kimura
20ab3af5ff
Bug 1601235 - Remove the second arg of nsIXULBrowserWindow::SetOverLink. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D55946
2019-12-05 14:23:01 +00:00
monikamaheshwari
edb30ffaec
Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Brian Grinstead
f9b8523642
Bug 1578569 - Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup r=mak
...
This was removed in Bug 1573158, where the following line change forced it to 0px:
https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12
This uses shadow parts instead of Shadow DOM + XBL selectors into the arrowscrollbox,
which unblocks arrowscrollbox Custom Element conversion and appears to have the same
visual effect as far as I can tell.
Differential Revision: https://phabricator.services.mozilla.com/D44556
2019-09-04 18:37:04 +00:00
Jared Wein
a559a71435
Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D40745
2019-08-08 15:18:49 +00:00
Bogdan Tara
b60cea4f7a
Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
...
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Alexander Surkov
b2f6a8c01e
Bug 1539651 - Convert places-popup-base and places-popup-arrow bindings to Custom Elements r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D33821
2019-08-08 14:28:36 +00:00
Jared Wein
8bcdbe62ed
Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D40745
2019-08-08 01:38:50 +00:00
Victor Porof
8eb72fd3fc
Bug 1561435 - Format browser/components/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Marco Bonardo
231f6645fe
Bug 1502119 - Remove obsolete nodeAnnotationChanged. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D34998
2019-06-16 13:46:14 +00:00
Andrew Swan
701b88bcd2
Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins
...
Code here explicitly references lastElementChild inside a toolbarbutton
but it doesn't have any tests so it wasn't caught when bug 1519577 landed :(
Differential Revision: https://phabricator.services.mozilla.com/D33104
2019-05-30 03:29:19 +00:00
Andrew Swan
1ab513d145
Bug 1519577 Convert toolbarbutton to a custom element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00