corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

1027 Commits

Author SHA1 Message Date
Punam Dahiya
9d5f7c528f Bug 1734127 - Fix displayed colorways name inside variation circle r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D127574
 2021-10-06 04:55:10 +00:00
Scott
4b13dd6aa5 Bug 1733675 - Fixes some nits in Pocket newtab experiment. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D127338
 2021-10-04 20:39:08 +00:00
Harry Twyford
f6c835067b Bug 1733646 - Use secondary background color in newtab context menus. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D127293
 2021-10-01 20:37:05 +00:00
Emily McMinn
d7efd82d81 Bug 1730571 - Add Thank You page to about:welcome flow r=pdahiya,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126406
 2021-10-01 15:06:27 +00:00
Punam Dahiya
d5c83d4cec Bug 1728852 - Add monochromatic themes to about:welcome r=Mardak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126346
 2021-09-30 22:32:58 +00:00
Scott
bae6836889 Bug 1730017 - Adding save to Pocket button to newtab Pocket cards on hover. r=fluent-reviewers,flod,gvn 
Differential Revision: https://phabricator.services.mozilla.com/D126748
 2021-09-29 20:20:32 +00:00
Scott
b1ecb29b6d Bug 1730018 - New Pocket footer section on newtab r=gvn,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126268
 2021-09-23 22:08:37 +00:00
Scott
d88d5f1009 Bug 1729946 - Adding Pocket newtab load more button. r=fluent-reviewers,gvn,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125631
 2021-09-23 02:48:38 +00:00
Andrei Oprea
52cf1b8ef5 Bug 1729943 - Fix json schema for Messaging System Spotlight component r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D125389
 2021-09-22 10:00:01 +00:00
Butkovits Atila
91d0db9a30 Backed out 3 changesets (bug 1719939, bug 1726437, bug 1730262) for causing failures on test_browserGlue_migration_ctrltab_recently_used_order.js. 
Backed out changeset ea1653e9644f (bug 1719939)
Backed out changeset 01f90db715a7 (bug 1726437)
Backed out changeset c0e23b2acfbb (bug 1730262)
 2021-09-21 05:15:31 +03:00
Junjie Ying
11151d13b2 Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D125345
 2021-09-21 00:03:49 +00:00
Andrei Oprea
bb93a041e0 Bug 1730497 - Add targeting attribute to detect browser pinned status r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125858
 2021-09-17 11:54:54 +00:00
Harry Twyford
44fb51f43f Bug 1727319 - Part 3 - Remove unused hardcoded colors in _variables.scss. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125609
 2021-09-16 21:50:30 +00:00
Harry Twyford
bd18b6c4d2 Bug 1727319 - Part 2 - Remove intermediary variables in _theme.scss. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125608
 2021-09-16 21:50:29 +00:00
Harry Twyford
fb98c10513 Bug 1727319 - Assign set of colors from bug 1727317 to the existing new tab CSS variables. r=Mardak 
While this is mainly a refactoring patch, a few visible effects are expected:
- Proton Primary teal is now used correctly in dark mode. I confirmed with UX that we want this.
- Various minor elements now may use slightly different colors than before. Things like hover states and borders are now functions of the main colors on the page rather than their own hardcoded colors. While one might be able to spot differences in a side-by-side comparison, the general idea is to capture the same "feeling".

Differential Revision: https://phabricator.services.mozilla.com/D125607
 2021-09-16 21:50:29 +00:00
Harry Twyford
2c68cf2971 Bug 1727317 - Define set of color variables to use in newtab. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125606
 2021-09-16 21:50:29 +00:00
Scott
79862bace3 Bug 1717682 - Pref and implementation for compact 4 card row layout for Pocket newtab. r=fluent-reviewers,gvn,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125307
 2021-09-15 23:47:41 +00:00
Harry Twyford
02b78f9fd1 Bug 1727333 - Add ntp_card_background theme API property. r=desktop-theme-reviewers,dao,mixedpuppy 
We want to introduce this new variable to be able to theme more surfaces on the NTP. ntp_card_background is the color of cards (top site tiles, Pocket cards, etc).

This patch changes browser_ext_themes_ntp_colors_perwindow.js and browser_ext_theme_ntp_colors.js. These aren't the most reliable tests; they fail on central and have [a lot of issues](https://bugzilla.mozilla.org/buglist.cgi?f5=component&f3=OP&f2=OP&f8=status_whiteboard&f9=cf_crash_signature&list_id=15832113&v8=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o8=substring&query_format=advanced&v9=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o9=substring&o5=substring&f10=CP&v5=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&f6=alias&classification=Client%20Software&classification=Developer%20Infrastructure&classification=Components&classification=Server%20Software&classification=Other&o4=substring&v4=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o7=substring&v1=Graveyard&f11=CP&o1=notequals&v7=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&j3=OR&f4=product&f1=classification&f7=short_desc&v6=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o6=substring). I will follow-up and attempt to fix them to be more reliable.

Differential Revision: https://phabricator.services.mozilla.com/D125115
 2021-09-15 18:54:02 +00:00
Harry Twyford
9ffc6060d1 Bug 1730560 - Fix newtab customize checkbox color. r=Mardak 
This patch also renames --customize-menu-primary-action-text to --customize-menu-slider-fill, since that's the only place its used.

Differential Revision: https://phabricator.services.mozilla.com/D125461
 2021-09-13 21:24:37 +00:00
Harry Twyford
75f4dc3868 Bug 1727321 - Part 4 - Stop using color variables elsewhere in newtab. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124401
 2021-09-08 22:06:27 +00:00
Harry Twyford
1cbd7abe67 Bug 1727321 - Part 3 - Stop using color variables in box-shadows. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124399
 2021-09-08 22:06:27 +00:00
Harry Twyford
a327978c95 Bug 1727321 - Part 2 - Stop using color variables in buttons. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124398
 2021-09-08 22:06:26 +00:00
Harry Twyford
913233dfed Bug 1727321 - Part 1 - Stop using color variables in links. r=thecount 
The purpose of this stack of patches is to stop using color variables directly in newtab CSS in favour of the semantic variables defined in _theme.scss. That way, we can later refactor _theme.scss to use theme variables instead of hardcoded colors.

There's a lot of dead CSS/components in new tab. This stack of patches refactors dead code as well, mostly because it's not clear what is dead and what is not. I tried to keep things generally looking the same on visible surfaces, but there are some minor style differences in dead components and in asrouter devtools. I spoke to Mardak on Slack and he confirmed it would be okay to slightly change the look of dead components. Scott, I tagged you for review since you know what is dead and what is not.

Differential Revision: https://phabricator.services.mozilla.com/D124397
 2021-09-08 22:06:26 +00:00
Harry Twyford
ff0ec1287a Bug 1726432 - Part 4 - Remove unused variables. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123387
 2021-09-08 22:06:26 +00:00
Harry Twyford
b421d1a2ae Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123386
 2021-09-08 22:06:25 +00:00
Harry Twyford
edebf41522 Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable. r=amy 
This is the variable we will eventually replace with ntp_secondary or equivalent.

Differential Revision: https://phabricator.services.mozilla.com/D123385
 2021-09-08 22:06:25 +00:00
Harry Twyford
89b1a551a1 Bug 1726432 - Part 1 - Remove newtab-experience class. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123384
 2021-09-08 22:06:24 +00:00
Harry Twyford
48fbf1d8f5 Bug 1710937 - Part 6 - Remove code related to showing fallback screenshots in Top Sites. r=amy 
I confirmed with Julian Gaibler that we don't want to show screenshots as fallbacks in Top Sites. We still want to support custom icons and screenshots in the "Recent activity" section, both of which are unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D123253
 2021-09-08 22:06:24 +00:00
Harry Twyford
caf54ef43c Bug 1710937 - Part 4 - Remove SectionMenus and section header icons. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123251
 2021-09-08 22:06:23 +00:00
Harry Twyford
9849e0e98e Bug 1710937 - Part 2 - Remove showCustomizationMenu pref and associated code. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123249
 2021-09-08 22:06:22 +00:00
Harry Twyford
b62fce7b38 Bug 1710937 - Part 1 - Remove newNewTabExperienceEnabled pref and associated code. r=amy,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D123248
 2021-09-08 22:06:22 +00:00
Andrei Oprea
3cbae7f729 Bug 1728420 - New messaging surface Spotlight r=Mardak,dmose,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D121913
 2021-09-03 13:41:21 +00:00
Scott
212496dc5d Bug 1725160 - Fixing newtab Pocket context menu position. r=gvn,zbraniecki 
Differential Revision: https://phabricator.services.mozilla.com/D123152
 2021-08-26 07:06:55 +00:00
Butkovits Atila
d74a262bb2 Backed out changeset 51400ee7a844 (bug 1725160) for causing failures at browser_newtab_last_LinkMenu.js. 2021-08-25 21:15:57 +03:00
Scott
56f393013e Bug 1725160 - Fixing newtab Pocket context menu position. r=gvn,zbraniecki 
Differential Revision: https://phabricator.services.mozilla.com/D123152
 2021-08-25 15:41:26 +00:00
Andrei Oprea
4d599e6e9a Bug 1726739 - Adjust profile activity related targeting to 28 day time interval r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D123212
 2021-08-23 17:51:26 +00:00
Andrei Oprea
14419b8a91 Bug 1725131 - Remove messaging system code related to the Bookmark panel r=pdahiya,Mardak,webdriver-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D122342
 2021-08-19 13:17:13 +00:00
Punam Dahiya
dceb09098b Bug 1721614 - Handle blank onboarding screen on navigating back from about:home r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D121037
 2021-08-04 23:04:22 +00:00
Emily McMinn
52a652ffb9 Bug 1722869 - Fix broken RTAMO styles for proton r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D121426
 2021-08-02 17:37:57 +00:00
Andrei Oprea
4f5577e8d4 Bug 1722465 - Investigate using telemetry archived data for determining profile activity r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D120959
 2021-07-30 15:57:54 +00:00
Scott
5156ff3a3b Bug 1722739 - Newtab Pocket privacy link hover underline fix r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D121124
 2021-07-29 19:04:17 +00:00
Scott
fc59d368e2 Bug 1691518 - Remove v1 personalization from newtab r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D120368
 2021-07-28 22:42:32 +00:00
Emily McMinn
bfedc240fc Bug 1720759 - Refactoring aboutwelcome.scss r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D120757
 2021-07-28 16:33:17 +00:00
Punam Dahiya
19d97ff4a9 Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak 
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
 2021-07-22 16:57:32 +00:00
Csoregi Natalia
26e41dfbdb Backed out changeset c2cb820e5a69 (bug 1720758) for causing failures on browser_aboutwelcome_multistage_default.js. CLOSED TREE 2021-07-22 10:03:54 +03:00
Punam Dahiya
d83c14f45e Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak 
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
 2021-07-22 05:18:06 +00:00
amy churchwell
dc203ba0ea Bug 1719727 - Change "Personalize" on New Tab to gear icon. r=prathiksha,fluent-reviewers,Gijs,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D119657
 2021-07-15 19:36:50 +00:00
Emily McMinn
0bc5ee4533 Bug 1716660 - Improve spacing around text items on import screen of about:welcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D118630
 2021-07-12 14:12:18 +00:00
Sam Foster
8548ab2296 Bug 1700124 - de-duplicate add (+) icons r=thecount,harry,desktop-theme-reviewers 
* Rename toolkit's add.svg to plus.svg, use it for the zoom-in buttons and about:newtab's add icon

Differential Revision: https://phabricator.services.mozilla.com/D118627
 2021-07-08 18:52:40 +00:00
Punam Dahiya
9e0755e758 Bug 1719707 - Include screen order in message id r=andreio 
Patch appends screen order in message id to be passed in Impression and Click telemetry from respective screen. This is useful to keep onboarding engagement dashboard consistent across releases by using message id that begins with 'feature id_screen order_%'

Differential Revision: https://phabricator.services.mozilla.com/D119345
 2021-07-08 17:58:37 +00:00