I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.
I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.
Differential Revision: https://phabricator.services.mozilla.com/D157369
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).
Differential Revision: https://phabricator.services.mozilla.com/D157581
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.
Differential Revision: https://phabricator.services.mozilla.com/D157518
Fix a bug where a rule for about:welcome was causing the background for
the multistage spotlight dialog to be white in HCM.
Differential Revision: https://phabricator.services.mozilla.com/D157367
Just remove the import of normalize.scss from aboutwelcome.scss, without
removing the file itself. Add styles needed to maintain the current
appearance and remove styles that were only necessary because of
normalize.scss.
Differential Revision: https://phabricator.services.mozilla.com/D157224
The about:home startup cache tests assert that Discovery Stream nodes are rendered in
the cached page after it loads. It seems that about:home startup is a bit asynchronous,
and _sometimes_ the Discovery Stream cards don't yet exist at the time of caching.
This updates our tests to wait for about:home to have finished loading the Discovery Stream
nodes before continuing.
Differential Revision: https://phabricator.services.mozilla.com/D157147
On Windows, when an alert is privileged and `name` is non-empty, round
trip its `name` (as `privilegedName`) through the Windows notification
mechanism, and provide it to the "relaunch" callback.
Differential Revision: https://phabricator.services.mozilla.com/D156636
I also cleaned up browser_aboutwelcome_multistage_mr.js so that each task is
idempotent and does not pollute the state of other tasks (e.g., by leaving
prefs set).
Differential Revision: https://phabricator.services.mozilla.com/D155886
If Firefox is the default app and pinned to the dock/taskbar, the
primary CTA on the welcome screen will have the same effect as the
secondary CTA. So we can hide one of them. The non-MR page already has
this feature and elects to hide the secondary CTA, so do the same here.
Differential Revision: https://phabricator.services.mozilla.com/D157019
In HCM on Windows, background colors are overridden by the HCM theme's
default background value. And if a CSS background property has more
than 1 layer, only the last layer can include a background-color, so I
suspect that if it has one, background-images on the previous layers
will be obscured by the overridden default background on the last
layer. This patch circumvents this by putting the background-color on
the same layer as the background-image.
Differential Revision: https://phabricator.services.mozilla.com/D156719
Make the dialog frame for Spotlight modal dialogs cover the full window,
prevent the fixed sizing in SubDialog for these dialogs, and vertically
center the dialog relative to its frame. Make the scrollport accommodate
the full Spotlight so it can be scrolled, without wasting any scroll
distance on margins. So, the top margin will shrink with the window,
like the other margins do.
Differential Revision: https://phabricator.services.mozilla.com/D156127
