Commit Graph

159 Commits

Author SHA1 Message Date
Tooru Fujisawa
769ca13218 Bug 1779988 - Part 1: Merge multiple ChromeUtils.defineESModuleGetters calls into one. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152879
2022-07-28 00:54:20 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
005cb01ee5 Bug 1773747 - Part 1: Do not use lazy getter for immediately-used symbol in browser/components/. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D149986
2022-06-24 11:03:52 +00:00
Tooru Fujisawa
754211aed1 Bug 1772100 - Part 9: Use plain object for lazy getter in browser/components/migration/. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D148019
2022-06-06 22:46:22 +00:00
Tooru Fujisawa
ebcb6dfd9c Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 04:42:10 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5 Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 02:49:14 +00:00
Jari Jalkanen
eb54d47215 Bug 1760074 - Report when error causing retry changes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D142322
2022-04-06 06:02:19 +00:00
Nick Alexander
381dd7c640 Bug 1749435 - Use Fluent to localize bookmarks.html at run-time rather than build-time. r=flod,mak,fluent-reviewers
This modernizes an old part of the build system to not require
build-time localization at all.  That's generally preferable.

The most significant changes to the in-product functionality is to
make import localize HTML so that we can use Fluent's `data-l10n-id`.

The locale used is the user's current locale.  This is different than
the existing approach, which always uses the build-time (repack)
locale.  I believe this is a strictly superior user experience and it
may lead to future improvements where-in the default bookmarks become
truly dynamic and vary with the user's chosen locale rather than being
point-in-time decisions.

I tried to restrict these changes to only applen when we import the
default bookmarks, but I think the various layers of flags no longer
achieve this restriction in practice and the formatting and
localization will apply to all imported `bookmarks.html` files.  Since
we don't anticipate (nor ourselves write) these new things in
(respectively, to) `bookmarks.html`, and the file is already
user-controlled, I don't think this exposes any meaningful change in
functionality (or in security surface).

Some notes:

1) There's no migration of `.inc` -> `.ftl` because this is the lone
   `.inc` file.

2) I elected to prefix all strings with `default-bookmarks-`, since
   the existing names were very short and likely to collide (now or in
   the future).

3) I elected to change the HTML file name for easier searching.

4) Since the `default-bookmarks.html` file is product-specific and the
   existing tests are in `toolkit/`, I elected to not test the file
   directly in automation.

5) We removed the explicit locale (or equivalent `%LOCALE%`) since
   Mozilla properties will redirect to the appropriate language
   automatically.

Differential Revision: https://phabricator.services.mozilla.com/D135816
2022-01-19 17:02:26 +00:00
Hector Zhao
6eef09bd08 Bug 1659730 - Update 360se migrator to work with v9+. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88530
2021-12-22 10:48:49 +00:00
Butkovits Atila
f5908e6b2d Backed out changeset dc43e9b0ba50 (bug 1659730) for causing failures at test_360seMigrationUtils.js. CLOSED TREE 2021-12-21 15:46:44 +02:00
Hector Zhao
7e12c141e5 Bug 1659730 - Update 360se migrator to work with v9+. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88530
2021-12-21 11:37:11 +00:00
Jake Gealer
38169acdd7 Bug 1557835 - Allow migration from Brave r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131731
2021-11-23 05:26:09 +00:00
Michael Kohler
017526e9d3 Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref in migration r=mak
Depends on D127589

Differential Revision: https://phabricator.services.mozilla.com/D127590
2021-10-14 07:51:15 +00:00
Jens Stutte
9a46720c62 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
Cosmin Sabou
8ec6cda9d8 Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE 2021-03-02 20:18:21 +02:00
Jens Stutte
7ef53cdaed Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
Gijs Kruitbosch
7e34ee9722 Bug 1665442 - remove the import button once the user successfully imports bookmarks, r=jaws
Any import of bookmarks that attempts to insert at least 1 bookmark successfully
will be treated as a success. This avoids discounting imports where one or more
bookmarks could not be imported due to issues with the URL, especially because
the user has no obvious remedial options - retrying is unlikely to fix things.

Differential Revision: https://phabricator.services.mozilla.com/D93768
2020-10-20 15:28:28 +00:00
Gijs Kruitbosch
005c43d234 Bug 1665442 - show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D93618
2020-10-20 15:29:30 +00:00
Gijs Kruitbosch
7f44ca97cb Bug 1665442 - cleanup in browser migration code while passing by, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93617
2020-10-20 13:04:40 +00:00
Ed Lee
a8bebc9422 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-24 20:00:08 +00:00
Mihai Alexandru Michis
027da3f15f Backed out 2 changesets (bug 1666373, bug 1665802) for causing gv-junit and xpcshell failures.
Backed out changeset 296c8ba967c9 (bug 1666373)
Backed out changeset c1fe3374ab97 (bug 1665802)
2020-09-24 10:52:40 +03:00
Ed Lee
379dc903a1 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-23 22:32:47 +00:00
Jared Wein
d4a3809d85 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 15:56:36 +00:00
Mihai Alexandru Michis
4b61ccb021 Backed out changeset 8b917683232d (bug 1656277) for causing xpcshell failures in test_IE_bookmarks.js
CLOSED TREE
2020-08-14 08:36:35 +03:00
Jared Wein
41d021123f Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 03:27:22 +00:00
Csoregi Natalia
aa0319a6dd Backed out changeset 4fc26e678c18 (bug 1656277) for failures on test_Edge_db_migration.js. CLOSED TREE 2020-08-14 04:21:35 +03:00
Jared Wein
1f16b4feae Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Noemi Erli
4de7581677 Backed out changeset c2c4b8d6b915 (bug 1656277) for causing build bustages in nsDocShell.cpp CLOSED TREE 2020-08-14 01:13:41 +03:00
Jared Wein
cccc0ccf92 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Gijs Kruitbosch
df86f6d8ed Bug 1643321 - fix missing/differently-identified fluent localization of browser profile migration data types, r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78412
2020-06-08 12:00:38 +00:00
Riley Byrd
1ebb0c9974 Bug 1518234 - Migrate migration wizard to Fluent r=flod,Gijs,fluent-reviewers
Based on a patch originally written by Ian Kirkpatrick <kirkpa47@msu.edu>

Differential Revision: https://phabricator.services.mozilla.com/D17393
2020-06-02 06:46:09 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Dão Gottwald
226dceee35 Bug 1620536 - Move "Import from Another Browser" to the Help menu. r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D66551
2020-03-13 17:29:15 +00:00
Matthew Noorenberghe
1c4e674073 Bug 1608513 - Chromium Edge migrator support on Windows and macOS. r=Gijs
Microsoft supports using both old and new Edge in side-by-side (SxS) mode so both migrators should be supported if they have data.

Also rename the existing EdgeHTML Edge migrator to "Microsoft Edge Legacy" to allow disambiguation. This is the name Microsoft uses in side-by-side (SxS) mode.

Differential Revision: https://phabricator.services.mozilla.com/D60621
2020-01-22 18:35:11 +00:00
Matthew Noorenberghe
5d4b5120a2 Bug 1605491 - Add Chromium Edge Beta migrator support on Windows. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D59542
2020-01-11 00:05:09 +00:00
Matthew Noorenberghe
b94148f2ca Bug 1605491 - Add Chromium Edge Beta migrator support on macOS. r=Gijs
Re-using all of the import logic from our Chrome/Chromium migrator.

Differential Revision: https://phabricator.services.mozilla.com/D58203
2020-01-10 21:40:30 +00:00
premk
ad0520c6ab Bug 1523179 - Support Chrome Beta import on Windows. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D59541
2020-01-10 20:00:10 +00:00
Matthew Noorenberghe
452fd0c08f Bug 1523179 - Fix Linux Chrome Beta and Chrome Dev migrator support and telemetry. r=Gijs
Symbols exported from a JSM cannot be nested inside an `if` otherwise `undefined` will be exported. I don't think it's worth filing a bug for that considering bug 1608269 is coming.

Differential Revision: https://phabricator.services.mozilla.com/D58202
2020-01-10 21:13:50 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Soeren Hentzschel
e2b69c9c3e Bug 1522856 - Add an "import" option to the file menu to make browser migration discoverable. r=MattN,felipe
Differential Revision: https://phabricator.services.mozilla.com/D19274
2019-03-04 15:29:03 -08:00