Commit Graph

80 Commits

Author SHA1 Message Date
Sam Foster
9bd8844f3d Bug 1780236 - Tighen up the spacing between section header, description and lists in fx-view. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D157868
2022-09-23 16:09:07 +00:00
Kelly Cochrane
e1313c43f7 Bug 1789826 - Update z-index of section headers to prevent focus ring from being obscured r=dao
Differential Revision: https://phabricator.services.mozilla.com/D157664
2022-09-22 17:28:35 +00:00
Shane Hughes
9a941ec9d1 Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs
Apply the usual HCM hover style to buttons in Firefox View, but also
override some of the custom properties for HCM so that Emily's patch for
bug 1790396 can use the same custom properties for feature callout hover
styles that we use in system content generally.

Differential Revision: https://phabricator.services.mozilla.com/D157364
2022-09-21 23:22:30 +00:00
Bernard Igiri
758c474634 Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements
Replaced tag containing Fx View logo and title with a non-navigational tag, so that screen readers do not announce it as a navigational element.

Differential Revision: https://phabricator.services.mozilla.com/D157260
2022-09-21 12:37:16 +00:00
Kelly Cochrane
6904dbb905 Bug 1790110 - Removing margin bottom for Colorways figure on smaller screens r=dao
Differential Revision: https://phabricator.services.mozilla.com/D157647
2022-09-19 14:59:51 +00:00
Cieara Meador
5a74791af6 Bug 1785736 - Progress bar HCM palette changes r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157370
2022-09-15 14:30:35 +00:00
Tim Giles
9e19362b07 Bug 1786397 - Fix Windows HCM issues in Firefox View. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156866
2022-09-13 14:40:41 +00:00
Dão Gottwald
52f305cd6c Bug 1790409 - Fix zap gradient border scaling. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157205
2022-09-13 12:50:30 +00:00
Niklas Baumgardner
64af4bc4a1 Bug 1790407 - Close button for mobile pick up card should be clickable. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157156
2022-09-13 09:11:46 +00:00
Kelly Cochrane
5f30b66795 Bug 1786966 - Make sure Fx View logo text doesn't wrap and sidebar width is automatically adjusted to accomodate it r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156976
2022-09-09 18:05:47 +00:00
Niklas Baumgardner
aa28bcc786 Bug 1789226 - Show zap gradient border for tab pickup cards. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156597
2022-09-09 16:09:26 +00:00
Kelly Cochrane
b382e80b07 Bug 1786966 - Increase Fx View logo font size r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156965
2022-09-09 15:10:54 +00:00
Kelly Cochrane
2986c474df Bug 1789318 - Resolving grid row spacing issues when collapsing accordions in Fx View r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D156882
2022-09-09 12:55:21 +00:00
Hanna Jones
817aaeb8da Bug 1785868 - Give tab pickup a more explicit height to remove vertical space r=Gijs
This is the same as using `minmax(0, max-content)`. Using this for the first track seems to get the height to more accurately reflect the content and removes some of the extra whitespace/jumpiness on the page.

Differential Revision: https://phabricator.services.mozilla.com/D156880
2022-09-08 19:13:50 +00:00
Cieara Meador
1b545e24e9 Bug 1787003 - Adjust font size of tab pickup timestamp r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D156868
2022-09-08 16:49:27 +00:00
Kelly Cochrane
d3383882e5 Bug 1786966 - Update Fx View logo font weight to match h1s r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156839
2022-09-08 15:12:59 +00:00
Kelly Cochrane
8417c12ebd Bug 1787262 - Update h1 font size and weight in Fx View to match Figma spec r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156594
2022-09-07 14:23:52 +00:00
Sam Foster
7379129193 Bug 1783277 - Use --fxview-text-secondary-color for placeholder content in both Tab Pickup and Recently Closed Tabs. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156351
2022-09-06 16:13:46 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-02 18:53:21 +00:00
Butkovits Atila
a1fa5a8368 Backed out changeset 5a064ed3c5dc (bug 1785868) as per request by Sam. 2022-09-02 18:57:57 +03:00
Noemi Erli
ec9494988d Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
fe2b36be03 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-01 22:30:42 +00:00
Sam Foster
bb5d2ac9ca Bug 1785868 - Allow items in the fx-view main column to move up into empty vertical space. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156217
2022-09-01 18:41:17 +00:00
Daniel Holbert
32e1997212 Bug 1787871 - fix line clamping in the title of the Firefox View tab pickup hero tab card, r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D155964
2022-08-31 11:16:32 +00:00
Daniel Holbert
62a59b16fd Bug 1787964: Improve content-based-sizing and vertical centering of Firefox View's "Last Active" badge. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D155917
2022-08-30 06:23:17 +00:00
Gijs Kruitbosch
93e3e2e766 Bug 1787253 - fix domains getting wrapped unnecessarily in Firefox View tab pickup section, r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D155768
2022-08-29 15:59:49 +00:00
Gijs Kruitbosch
56c436dc5c Bug 1783276 - use min-content for timestamps and more space for the domain in the recently closed tabs grid, r=niklas
The request from UX is for 16px column gaps but 8px between the URL and timestamp.
CSS grid doesn't support individual columns having different gaps, so I've made
the gap 8px and filled in the other 8px by incrementing inline start padding on
the title and URL.

Differential Revision: https://phabricator.services.mozilla.com/D155704
2022-08-26 21:58:10 +00:00
Gijs Kruitbosch
5b4922b83b Bug 1787009 - ensure timestamps do not wrap in Firefox View in either tab pickup or recently closed tabs list, r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D155703
2022-08-26 16:25:55 +00:00
Dão Gottwald
2595d2f756 Bug 1786627 - Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D155477
2022-08-26 11:26:21 +00:00
Cristian Tuns
ebb501eec5 Backed out changeset 01a6e9812b8c (bug 1786627) for causing mochitest failures on browser_ext_themes_ntp_colors.js CLOSED TREE 2022-08-26 04:52:03 -04:00
Dão Gottwald
b4a515db76 Bug 1786627 - Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D155477
2022-08-26 08:14:24 +00:00
Amy Churchwell
471c9fb459 Bug 1770472 - Center favicon in recently closed tabs list. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D154822
2022-08-18 18:19:49 +00:00
Bernard Igiri
0c72639661 Bug 1783271 - Make Colorways null state text white r=dao
Make Colorways null state text white when overlaying the graphic.

Differential Revision: https://phabricator.services.mozilla.com/D154539
2022-08-15 16:14:08 +00:00
Sam Foster
4b70d80706 Bug 1783278 - Allow primary buttons to wrap in card layout at narrow widths. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D154312
2022-08-12 00:46:55 +00:00
Sam Foster
a6cd751937 Bug 1783197 - Correct the fxview ghost button styles in high-contrast mode. r=sclements
* Leverage shared styles for the utility buttons (close, twisty) and update the background/color variables they use instead of overriding
* Ensure button color contrasts with its background in HCM
* Special-case the success confirmation close button which doesn't use the theme colors

Differential Revision: https://phabricator.services.mozilla.com/D154181
2022-08-11 19:40:42 +00:00
Bernard Igiri
f719654d8b Bug 1774771 - Wrap tab pickup list in anchor tag r=Gijs
Wrapped tab pickup list in an anchor tag.

Differential Revision: https://phabricator.services.mozilla.com/D152985
2022-08-11 14:15:40 +00:00
Sam Foster
0fdec93d93 Bug 1783269 - Fix fxview setup progressbar colors. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154023
2022-08-10 19:40:39 +00:00
Sarah Clements
72b1f95165 Bug 1780045 - Fix list item format in Tab Pickup list r=Gijs
* change grid for second and third li's so the url is on its own row and remove
span wrapping url and device

Differential Revision: https://phabricator.services.mozilla.com/D153945
2022-08-08 14:27:13 +00:00
Bernard Igiri
7e8e82c182 Bug 1782565 - Applied FxView responsive design for null state of Colorway CTA r=dao
Applied FxView responsive design for null state of Colorway CTA.

Differential Revision: https://phabricator.services.mozilla.com/D153413
2022-08-04 13:31:39 +00:00
Sarah Clements
f5b9a6d56a Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-03 12:14:32 +00:00
Sandor Molnar
daecd1c9e2 Backed out changeset 8390be8eb18e (bug 1768695) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js CLOSED TREE 2022-08-02 18:58:22 +03:00
Sarah Clements
122e755a1c Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-02 11:56:23 +00:00
Sam Foster
469917ce66 Bug 1776779 - Add mobile promo and success confirmation banner. r=Gijs,markh
* Add mobile promo element to the Fxa/sync setup flow, and logic to show/hide it
* Add success confirmation for the mobile sync connection with logic to show/hide it
* Watch a new pref 'browser.tabs.firefox-view.mobilePromo.dismissed' for the promo
* Add a new notification in FxAccountsDevice when the devicelist cache is updated
* Use the devicelist updated notification drive the state changes in the setup flow manager
* Add test coverage for the mobile promo

Differential Revision: https://phabricator.services.mozilla.com/D151895
2022-07-30 01:30:15 +00:00
Sam Foster
dc2bd1d8d0 Bug 1779328 - Use currentColor for favicons which support context-fill. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D153129
2022-07-29 15:05:54 +00:00
Sarah Clements
1e419131ff Bug 1761782 - Firefox View colors update in response to theme changes r=dao
* Use contentTheme.js to dynamically update text and background colors in response to
theme changes, including from colorways modal

Differential Revision: https://phabricator.services.mozilla.com/D151043
2022-07-28 12:19:02 +00:00
Gijs Kruitbosch
6bc0ec0cd5 Bug 1780855 - update empty state strings and padding, r=sclements,flod
Differential Revision: https://phabricator.services.mozilla.com/D152573
2022-07-26 16:22:54 +00:00
Amy Churchwell
12b39c0b43 Bug 1780456 - Illustrations that are not square are distorted. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D152317
2022-07-22 22:18:22 +00:00
Bernard Igiri
fda7bc00a6 Bug 1780047 - Make Colorway CTA in Fx View responsive r=dao
Added dynamic layout adjustments to Colorway CTA in Firefox View according to both S and L sizing as described in Figma.

Differential Revision: https://phabricator.services.mozilla.com/D152215
2022-07-22 15:14:13 +00:00
Dão Gottwald
436f2bb942 Bug 1780525 - [Colorway Closet] Port expiry pill layout adjustments to Firefox View and about:addons. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D152363
2022-07-21 21:42:49 +00:00
Bernard Igiri
cbd7df1750 Bug 1776221 - Added auto update of Colorway CTA on theme change r=sfoster
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.

Differential Revision: https://phabricator.services.mozilla.com/D150878
2022-07-15 21:36:56 +00:00