corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

72 Commits

Author SHA1 Message Date
Luca Greco
b2565a2a3f Bug 1767550 - Make sure defaultSearch overrides levelOfControl is consistent with the default engine currently set before overriding the current default. r=mixedpuppy 
For add-ons installed before the changes introduced by Bug 1757760 ExtensionSettingStorage.getLevelOfControl resolves to "controlled_by_this_extension"
even if the user did not opt-in when prompted (either by never answer the prompt, or by setting No).

The changes landed by Bug 1757760 did make sure that for a newly installed extensions ExtensionSettingsStorage.getLevelOfControl resolves to "controllable_by_this_extension"
until the user actually explicitly opt-in to the default search engine provided by the installed extension, by making sure to initially set as disabled
the defaultSearch setting for a newly installed extension (which will then be enabled if the user does explicitly opt-in).

Unfortunately, that change doesn't have any effect if the extension has been installed in a Firefox version that did not yet include Bug 1757760 changes,
in that case the setting listed in the pre-existing extension-settings.json file in the Firefox profile will still have the setting marked
as enabled even if the user did never opt-in.

This patch includes a new test task that is injecting into extension-settings.json the data needed to recreate the inconsistent state
(level of control set to "controlled_by_this_extension" while the related search engine isn't actually set as default).

In addition to the new test case, this patch is applying the following changes to `chrome_settings_overrides`:

- in the `setDefault` method: if ExtensionSettingsStorage.getLevelOfControl resolves to "controlled_by_this_extension"
  but the default search engine currently set is not the one associated to the extension, then explicitly disable the
  setting and recompute the level of control (which will resolve to "controllable_by_this_extension" as a side effect
  of explicitly disable the setting)

- in the `ensureSetting` method: remove the check on `item?.enabled`, because the result of ExtensionSettingsStorage.getSetting
  does actually never have an `enabled` property set, instead it is part of the content of the extension-settings.json file
  and it is used internally by ExtensionSettingsStorage without being returning in the format of the object returned by
  calling ExtensionSettingsStorage.getSetting
  (see https://searchfox.org/mozilla-central/rev/97c902e8f92b15dc63eb584bfc594ecb041242a4/toolkit/components/extensions/ExtensionSettingsStore.jsm#164-177)

Differential Revision: https://phabricator.services.mozilla.com/D146294
 2022-05-25 18:46:12 +00:00
Shane Caraveo
2530614cac Bug 1757760 retain correct search default setting after addon update r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D141294
 2022-03-18 19:43:43 +00:00
Shane Caraveo
1034bc2ebf Bug 1705835 remove unused engineAdded extension setting r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D112432
 2021-04-22 15:33:51 +00:00
Mark Banner
c9be59b5ad Bug 1702454 - Re-enabling an add-on that overrides search engine parameters shouldn't cause a prompt. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D110562
 2021-04-15 15:57:41 +00:00
Shane Caraveo
f259d96a14 Bug 1698619 fix updating homepage setting on updates and for localization r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D110717
 2021-04-12 18:58:27 +00:00
Shane Caraveo
b46aa07a7d Bug 1646338 ask to set as default again when enabling a search addon r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D107132
 2021-03-29 15:42:23 +00:00
Erica Wright
702fb9a86f Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-20 21:40:14 +00:00
Bogdan Tara
ff248efb24 sBacked out changeset 26f7d3a8b1b6 (bug 1595858) for overrides related mochitest failures CLOSED TREE 2020-11-18 01:42:59 +02:00
Erica Wright
e6b0316387 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-17 19:49:36 +00:00
Bogdan Tara
07d282afc6 Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE 2020-11-13 06:11:35 +02:00
Erica Wright
5855481ca4 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-13 02:02:47 +00:00
Mark Banner
88ece2d4ce Bug 1643858 - When an add-on is uninstalled at early startup, ensure that we also remove associated search engines. r=mixedpuppy,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D95540
 2020-11-04 11:20:45 +00:00
Mark Banner
bc781a0864 Bug 1638888 - Make disabling and enabling a WebExtension restore the default search engine correctly. r=mixedpuppy,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D76503
 2020-06-16 08:54:24 +00:00
Mark Banner
7fc2b2098c Bug 1638888 - Simplify processSearchProviderManifestEntry to handle the not setting as default engine case first. r=mixedpuppy,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D79271
 2020-06-16 08:54:16 +00:00
Mark Banner
2b1410dfe5 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D77429
 2020-05-31 12:19:18 +00:00
Mihai Alexandru Michis
ffc388df9a Backed out changeset d82a23f070f6 (bug 1641261) for causing xpcshell failures in test_override_allowlist.js 
CLOSED TREE
 2020-05-30 11:19:08 +03:00
Mark Banner
097b0ab538 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D77429
 2020-05-29 23:09:34 +00:00
Mark Banner
a4bd46c2dd Bug 1635235 - Ensure browser_ext_settings_overrides_default_search.js can wait for search engine setup to complete to avoid intermittents. r=mixedpuppy 
Depends on D76480

Differential Revision: https://phabricator.services.mozilla.com/D76910
 2020-05-26 19:53:42 +00:00
Mark Banner
be3d4dc1e4 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey 
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
 2020-05-26 19:40:42 +00:00
Mihai Alexandru Michis
cc78e5f718 Backed out 2 changesets (bug 1635235, bug 1635239) for causing Bug 1640583. 
CLOSED TREE

Backed out changeset 97ecda13df18 (bug 1635239)
Backed out changeset c9f80397bbec (bug 1635235)
 2020-05-25 16:43:03 +03:00
Mark Banner
6c826e7ba0 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey 
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
 2020-05-24 21:45:41 +00:00
Mark Banner
5beee96289 Bug 1635231 - Allow overriding and setting as default specific search engines according to a allowlist. r=daleharvey,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D75613
 2020-05-21 10:42:20 +00:00
Dale Harvey
688a142a4d Bug 1621892 - Maintain engine settings when upgrading extension r=Standard8,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D68247
 2020-04-07 15:58:05 +00:00
Mark Banner
b7230156ea Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D69235
 2020-04-03 11:36:35 +00:00
Dorel Luca
7eec6ba613 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE 
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)
 2020-04-02 18:39:32 +03:00
Mark Banner
ba85723ecd Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey 
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235
 2020-04-02 14:31:45 +00:00
Shane Caraveo
82889634a5 Bug 1578513 make disable/enable during safe mode update extension settings r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D44595
 2019-11-27 20:00:08 +00:00
Shane Caraveo
f559d8e729 Bug 1578513 make uninstall during safemode remove extension settings r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D44594
 2019-11-27 22:19:15 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D45629
 2019-09-14 09:39:26 +00:00
mandy cheang
861abbb961 Bug 1566489 - Avoid reading extension-setting.json on start-up, read it lazily. r=aswan,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D40860
 2019-08-08 16:15:17 +00:00
Mark Banner
967c3814e1 Bug 1535049 - Add telemetry for the homepage ignore actions. r=daleharvey,chutten,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D40394
 2019-08-05 21:53:09 +00:00
Mark Banner
bf6f936245 Bug 1535049 - Disallow setting homepages to ignored urls. r=daleharvey,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D40393
 2019-08-05 21:52:59 +00:00
Brindusan Cristian
fa58466122 Backed out 2 changesets (bug 1556789) on request from aryx for causing Bug 1565836. a=backout 
Backed out changeset ca5fdf3a0ddd (bug 1556789)
Backed out changeset 19419ff4e756 (bug 1556789)
 2019-07-13 20:52:45 +03:00
Shane Caraveo
d24d4ba91c Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey 
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
 2019-07-12 19:33:32 +00:00
Gurzau Raul
719f78a402 Backed out 2 changesets (bug 1556789) for assertion failures in FF functional tests on a CLOSED TREE. 
Backed out changeset 2d10e95cf0cd (bug 1556789)
Backed out changeset 0acf6bafda0f (bug 1556789)
 2019-07-12 04:45:46 +03:00
Shane Caraveo
5e55c6af34 Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey 
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
 2019-07-11 18:42:00 +00:00
Noemi Erli
b0fe69e20f Backed out 2 changesets (bug 1556789) for failures in test_engines_on_restart.py 
Backed out changeset 5488dbd0fa34 (bug 1556789)
Backed out changeset 021d8cd8ba70 (bug 1556789)
 2019-07-11 03:37:26 +03:00
Shane Caraveo
3aca06f599 Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey 
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
 2019-07-10 22:47:02 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
 2019-07-05 09:53:32 +02:00
Andrew Swan
c0ee1b6276 Bug 1549192 Fix extension apis that handle addon disabling r=kmag 
API implementations that check shutdownReason for values other than
APP_SHUTDOWN during extension shutdown are inherently broken since an
addon may be disabled or uninstalled between browser sessions, in which
case code that is meant to run in these cases will not get executed.
This patch fixes existing api implementations that are broken in this way.

Also ensure that APIs' onDisabled methods get called properly when an
extension is disabled between browser sessions.

Differential Revision: https://phabricator.services.mozilla.com/D30604
 2019-05-09 19:59:21 -07:00
Shane Caraveo
b53bd5c5ef Bug 1541317 fix extension failures when setting homepage on upgrade r=aswan 
Differential Revision: https://phabricator.services.mozilla.com/D29912
 2019-05-08 01:30:25 +00:00
Dale Harvey
58a8a68238 Bug 1549122: Duct tape to prevent deadlock when search extensions upgraded on startup. r=mikedeboer a=Aryx 
Differential Revision: https://phabricator.services.mozilla.com//D30004
 2019-05-06 13:06:34 +02:00
Shane Caraveo
22782c87a5 Bug 1544965 only remove search engines for an extension if the extension actually has one r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D29411
 2019-05-01 14:55:12 +00:00
Noemi Erli
813ba27d62 Backed out changeset f706ae697922 (bug 1541317) for failures in test_ext_settings_overrides_search.js 2019-04-27 02:01:58 +03:00
Shane Caraveo
28c8a8e5ce Bug 1541317 support homepage setting on upgrade r=rpl,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D28265
 2019-04-26 18:54:19 +00:00
Dale Harvey
062752de53 Bug 1496075 - Part 1: Extensions changes to support search extensions. r=mixedpuppy,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D25244
 2019-04-11 21:30:47 +00:00
Shane Caraveo
b371837b78 Bug 1532165 use prefs to support extension newtab and homepage on startup. r=kmag 
Differential Revision: https://phabricator.services.mozilla.com/D25808
 2019-04-08 22:36:26 +00:00
Rob Wu
b51d89ac07 Bug 1525729 - Stop blocking extension startup on searchInitialized r=aswan 
Depends on D23311

Differential Revision: https://phabricator.services.mozilla.com/D19701
 2019-03-13 18:48:57 +00:00
Andrew Swan
3753935bea Bug 1534796 Tweak default search prompts r=mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D23227
 2019-03-12 14:32:24 -07:00
Narcis Beleuzu
fa44140bd3 Backed out changeset 52747743fe65 (bug 1525729) for XPCShell failures on test_ext_chrome_settings_overrides_update.js . CLOSED TREE 2019-02-28 22:59:55 +02:00