Commit Graph

119 Commits

Author SHA1 Message Date
Doug Thayer
4c535e830a Bug 1441308 - Core renderroot splitting changes r=kats,sotaro
This is a large patch that contains all of the core changes for
renderroot splitting.

Differential Revision: https://phabricator.services.mozilla.com/D20701
2019-03-22 03:15:14 +00:00
Neil Deakin
ce9efe8f68 Bug 1519953, replace calls to retrieve boxobject position and size with getBoundingClientRect, r=gijs 2019-03-01 12:26:45 -05:00
Luca Greco
bd2c18d158 Bug 1446027 - Prevents synchronous uninterruptible reflow from ExtensionPopups.jsm. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D12158
2019-01-30 20:08:08 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Rob Wu
4b28cecd93 Bug 1518598 - Return early if popup has already been closed r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D16033
2019-01-15 18:50:49 +00:00
Gijs Kruitbosch
ae4c0d1d3d Bug 1493655 - make nsISecureBrowserUI initialize from a docshell instead of a window, r=keeler,nika
This also removes the (afaict, unused) stub implementation from TabParent. The netwerk header
inclusions were necessary because those files included TabParent.h and through it,
nsISecureBrowserUI, but now TabParent.h no longer does that.

Differential Revision: https://phabricator.services.mozilla.com/D6829
2018-09-26 17:48:38 +00:00
Brendan Dahl
532fe1f6b0 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265
2018-08-25 00:16:27 +00:00
Cosmin Sabou
4ad8223a46 Merge mozilla-inbound to mozilla-central. a=merge 2018-08-15 03:51:45 +03:00
Brian Grinstead
c8b3483e82 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275
2018-08-14 16:22:44 +00:00
Kris Maglione
2250619ab1 Bug 1480244: Part 5 - Run most framescripts in shared scope. r=mconley
Creating non-shared scopes for frame scripts is fairly expensive. After these
changes it's even more expensive. However, many frame scripts have no use for
the shared scopes at all. Run-once scripts which execute in closures, for
instance, make no use of them. And after bug 1472491, neither do most of our
default frame scripts.

MozReview-Commit-ID: 9PK7bYdQ0yh
2018-08-10 13:58:18 -07:00
Kris Maglione
b7734387b8 Bug 1452514: Correctly handle a browser window closing before its popups do. r=mixedpuppy
MozReview-Commit-ID: DOqfniMPf87
2018-07-19 19:03:20 -07:00
Kris Maglione
bb663b9c15 Bug 1471102: Move more code out of ExtensionUtils.jsm. r=aswan
MozReview-Commit-ID: Fqlv5BRuuW8
2018-06-25 19:30:21 -07:00
Jared Wein
db7b884c93 Bug 1459066 - Overflow menu WebExtension subview header should use the default browser styling instead of the extension's styling. r=mixedpuppy
MozReview-Commit-ID: EtQ6VS5OH0e
2018-05-07 13:06:46 -04:00
Dorel Luca
d3b5384c06 Backed out 2 changesets (bug 1317581) for Browser chrome failures on toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js. CLOSED TREE
Backed out changeset 5cc146254899 (bug 1317581)
Backed out changeset 963466173a74 (bug 1317581)
2018-04-18 18:54:38 +03:00
Jared Wein
1c4aed9f49 Bug 1317581 - DateTimePicker should support high contrast mode on Windows. r=dao
MozReview-Commit-ID: DEBBjcgHIyH
2018-03-22 13:01:28 -04:00
Mark Striemer
fe7abfc02e Bug 1397809 - Part 1: Convert New Tab doorhanger to a generic class r=aswan,Gijs
MozReview-Commit-ID: 40RwrXjtsJJ
2017-12-19 13:56:04 -06:00
Jared Wein
28815611e2 Bug 1453803 - Increase the opacity of the default border color for WebExtension popups. r=ntim
MozReview-Commit-ID: AeDmPJtPdBE
2018-04-12 18:48:39 -04:00
Jared Wein
28c794cd9e Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r=mixedpuppy
MozReview-Commit-ID: CVXySkhYaem
2018-03-30 15:29:31 -07:00
Kris Maglione
b372706fa5 Bug 1451058: Follow-up: Fix window leak in popup tests. r=bustage
MozReview-Commit-ID: 7ucAN5usp0o
2018-04-06 19:22:39 -07:00
Kris Maglione
7d36b903cc Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f
2018-04-03 11:14:49 -07:00
Andreea Pavel
80d67e9698 Backed out 2 changesets (bug 1451058) for failing browser chrome at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_popup.js on a CLOSED TREE
Backed out changeset 7047a6811fdc (bug 1451058)
Backed out changeset 29b2567d16eb (bug 1451058)
2018-04-06 10:39:42 +03:00
Kris Maglione
d318dae8ff Bug 1451058: Follow-up: Fix unhandled rejections. r=bustage
MozReview-Commit-ID: FELukWQ8fEz
2018-04-05 21:33:42 -07:00
Kris Maglione
101bbe25b0 Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Creating the temporary panel for a pre-load popup can be expensive, especially
for OOP popups, where we need to create a compositor. Since we currently need
to create a pre-load popup every time we hover over a browser action with a
popup, it's probably worth saving and re-using them, rather than always
creating a new one.

MozReview-Commit-ID: GwG7qJNdk8f
2018-04-03 11:14:49 -07:00
Tim Nguyen
d49de43825 Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht
2018-03-16 23:21:46 +00:00
Margareta Eliza Balazs
8ad3204b44 Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE
Backed out changeset 71f61091a716 (bug 1444760)
Backed out changeset 4956db1e9bdd (bug 1444760)
2018-03-25 15:29:54 +03:00
Tim Nguyen
76bd43b52d Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht
2018-03-16 23:21:46 +00:00
Sam Foster
cd8e6dc737 Bug 1402845 - Fix panelview sizing when customRectGetter is used. r=mikedeboer,Paolo
* The extension content drives the sizing of the browser and popup that contains it via the Extension:BrowserResized message. The ignoreResizes property throttles/debounces this initially, stashing the dimensions received rather than triggering resize of the popup for every message. When the popup is a subview and fixedWidth, we ignore width but *do* want to use the stashed height value.

* Until the panel is given visibility, it has 0 height, so after setting visibility, wait until the next refresh-driver tick before measuring any header which should get added to the overall view height

MozReview-Commit-ID: AgcruVb9QPA
2017-10-05 10:23:53 -07:00
Shane Caraveo
cc9b7fb4c5 Bug 1398713 pass triggeringPrincipal when using browser.loadURI, r=Gijs,kmag 2018-02-28 17:32:01 -06:00
Shane Caraveo
d86aa77f96 Bug 1324255 make webextension panels focused when opened, r=Gijs,rpl 2018-02-15 09:52:54 -07:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Tim Nguyen
ecbd0af966 Bug 1425868 - Consolidate arrow panel styling. r=dao
Original patch by Jared Wein [:jaws]

MozReview-Commit-ID: D8GxCjJ8Si3
2017-12-19 08:00:00 -06:00
Dorel Luca
824fce99c6 Backed out changeset 4f6ed26bdb9b (bug 1425868) for build bustages on OS X and Windows r=backout on a CLOSED TREE 2017-12-19 15:43:13 +02:00
Tim Nguyen
63dcea73ca Bug 1425868 - Consolidate arrow panel styling. r=dao
Original patch by Jared Wein [:jaws]

MozReview-Commit-ID: RAGeRpgoJF
2017-12-19 07:00:24 -06:00
Masatoshi Kimura
1dfecd5932 Bug 1418914 - Move E10SUtils.jsm into toolkit/. r=mossop
MozReview-Commit-ID: EgDzEEKAeh1
2017-12-12 21:35:16 +09:00
Drew Willcoxon
f35c08c797 Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: WebExtensions changes. r=mixedpuppy
MozReview-Commit-ID: n2eR3q1aZF
2017-10-27 17:39:57 -04:00
Mike de Boer
54d03a3835 Bug 1403466 - Don't set a max-height on panelviews used by WebExtensions, because it causes browser contents to be cut-off. r=Gijs
Setting a max-height caused the '_handleDOMChange' method in ext-browser-content.js
to consistently lie about the scrollHeight, since it was never allowed to grow
beyond the maxHeight - even when the document needs to be larger to fit its contents.
We don't need this aggressiveness in Photon panels anyway, so that makes it
doubly safe to remove this code.

MozReview-Commit-ID: HJVMXXHS4By
2017-10-10 12:44:04 +02:00
Kris Maglione
04e5cf32c0 Bug 1384078: Prevent enter key from closing extension panels. r=Gijs
MozReview-Commit-ID: DnpiIUc4RkH
2017-09-19 16:37:07 -07:00
Kris Maglione
81d6b6f832 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI
2017-08-02 12:49:25 -07:00
Sebastian Hengst
c4ad0ce869 Backed out changeset c0ab60d3c1f8 (bug 1375490) for failing browser_ext_popup_corners.js on OSX and Windows. r=backout on a CLOSED TREE 2017-08-02 13:12:55 +02:00
Sebastian Hengst
adf678b610 Backed out changeset ec8efb7cf1d3 (bug 1375490) 2017-08-02 13:10:14 +02:00
Kris Maglione
9f1100a6e6 Bug 1375490: Follow-up: Fix resize test failures. r=bustage CLOSED TREE
MozReview-Commit-ID: JMWjtKd7CvX
2017-08-01 22:56:40 -07:00
Kris Maglione
23871a6c13 Bug 1375490: Part 1 - Correctly support alerts in OOP popups. r=mixedpuppy
MozReview-Commit-ID: KgqAKMLmuTI
2017-08-01 15:28:25 -07:00
Gijs Kruitbosch
6ea9acbc72 Bug 1354086 - switch overflow panel to using a photonpanelmultiview, allowing webextension views to specify their own size, r=mikedeboer
MozReview-Commit-ID: 1uHEKXsO8vh
2017-07-19 21:23:46 +01:00
Kris Maglione
6efaf66ac4 Bug 1381337: Don't contstrain popup select dropdowns to the document viewport. r=aswan
MozReview-Commit-ID: HzISTjddHHK
2017-07-16 13:13:03 -07:00
Kris Maglione
d1e71fd7ee Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers. r=zombie
MozReview-Commit-ID: BuAjyqg1aja
2017-07-13 15:47:52 -07:00