Commit Graph

335 Commits

Author SHA1 Message Date
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Brian Grinstead
26c903fe0b Bug 1503342 - Rename richlistbox.children to richlistbox.itemChildren so .children will refer to the normal DOM API;r=paolo
In Bug 1479125 we put calls to .children that were intended to access child elements into the custom
method, which is a slower path. We may eventually want to remove itemChildren altogether and just assume
that all children are items, but that's out of scope for a perf fix like this.

Differential Revision: https://phabricator.services.mozilla.com/D10751
2018-11-11 13:21:18 +00:00
Dão Gottwald
c3d8c2c9f4 Bug 1506112 - Replace customize-context-autoHide class with meaningful id. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D11469
2018-11-09 16:23:52 +00:00
Eliza Balazs
4f580a0dd8 Bug 1306510 - Disable browser_libraryDrop.js on win10 ccov for almost perma fail. r=jmaher 2018-11-06 06:54:00 +02:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brian Grinstead
dd4fd5c38b Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3530
2018-08-17 16:45:52 +00:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Mark Banner
eea8615fb6 Bug 1473607 - Add a test for clearing all downloads via the Library window commands. r=paolo
MozReview-Commit-ID: EkIcgCskYeV

Differential Revision: https://phabricator.services.mozilla.com/D1973
2018-07-09 15:37:40 +00:00
Oriol Brufau
2789d3a111 Bug 1452970 - Add auto-hide option to Download toolbar icon context menu r=Gijs
MozReview-Commit-ID: VVPQesdzJ6
2018-04-14 11:26:03 +02:00
shindli
382510a517 Backed out changeset b12b76bbe1c6 (bug 1452970) for TV failures in browser/components/downloads/test/browser/browser_downloads_autohide.js on a CLOSED TREE 2018-05-09 15:16:40 +03:00
Oriol Brufau
cbfb159c61 Bug 1452970 - Add auto-hide option to Download toolbar icon context menu r=Gijs
MozReview-Commit-ID: VVPQesdzJ6
2018-04-14 11:26:03 +02:00
Marco Castelluccio
7cd550a10b Bug 1423667 - Reenable some tests that were disabled because of a Clang update. r=jmaher 2018-04-05 09:20:47 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Tooru Fujisawa
fbc75c930b Bug 1435910 - Part 0.2: Add BrowserTestUtils.{promiseAlertDialogOpen,promiseAlertDialog}. r=Gijs 2018-02-28 10:36:42 +09:00
Paolo Amadini
f7c87a1ab1 Bug 1439358 - Part 2 - Don't use the "current" property when restoring focus from the blocked downloads subview. r=Gijs
MozReview-Commit-ID: ASmmdQMctr5
2018-02-22 12:20:53 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Ryan VanderMeulen
6f96d4a01d Bug 1423667 - Disable some tests that fail on Windows Code Coverage builds with clang-cl r317840. rs=marco 2017-12-06 20:40:46 -05:00
Mark Banner
4de85b3d5b Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ
2017-10-11 15:43:51 +01:00
Erica Wright
942200ccac Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE
2017-09-13 15:49:32 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
495e08000d Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
32c4aa5540 Bug 1399490 - fix unhiding the downloads button in customize mode if it was moved to the palette, r=nhnt11
MozReview-Commit-ID: 7Q8yPzBVxim
2017-09-13 16:24:13 +01:00
Gijs Kruitbosch
6d7a67d2e5 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv
2017-09-11 18:54:48 +01:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Paolo Amadini
7c101fe117 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P
2017-09-06 13:09:27 +01:00
Zibi Braniecki
58ed110740 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8
2017-09-01 01:54:34 -07:00
Johann Hofmann
5a64d26ebe Bug 1139913 - Downloads with partial data should still keep the placeholder on disk. r=mak
This prevents naming conflicts if a paused or blocked download is retried from the original page.

MozReview-Commit-ID: 4rFZ5rP8saJ
2017-08-25 16:42:45 +01:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
89a0e2f431 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ
2017-08-16 15:54:36 +01:00
Andrew Halberstadt
1ecb0adc26 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Phil Ringnalda
5e91797776 Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Andrew Halberstadt
6c60ffa524 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Marco Bonardo
40d62d0387 Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=adw
MozReview-Commit-ID: DbEJgKbTxd7
2016-05-17 09:35:45 +02:00
Blake Kaplan
5ffe1ce19c Bug 1375710 - Remove CPOWs from browser_iframe_gone_mid_download.js. r=Gijs
MozReview-Commit-ID: JUF8Vdx0vsy
2017-05-16 18:58:28 -07:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Edouard Oger
5228b84006 Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
MozReview-Commit-ID: FPB4HebP3g7
2017-06-02 15:50:30 -04:00
Florian Quèze
331a9ab51b Bug 1362882 - hand cleanup after applying the previous script-generated patch, r=Mossop. 2017-05-12 14:56:12 +02:00
Florian Quèze
15feaa278a Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
b2499a4c57 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Wes Kocher
76ce4b0d6d Merge m-c to autoland, a=merge
MozReview-Commit-ID: 3BrkDVl7521
2017-05-08 16:24:51 -07:00
Sam Foster
799e3c8af3 Bug 1329109 - remove unused time and progressbar code from downloads toolbar icon. r=Paolo
This removes the arrowStyledIndicator killswitch and the associated ability for system add-ons to restore the previous design of the Downloads Indicator in the toolbar. The removal includes all the related code, styles, and strings. Based on the original patch by :rexboy.

MozReview-Commit-ID: 2OEBzPNzl0O
2017-05-08 10:11:52 -07:00
Paolo Amadini
b972e9cc0c Bug 1362207 - Remove the dropdown menu from the footer of the Downloads Panel. r=mak
MozReview-Commit-ID: CFrHklbB7TK
2017-05-05 15:37:00 +01:00
Paolo Amadini
fece3c6437 Bug 1281186 - Remove uses of nsIDownloadManager from DownloadsCommon.jsm, DownloadsViewUI.jsm, and allDownloadsViewOverlay.js. r=mak
MozReview-Commit-ID: 28nc8aTea5v
2017-05-05 11:20:53 +01:00
Phil Ringnalda
2e7a18850e Bug 1352792 - disable browser_downloads_panel_block.js for failing every time that adding unrelated tests causes it to move into a different chunk
MozReview-Commit-ID: J3baNLdtLk3
2017-05-01 21:15:16 -07:00