Commit Graph

1023 Commits

Author SHA1 Message Date
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 12:43:32 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Mathew Hodson
23d098346b Bug 1762444 - Replace setUp tasks with add_setup in browser mochitests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150330
2022-08-29 08:54:54 +00:00
Eemeli Aro
a96b427af3 Bug 1786055 - Drop find keys from editMenuKeys.inc.xhtml. r=mconley
It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D155448
2022-08-26 16:31:40 +00:00
Mike Kaply
7502caaba1 Bug 1779018 - Use policy to determine if executable files can be launched. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D152195
2022-08-16 22:32:52 +00:00
Calixte
379358db72 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D151431
2022-08-08 18:56:24 +00:00
Butkovits Atila
5b38a79427 Backed out changeset 724282da88eb (bug 1778714) for causing failures at browser_library_select_all.js. 2022-08-08 18:14:00 +03:00
Calixte
7428eacbc4 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D151431
2022-08-08 13:47:55 +00:00
Shane Hughes
a92838525b Bug 1783643 - Don't open downloads panel if window is inactive. r=Gijs
Since bug 1741076, the downloads panel is already configured not to show
the downloads panel if the top chrome window is inactive. However, this
check doesn't matter if the downloads panel has never been opened before
in the profile (represented by pref browser.download.panel.shown). This
patch changes the check so that if the top window is not active, we
don't show the panel, no matter what.

Differential Revision: https://phabricator.services.mozilla.com/D153334
2022-08-08 12:15:40 +00:00
Barret Rennie
8b95dddad0 Bug 1776304 - Port osfile.jsm usage to IOUtils in browser/components/downloads r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150203
2022-08-04 20:23:05 +00:00
Emilio Cobos Álvarez
2c1499dce8 Bug 1782185 - Fix a typo introduced in bug 1765083. r=Gijs
I confirmed it's the only one, whoops.

Differential Revision: https://phabricator.services.mozilla.com/D153152
2022-07-29 09:52:38 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
Mark Banner
bf597b1f3a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-25 12:46:48 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
78524564fc Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 15:50:42 +00:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
9cb7e8c83c Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 10:36:51 +00:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Emilio Cobos Álvarez
0091892fb9 Bug 1779559 - Do this in toolkit instead. r=Gijs
This simplifies a bit the tabbrowser/tab switcher code, and makes it
work in all windows.

The WPT failures are due to bug 1780212.

Differential Revision: https://phabricator.services.mozilla.com/D151822
2022-07-19 19:25:48 +00:00
Cristian Tuns
b650749369 Backed out 5 changesets (bug 1779559) for causing wpt failures on unload-bubbles.html CLOSED TREE
Backed out changeset fbb29df4aa9e (bug 1779559)
Backed out changeset eab896a61170 (bug 1779559)
Backed out changeset 645bdd59bb99 (bug 1779559)
Backed out changeset 23fe4f24d483 (bug 1779559)
Backed out changeset a68a015349ed (bug 1779559)
2022-07-19 13:27:32 -04:00
Emilio Cobos Álvarez
8807f9dc40 Bug 1779559 - Disable occlusion in another mochitest.
MANUAL PUSH: Orange fix CLOSED TREE
2022-07-19 15:44:32 +02:00
Shane Hughes
f41f7c4796 Bug 1739348 - Don't open downloads panel after download dialogs. r=NeilDeakin
This is a medium sized patch to legacy download construction. It takes
advantage of the new property added in Bug 1762033 to prevent the
downloads panel from being automatically shown when a download is added
after an interaction with the unknown content type dialog or the file
picker dialog. I chose to not do the same for failed transfers since I
thought it might serve some use, but that might be wrong. I don't know
if there's a way to test the dialog that appears when you download an
executable without going through the same path I adjusted with the
patch. It seems like it's covered but I could be wrong. Also add a test
to cover these changes from the bottom up. Thanks and apologies for my
sloppy C++, though I'm sure I'll learn a lot more from the review 😅

Differential Revision: https://phabricator.services.mozilla.com/D145312
2022-07-18 20:45:41 +00:00
Marco Bonardo
b63a82b2f9 Bug 1743263 - Disable browser_download_spam_protection.js again on Linux 64. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D152032
2022-07-18 16:04:52 +00:00
ui.sayuree
af637533ab Bug 1777147 - remove DownloadsSubview module reference. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D151862
2022-07-15 14:28:08 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Barret Rennie
a70c93c344 Bug 1772941 - Port osfile.jsm usage to IOUtils in toolkit/content/ r=florian,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149303
2022-07-12 00:25:35 +00:00
Emilio Cobos Álvarez
aa13814e76 Bug 1765083 - Introduce FocusOptions.focusVisible. r=smaug,pip-reviewers
As per:

 * https://github.com/whatwg/html/issues/7830
 * https://github.com/whatwg/html/pull/8087

Replace the internal preventFocusRing with the new flag.

Differential Revision: https://phabricator.services.mozilla.com/D151326
2022-07-11 22:04:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Marco Bonardo
be7530af5c Bug 1743263 - intermittent failure in browser_download_spam_protection.js. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D151085
2022-07-07 09:05:37 +00:00
Shane Hughes
e7c1bed038 Bug 1766075 - Fix a downloads panel test failure. r=mak
I think this test may have failed in sequence because of another test
setting the pref that the test currently takes for granted. So, enable
the alwaysOpenPanel pref before waiting for the panel to open.

Differential Revision: https://phabricator.services.mozilla.com/D145287
2022-07-06 09:32:40 +00:00
Mark Banner
47ee15c4bc Bug 1774768 - Fix accesses of undefined constants on Services.perms in tests. r=Gijs
Depends on D149604

Differential Revision: https://phabricator.services.mozilla.com/D149605
2022-06-20 09:44:14 +00:00
Cosmin Sabou
480bc942f5 Backed out changeset b7ac1dc2e29e (bug 1739348) for causing frequent failures on browser_downloads_panel_opens.js. 2022-06-10 23:49:24 +03:00
Shane Hughes
ed09ae2a84 Bug 1739348 - Don't open downloads panel after download dialogs. r=NeilDeakin
This is a medium sized patch to legacy download construction. It takes
advantage of the new property added in Bug 1762033 to prevent the
downloads panel from being automatically shown when a download is added
after an interaction with the unknown content type dialog or the file
picker dialog. I chose to not do the same for failed transfers since I
thought it might serve some use, but that might be wrong. I don't know
if there's a way to test the dialog that appears when you download an
executable without going through the same path I adjusted with the
patch. It seems like it's covered but I could be wrong. Also add a test
to cover these changes from the bottom up. Thanks and apologies for my
sloppy C++, though I'm sure I'll learn a lot more from the review 😅

Differential Revision: https://phabricator.services.mozilla.com/D145312
2022-06-10 17:31:27 +00:00
Tooru Fujisawa
fd5259f6db Bug 1772100 - Part 6: Use plain object for lazy getter in browser/components/downloads/DownloadsViewUI.jsm. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D148016
2022-06-08 20:47:41 +00:00
Tooru Fujisawa
986ce73e75 Bug 1772100 - Part 5: Use plain object for lazy getter in browser/components/downloads/. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D148015
2022-06-08 20:47:40 +00:00
Neil Deakin
6e3e942a21 Bug 1761265, don't show the downloads panel when a download was started by user action that they expect will save the file, r=mhowell,necko-reviewers,kershaw
The download panel should still appear when clicking on download links or those with content-disposition: attachment

Differential Revision: https://phabricator.services.mozilla.com/D147875
2022-06-06 22:23:58 +00:00
Tooru Fujisawa
3e483c26e8 Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
c98ea942de Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 02:49:10 +00:00
Norisz Fay
1840c74ad9 Backed out changeset 5e08d0841b10 (bug 1739348) for causing browser-chrome failures on browser_pdfjs_download_button.js, browser_tempfilename.js 2022-06-03 00:09:47 +03:00