Commit Graph

3814 Commits

Author SHA1 Message Date
Nikki Sharpley
579d6a695e Bug 1989248 - Bookmarks sidebar heading has wrong semantics (generic XUL element, rather than html:h4) a=RyanVM DONTBUILD
Original Revision: https://phabricator.services.mozilla.com/D265706

Differential Revision: https://phabricator.services.mozilla.com/D266660
2025-09-29 20:55:02 +00:00
Gijs Kruitbosch
78ebe33ed8 Bug 1962056 - move places initialization out of BrowserGlue, r=places-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,mossop,mak,mconley
Places frontend initialization is surprisingly complex, and disentangling it
from the rest of startup by moving it to its own file helps make some of the
logic a little more obvious, and makes unit-testing a bit easier.

This also removes BrowserGlue from the indirection mechanism used between
MigatorBase instances and Places, by switching to category-manager-based
invocation - this way, migrator code does not need to directly
call places code to tell it it's done, but we don't need BrowserGlue to play
messenger between them.

It would be nice to do the same thing for `places-init-complete` but
that is notified from C++ code so unfortunately that is not easily possible.

Differential Revision: https://phabricator.services.mozilla.com/D244428
2025-05-21 13:54:58 +00:00
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
baa5d72bbd Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D249182
2025-05-21 03:55:13 +00:00
Moritz Beier
d485c1efce "Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak"
This reverts commit 572b2c4826.
2025-05-13 00:03:02 +00:00
Atila Butkovits
572b2c4826 Revert "Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak" for causing failures at browser_native_font_cache_macos.js.
This reverts commit b27474929f.
2025-05-12 18:54:24 +00:00
Moritz Beier
b27474929f Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D247898
2025-05-12 17:03:58 +00:00
Daisuke Akatsuka
2dcb5406f4 Bug 1915762: Remove PlacesUtils.promiseFaviconData() r=sync-reviewers,profiler-reviewers,devtools-reviewers,mak,nchevobbe,canaltinova,markh
Depends on D241353

Differential Revision: https://phabricator.services.mozilla.com/D241354
2025-04-23 04:40:36 +00:00
Cristian Tuns
a9d8f21da6 Backed out 11 changesets (bug 1915762) for causing node failures in gecko.d.ts CLOSED TREE
Backed out changeset 5c7edcb3b105 (bug 1915762)
Backed out changeset 05691232a461 (bug 1915762)
Backed out changeset 964a29c9a07a (bug 1915762)
Backed out changeset 5d74e419e249 (bug 1915762)
Backed out changeset 677c35e884d3 (bug 1915762)
Backed out changeset 8a7b0b87a0ef (bug 1915762)
Backed out changeset 5e38449cd4d9 (bug 1915762)
Backed out changeset ec8a0553d97a (bug 1915762)
Backed out changeset fb2232e5f3b5 (bug 1915762)
Backed out changeset b290501f5832 (bug 1915762)
Backed out changeset 9955e42e749b (bug 1915762)
2025-04-22 22:15:19 -04:00
Daisuke Akatsuka
5ed19f3694 Bug 1915762: Remove PlacesUtils.promiseFaviconData() r=sync-reviewers,profiler-reviewers,devtools-reviewers,mak,nchevobbe,canaltinova,markh
Depends on D241353

Differential Revision: https://phabricator.services.mozilla.com/D241354
2025-04-23 01:49:40 +00:00
Joel Maher
397e8ec3f4 Bug 1961608 - Green up macosx 15.30. r=aryx,necko-reviewers,extension-reviewers,media-playback-reviewers,credential-management-reviewers,sync-reviewers,anti-tracking-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,profiles-reviewers,pdahiya,alwu,jhirsch,mtigley,skhamis,timhuang,valentin,robwu,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D246100
2025-04-22 18:12:28 +00:00
Nikki Sharpley
9dc7dba546 Bug 1953900 - Update "Forget Site Data" prompt to new dialog r=sidebar-reviewers,fluent-reviewers,places-reviewers,bolsson,kcochrane,mak
Depends on D241874

Differential Revision: https://phabricator.services.mozilla.com/D245463
2025-04-18 16:23:02 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
smolnar
e373a72183 Backed out changeset 1044d79e4efd (bug 1953900) for causing bc failures @ browser_history_sidebar CLOSED TREE 2025-04-17 17:42:56 +03:00
Nikki Sharpley
d1a21c0c14 Bug 1953900 - Update "Forget Site Data" prompt to new dialog r=sidebar-reviewers,fluent-reviewers,places-reviewers,bolsson,kcochrane,mak
Depends on D241874

Differential Revision: https://phabricator.services.mozilla.com/D245463
2025-04-17 13:54:46 +00:00
Nikki Sharpley
1c7e0d81c6 Bug 1919475 - Update context menu for History entries r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,places-reviewers,bolsson,Standard8,kcochrane
- added "open in new tab", "open in new container tab", "bookmark page", "clear all data for website".
- updated "delete page from history"

Differential Revision: https://phabricator.services.mozilla.com/D241874
2025-04-16 18:22:15 +00:00
Norisz Fay
db5fc6c027 Backed out changeset 93c537af6ab8 (bug 1919475) for causing multiple bc failures CLOSED TREE 2025-04-12 01:10:21 +03:00
Nikki Sharpley
5b6624cacf Bug 1919475 - Update context menu for History entries r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,places-reviewers,bolsson,Standard8,kcochrane
- added "open in new tab", "open in new container tab", "bookmark page", "clear all data for website".
- updated "delete page from history"

Differential Revision: https://phabricator.services.mozilla.com/D241874
2025-04-11 19:33:04 +00:00
Tom Schuster
357d0e78d6 Bug 1958798 - Actually apply the CSP in the interactions viewer. r=simonf,jteow
Differential Revision: https://phabricator.services.mozilla.com/D244889
2025-04-09 14:08:13 +00:00
Yazan Al Macki
a5536418e1 Bug 1954589 - Remove -moz-crisp-edges from favicons. r=desktop-theme-reviewers,settings-reviewers,tabbrowser-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D243711
2025-04-02 13:54:15 +00:00
Goloman Adrian
834491dc87 Backed out changeset 01df955df632 (bug 1919475) for causing bc failures @browser_glean_sidebar.js. CLOSED TREE 2025-03-28 00:21:01 +02:00
Nikki Sharpley
89239b5610 Bug 1919475 - Update context menu for History entries r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,places-reviewers,bolsson,Standard8,kcochrane
- added "open in new tab", "open in new container tab", "bookmark tab", "clear all data for website".
- updated "delete page from history"

Differential Revision: https://phabricator.services.mozilla.com/D241874
2025-03-27 21:08:51 +00:00
Moritz Beier
b0bf2330d7 Bug 1557853 - Fix display order of bookmarks being incorrect after moving multiple bookmarks in some cases. r=places-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D241032
2025-03-21 09:50:32 +00:00
Gijs Kruitbosch
28515892e4 Bug 1953575 - abstract out a reasonable API to copy links, r=places-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D241486
2025-03-20 15:54:31 +00:00
James Teow
014c14cccd Bug 1952884 - Allow interactions viewer to be visible behind a pref - r=places-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D240942
2025-03-13 18:08:53 +00:00
Tom Schuster
0527efd6e1 Bug 1951621 - Remove inline scripts from browser.xhtml. r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D240606
2025-03-10 09:51:32 +00:00
Cosmin Sabou
8555932c41 Backed out changeset 96b6563dccc6 (bug 1951621) for turning Bug 1798750 into permafail. a=backout 2025-03-12 05:49:35 +02:00
Tom Schuster
02532fee53 Bug 1951621 - Remove inline scripts from browser.xhtml. r=firefox-desktop-core-reviewers ,frontend-codestyle-reviewers,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D240606
2025-03-10 09:51:32 +00:00
Moritz Beier
34069ddca2 Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238277
2025-03-04 17:18:21 +00:00
Goloman Adrian
55008ab2ea Backed out 2 changesets (bug 1948326) for causing bc failures @nsContentSecurityUtils.cpp. CLOSED TREE
Backed out changeset 172464722456 (bug 1948326)
Backed out changeset 855648c27237 (bug 1948326)
2025-03-04 15:12:56 +02:00
Moritz Beier
4841f6aadb Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238277
2025-03-04 12:24:49 +00:00
Gijs Kruitbosch
dcb8be8cff Bug 1950871 - switch browser/components/tabbrowser to use moz-src, r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239926
2025-03-03 12:47:49 +00:00
Tom Schuster
f81d16e706 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 16:13:13 +00:00
Sandor Molnar
bc9b3e4b97 Backed out 2 changesets (bug 1941365) for causing CSP related dt failures. CLOSED TREE
Backed out changeset b022efa3b9e7 (bug 1941365)
Backed out changeset 90c5b60c6163 (bug 1941365)
2025-02-26 17:28:48 +02:00
Tom Schuster
07c8930ba5 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 14:36:42 +00:00
Florian Quèze
56108afec5 Bug 1948320 - Duplicate remaining legacy telemetry probes into Glean (browser/components/places), r=Standard8,places-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D238471
2025-02-21 13:04:11 +00:00
James Teow
f76e439a48 Bug 1946754 - Move tab select idle time threshold into a hidden pref - r=mak,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237223
2025-02-19 18:50:45 +00:00
Tom Schuster
3ab66095b7 Bug 1947185 - Use style-src instead of style-src-elem directive for the history sidebar CSP. r=Standard8,places-reviewers
The history sidebar uses a `style-src-elem 'unsafe-inline'` directive, which is incorrect and would break its use of an inline style, but works because of XUL prototype cache stuff.
Using style-src instead of style-src-elem also simplifies the code in bug 1946040.

Differential Revision: https://phabricator.services.mozilla.com/D237691
2025-02-13 14:26:10 +00:00
Tom Schuster
d2855a6fee Bug 1947185 - Remove style-src-elem 'unsafe-inline' directive from the bookmarks sidebar CSP. r=Standard8,places-reviewers
After bug 1945493 we should not need this directive anymore, because the
<menupopup> does not rely on inline styles anymore.

Differential Revision: https://phabricator.services.mozilla.com/D237685
2025-02-13 14:26:10 +00:00
James Teow
8b5ed5272b Bug 1946837 - Add sorting to Interaction Viewer - r=mak,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237252
2025-02-10 17:45:39 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
James Teow
db391aba2f Bug 1945912 - Add frecency scores to Interactions Viewer - r=mak,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236741
2025-02-05 18:08:46 +00:00
Harshit Sohaney
79547d182a Bug 1944566 - Fix formdata removal when clearing on shutdown. r=emz,places-reviewers,manuel
Differential Revision: https://phabricator.services.mozilla.com/D236265
2025-02-04 16:33:54 +00:00
Tom Schuster
fe76edcd37 Bug 1945058 - Allow data: URL images in bookmarksSiderbar.xhtml and places.xhtml for now. r=places-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D236513
2025-02-04 15:10:20 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Alexandru Marc
40cac9719f Bug 1829323 - Disable browser_autoshow_bookmarks_toolbar.js on linux1804 asan for frequent failures r=#intermittent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236429
2025-01-31 22:08:59 +00:00
James Teow
aa930ffb1c Bug 1945152 - Disable interactions export test on non-Nightly builds - r=places-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D236349
2025-01-31 20:28:34 +00:00
James Teow
0507d1c91f Bug 1940782 - Enable ability to download interactions as a CSV - r=mak,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234269
2025-01-30 14:14:01 +00:00
Florian Quèze
1ee252004d Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley.
Differential Revision: https://phabricator.services.mozilla.com/D234008
2025-01-24 16:18:32 +00:00