Commit Graph

215 Commits

Author SHA1 Message Date
Greg Stoll
5bad86a2d5 Bug 1926390 part 2 - add telemetry and tests for explicit tab unloading r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D229141
2024-11-18 15:02:41 +00:00
Dão Gottwald
f537dbd899 Bug 1926382 - Shift group labels along with the group's first tab. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D229122
2024-11-15 16:30:38 +00:00
Dão Gottwald
574d406c84 Bug 1931370 - Rename "Add tab to group" to "New tab in group". r=dwalker,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D229123
2024-11-15 14:38:52 +00:00
codesuki
95975f82f7 Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
2024-11-15 11:51:17 +00:00
Dão Gottwald
ddc5737e8c Bug 1928166 - Maintain tab order when ungrouping. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228990
2024-11-14 19:52:58 +00:00
Florian Quèze
634ebeeac3 Bug 1930163 - Remove support for setting a legacy telemetry scalar when a notification bar is shown, r=mstriemer,tabbrowser-reviewers,reusable-components-reviewers,dao.
Differential Revision: https://phabricator.services.mozilla.com/D228453
2024-11-14 17:25:13 +00:00
Gijs Kruitbosch
a50c45946e Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley,dao
Differential Revision: https://phabricator.services.mozilla.com/D226907
2024-11-14 17:14:50 +00:00
Dão Gottwald
f8d89fd012 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 16:33:19 +00:00
Alexandru Marc
898e7469f6 Backed out changeset 365a4dc7fe2d (bug 1930654) for causing bc failures @ browser_standalone_application_chooser_window_fallback.js . CLOSED TREE 2024-11-14 17:37:47 +02:00
Dão Gottwald
af03c5baa7 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 14:02:57 +00:00
Simon Friedberger
4fcd691190 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
9e0c14a80e Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE 2024-11-13 15:20:39 +02:00
Simon Friedberger
8eafd874fe Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Dão Gottwald
c40a1cb421 Bug 1929898 - Implement pause on drag and drop to create tab group. r=sthompson
Differential Revision: https://phabricator.services.mozilla.com/D228570
2024-11-12 16:54:20 +00:00
Jeremy Swinarton
8a3c3e1e4c Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-12 16:34:19 +00:00
Dão Gottwald
a4362055ee Bug 1930608 - Refactor _updateAfterMoveTabTo. r=jswinarton,tabbrowser-reviewers
Also simplify moveTabToStart and moveTabToEnd.

Differential Revision: https://phabricator.services.mozilla.com/D228646
2024-11-12 14:09:52 +00:00
Dão Gottwald
b567a0990b Bug 1926371 - Make "Remove from group" not move the tab into another group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228636
2024-11-12 14:09:52 +00:00
Stephen Thompson
b25e5f9796 Bug 1929384 - do not close window if there are still collapsed tab groups r=dao,tabbrowser-reviewers
When closing the last visible tab, if there are any collapsed tab groups, make one of the tabs in a tab group active. Based on pre-existing behavior, activating a tab in a collapsed tab group causes the tab group to expand.

Currently, if you close the last visible tab while you still have collapsed tab groups present on the tab bar, the browser window will close. This is surprising and sad behavior for users.

Differential Revision: https://phabricator.services.mozilla.com/D228274
2024-11-11 10:39:11 +00:00
Emilio Cobos Álvarez
883968ff6c Bug 1928151 - With vertical tabs, make the sidebar and toolbars match the toolbox. r=sidebar-reviewers,sfoster,desktop-theme-reviewers,sclements
As per discussion with UX, we might want the toolbox background to be
different in (some of) our default themes in this case, but that seems
orthogonal, and this seems somewhat straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D227494
2024-11-09 00:07:54 +00:00
Dão Gottwald
372e1282c7 Bug 1927884 - Update tab line colour when moving between groups. r=sthompson
Differential Revision: https://phabricator.services.mozilla.com/D228466
2024-11-08 18:57:28 +00:00
Nikki Sharpley
d694d21a6e Bug 1918217 - Improve drag and drop experience for pinned tabs when vertical tabs expanded r=tabbrowser-reviewers,dao
- you can now drag and drop when there are only 2 or 3 pinned tabs
- the position of the dragged tab has been fixed when scrolling overflow

Differential Revision: https://phabricator.services.mozilla.com/D227992
2024-11-08 17:35:48 +00:00
Butkovits Atila
85eb562171 Backed out changeset 307c830b0d2b (bug 1908422) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-11-08 21:50:37 +02:00
Jeremy Swinarton
f5892027d4 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 17:29:38 +00:00
Alexandru Marc
f7c8138cf9 Backed out changeset 9e5edf53c876 (bug 1908422) for causing bc failures @ browser_tab_groups_a11y.js 2024-11-08 16:57:36 +02:00
Jeremy Swinarton
62d713d116 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 13:53:19 +00:00
Stephen Thompson
1af22827e1 Bug 1926354 - only allow drag-drop tab group creation on ungrouped tabs r=dao,tabbrowser-reviewers
Currently, we provide a visual indicator + functionality to create a new tab group by dropping any tab onto any other tab. We think users will generally only use this to create new tab groups between standalone tabs; users are probably more likely to be making a mistake if they end up creating a new tab group by dropping a tab onto another tab that's already in a tab group. In order to prevent that, this patch just turns off the ability to create a new tab group by dropping onto any grouped tab.

Differential Revision: https://phabricator.services.mozilla.com/D228381
2024-11-08 10:13:33 +00:00
Stephen Thompson
de5857f96b Bug 1927910 - limit color changes when dragging to create tab groups r=dao,tabbrowser-reviewers
When all 9 tab group colors are in use, drag-drop code picks a random tab group color to highlight the tab drop target if the drop will create a tab group. The random pick is executed once per dragover event, so the color appears to change a few times a second. Kinda cool but distracting.

This patch chooses the next new tab group color on dragstart, saves that color on the drag data, and uses that color for all of the presentation + logic for creating a new tab group from a drop. The color will still be random when there are many tab groups, but the color will stay the same throughout a single drag operation.

Differential Revision: https://phabricator.services.mozilla.com/D228386
2024-11-08 10:04:07 +00:00
Stephen Thompson
120dd5317f Bug 1922268: inserting tabs behaves with adjacent tab groups r=dao,tabbrowser-reviewers
Fixes a number of edge cases where tabs created/inserted in the tab strip were incorrectly being placed inside of an adjacent tab group or incorrectly being placed outside of the intended tab group

Differential Revision: https://phabricator.services.mozilla.com/D226705
2024-11-05 17:57:09 +00:00
Stephen Thompson
8e4dfe1e0e Bug 1921814 - add keyboard focus for tab group labels r=dao,dwalker,desktop-theme-reviewers,tabbrowser-reviewers
This patch makes tab group labels "focusable" using the keyboard when the tab strip contains both tabs and tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D226154
2024-11-05 16:52:19 +00:00
DJ
3b0844e1e4 Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-05 15:59:01 +00:00
Florian Quèze
72e00a824e Bug 1927093 - Migrate scalars to use Glean APIs for browser.engagement.* (excluding browser.engagement.navigation.*), r=chutten,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,sfoster.
Differential Revision: https://phabricator.services.mozilla.com/D226371
2024-11-05 13:22:58 +00:00
Norisz Fay
a327d3221e Backed out changeset 9515be9963ea (bug 1927094) for causing bc failures on browser_hide_sidebar_on_popup.js CLOSED TREE 2024-11-05 13:53:00 +02:00
Gijs Kruitbosch
ea7dda1742 Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D226907
2024-11-05 10:03:35 +00:00
Iulian Moraru
ba826d51af Backed out changeset 068e6a4704bf (bug 1922276) for causing bc failures on browser_tab_groups.js. 2024-11-05 01:45:16 +02:00
DJ
0de1e8d91b Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-04 16:31:09 +00:00
Dão Gottwald
be20b43235 Bug 1925312 - Fix typo. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D227807
2024-11-04 15:29:55 +00:00
Greg Stoll
e8e176f8e8 Bug 1926055 part 1 - add "Unload Tab" to context menu r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Also make sure to select another tab if unloading the currently selected
tab (or Firefox View if unloading all tabs in the window) and handle
multiselect.

Differential Revision: https://phabricator.services.mozilla.com/D226346
2024-11-04 12:20:08 +00:00
Butkovits Atila
3609354615 Backed out changeset 5c7de47bcacb (bug 1927094) for causing Bug 1928689. a=backout 2024-11-01 18:11:08 +02:00
DJ
181219c0f1 Bug 1923651 - implement "move group to new window" in tabgroup edit menu. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226325
2024-10-31 15:01:07 +00:00
Gijs Kruitbosch
785b95b32e Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D226907
2024-10-31 10:55:30 +00:00
DJ
079c3f85da Bug 1926293 - handle moving tabs into groups across windows. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226729
2024-10-28 14:15:58 +00:00
Sam Foster
95be994d16 Bug 1922307 - Adjust the height of the auto-hiding menu toolbar when the tabstrip is hidden. r=desktop-theme-reviewers,dao,tabbrowser-reviewers,urlbar-reviewers
* Set the 'tabs-hidden' attribute on the #navigator-toolbox instead of the #nav-bar
* Add a --urlbar-padding-block variable for the padding around the urlbar

Differential Revision: https://phabricator.services.mozilla.com/D226568
2024-10-24 22:54:23 +00:00
Gijs Kruitbosch
edbf38b3fa Bug 1924534 - make scrolledtostart work for vertical tabs by relying on pinned instead of _pinnedUnscrollable, r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226756
2024-10-24 16:20:27 +00:00
Gijs Kruitbosch
f479b0afd6 Bug 1926834 - put pid pref getter on tabbrowser and use from both tab hover previews and tabbrowser itself, r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D226767
2024-10-24 15:25:36 +00:00
Dão Gottwald
a255af1381 Bug 1926582 - Rename things related to moving multiselected tabs together to avoid confusion with tab groups. r=dwalker,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226640
2024-10-24 14:12:27 +00:00
Florian Quèze
fc2b365faf Bug 1923028 - Migrate scalars to use Glean APIs for browser.ui.interaction.* probes outside of BrowserUsageTelemetry.sys.mjs, r=chutten,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D226514
2024-10-24 10:52:57 +00:00
Brian Grinstead
f6bb34aa25 Bug 1925724 - Use page wireframe for tab hover preview as a fallback when a normal thumnail is not available;r=mconley,sessionstore-reviewers,tabbrowser-reviewers,farre
This will only work when the pref is enabled (browser.history.collectWireframes), and is being landed primarily
to allow some expanded testing to see if it's worth cleaning this up further and turning it on.

Differential Revision: https://phabricator.services.mozilla.com/D226080
2024-10-24 03:34:40 +00:00
Stanca Serban
33720e7c62 Backed out 2 changesets (bug 1926582, bug 1926394) for causing mochitests failures in browser_preserveTabPipIconOverlay.js. CLOSED TREE
Backed out changeset 851d64f4461e (bug 1926582)
Backed out changeset 79c92abcd174 (bug 1926394)
2024-10-23 19:41:00 +03:00
Dão Gottwald
229b55fa59 Bug 1926582 - Rename things related to moving multiselected tabs together to avoid confusion with tab groups. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226640
2024-10-23 14:26:43 +00:00
Dão Gottwald
4be8b6fec6 Bug 1926359 - Add tab group line to dragged tabs when dragging into a group. r=dwalker,tabbrowser-reviewers
Ideally the line should cover the whole group, but I don't know that we can do this given our use of display:contents. If someone has ideas we can file a followup on that. As it stands the line will extend under dragged tabs themselves, but left or right from those there can be gaps in the line.

Differential Revision: https://phabricator.services.mozilla.com/D226634
2024-10-23 14:21:34 +00:00