Commit Graph

1346 Commits

Author SHA1 Message Date
Tom Schuster
e709a4d123 Bug 1964754 - Remove nsIContentPolicy TYPE_OBJECT_SUBREQUEST. r=necko-reviewers,webdriver-reviewers,extension-reviewers,devtools-reviewers,valentin,robwu,whimboo,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250027
2025-05-22 08:27:55 +00:00
Alexandru Marc
43acd12a3b Revert "Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau" for causing multiple failures
This reverts commit 585626d8fc.

Revert "Bug 1955685 - Improve cookie validation - part 6 - CookieValidation for web-ext, r=robwu,cookie-reviewers,valentin"

This reverts commit b38d308433.

Revert "Bug 1955685 - Improve cookie validation - part 5 - 0x20 as invalid chars for cookie names and values r=valentin,cookie-reviewers"

This reverts commit 3578880f65.

Revert "Bug 1955685 - Improve cookie validation - part 4 - expiry validation, r=edgul,cookie-reviewers,valentin"

This reverts commit 26e16d402f.

Revert "Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu"

This reverts commit 433a4d736d.

Revert "Bug 1955685 - Improve cookie validation - part 2 - nsICookieValidation in cookieManager.addNative, r=edgul,cookie-reviewers,geckoview-reviewers,nalexander,glandium"

This reverts commit 818c2c1769.

Revert "Bug 1955685 - Improve cookie validation - part 1 - nsICookieValidation, r=edgul,cookie-reviewers"

This reverts commit 55ad680779.
2025-05-20 09:31:40 +00:00
Andrea Marchesini
585626d8fc Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D248600
2025-05-20 08:02:18 +00:00
Andrea Marchesini
433a4d736d Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu
Differential Revision: https://phabricator.services.mozilla.com/D244897
2025-05-20 08:02:03 +00:00
Tom Schuster
1faa92ea02 Bug 1966621 - Use nsContentPolicyType in IPCInternalRequest IPDL. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D249533
2025-05-16 05:44:34 +00:00
Sean Feng
3d9727c887 Bug 1964407 - Implement TaskSignal.any for the web task scheduling API r=jjaschke,dom-core,webidl,smaug
Spec: https://wicg.github.io/scheduling-apis/#dom-tasksignal-any

Differential Revision: https://phabricator.services.mozilla.com/D248346
2025-05-15 15:14:14 +00:00
Eden Chuang
0dd34d4e02 Bug 1963402 - Using DirectTaskDispatch for MozPromises related to FetchService. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D247131
2025-05-02 10:08:13 +00:00
Rob Wu
62248a8bcc Bug 1953004 - Run test-manifest-toml --fix on all toml files in the trees r=credential-management-reviewers,places-reviewers,desktop-theme-reviewers,Standard8,devtools-reviewers,hjones,jmaher,jdescottes,dimi,necko-reviewers,sidebar-reviewers,jsudiaman,kershaw
This diff was generated as follows:

List all toml files in the tree:

`find * -name '*.toml' > /tmp/toml`

Manually edited /tmp/toml to drop non-relevant entries (objdir).

Ran the toml linter for all files:

`cat /tmp/toml | xargs ./mach lint -l test-manifest-toml --fix`

Differential Revision: https://phabricator.services.mozilla.com/D240948
2025-04-14 08:30:13 +00:00
Benjamin VanderSloot
d27e9eaab8 Bug 1945565 - Add ChromeOnly features to Fetch to allow FedCM to work - r=valentin,necko-reviewers,webidl,farre,sefeng,smaug
This updates RequestInit's ChromeOnly behavior:
- fixes up triggeringPrincipalOverride
- adds neverTaint

This adds Content-type: web-identity to ORB's allowlist.

Differential Revision: https://phabricator.services.mozilla.com/D237043
2025-03-14 14:38:49 +00:00
Stanca Serban
4a67a80267 Backed out 2 changesets (bug 1945565) for causing wpt failures.
Backed out changeset fbdc65ce6f84 (bug 1945565)
Backed out changeset 5296261171bc (bug 1945565)
2025-03-13 18:53:37 +02:00
Benjamin VanderSloot
968d298a34 Bug 1945565 - Add ChromeOnly features to Fetch to allow FedCM to work - r=valentin,necko-reviewers,webidl,farre,sefeng,smaug
This updates RequestInit's ChromeOnly behavior:
- fixes up triggeringPrincipalOverride
- adds neverTaint

This adds Content-type: web-identity to ORB's allowlist.

Differential Revision: https://phabricator.services.mozilla.com/D237043
2025-03-13 12:34:57 +00:00
Norisz Fay
739bf939a1 Backed out 2 changesets (bug 1945565) for causing bustageson Request.cpp CLOSED TREE
Backed out changeset 7c9eb04edd98 (bug 1945565)
Backed out changeset 155edbe21877 (bug 1945565)
2025-03-13 03:57:45 +02:00
Benjamin VanderSloot
950c05697e Bug 1945565 - Add ChromeOnly features to Fetch to allow FedCM to work - r=valentin,necko-reviewers,webidl,farre,sefeng,smaug
This updates RequestInit's ChromeOnly behavior:
- fixes up triggeringPrincipalOverride
- adds neverTaint

This adds Content-type: web-identity to ORB's allowlist.

Differential Revision: https://phabricator.services.mozilla.com/D237043
2025-03-13 00:51:19 +00:00
Emilio Cobos Álvarez
db9bcd53f7 Bug 1948889 - Simplify SRICheck by getting location from http referrer info. r=freddyb,tschuster
The referrer info is more directly what we want (what triggered this
load).

I could add this information for non-http channels, but I think it's
probably not worth it. This is useful because it's thread-safe, which
allows me to support off-main-thread parsing of stylesheets that contain
SRI metadata.

It also simplifies the API and avoids getting URIs around in non-error
code paths.

Differential Revision: https://phabricator.services.mozilla.com/D238612
2025-02-25 09:38:28 +00:00
Nika Layzell
3fedfa61ee Bug 1869650 - Remove MozPromise::IsResolved(), r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D238312
2025-02-18 20:40:20 +00:00
Eden Chuang
234eab4e05 Bug 1947434 - Use default memory ordering policy for FetchInstance::mActorDying. r=dom-worker-reviewers,smaug
Differential Revision: https://phabricator.services.mozilla.com/D237699
2025-02-12 08:57:20 +00:00
smayya
85f33b56ef Bug 1938471 - synchronize access to FetchDriver::mObserver. r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D235762
2025-02-04 15:48:43 +00:00
smayya
2ccb26b302 Bug 1938471 - Backed out changeset dcfa4149aaf3. r=necko-reviewers,kershaw
Please see the explaination for the fix in the bug [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1938471#c16 | comment ]]

Differential Revision: https://phabricator.services.mozilla.com/D235761
2025-02-04 15:48:43 +00:00
Florian Quèze
9609e47f62 Bug 1879329 - script generated replacement of the GleanMetrics.h includes, r=chutten,valentin,media-playback-reviewers,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,rkraesig,emz,aabh,padenot.
Differential Revision: https://phabricator.services.mozilla.com/D234744
2025-01-21 11:21:45 +00:00
Kagami Sascha Rosylight
ee4d846761 Bug 1941210 - Strongly grab FetchStreamReader while waiting for writing r=smaug
Nothing strongly grabs ReadableStream nor FetchStreamReader while waiting for nsIAsyncOutputStream to respond. mAsyncWaitReader should now strongly grab the reader until the output stream responds.

Differential Revision: https://phabricator.services.mozilla.com/D234031
2025-01-14 19:24:05 +00:00
Tim Huang
5cd3f25e6a Bug 1915355 - Part 2: Propagate the isOn3PCBExcpetionList to workers. r=edenchuang
We need to propagate the isOn3PCBExceptionList flag from the nsILoadInfo
to workers so that the requests from workers can have the flag to exempt
third-party cookie blocking. We will also tackle the fetch request in
the worker scope in the patch.

Depends on D223380

Differential Revision: https://phabricator.services.mozilla.com/D223936
2025-01-10 08:24:28 +00:00
Kagami Sascha Rosylight
6447a11979 Bug 1939295 - Add OutputStreamHolder r=jesup
Similar to InputStreamHolder, this adds OutputStreamHolder to FetchStreamReader:

1. OutputStreamHolder is not part of the cycle collection but is freed when FetchStreamReader goes away
2. nsIAsyncOutputStream holds OutputStreamHolder which only weakly hold FetchStreamReader, allowing FetchStreamReader to be cycle collected.
3. GlobalTeardownObserver is not added here as we only accept JS ReadableStream here instead of nsIInputStream, which is part of the cycle collection unlike nsIInputStream.

Differential Revision: https://phabricator.services.mozilla.com/D233553
2025-01-09 15:20:35 +00:00
Stanca Serban
3eac2f1354 Backed out 8 changesets (bug 1915355) for causing xpcshell failures.
Backed out changeset d292c3a2592d (bug 1915355)
Backed out changeset 3386ee00459e (bug 1915355)
Backed out changeset 98848e63dfbf (bug 1915355)
Backed out changeset b668d0c685e8 (bug 1915355)
Backed out changeset 08acd8256071 (bug 1915355)
Backed out changeset 3ae9463ee988 (bug 1915355)
Backed out changeset 2dd416f1b847 (bug 1915355)
Backed out changeset 17107bbcf8c8 (bug 1915355)
2025-01-08 23:36:08 +02:00
Tim Huang
480c19889f Bug 1915355 - Part 2: Propagate the isOn3PCBExcpetionList to workers. r=edenchuang
We need to propagate the isOn3PCBExceptionList flag from the nsILoadInfo
to workers so that the requests from workers can have the flag to exempt
third-party cookie blocking. We will also tackle the fetch request in
the worker scope in the patch.

Depends on D223380

Differential Revision: https://phabricator.services.mozilla.com/D223936
2025-01-08 19:25:58 +00:00
smayya
76b65f790f Bug 1935088 - set thirdparty contexts for fetch keepalive requests. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D231754
2025-01-07 14:41:55 +00:00
Alexandru Marc
0c1f8f4e28 Backed out 7 changesets (bug 1915355) for causing performance regressions CLOSED TREE
Backed out changeset 77b4cc920fe4 (bug 1915355)
Backed out changeset da9446e06954 (bug 1915355)
Backed out changeset 20708fe16d2a (bug 1915355)
Backed out changeset 7c4b003d1e48 (bug 1915355)
Backed out changeset 36163490219b (bug 1915355)
Backed out changeset 8f867025b79b (bug 1915355)
Backed out changeset 3d647f81adb9 (bug 1915355)
2024-12-30 13:02:45 +02:00
Alexandru Marc
c814f3818a Backed out changeset 5efbaa9e5c01 (bug 1935088) for causing conflicts 2024-12-30 12:57:53 +02:00
smayya
0aab8b73b0 Bug 1935088 - set thirdparty contexts for fetch keepalive requests. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D231754
2024-12-20 11:36:24 +00:00
Tim Huang
2beb9afe1b Bug 1915355 - Part 2: Propagate the isOn3PCBExcpetionList to workers. r=edenchuang
We need to propagate the isOn3PCBExceptionList flag from the nsILoadInfo
to workers so that the requests from workers can have the flag to exempt
third-party cookie blocking. We will also tackle the fetch request in
the worker scope in the patch.

Differential Revision: https://phabricator.services.mozilla.com/D223936
2024-12-17 21:44:36 +00:00
Alexandru Marc
424d306b7d Backed out 7 changesets (bug 1915355) for causing build bustages @ ThirdPartyCookieBlockingExceptions.cpp CLOSED TREE
Backed out changeset 5e5278038a79 (bug 1915355)
Backed out changeset d2381f88168a (bug 1915355)
Backed out changeset 675785853d7a (bug 1915355)
Backed out changeset de6a26d3e3df (bug 1915355)
Backed out changeset b2934cae3c23 (bug 1915355)
Backed out changeset e7077b00cfc1 (bug 1915355)
Backed out changeset c5d7f4e7e839 (bug 1915355)
2024-12-17 12:39:21 +02:00
Tim Huang
ccba861132 Bug 1915355 - Part 2: Propagate the isOn3PCBExcpetionList to workers. r=edenchuang
We need to propagate the isOn3PCBExceptionList flag from the nsILoadInfo
to workers so that the requests from workers can have the flag to exempt
third-party cookie blocking. We will also tackle the fetch request in
the worker scope in the patch.

Differential Revision: https://phabricator.services.mozilla.com/D223936
2024-12-17 08:57:30 +00:00
Jonatan Klemets
d60f6391b3 Bug 1858078 - Part 1: Add nsIContentPolicy::{TYPE_JSON,TYPE_INTERNAL_JSON_PRELOAD} r=extension-reviewers,webidl,devtools-reviewers,dom-core,smaug,robwu,tschuster,nchevobbe,farre
Differential Revision: https://phabricator.services.mozilla.com/D229524
2024-12-12 17:39:18 +00:00
Randell Jesup
e25cedb938 Bug 1917901: Make it ok to retarget OnDataAvailable multiple times until the first ODA is received r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D223651
2024-12-02 16:38:25 +00:00
Alexandru Marc
d900437bd8 Backed out changeset f9ccd9f31b9c (bug 1917901) for causing networking crashes. a=backout 2024-11-21 11:26:48 +02:00
Randell Jesup
a9c3cf04c0 Bug 1917901: Make it ok to retarget OnDataAvailable multiple times until the first ODA is received r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D223651
2024-11-20 11:25:54 +00:00
Julian Descottes
53cfe5f498 Bug 1932162 - Expose fetch destination on nsILoadInfo r=necko-reviewers,valentin
Depends on D229378

Expose a getter on nsILoadInfo to easily retrieve the fetch destination as a string
This avoids duplicating the mapping logic in JS for webdriver bidi

Differential Revision: https://phabricator.services.mozilla.com/D229384
2024-11-20 09:07:37 +00:00
serge-sans-paille
aee8b0d98b Bug 1920080 - Make nsCString default constructor constexpr r=glandium,xpcom-reviewers,emilio
This make it possible to flag a few MOZ_RUNINIT variables as
MOZ_CONSTINIT.

Differential Revision: https://phabricator.services.mozilla.com/D227451
2024-11-13 19:39:45 +00:00
Norisz Fay
94a225c4ec Backed out changeset 75935042f60b (bug 1920080) for causing assertion failure on FetchUtil.cpp 2024-11-13 01:47:14 +02:00
serge-sans-paille
52e61eb6ac Bug 1920080 - Make nsCString default constructor constexpr r=glandium,xpcom-reviewers,emilio
This make it possible to flag a few MOZ_RUNINIT variables as
MOZ_CONSTINIT.

Differential Revision: https://phabricator.services.mozilla.com/D227451
2024-11-12 22:08:02 +00:00
serge-sans-paille
5946338a6a Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-30 11:05:24 +00:00
Tamas Szentpeteri
8285dfaab8 Backed out changeset 4b1409597101 (bug 1920718) for causing bp bustages on rapl.cpp. 2024-10-08 23:27:18 +03:00
serge-sans-paille
1966f9a43c Bug 1920718 - Annotate all global variable with runtime initialization as MOZ_RUNINIT r=application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-08 16:49:51 +00:00
Valentin Gosu
533ec6637b Bug 1900561 - Set nsIClassOfService::fetchPriority where callers use nsISupportsPriority.adjustPriority r=acreskey
Differential Revision: https://phabricator.services.mozilla.com/D221958
2024-09-25 18:42:52 +00:00
smayya
6b4a826e78 Bug 1914632 - delete the actors during shutdown for worker keepalive requests.r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D222437
2024-09-24 17:10:06 +00:00
smayya
2542858288 Bug 1914632 - modify shutdown handling for keepalive requests. r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D221458
2024-09-24 17:10:05 +00:00
smayya
61755154fe Bug 1914632 - support fetch keepalive for workers. r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D220018
2024-09-24 17:10:05 +00:00
Butkovits Atila
e6ce34045f Backed out 3 changesets (bug 1900561, bug 1919158) for causing bustages at ipc_message_utils.h. CLOSED TREE
Backed out changeset a2a4a88ef8d1 (bug 1919158)
Backed out changeset ecb590690d2e (bug 1900561)
Backed out changeset ef92a69ff2d1 (bug 1900561)
2024-09-24 18:58:08 +03:00
Butkovits Atila
47fc85341d Backed out 5 changesets (bug 1906952, bug 1914632, bug 1901761) for causing bustage at RefPtr.h. CLOSED TREE
Backed out changeset 4dadc74e5e51 (bug 1906952)
Backed out changeset 0689a41fae4c (bug 1914632)
Backed out changeset 1f93aaf15cf6 (bug 1914632)
Backed out changeset 37dbae4a6310 (bug 1914632)
Backed out changeset 177540310817 (bug 1901761)
2024-09-24 17:21:15 +03:00
Valentin Gosu
ebbb22fc8b Bug 1900561 - Set nsIClassOfService::fetchPriority where callers use nsISupportsPriority.adjustPriority r=acreskey
Depends on D221957

Differential Revision: https://phabricator.services.mozilla.com/D221958
2024-09-24 12:29:08 +00:00
smayya
fe6c28d58c Bug 1914632 - delete the actors during shutdown for worker keepalive requests.r=edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D222437
2024-09-24 11:30:22 +00:00