corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
858,376 Commits 1 Branch 0 Tags
08a3c0fce26aa901b66d9a3f7f82718505f3737d
Commit Graph

92 Commits

Author SHA1 Message Date
Yi Xiong Wong
9457049851 Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D205528
 2024-03-28 17:05:02 +00:00
Dave Townsend
8ca92a1c30 Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D202999
 2024-03-05 14:21:14 +00:00
Mark Banner
32e5048c7c Bug 1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D187512
 2023-09-25 10:44:49 +00:00
Sandor Molnar
a59dc0e8cf Backed out changeset f0a2aa2ffe6d (bug 1832704) for causing xpc failures in toolkit/components/search/tests/xpcshell/test_async.js 2023-09-19 03:19:30 +03:00
Mark Banner
8b11f7c564 Bug 1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D187512
 2023-09-18 15:09:56 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
ganna
6ae89f2f46 Bug 1814414 - Replace constructed xul label with moz-support-link in ExtensionControlledPopup.jsm r=extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D179835
 2023-06-07 14:27:39 +00:00
Rob Wu
f0c7c874d6 Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D179890
 2023-06-05 10:23:40 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE 
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
 2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 10:21:37 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
William Durand
36e8ea3c75 Bug 1822306 - Add Extension.getPreferredIcon() method and use it. r=zombie 
It looks like `extension.iconURL` never worked. I added a `getPreferredIcon()`
that relies on `IconDetails.getPreferredIcon()` under the hood in order to
easily get icon URLs from an instance of an `Extension`. I updated a few places
where using this new method is a bit better.

Differential Revision: https://phabricator.services.mozilla.com/D173158
 2023-03-27 11:04:50 +00:00
Gijs Kruitbosch
64b3d90475 Bug 1810141 - fix replaceUrlInTab webextension utility to deal with loadURI changes, r=rpl 
Depends on D168392

Differential Revision: https://phabricator.services.mozilla.com/D168393
 2023-02-13 23:50:39 +00:00
Cristina Horotan
f062495d94 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE 
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
 2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
214358c5c7 Bug 1810141 - fix replaceUrlInTab webextension utility to deal with loadURI changes, r=rpl 
Depends on D168392

Differential Revision: https://phabricator.services.mozilla.com/D168393
 2023-02-13 12:55:24 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Luca Greco
b2565a2a3f Bug 1767550 - Make sure defaultSearch overrides levelOfControl is consistent with the default engine currently set before overriding the current default. r=mixedpuppy 
For add-ons installed before the changes introduced by Bug 1757760 ExtensionSettingStorage.getLevelOfControl resolves to "controlled_by_this_extension"
even if the user did not opt-in when prompted (either by never answer the prompt, or by setting No).

The changes landed by Bug 1757760 did make sure that for a newly installed extensions ExtensionSettingsStorage.getLevelOfControl resolves to "controllable_by_this_extension"
until the user actually explicitly opt-in to the default search engine provided by the installed extension, by making sure to initially set as disabled
the defaultSearch setting for a newly installed extension (which will then be enabled if the user does explicitly opt-in).

Unfortunately, that change doesn't have any effect if the extension has been installed in a Firefox version that did not yet include Bug 1757760 changes,
in that case the setting listed in the pre-existing extension-settings.json file in the Firefox profile will still have the setting marked
as enabled even if the user did never opt-in.

This patch includes a new test task that is injecting into extension-settings.json the data needed to recreate the inconsistent state
(level of control set to "controlled_by_this_extension" while the related search engine isn't actually set as default).

In addition to the new test case, this patch is applying the following changes to `chrome_settings_overrides`:

- in the `setDefault` method: if ExtensionSettingsStorage.getLevelOfControl resolves to "controlled_by_this_extension"
  but the default search engine currently set is not the one associated to the extension, then explicitly disable the
  setting and recompute the level of control (which will resolve to "controllable_by_this_extension" as a side effect
  of explicitly disable the setting)

- in the `ensureSetting` method: remove the check on `item?.enabled`, because the result of ExtensionSettingsStorage.getSetting
  does actually never have an `enabled` property set, instead it is part of the content of the extension-settings.json file
  and it is used internally by ExtensionSettingsStorage without being returning in the format of the object returned by
  calling ExtensionSettingsStorage.getSetting
  (see https://searchfox.org/mozilla-central/rev/97c902e8f92b15dc63eb584bfc594ecb041242a4/toolkit/components/extensions/ExtensionSettingsStore.jsm#164-177)

Differential Revision: https://phabricator.services.mozilla.com/D146294
 2022-05-25 18:46:12 +00:00
Shane Caraveo
2530614cac Bug 1757760 retain correct search default setting after addon update r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D141294
 2022-03-18 19:43:43 +00:00
Shane Caraveo
1034bc2ebf Bug 1705835 remove unused engineAdded extension setting r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D112432
 2021-04-22 15:33:51 +00:00
Mark Banner
c9be59b5ad Bug 1702454 - Re-enabling an add-on that overrides search engine parameters shouldn't cause a prompt. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D110562
 2021-04-15 15:57:41 +00:00
Shane Caraveo
f259d96a14 Bug 1698619 fix updating homepage setting on updates and for localization r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D110717
 2021-04-12 18:58:27 +00:00
Shane Caraveo
b46aa07a7d Bug 1646338 ask to set as default again when enabling a search addon r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D107132
 2021-03-29 15:42:23 +00:00
Erica Wright
702fb9a86f Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-20 21:40:14 +00:00
Bogdan Tara
ff248efb24 sBacked out changeset 26f7d3a8b1b6 (bug 1595858) for overrides related mochitest failures CLOSED TREE 2020-11-18 01:42:59 +02:00
Erica Wright
e6b0316387 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-17 19:49:36 +00:00
Bogdan Tara
07d282afc6 Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE 2020-11-13 06:11:35 +02:00
Erica Wright
5855481ca4 Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D93584
 2020-11-13 02:02:47 +00:00
Mark Banner
88ece2d4ce Bug 1643858 - When an add-on is uninstalled at early startup, ensure that we also remove associated search engines. r=mixedpuppy,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D95540
 2020-11-04 11:20:45 +00:00
Mark Banner
bc781a0864 Bug 1638888 - Make disabling and enabling a WebExtension restore the default search engine correctly. r=mixedpuppy,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D76503
 2020-06-16 08:54:24 +00:00
Mark Banner
7fc2b2098c Bug 1638888 - Simplify processSearchProviderManifestEntry to handle the not setting as default engine case first. r=mixedpuppy,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D79271
 2020-06-16 08:54:16 +00:00
Mark Banner
2b1410dfe5 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D77429
 2020-05-31 12:19:18 +00:00
Mihai Alexandru Michis
ffc388df9a Backed out changeset d82a23f070f6 (bug 1641261) for causing xpcshell failures in test_override_allowlist.js 
CLOSED TREE
 2020-05-30 11:19:08 +03:00
Mark Banner
097b0ab538 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D77429
 2020-05-29 23:09:34 +00:00
Mark Banner
a4bd46c2dd Bug 1635235 - Ensure browser_ext_settings_overrides_default_search.js can wait for search engine setup to complete to avoid intermittents. r=mixedpuppy 
Depends on D76480

Differential Revision: https://phabricator.services.mozilla.com/D76910
 2020-05-26 19:53:42 +00:00
Mark Banner
be3d4dc1e4 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey 
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
 2020-05-26 19:40:42 +00:00
Mihai Alexandru Michis
cc78e5f718 Backed out 2 changesets (bug 1635235, bug 1635239) for causing Bug 1640583. 
CLOSED TREE

Backed out changeset 97ecda13df18 (bug 1635239)
Backed out changeset c9f80397bbec (bug 1635235)
 2020-05-25 16:43:03 +03:00
Mark Banner
6c826e7ba0 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey 
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
 2020-05-24 21:45:41 +00:00
Mark Banner
5beee96289 Bug 1635231 - Allow overriding and setting as default specific search engines according to a allowlist. r=daleharvey,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D75613
 2020-05-21 10:42:20 +00:00
Dale Harvey
688a142a4d Bug 1621892 - Maintain engine settings when upgrading extension r=Standard8,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D68247
 2020-04-07 15:58:05 +00:00
Mark Banner
b7230156ea Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D69235
 2020-04-03 11:36:35 +00:00
Dorel Luca
7eec6ba613 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE 
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)
 2020-04-02 18:39:32 +03:00
Mark Banner
ba85723ecd Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey 
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235
 2020-04-02 14:31:45 +00:00
Shane Caraveo
82889634a5 Bug 1578513 make disable/enable during safe mode update extension settings r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D44595
 2019-11-27 20:00:08 +00:00
Shane Caraveo
f559d8e729 Bug 1578513 make uninstall during safemode remove extension settings r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D44594
 2019-11-27 22:19:15 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D45629
 2019-09-14 09:39:26 +00:00
mandy cheang
861abbb961 Bug 1566489 - Avoid reading extension-setting.json on start-up, read it lazily. r=aswan,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D40860
 2019-08-08 16:15:17 +00:00