corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
896,715 Commits 1 Branch 0 Tags
071931b71650fedd376afb51c7e5df80d741dff6
Commit Graph

3724 Commits

Author SHA1 Message Date
Marco Bonardo
b1c63066f1 Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238060
 2025-02-20 14:06:22 +00:00
Dale Harvey
75d808dbae Bug 1940591 - Match contextual engines by name instead of domain. r=mak,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233637
 2025-02-19 21:01:21 +00:00
Goloman Adrian
89bb435086 Backed out changeset 6c1483bf5f26 (bug 1945422) for causing bc failures @browser_searchSuggestions.js. CLOSED TREE 2025-02-19 23:38:47 +02:00
Stephanie Cunnane
f87d4b5743 Bug 1932715 - Remove legacy urlbar.tabtosearch.* scalars and Glean urlbar.tabtosearch.* labeled counters. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D238292
 2025-02-19 16:21:10 +00:00
Marco Bonardo
3c196e2f8a Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238060
 2025-02-19 14:45:20 +00:00
Stephanie Cunnane
002c094a5c Bug 1932713 - Remove legacy urlbar.picked.* scalars and Glean urlbar.picked.* labeled counters. r=adw,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D237974
 2025-02-18 21:18:58 +00:00
Drew Willcoxon
07c0872acb Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop 
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
 2025-02-18 20:05:11 +00:00
Drew Willcoxon
1dfff69006 Bug 1948037 - UrlbarView shouldn't skip over existing rows when processing hidden-exposure results. r=mak,urlbar-reviewers 
When the view is updating existing rows and it encounters a hidden-exposure
result, it shouldn't increment `rowIndex` because the row isn't actually updated
in that case. The view should revisit the row in the next iteration.

Differential Revision: https://phabricator.services.mozilla.com/D238147
 2025-02-18 18:09:36 +00:00
Alexandru Marc
eb7e658712 Backed out changeset dbfd15553a78 (bug 1948166) for causing bc failures @ browser_search_firefoxSuggest.js CLOSED TREE 2025-02-18 19:58:24 +02:00
Drew Willcoxon
cf1c98539b Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop 
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
 2025-02-18 16:11:30 +00:00
Gregory Pappas
408fd9c57f Bug 1925823 - Stop disabling screenshots component in mochitest r=urlbar-reviewers,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D226241
 2025-02-17 22:39:54 +00:00
Yazan Al Macki
921b039775 Bug 1903903 - Ensure search extension is properly unloaded to avoid clashing with other tests. r=daisuke,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238527
 2025-02-17 22:11:12 +00:00
Dale Harvey
e7bd680c67 Bug 1947742 - Prevent search actions overriding other actions. r=dao,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238407
 2025-02-17 21:48:21 +00:00
Yazan Al Macki
b1a1106ec2 Bug 1948089 - Copy localized string on calculator result selection. r=urlbar-reviewers,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D238093
 2025-02-14 18:01:47 +00:00
Drew Willcoxon
7e8ec5f0cd Bug 1947059 - Remove the concept of Suggest scenarios. r=daisuke 
Depends on D237507

Differential Revision: https://phabricator.services.mozilla.com/D237508
 2025-02-14 17:06:38 +00:00
Drew Willcoxon
6dab314205 Bug 1947057 - Move some async Suggest initialization so it only happens once. r=daisuke 
Depends on D237506

Differential Revision: https://phabricator.services.mozilla.com/D237507
 2025-02-14 17:06:37 +00:00
Yazan Al Macki
49b4ec5ec3 Bug 1946467 - Treat multiple commas/periods as thousands separators not as decimal points. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D237629
 2025-02-14 06:00:06 +00:00
Drew Willcoxon
f4c362c95a Bug 1947055 - Simplify Suggest initialization and how it handles updates to Nimbus variables. r=daisuke 
Depends on D237505

Differential Revision: https://phabricator.services.mozilla.com/D237506
 2025-02-13 22:14:58 +00:00
Yazan Al Macki
7c9e2465af Bug 1946089 - Add scientific notation to calculator. r=daleharvey,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237893
 2025-02-13 17:40:22 +00:00
Stephanie Cunnane
dff74b6859 Bug 1932711 - Remove legacy urlbar.engagement and urlbar.abandonment scalars, as well as their mirrors to Glean counters. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D237255
 2025-02-13 16:57:41 +00:00
Daisuke Akatsuka
e78979d818 Bug 1934410: Use menupopup element for Unified Search popup instead of panel r=daleharvey,desktop-theme-reviewers,emilio,dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D232573
 2025-02-12 23:47:19 +00:00
Drew Willcoxon
0e869a558b Bug 1947053 - Remove the quickSuggestScenario Nimbus variable. r=daisuke 
Depends on D237314

Differential Revision: https://phabricator.services.mozilla.com/D237505
 2025-02-12 09:12:49 +00:00
Yazan Al Macki
e5e98b7e13 Bug 1714493 - Make the calculator result read undefined when dividing by 0. r=fluent-reviewers,bolsson,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D236908
 2025-02-11 20:07:01 +00:00
Drew Willcoxon
68cf4c2660 Bug 1946919 - Remove shouldShowOnboardingDialog from default Suggest prefs. r=daisuke 
Depends on D237312

Differential Revision: https://phabricator.services.mozilla.com/D237314
 2025-02-11 02:58:53 +00:00
Drew Willcoxon
5dc88e8b46 Bug 1946918 - Remove Suggest's online scenario initialization code path. r=daisuke 
This builds on D237170. Like that revision, I kept this one small and focused to
make the changes easier to see. There are opportunities for further cleanup that
I'll work on in follow-ups.

Depends on D237170

Differential Revision: https://phabricator.services.mozilla.com/D237312
 2025-02-11 02:58:53 +00:00
Drew Willcoxon
9dddb45dad Bug 1937250 - Move Suggest prefs initialization from UrlbarPrefs to QuickSuggest. r=daisuke,urlbar-reviewers 
This mostly just moves all Suggest-related things from `UrlbarPrefs` to
`QuickSuggest`. To keep the patch small and make review easier, I tried to keep
it a straight move rather than making improvements, renames, and other
unnecessary changes. There's opportunity to improve and simplify some things,
and I'd like to do that in follow-ups.

Depends on D237281

Differential Revision: https://phabricator.services.mozilla.com/D237170
 2025-02-11 02:58:53 +00:00
Meg Viar
7ecf60304b Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI r=nalexander,emilio,urlbar-reviewers,adw 
Addresses issue where the URL bar appeared through the UI of the preonboarding modal (see screenshot in bug).
- Show the preonboarding after the "MozAfterPaint" event fires for the browser chrome.
- If for some reason the "MozAfterPaint" event never fires of the event listener was added after it fired, show the modal after 1 second as a fallback.

Differential Revision: https://phabricator.services.mozilla.com/D237100
 2025-02-10 22:46:06 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-10 15:24:32 +00:00
Alexandru Marc
c2a0f3fcfe Backed out changeset 26dd5b76091a (bug 1934410) for causing bc failures @ browser_searchMode 2025-02-10 16:39:36 +02:00
Daisuke Akatsuka
1ced078441 Bug 1934410: Use menupopup element for Unified Search popup instead of panel r=daleharvey,desktop-theme-reviewers,emilio,dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D232573
 2025-02-10 12:19:14 +00:00
Alexandru Marc
3b25cc24f7 Backed out changeset c28f8599b92c (bug 1934410) for causing bc failures @ browser_searchModeSwitcher_telemetry.js CLOSED TREE 2025-02-10 10:31:38 +02:00
Daisuke Akatsuka
e91bbe7c76 Bug 1934410: Use menupopup element for Unified Search popup instead of panel r=daleharvey,desktop-theme-reviewers,emilio,dao,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D232573
 2025-02-10 07:25:32 +00:00
Daisuke Akatsuka
b4f6558ec6 Bug 1944420: Change the frequency of display after dismissal r=urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D236506
 2025-02-10 01:36:39 +00:00
Daisuke Akatsuka
af04d78547 Bug 1944420: Show contextual opt-in message on top r=urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D236505
 2025-02-10 01:36:39 +00:00
Daisuke Akatsuka
acd8013a9e Bug 1944420: Update contextual opt-in message and remove the variation r=urlbar-reviewers,fluent-reviewers,dao,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D236504
 2025-02-10 01:36:39 +00:00
Drew Willcoxon
994aa0c26b Bug 1946000 - Update Policies.sys.mjs for Firefox Suggest initialization change. r=daisuke,mkaply 
Depends on D236825

Differential Revision: https://phabricator.services.mozilla.com/D236826
 2025-02-07 21:35:23 +00:00
Drew Willcoxon
1175b84265 Bug 1945999 - Make Suggest initialization happen in one place. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D236825
 2025-02-07 21:35:22 +00:00
Gijs Kruitbosch
747d34d801 Bug 1916424 - allow idle dispatch from BrowserUtils' category manager-based invocations, r=mossop,search-reviewers,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220896
 2025-02-07 16:54:50 +00:00
Stephanie Cunnane
c9ddaf4b3d Bug 1932716 - Remove legacy urlbar.tips scalar and Glean urlbar.tips labeled counter. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D236590
 2025-02-07 14:53:12 +00:00
James Teow
d522d53d26 Bug 1945208 - Add Interaction related prefs to Nimbus - r=mak,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236989
 2025-02-06 17:05:47 +00:00
Daisuke Akatsuka
1eb28dfd86 Bug 1925988: Use bookmark title if no visit_date r=urlbar-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D226829
 2025-02-04 21:48:14 +00:00
Emilio Cobos Álvarez
ab23c6cf79 Bug 1945451 - Avoid breaking out the urlbar while in customize mode. r=dao,urlbar-reviewers 
Density changes called directly into the urlbar input to update the
breakout. But when customizing the urlbar shouldn't break out.

That means that this code is mostly for when density is changed via
another window, or direct pref changes I guess.

Differential Revision: https://phabricator.services.mozilla.com/D236539
 2025-02-04 19:42:04 +00:00
Marco Bonardo
3c355b0f03 Bug 1925496 - Test. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D228316
 2025-02-04 13:51:27 +00:00
Moritz Beier
4afb8b6192 Bug 1880913 - Part 5: Display search engine removal notification via category manager. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236217
 2025-02-04 11:07:13 +00:00
Moritz Beier
4ff8ed5deb Bug 1880913 - Part 4: Remove BrowserSearch.searchBar getter. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D235598
 2025-02-04 11:07:12 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235597
 2025-02-04 11:07:12 +00:00
Moritz Beier
6c0a5096a8 Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D235595
 2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-04 08:25:28 +00:00
Drew Willcoxon
f23e8f81c3 Bug 1945021 - Set result.isBestMatch instead of suggestion.is_top_pick. r=daisuke 
Depends on D236300

Differential Revision: https://phabricator.services.mozilla.com/D236303
 2025-02-04 01:16:49 +00:00