Bug 1583109 introduced new function templates StringJoin and StringJoinAppend.
These are now used to replace several custom loops across the codebase that
implement string-joining algorithms to simplify the code.
Differential Revision: https://phabricator.services.mozilla.com/D98750
Bug 1583109 introduced new function templates StringJoin and StringJoinAppend.
These are now used to replace several custom loops across the codebase that
implement string-joining algorithms to simplify the code.
Differential Revision: https://phabricator.services.mozilla.com/D98750
Before this patch, nsUrlClassifierDBService::Shutdown() would check if its
classifier had been set before dispatching an event to have it disable async
updates. However, this was racy, as the pointer being checked is set on a
background thread, and this ::Shutdown() runs on the main thread.
This race was introduced in bug 1363038 to avoid a deadlock. It seems the real
cause of the deadlock was addressed shortly after in bug 1394031, but this change
was never reverted until now.
Differential Revision: https://phabricator.services.mozilla.com/D99715
In the Safe Browsing spec, it says "Do not apply these path canonicalizations to the query parameters.",
we should follow it.
Differential Revision: https://phabricator.services.mozilla.com/D98898
REMOVED
-------
toolkit/components/url-classifier/tests/browser/browser_flashblock_{on,off}_with_{always,ask to,never}_activate.js
bug 1350381
Test Flash user pref and Flash Block combination wrt sites blocklisted in different ways
toolkit/components/forgetaboutsite/test/browser/browser_clearplugindata.js
Test plugindata part of ForgetAboutSite's use of nsIClearDataService, which uses nsPluginHost to call's the plugin's (here, testplugin's) exported NPP_ClearSiteData function.
Differential Revision: https://phabricator.services.mozilla.com/D95917
REMOVED
-------
toolkit/components/url-classifier/tests/browser/browser_flashblock_{on,off}_with_{always,ask to,never}_activate.js
bug 1350381
Test Flash user pref and Flash Block combination wrt sites blocklisted in different ways
toolkit/components/forgetaboutsite/test/browser/browser_clearplugindata.js
Test plugindata part of ForgetAboutSite's use of nsIClearDataService, which uses nsPluginHost to call's the plugin's (here, testplugin's) exported NPP_ClearSiteData function.
Differential Revision: https://phabricator.services.mozilla.com/D95917
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.
This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.
Differential Revision: https://phabricator.services.mozilla.com/D94641
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.
This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.
Differential Revision: https://phabricator.services.mozilla.com/D94641
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
We treat it exactly the same as -moz-broken. The pseudo-class is not
exposed to content, so I don't think we have a reason to keep it around.
Differential Revision: https://phabricator.services.mozilla.com/D89904
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Depends on D89258
Differential Revision: https://phabricator.services.mozilla.com/D89259
In fission cross-origin mochitests, "mochi.xorigin-test" is the
top-level url instead of "mochi.test".
Our pairwise whitelist has to use the right top-level host accordingly
to make testcase work.
Differential Revision: https://phabricator.services.mozilla.com/D84585
