corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
880,195 Commits 1 Branch 0 Tags
05e3f046df19d26456088534e463dc47bc0c687d
Commit Graph

6050 Commits

Author SHA1 Message Date
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
Dão Gottwald
a5b1716f01 Bug 1921860 - Tab counts should include hidden tabs and tabs in collapsed tab groups. r=sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D225206
 2024-10-10 13:59:46 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D223833
 2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE 
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
 2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D223833
 2024-10-07 17:29:57 +00:00
Gijs Kruitbosch
70debc7c0a Bug 1920319 - add dedicated keypress handler for new tab buttons, r=tabbrowser-reviewers,dao 
Right now, tabbrowser relies on browser-toolbarKeyNav.js for keyboard access to these buttons on macOS.
There's also toolkit handling for space, but not enter, in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/toolkit/content/widgets/button.js#27-34 .
In vertical tabs mode, browser-toolbarKeyNav does not help us as the buttons aren't in the toolbox.
On Nightly, the containers-related code in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/browser/components/tabbrowser/content/tabs.js#1422-1428
adds the buttons to gClickAndHoldListeners, which have their own keypress handling. This happens whenever
containers are enabled. Those are not enabled by default on non-nightly, and so we end up missing a keypress
handler in vertical tabs mode on non-Nightly on macOS.

This is all a big mess and we should probably figure out a better solution. But given this needs beta uplift,
the expedient solution seems to be a dedicated listener and making sure that only 1 listener is invoked.

Differential Revision: https://phabricator.services.mozilla.com/D224094
 2024-09-30 13:15:28 +00:00
Florian Quèze
03b00e2a53 Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman. 
Differential Revision: https://phabricator.services.mozilla.com/D222416
 2024-09-20 13:58:15 +00:00
Henry Wilkes
1a0ae5644c Bug 1919363 - Only show one app menu "new window" item in permanent private browsing. r=mconley 
We also update the browser_private_browsing_window.js test.
The previous test was limited because it was referring to non-existent
"appmenu_newNavigator" and "appmenu_newPrivateWindow".

Differential Revision: https://phabricator.services.mozilla.com/D222507
 2024-09-19 19:23:04 +00:00
Henry Wilkes
e8235e9c72 Bug 1919297: Clean up unused isProductURL import in browser.js. r=shopping-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222477
 2024-09-17 14:07:50 +00:00
Manuel Bucher
da7c7ce7fc Bug 1452899 - Update the certificate security info on changed certificate in url bar lock icon r=pbz 
This removes the security information cache from the lock icon.
Basic testing of how often the cache is used showed that it was only
used rarly (2%-3% of the function calls).

The alternative approach would be to also check whether the cert changed
using `gBrowser.securityUI.secInfo.serverCert`. However, caching the
security information doesn't seem worth the effort here. The cache only
gets used when url is exactly the same (uri.spec). And checking
whether the cert is exactly the same looks more expensive to do each
time vs the slim benefit of rarely not needing to update the UI.

Differential Revision: https://phabricator.services.mozilla.com/D214549
 2024-09-17 12:01:51 +00:00
Emilio Cobos Álvarez
90897ae6d8 Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-16 13:21:51 +00:00
Cristian Tuns
482d5b9f87 Backed out 5 changesets (bug 1917458) for causing wpt failures in no_window_open_when_term_nesting_level_nonzero.window.html CLOSED TREE 
Backed out changeset 157eb2ada2ca (bug 1917458)
Backed out changeset 3f6d758ac9c6 (bug 1917458)
Backed out changeset 65384dcd3d9a (bug 1917458)
Backed out changeset e4cca274eb5a (bug 1917458)
Backed out changeset 2b1c3c2aef15 (bug 1917458)
 2024-09-14 21:04:04 -04:00
Emilio Cobos Álvarez
8d2ba7e03e Bug 1917458 - Remove bookmarks-toolbar-overlapping-browser code. r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
After the previous patch, we don't jank all remote tabs when resizing
the browser, so this can go. This should also make general window
resizing faster.

Differential Revision: https://phabricator.services.mozilla.com/D221996
 2024-09-14 23:23:52 +00:00
Niklas Baumgardner
12a9f7dca7 Bug 1885997 - Show profiles in profile selector window. r=jhirsch,fluent-reviewers,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220032
 2024-09-12 15:58:04 +00:00
Florian Quèze
7346c45e51 Bug 1917838 - Remove expired telemetry event close_tab_warning.shown, r=chutten,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao. 
Differential Revision: https://phabricator.services.mozilla.com/D221650
 2024-09-12 13:42:22 +00:00
Paul Zuehlcke
d44af5f1e9 Bug 1916946 - Remove 'private_browsing.window_open_during_teardown' telemetry. r=firefox-desktop-core-reviewers ,mconley 
This reverts commit 90baa7558e4bb31de60d8a4604ca965e4f8c6485.

Differential Revision: https://phabricator.services.mozilla.com/D221457
 2024-09-09 15:42:31 +00:00
isaacylee
cfa004f3c1 Bug 1558149 - Use 'loadFlags' instead of 'flags' for flags eventually passed to 'loadURI' or 'fixupAndLoadURIString' r=Gijs,geckoview-reviewers,tabbrowser-reviewers,dao,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D216324
 2024-08-31 22:00:59 +00:00
Adam Vandolder
d62196f820 Bug 1734181 - Part 3: Always display the current history entry in the menulist, regardless of interaction state. r=jjaschke,peterv,dom-core 
Differential Revision: https://phabricator.services.mozilla.com/D216827
 2024-08-24 19:43:31 +00:00
timw-dev
84076b9d83 Bug 1896764 - onViewToolbarsPopupShowing and ToolbarContextMenu should move out of browser.js.r=scunnane,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D217795
 2024-08-22 11:11:50 +00:00
Niklas Baumgardner
2d9dacd550 Bug 1893710 - Update default profile on window focus. r=jhirsch,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D217825
 2024-08-21 11:47:32 +00:00
Florian Quèze
fa2a31be59 Bug 1913624 - Remove expired telemetry histogram FX_TABLETMODE_PAGE_LOAD, r=TravisLong. 
Depends on D219484

Differential Revision: https://phabricator.services.mozilla.com/D219485
 2024-08-21 09:14:32 +00:00
Butkovits Atila
6d3e02fa30 Backed out 5 changesets (bug 1734181) for causing failures at test_ext_tabs_goBack_goForward.html. CLOSED TREE 
Backed out changeset eb37aa9ac513 (bug 1734181)
Backed out changeset a94eb78e58c2 (bug 1734181)
Backed out changeset aa72b0e38e8b (bug 1734181)
Backed out changeset f4b8c6babb7e (bug 1734181)
Backed out changeset 8ec6704b8022 (bug 1734181)
 2024-08-21 05:58:08 +03:00
Adam Vandolder
9192f0cab2 Bug 1734181 - Part 3: Always display the current history entry in the menulist, regardless of interaction state. r=jjaschke,peterv,dom-core 
Differential Revision: https://phabricator.services.mozilla.com/D216827
 2024-08-20 14:21:29 +00:00
Gijs Kruitbosch
bd8b1a3534 Bug 1909163 - make select dropdowns more properly tabspecific, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D219618
 2024-08-20 12:48:42 +00:00
Gijs Kruitbosch
628fafe237 Bug 1896783 - don't rely on the ReportBrokenSite object existing as a window property, r=twisniewski,pbz,webcompat-reviewers 
Unfortunately the addition in browser-siteProtections.js still makes this a
variable on the browser window, but refactoring the contents of that file to
be module-based is a separate effort.

Differential Revision: https://phabricator.services.mozilla.com/D210434
 2024-08-14 13:10:41 +00:00
Mark Banner
c2f47cc6bd Bug 1911729 - Move openContextMenu from the browser window to ContextMenuParent.sys.mjs. r=firefox-desktop-core-reviewers ,dao 
Differential Revision: https://phabricator.services.mozilla.com/D218617
 2024-08-06 14:25:30 +00:00
hanna alemu
698a6834b4 Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 15:09:21 +00:00
Tamas Szentpeteri
03b8b4ec2d Backed out changeset 8e5aa4b063cc (bug 1901261) for causing py3 failures on make-schemas.py. CLOSED TREE 2024-07-31 17:13:20 +03:00
hanna alemu
f04c2799bc Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 13:21:47 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane 
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
 2024-07-29 11:30:37 +00:00
spdev
56088e7d26 Bug 1882776 - gPopupBlockerObserver shouldn't live in browser.js. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D210964
 2024-07-22 21:45:33 +00:00
Dale Harvey
0c3d03e94d Bug 1905510 - Ensure SearchModeSwitcher popup opens in correct window. r=urlbar-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D215311
 2024-07-19 21:43:39 +00:00
Tooru Fujisawa
5903c49a48 Bug 1081542 - Part 1: Add nsIBrowserDOMWindow.OPEN_NEWTAB_FOREGROUND. r=smaug,geckoview-reviewers,Gijs,amejiamarmol,tabbrowser-reviewers,dao 
Given meta/ctrl key should use browser.tabs.loadInBackground pref instead of
browser.tabs.loadDivertedInBackground pref, the existing
nsIBrowserDOMWindow.OPEN_NEWTAB behavior doesn't match the requirement.

Add dedicate flag for "open in foreground tab" to make it controllable from
nsWindowWatcher::IsWindowOpenLocationModified.

Differential Revision: https://phabricator.services.mozilla.com/D201929
 2024-07-10 06:16:52 +00:00
James Teow
fa3b3d1fea Bug 1905100 - Remove Persisted Search Tip - r=adw,urlbar-reviewers 
The onboarding will be handled by OMC who will help with the
messaging for all the scotch bonnet features.

Differential Revision: https://phabricator.services.mozilla.com/D215234
 2024-07-01 23:45:47 +00:00
Niklas Baumgardner
df62137829 Bug 1895563 - Update nsContextMenu to a system module. r=Gijs,frontend-codestyle-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D209458
 2024-07-01 16:44:24 +00:00
Tom Schuster
b558a0cc09 Bug 1900381 - Remove (direct) mainPopupset onpopupshowing inline event handlers. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D213940
 2024-07-01 08:10:00 +00:00
Paul Zuehlcke
b57f55daae Bug 1905032 - Add telemetry for PBM new window race condition. r=Gijs,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D214968
 2024-06-30 12:49:37 +00:00
Dão Gottwald
f0cf92a1c5 Bug 1903996 - Make customizing and mousedown proper boolean attributes. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D214525
 2024-06-21 15:38:54 +00:00
Tom Schuster
728dc2abf5 Bug 1904029 - Correctly init View > Toolbars in the menubar. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D214543
 2024-06-21 15:11:46 +00:00
Max Christian Pohle
87f35f6c5c Bug 1899887 - Fix race condition in mailto test, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D213605
 2024-06-18 23:56:33 +00:00
Tom Schuster
7f5c4efe21 Bug 1900381 - Remove (direct) mainPopupset oncommand inline event handlers. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D213404
 2024-06-17 15:29:51 +00:00
Dale Harvey
3a3707ff44 Bug 1891863 - Implement initial prototype of dedicated search button. r=dao,fluent-reviewers,desktop-theme-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D209469
 2024-06-12 13:14:14 +00:00
Gregory Pappas
afef1fb448 Bug 1901164 - Don't set the cursor to auto if browser.spin_cursor_while_busy=false r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D212938
 2024-06-07 18:28:11 +00:00
Moritz Beier
0dcee9a58f Bug 1610530 - Use classes instead of ids to access urlbar elements from UrlbarInput. r=dao,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D212095
 2024-06-04 12:58:52 +00:00
Max Christian Pohle
06674fbbd1 Bug 1894024 - mailto: remind users to finish the configuration of a webmailer, r=Gijs,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209067
 2024-05-30 15:59:30 +00:00
Niklas Baumgardner
22597462bf Bug 1893693 - Create SelectableProfile and SelectableProfileService. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D210201
 2024-05-28 22:14:13 +00:00
Gregory Pappas
974de01de7 Bug 1858801 - Add ability to spin the cursor while the page is loading r=emilio,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D207953
 2024-05-22 18:51:54 +00:00
Dão Gottwald
04686bbe63 Bug 1837575 - Move Tabbed Browser related files to browser/components/tabbrowser/. r=mconley,desktop-theme-reviewers,zeid,tabbrowser-reviewers,frontend-codestyle-reviewers,Itiel 
This is a start, there are more modules and scripts we can/should move, as well as tests.

Differential Revision: https://phabricator.services.mozilla.com/D210676
 2024-05-17 13:25:23 +00:00
Mathew Hodson
3554ad4e18 Bug 1896249 - Use BrowserUtils.getRootEvent everywhere r=Gijs,places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D210121
 2024-05-15 09:23:19 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D208680
 2024-05-08 14:33:17 +00:00