corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
784,168 Commits 1 Branch 0 Tags
05c7ba7f5237a421234d9bf06bf443bc6a79dee1
Commit Graph

70 Commits

Author SHA1 Message Date
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-03 13:46:47 +00:00
Mike Conley
76072f1bb0 Bug 1830726 - Only show the scrollbar in the migration wizard browser profile selector when there is something to scroll to. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D176810
 2023-05-01 18:22:22 +00:00
Mike Conley
819a3c15f1 Bug 1829733 - Remove extraneous block margin around migration wizard checkboxes. r=niklas 
This also updates the iterator that was - unchecking and hiding all of
the resource checkboxes during the start of the routine that runs
when the browser / profile selector changes. This original iterator
was accidentally including the "Select All" checkbox from Variant 2,
and setting the "hidden" attribute on it. That attribute has no effect,
but it _does_ cause the label:not([hidden]) selector in the migration
wizard to not select it, which cause the label to not have the right
vertical alignment.

This patch updates the iterator to just select and hide the checkboxes
that have resources associated with them.

Differential Revision: https://phabricator.services.mozilla.com/D176342
 2023-04-26 20:27:13 +00:00
elephanteatsapple
9a04884ec9 Bug 1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D175447
 2023-04-21 13:18:42 +00:00
Mike Conley
efc612f60b Bug 1829196 - Use the term 'Continue' rather than 'Done' in the success state of the new migration wizard when embedding. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D176072
 2023-04-21 03:18:13 +00:00
Mike Conley
ca528a2ed9 Bug 1820640 - Enforce left-alignment and expose the button containers for the new Migration Wizard. r=kpatenio 
This is so that the contents of the Migration Wizard don't get automatically
centered if its embedding context is centering things.

This change also makes it so that embedders can customize some of the rules of how
buttons are laid out.

Differential Revision: https://phabricator.services.mozilla.com/D171771
 2023-04-21 03:18:12 +00:00
Mike Conley
a98705b9fd Bug 1828758 - Make Password file migrator only available if importing logins from CSV is enabled. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175804
 2023-04-18 22:36:26 +00:00
Mike Conley
73c69aafb8 Bug 1828463 - Make file migrator icon the same size as browser icons in the browser-profile-selector dropdown. r=niklas,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D175677
 2023-04-18 19:22:25 +00:00
Mike Conley
4922e2e5c2 Bug 1827204 - Set the right aria roles and attributes for the browser profile selector in the new migration wizard. r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175052
 2023-04-18 14:31:50 +00:00
Mike Conley
3b8c2d4517 Bug 1827274 - Allow users to use file importers after showing NO_BROWSERS_FOUND page in the new migration wizard. r=kpatenio,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D175069
 2023-04-14 17:37:57 +00:00
Mike Conley
8cf40900bd Bug 1828003 - Remove aria-live attribute from new Migration Wizard deck to reduce chattiness. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D175410
 2023-04-13 21:31:39 +00:00
Mike Conley
a6b4bb2db1 Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Depends on D174537

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 20:15:03 +00:00
Butkovits Atila
08ba617ed0 Backed out 2 changesets (bug 1821187) for causing failures at browser_file_migration.js. CLOSED TREE 
Backed out changeset 8402100dfc12 (bug 1821187)
Backed out changeset 2a7196e34b3d (bug 1821187)
 2023-04-13 05:28:27 +03:00
Mike Conley
cd18f710fc Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 01:28:38 +00:00
Mike Conley
a1a329e69b Bug 1827206 - Focus the Done button after migration completes in the new wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175050
 2023-04-11 20:53:23 +00:00
Mike Conley
02d9100424 Bug 1827205 - Make sure browser / profile selector is focused when showing the selection page in the new migration wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175049
 2023-04-11 20:53:22 +00:00
elephanteatsapple
9674321f7e Bug 1825070 - Make the Migration Wizard panel / panel-list closer to the width of the selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174801
 2023-04-05 21:42:35 +00:00
Mike Conley
3dcc43bd41 Bug 1824786 - Add event telemetry for the migration wizards. data-review=jhirsch, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D174184
 2023-04-03 20:47:13 +00:00
Mike Conley
d2ac8a1acd Bug 1821779 - Move migrationWizard.ftl out from locales-preview into the locales folder. r=flod,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D174482
 2023-04-03 17:25:18 +00:00
steven wang
f6145d6708 Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D173544
 2023-03-31 15:17:19 +00:00
Mike Conley
77137ac6ce Bug 1801981 - Use the word "favorites" instead of "bookmarks" when importing from IE / Edge. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173567
 2023-03-29 17:58:22 +00:00
elephanteatsapple
ad08437d43 Bug 1822312 - Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173537
 2023-03-29 03:43:37 +00:00
Mike Conley
4c8c666841 Bug 1825024 - Make sure that the Select All checkbox is checked if all visible resources are checked, and unchecked otherwise. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173851
 2023-03-28 19:26:26 +00:00
Mike Conley
8df981ea97 Bug 1825009 - Make sure that Select All only checks resources that are visible. r=kpatenio 
This also adds some belt-and-suspenders checks here so that even if the Migration Wizard
somehow gets confused and sends resource types that the migrator can't import from, they'll
just get ignored rather than having a forever-progress-spinner for that resource type.

Differential Revision: https://phabricator.services.mozilla.com/D173848
 2023-03-28 19:26:26 +00:00
Mike Conley
eccb282189 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 20:08:54 +00:00
Cosmin Sabou
4b7311ed63 Backed out changeset fe5dd9d4dcbb (bug 1822676) for causing macOS shippable bc failures on browser_safari_permissions.js. 2023-03-27 21:21:39 +03:00
Mike Conley
bd4fe113d7 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 16:51:12 +00:00
Iulian Moraru
16af5615b7 Backed out changeset 518a61189274 (bug 1822676) for causing doc-generate failures. CLOSED TREE 2023-03-27 19:12:29 +03:00
Mike Conley
5919c6fa99 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 14:48:39 +00:00
Alvin Lew
f8d7001c7d Bug 1818789 - Implement Safari / macOS permission wizard page for Passwords. r=mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173540
 2023-03-27 13:15:12 +00:00
Nolan Ishii
ed95067087 Bug 1822309 - Disable the 'Import' button in the selection page of the new Migration Wizard if no resource types are selected. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D172810
 2023-03-22 15:55:01 +00:00
Mike Conley
e802dcf6c3 Bug 1823495 - Bring the panel-list dropdown in the new Migration Wizard closer to the spec. r=kpatenio 
Some of this styling requires us to hack around with inline styles from JS since
the <panel-list>, <panel-item>'s and <xul:panel> are slotted. Bug 1823489 has been
filed to investigate not using slotted items to make it easier to style using the
migration-wizard.css stylesheet instead.

Differential Revision: https://phabricator.services.mozilla.com/D173064
 2023-03-21 19:41:39 +00:00
Mike Conley
9aaa821f97 Bug 1823438 - Have Migration Wizard panel-list assume the selector button width as minimum. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173059
 2023-03-21 19:41:39 +00:00
Mike Conley
c3739b9d73 Bug 1814278 - Align the spacing and layout of the new Migration Wizard more closely to the spec. r=kpatenio,fluent-reviewers,flod,settings-reviewers 
Along with bringing us closer to the layout and spacing from Figma, this does the following:

1. Changes the header element to an <h1> and uses CSS to get the expected font size. This should
   make the organization of the wizard make more sense to screenreaders.
2. Handles the "single resource" case for Variant 2, where we hide "Select All" and align the
   resource list to the left if there's only a single resource to import.
3. Fixes a string to match the spec.

Differential Revision: https://phabricator.services.mozilla.com/D173054
 2023-03-21 12:35:19 +00:00
Mike Conley
0d347f3bbf Bug 1822686 - Add a browser profile selector button to the new Migration Wizard more closely aligned with the specification. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D172832
 2023-03-20 16:42:26 +00:00
elephanteatsapple
2f039e6f10 Bug 1811933 -Replace placeholder <select> and <options> in MigrationWizard with a <button> and a <panel-list>. r=mconley,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D170420
 2023-03-20 14:56:41 +00:00
steven wang
410aed13c6 Bug 1819167 - Put a message above the resource checkboxes in Variant 1 of the MigrationWizard. r=mconley,fluent-reviewers,flod. 
Differential Revision: https://phabricator.services.mozilla.com/D172524
 2023-03-16 14:14:07 +00:00
Bryan Macoy
35eb847665 Bug 1803445 - Implement Safari / macOS permission wizard page for Bookmarks / History r=mconley,fluent-reviewers,flod. 
Differential Revision: https://phabricator.services.mozilla.com/D171602
 2023-03-16 13:51:33 +00:00
Nolan Ishii
f243dbd6d7 Bug 1820798 - Variant 2 selector page details section should default to closed. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D172583
 2023-03-15 19:16:13 +00:00
Mike Conley
479bf84a3b Bug 1822094 - Add a shared class for deemphasized text in the new Migration Wizard. r=kpatenio,desktop-theme-reviewers,dao 
Notably, this also updates the em ratio of the "base" font size and the deemphasized font-size.

In the Figma specification, the base font size is 13px, and the deemphasized font-size is 10px,
which is ~84% of 13px.

Differential Revision: https://phabricator.services.mozilla.com/D172443
 2023-03-13 21:04:59 +00:00
Nolan Ishii
2fe7189288 Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D170228
 2023-03-13 16:16:16 +00:00
Mike Conley
09574d63a6 Bug 1819343 - Allow MigrationWizard initialization to be kicked off either on binding to the DOM or with script. r=kpatenio,settings-reviewers,Gijs 
Up until now, we've used the connectedCallback to initialize the MigrationWizard. That's
been fine, except that it requires us to remove and then re-add the element to the DOM
if we want to "reset" it and start over.

This patch adds a method "requestState" to the MigrationWizard that kicks off the
initialization. Embedders can set the `auto-request-state` attribute on the
element if they're happy to just use the connectedCallback.

Finally, this adds an intrinsic width to the entire MigrationWizard element to reduce
flicker when transitioning between states.

Differential Revision: https://phabricator.services.mozilla.com/D171742
 2023-03-06 21:39:01 +00:00
Mike Conley
3e4aa35ac7 Bug 1819343 - Add a skeleton loading page for the new MigrationWizard component. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D171741
 2023-03-06 21:39:01 +00:00
brian
ed9f9dee81 Bug 1809347 Implement the page that appears if no other browsers to import cannot be found. r=mconley,fluent-reviewers,flod. 
Differential Revision: https://phabricator.services.mozilla.com/D168981
 2023-03-03 20:35:52 +00:00
Norisz Fay
5e05f73d55 Backed out changeset cfa8d4331629 (bug 1809347) for causing mochitest failures on test_migration_wizard.html CLOSED TREE 2023-03-03 22:10:10 +02:00