Commit Graph

64 Commits

Author SHA1 Message Date
Niklas Baumgardner
04d3f814c0 Bug 1882925 - Floor coordinates before drawing to canvas in screenshots. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D203769
2024-03-07 22:55:58 +00:00
Niklas Baumgardner
d918992b35 Bug 1873947 - Fix dragging screenshots tab to new window. r=sfoster,mconley
Differential Revision: https://phabricator.services.mozilla.com/D198470
2024-03-07 13:32:00 +00:00
Sam Foster
e10d714796 Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-03-04 21:13:17 +00:00
Sandor Molnar
7ec5066cee Backed out changeset 5b88e57227bc (bug 1789727) for causing bc failures @ browser_feature_callout_in_chrome.js & browser_asrouter_toolbarbadge CLOSED TREE 2024-03-01 20:33:14 +02:00
Sam Foster
27c17caceb Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-03-01 15:02:51 +00:00
Noemi Erli
6b84db45b8 Backed out changeset 9b4da905ce36 (bug 1789727) for causing failures in browser_asrouter_toolbarbadge.js CLOSED TREE 2024-02-29 22:43:51 +02:00
Sam Foster
998fa1d9fe Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-29 18:27:46 +00:00
Sandor Molnar
0941fe84f2 Backed out changeset c8f7d19d58bb (bug 1789727) for causing telemetry/marionette/tests/client/test_subsession_management.py CLOSED TREE 2024-02-28 18:42:48 +02:00
Sam Foster
0b69b3a243 Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-28 15:40:08 +00:00
Sam Foster
923aed9c7c Bug 1874154 - Anchor the 'Screenshot copied' notification on the hamburger menu button if the screenshot button isn't available. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D201143
2024-02-14 20:12:30 +00:00
Niklas Baumgardner
bb40d6b5a8 Bug 1791086 - Select elements within iframes in screenshots. r=sfoster,mconley
Differential Revision: https://phabricator.services.mozilla.com/D195165
2024-02-09 22:02:51 +00:00
Niklas Baumgardner
f37dadc23b Bug 1876779 - Fix issue with last screenshot method. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D199747
2024-01-30 20:05:53 +00:00
Niklas Baumgardner
a145338e1e Bug 1875034 - Round screenshots region before drawSnapshot. r=sfoster
Both the extension and the component were both passing in numbers like 286.6499938964844 but they were behind rounded differently or something?
It seems to me that the extension was flooring the numbers somewhere and the component wasn't flooring or rounding the numbers anywhere.
The two images would start off being the same but then would progressively become more different. See image diff below
{F5955989}

If we round the region before drawing the snapshot the resulting images will match.
Sometimes there is some offset difference (only 1 px difference) because the component now `round`s and I think the extensions `floor`s. `286.6499938964844` would be `286` for the extension and `287` for the component.

Differential Revision: https://phabricator.services.mozilla.com/D199059
2024-01-25 15:27:08 +00:00
Niklas Baumgardner
9b5daf0abd Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Natalia Csoregi
eb2e3cf8cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
729c5b4066 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 00:07:46 +00:00
Iulian Moraru
e1d66150c9 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Niklas Baumgardner
6dd5c4f60b Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-18 17:47:54 +00:00
Niklas Baumgardner
59c6f758c4 Bug 1874014 - Check that screenshots anchor is connected to document. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D198199
2024-01-11 18:51:57 +00:00
Sam Foster
e1e878dc76 Bug 1820015 - Make the screenshots UI keyboard accessible. r=niklas
* Move the chrome panel buttons into a `box` which is inserted into #navigator-toolbox
* Adjust what open/closed means using hidden instead
* Capture a weak ref to the focused element on open, and attempt to put focus back on exit
* Add some restore-focus tests
* Fix a bug where cancel via overlay "X" button wasn't exiting properly
* Place initial focus in the preview dialog button on the download button

Differential Revision: https://phabricator.services.mozilla.com/D181184
2023-12-18 19:01:44 +00:00
Niklas Baumgardner
59a1e1e591 Bug 1842037 - Update screenshots telemetry. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D191679
2023-11-14 15:57:46 +00:00
Norisz Fay
1b95461566 Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
80c28a9bea Bug 1842037 - Update screenshots telemetry. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D191679
2023-11-13 23:57:17 +00:00
Niklas Baumgardner
5764e40cb8 Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189158
2023-10-12 16:15:41 +00:00
Cristina Horotan
29fed10407 Backed out changeset 919bb91f27bb (bug 1854953) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-10-11 00:38:25 +03:00
Niklas Baumgardner
6f5f28c5bf Bug 1854953 - Improve performance when taking large screenshots. r=sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189158
2023-10-10 16:39:02 +00:00
Sam Foster
52016ee064 Bug 1812202 - Reduce the max capture dimension by 1px. r=niklas
* Captures at exactly the max dimension (32767) result in a fully transparent image.
* Import these dimensions to use in tests so we have a single source of truth
* Update the same constant in the extension

Differential Revision: https://phabricator.services.mozilla.com/D190221
2023-10-06 22:37:16 +00:00
Sam Foster
c20c018e69 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
2023-09-19 00:14:27 +00:00
Niklas Baumgardner
8464bcdbb9 Bug 1844171 - Refactor screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-27 16:15:02 +00:00
Sebastian Hengst
945cff3a90 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
2023-07-26 21:24:18 +02:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Niklas Baumgardner
51b2d1bafb Bug 1844171 - Refactor screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-26 15:37:45 +00:00
Niklas Baumgardner
655e4f5c79 Bug 1832667 - Add ConfirmationHint when screenshot is copied. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D178674
2023-05-25 14:27:24 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Niklas Baumgardner
af7af69abe Bug 1814917 - Crop screenshots from overlay when they are too big. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D174896
2023-04-11 13:16:22 +00:00
Niklas Baumgardner
8d87e40736 Bug 1801019 - Add telemetry for screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-25 17:26:34 +00:00
Sam Foster
aaece76dd7 Bug 1799211 - Place focus on the first panel button when opening screenshots UI. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D168497
2023-02-24 02:35:25 +00:00
Marian-Vasile Laza
ac8ed92c6a Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
4a2f7b7309 Bug 1801019 - Add telemetry for screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-23 17:37:01 +00:00
Butkovits Atila
0cf8d92417 Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
3b1f991f19 Bug 1801019 - Add telemetry for screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-21 19:59:09 +00:00
Niklas Baumgardner
a36a35df45 Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D160565
2023-01-24 23:51:33 +00:00
Butkovits Atila
98c250d934 Backed out changeset 39f3534179a7 (bug 1743887) for causing failures at browser_screenshots_test_screenshot_too_big.js. 2023-01-18 03:30:07 +02:00
Niklas Baumgardner
6991fe86f4 Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D160565
2023-01-17 19:03:33 +00:00
Niklas Baumgardner
a0bed53d66 Bug 1806590 - Downloading screenshot now shows panel in private windows. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D166341
2023-01-10 22:00:17 +00:00
Niklas Baumgardner
ad90b95338 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D158678
2022-12-06 00:06:20 +00:00
Stanca Serban
7d855ec985 Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-12-02 16:39:01 +02:00
Niklas Baumgardner
47288cb256 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D158678
2022-12-02 13:45:57 +00:00