Commit Graph

332 Commits

Author SHA1 Message Date
Daniel Holbert
a3efd84588 Bug 941916 followup: Drop another unused param "aFlexContainerFrame" from SingleLineCrossAxisPositionTracker constructor. r=trivial (essentially the same as previous patch) 2013-11-23 11:07:33 -08:00
Daniel Holbert
44ac502b2b Bug 941916: Drop unused constructor param "aItems" from SingleLineCrossAxisPositionTracker constructor. r=mats 2013-11-21 22:50:47 -08:00
Daniel Holbert
2ed2d620a1 Bug 811024 part 4: Don't ask for bottom border/padding space on a flex container if it's going to get a continuation. r=mats 2013-11-21 10:20:02 -08:00
Daniel Holbert
623bdff49b Bug 811024 part 3: Split horizontal flex containers whose cross size (height) is larger than available height (and refactor cross-size computation). r=mats 2013-11-21 10:20:01 -08:00
Daniel Holbert
508bbd02b3 Bug 811024 part 2: Split vertical flex containers whose main size (height) is larger than available height. r=mats 2013-11-21 10:20:01 -08:00
Daniel Holbert
52b518f7ad (no bug) Remove some obsolete/incorrect comments from nsFlexContainerFrame.cpp. comment-only, DONTBUILD 2013-11-15 20:41:48 -08:00
Daniel Holbert
aa25acef99 (no bug) Fix a few whitespace issues in nsFlexContainerFrame.*
DONTBUILD because whitespace-only
2013-11-12 18:50:39 -08:00
Daniel Holbert
90007e2b2c Bug 903880 part 4: Resolve stretched cross-size early, if we know the container's cross size, and use the result when establishing main size. r=dbaron 2013-10-31 19:39:02 -07:00
Daniel Holbert
32936e8c68 Bug 903880 part 3: Convert "ResolveStretchedSize" into a member-function on FlexItem. r=dbaron 2013-10-31 19:39:02 -07:00
Daniel Holbert
f3c99c7367 Bug 903880 part 2: Resolve the flex base size produced by "height:auto" *after* we create a FlexItem object. r=dbaron 2013-10-31 19:39:02 -07:00
Daniel Holbert
22de9a47a2 Bug 903880 part 1: Create a helper-function to set a flex item's base size (and update its hypothetical main size). r=dbaron 2013-10-31 19:39:02 -07:00
Daniel Holbert
d208ba54f3 Bug 922410: Consolidate loops in MainAxisPositionTracker constructor. r=mats 2013-09-30 20:30:24 -07:00
Daniel Holbert
deb3532c78 Bug 921522: Use already-established flex container content-box main size to determine packing space, instead of checking reflow state. r=mats 2013-09-30 16:38:36 -07:00
Ehsan Akhgari
6cf84bf2d9 Bug 921876 - Stop #including nsIFrame.h in nsLayoutUtils.h; r=roc
This patch does the following:
* Move nsIFrame::IntrinsicSize to mozilla::IntrinsicSize so that it can
  be forward-declared.
* Move a number of templated inline nsLayoutUtils methods to nsIFrame.
* Use mozilla::layout::FrameChildListID instead of the
  nsIFrame::ChildListID typedef in nsLayoutUtils.h.
* Move nsReflowFrameRunnable to its only user, nsProgressMeterFrame.cpp.
* Make a number of functions requiring nsIFrame.h out-of-line.
* Remove the nsIFrame.h #include from nsLayoutUtils.h and add it to the
  places which require it implicitly.
2013-09-30 17:26:04 -04:00
Daniel Holbert
ffde065409 Bug 918519 part 2: Replace GetMainComponent/GetCrossComponent invocations with macros to avoid unnecessarily constructing nsSize() on-the-fly. r=mats 2013-09-20 13:26:52 -07:00
Daniel Holbert
ecd2b0fcf1 Bug 918519 part 1: Add macros GET_MAIN_COMPONENT and GET_FLEX_COMPONENT to nsFlexContainerFrame.cpp, and use them to implement existing utility methods. r=mats 2013-09-20 13:26:52 -07:00
Daniel Holbert
1a3d659c97 Bug 917032 part 3: Move flex item physicalPosn computation up a bit higher. r=mats 2013-09-17 14:54:07 -07:00
Daniel Holbert
5ed56b8778 Bug 917032 part 2: Make PhysicalPositionFromLogicalPosition() take the content-box size, so it can do polarity-flipping if necessary. r=mats 2013-09-17 14:54:02 -07:00
Daniel Holbert
cd787cda63 Bug 917032 part 1: Do flex layout in content-box space, rather than in frame-rect (border-box) space, and adjust for border/padding at the end of reflow. r=mats 2013-09-17 14:53:56 -07:00
Daniel Holbert
e85e587fb4 Bug 914937: Remove nsFlexContainerFrame::GetSkipSides, now that we can inherit a useful impl from nsSplittableFrame. r=mats 2013-09-11 13:54:44 -07:00
Scott Johnson
6175e00428 Bug 794693, part 1: Refactor nsHTMLReflowState constructor to allow initialization to be done by caller. [r=dbaron] 2013-09-09 15:29:05 -05:00
Ehsan Akhgari
06d49ffd4d Bug 907883 - Minimize #includes in layout/generic; r=roc 2013-08-22 14:32:52 -04:00
Daniel Holbert
4f08ba30cf (no bug, whitespace only) Remove unnecessary newline in nsFlexContainerFrame.cpp. DONTBUILD 2013-08-16 18:00:13 -07:00
Corey Ford
6a0ae7831b Bug 898794 - Store normal frame position before applying relative positioning. r=dbaron 2013-08-08 17:20:17 -07:00
Scott Johnson
4006c68438 Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc] 2013-07-25 10:34:27 -05:00
Ryan VanderMeulen
12fbc93e27 Backed out 6 changesets (bug 743402) for reftest failures on a CLOSED TREE.
Backed out changeset 19848fff857e (bug 743402)
Backed out changeset 049168537ae0 (bug 743402)
Backed out changeset 3098fea37f2d (bug 743402)
Backed out changeset ada93e976dca (bug 743402)
Backed out changeset c7907c54187f (bug 743402)
Backed out changeset 2edbbf6440c4 (bug 743402)
2013-07-24 15:14:04 -04:00
Scott Johnson
1c74186f48 Bug 743402, Part 4: Refactor ApplySkipSides() and GetSkipSides() to return the correct value during reflow by adding an optional nsHTMLReflowState parameter. [r=roc] 2013-07-24 12:47:17 -05:00
Corey Ford
1113bd3173 Bug 893962 - Refactor the application of relative positioning. r=dbaron 2013-07-15 17:28:09 -07:00
Daniel Holbert
45ff7c682c Bug 885424 part 4: Refactor ComputeFlexContainerMainSize to have a clearer horizontal case vs. vertical case. r=dbaron 2013-07-11 16:47:03 -07:00
Daniel Holbert
8fe3619909 Bug 885424 part 3: Rename flexContainerMainSize to contentBoxMainSize, for clarity, and mark that & 'frameMainSize' as const. r=dbaron 2013-07-09 14:38:59 -07:00
Daniel Holbert
53cc5bac00 Bug 885424 part 2: Perform flexbox main-axis alignment separately from cross-size determination, to more closely match the ordering of steps in flexbox spec. r=dbaron 2013-07-09 14:38:59 -07:00
Daniel Holbert
01c79df260 Bug 885424 part 1: Set aStatus at the very beginning of flexbox reflow, and call NS_FRAME_SET_TRUNCATION at the very end. r=dbaron 2013-07-09 14:38:59 -07:00
Daniel Holbert
4ee4f4c2a6 Bug 885424 part 0: Shift declarion of 'frameCrossSize' down to where it's actually used. r=dbaron 2013-07-09 14:38:59 -07:00
Justin Lebar
8cc88f21ce Bug 820686 - Remove code after MOZ_CRASH or MOZ_ASSUME_NOT_REACHED. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=waldo for js
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
2013-06-28 18:38:32 -07:00
Justin Lebar
de89040a2c Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else

This is a mechanical change made with sed.  Later patches in this queue
clean up the whitespace errors and so on.
2013-06-28 18:38:30 -07:00
Daniel Holbert
24d88eaa57 (no bug) Improve/correct some comments in nsFlexContainerFrame::Reflow. comment-only, DONTBUILD 2013-06-20 12:05:35 -07:00
Daniel Holbert
39c831c671 Bug 877890: In CSS flexbox and XUL box model, sort placeholders using their out-of-flow frame's order/ordinal value. r=bz 2013-05-31 22:14:03 -07:00
Daniel Holbert
6e4f676e52 Bug 876074: Soften flexbox assertion about out-of-order children, since it's not dangerous and it can be triggered by unrelated-to-flexbox tree mutations. r=bz 2013-05-28 09:39:02 -07:00
Daniel Holbert
6cd9a76182 Bug 825810 part 2: When digging for a flex item's first non-anonymous descendant, check table caption list & column-group list. r=bz 2013-05-22 11:59:36 +08:00
Daniel Holbert
672afee4c6 Bug 825810 part 1: Make GetFirstNonAnonBoxDescendant() okay with receiving & returning null frame pointers. r=bz 2013-05-22 11:59:35 +08:00
Daniel Holbert
783fb79af6 Bug 873172: When checking whether a flex item is generated content, skip past any anonymous boxes around it. r=bz 2013-05-19 11:37:56 +08:00
Daniel Holbert
c9073df319 (no bug, comment-only) s/:before/::before/ in one comment, for consistency with rest of the comment. DONTBUILD 2013-05-16 15:02:16 -07:00
Daniel Holbert
663cbd631b Bug 870555 part 2: Add nsFlexContainerFrame::GetSkipSides specialization. r=mats 2013-05-09 20:10:49 -07:00
Daniel Holbert
658c3b637b Bug 867454: Treat a flex container's ::before and ::after generated content nodes as flex items. r=bz 2013-05-02 14:04:47 -07:00
Daniel Holbert
9a52173441 Bug 858332: Make flex items pseudo-stacking contexts, per recent spec change. r=mats 2013-04-18 09:51:18 -07:00
Joshua Cranmer
697498ab75 Bug 856108 - Port static analyses to clang, part 2e: use MOZ_STACK_CLASS in layout. r=mats 2013-04-11 22:20:45 -05:00
Daniel Holbert
f830f8c991 Bug 785468: Compute flex container's baseline as-described in the spec. r=dbaron 2013-03-29 18:32:08 -07:00
Daniel Holbert
46fb411141 Bug 853946: Replace flex container's cached content-box cross-size and cached ascent with local variables in Reflow(). rs=Waldo 2013-03-29 18:32:03 -07:00
Daniel Holbert
3f1c120f49 Bug 854263: Add special-case for flex items that are instances of nsFrame, whose trivial reflow impl doesn't request enough space for its border/padding. r=dbaron 2013-03-28 01:50:21 -07:00
Daniel Holbert
3263b0600e Bug 848539 part 3: Back out part of 076d87bf30d0, bug 666041 part 7 (flexbox frame class impl -- just removing the code that deals with min-height:auto). r=dbaron 2013-03-27 23:33:19 -07:00