This is a medium sized patch to legacy download construction. It takes
advantage of the new property added in Bug 1762033 to prevent the
downloads panel from being automatically shown when a download is added
after an interaction with the unknown content type dialog or the file
picker dialog. I chose to not do the same for failed transfers since I
thought it might serve some use, but that might be wrong. I don't know
if there's a way to test the dialog that appears when you download an
executable without going through the same path I adjusted with the
patch. It seems like it's covered but I could be wrong. Also add a test
to cover these changes from the bottom up. Thanks and apologies for my
sloppy C++, though I'm sure I'll learn a lot more from the review 😅
Differential Revision: https://phabricator.services.mozilla.com/D145312
This patch includes the workaround mentioned in Bug 1748808 comment 25 as a short term workaround to prevent the test from
failure due to the position where a previous test may have moved the mouse to.
The short term test-only workaround would become unnecessary once we have landed a proper longer term fix
from Bug 1780008, and so:
- if this patch landes before Bug 1780008, as part of Bug 1780008 we should also remove this short term workaround
- if Bug 1780008 got already signed and pushed to autoland before this one, then this patch can be just dropped
and the related bug marked as fixed by Bug 1780008.
Differential Revision: https://phabricator.services.mozilla.com/D152090
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.
Differential Revision: https://phabricator.services.mozilla.com/D150878
The suggested solution for this bug is to disable browser.fixup.alternate.enabled
unless toggled by the user, and to add telemetry to the preference so that if we
find users rarely use the option, we can safely remove the feature in a future release.
Many tests rely on expecting URI's to be modified, so I modified them so that they
should not expect the prefix or suffix to be modified.
Differential Revision: https://phabricator.services.mozilla.com/D147795
Please see the bug for details. We recently improved the handling of "www" and
prefixes for adaptive history autofill and made it more like origin autofill,
and this revision makes it even more like origin autofill. Origin autofill
computes a `host_fixed` value that is the matching host except it doesn't
contain "www" if the user didn't type it. This revision does something similar
for adaptive history autofill by computing `url_fixed`. This also allows
`_processRow()` to be a little simpler for the adaptive history case and it's
almost exactly the same as the origin case now.
I changed the `:searchString` param so that it's `this._searchString` instead of
`queryContext.searchString`. That's consistent with the two other autofill
queries and it made fixing this bug easier.
I also added some comments that should be helpful.
Differential Revision: https://phabricator.services.mozilla.com/D151897
Add an "Open in New Container Tab" menu to the Synced Tabs sidebar
context menu, to match similar menus elsewhere in tab menus.
Differential Revision: https://phabricator.services.mozilla.com/D151777
The test disables the pref so that it can test the feature's interaction with
Nimbus, but didn't re-enable the pref, so tests after it would break.
Differential Revision: https://phabricator.services.mozilla.com/D151566
* Add some additional steps and assertions in the test that would catch the case where synced tabs are already showing and we sync again
Differential Revision: https://phabricator.services.mozilla.com/D151678
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.
Differential Revision: https://phabricator.services.mozilla.com/D150878
