Commit Graph

283 Commits

Author SHA1 Message Date
Florian Quèze
02b789706d Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-19 13:31:17 +00:00
Cristian Tuns
09099c11ef Backed out 2 changesets (bug 1745511) for causing mochitest failures on GeckoChildProcessHost.cpp CLOSED TREE
Backed out changeset 620e4b9d8b61 (bug 1745511)
Backed out changeset 0fadea77038a (bug 1745511)
2022-01-19 07:24:42 -05:00
Florian Quèze
c1505dc115 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-18 22:24:10 +00:00
Jan-Erik Rediger
4bbff140fb Bug 1750544 - Upgrade to Glean v43.0.2. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D136138
2022-01-17 16:26:33 +00:00
Alexandru Michis
6b0888bb3b Backed out changeset 19b1136a92ec (bug 1745511) for causing mochitest failures in GMPServiceParent.cpp
CLOSED TREE
2022-01-13 18:49:34 +02:00
Florian Quèze
8fb191e021 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-13 13:44:22 +00:00
Jan-Erik Rediger
ccb8ab9de0 Bug 1746254 - Use simple default hash state to avoid random seeding r=chutten,padenot
This replaces the default-used `RandomState`[1] on the hashmaps used in
FOG's IPC with a simple wrapper around `DefaultHasher`.

`RandomState` uses `DefaultHasher` internally, which at the moment of
this commit, uses `SipHasher13` internally.
Our `HashState` does the same, but with default keys of `(0, 0)`
(whereas `RandomState` uses some random keys).

This will result in the same hashes used for the same values in
different hashmaps.
But this should be fine for the use here:
The key for all those hash maps is a `MetricId`, which is a simple `u32`.
It's already a unique identifier generated from defined metrics and not
user-manipulated.
Therefore we shouldn't need to worry about HashDos-resistance.

[1]: https://doc.rust-lang.org/std/collections/hash_map/struct.RandomState.html

Differential Revision: https://phabricator.services.mozilla.com/D135208
2022-01-12 10:10:30 +00:00
Nika Layzell
f01bb10add Bug 1748718 - Part 3: Remove now-unnecessary xpidl constant casts, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D135166
2022-01-07 20:35:15 +00:00
Nika Layzell
921726892b Bug 1748718 - Part 2: Use the specified type for rust xpidl constants, r=emilio
Previously all xpidl constants were specified as `i64` which means they require
casts before being passed to any xpcom methods. The lack of typing was not an
issue in c++ due to implicit casts from enums to integer types, but using the
correct type is much more valuable in Rust.

Differential Revision: https://phabricator.services.mozilla.com/D135165
2022-01-07 20:35:15 +00:00
Florian Quèze
52ec666a9b Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 22:18:32 +00:00
Narcis Beleuzu
a8e91af26f Backed out 4 changesets (bug 1745444) for GTest failures on IHistory.Test . CLOSED TREE
Backed out changeset b3a2dc754e16 (bug 1745444)
Backed out changeset 7b9d52dff930 (bug 1745444)
Backed out changeset 15d9a79cc305 (bug 1745444)
Backed out changeset 497572ee54af (bug 1745444)
2021-12-15 20:50:24 +02:00
Florian Quèze
6471c9335c Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 16:27:56 +00:00
Chris H-C
7a5557d320 Bug 1745660 - Flush FOG IPC every 100k samples r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D133664
2021-12-13 20:18:57 +00:00
Jan-Erik Rediger
2d1dbd7fb9 Bug 1744674 - Update to Glean v42.3.0 & glean_parser v4.3.1 r=chutten
Also updates the docs on how to update the glean_parser in-tree.
Also adds a `no_lint` exception to test pings to avoid breaking the
build.

Differential Revision: https://phabricator.services.mozilla.com/D133077
2021-12-13 11:24:50 +00:00
Narcis Beleuzu
d5f770f02c Backed out changeset 7ca282be411f (bug 1744674) for python failures on test_site_compatibility.py. CLOSED TREE 2021-12-11 01:08:45 +02:00
Florian Queze
3d358fc2aa Bug 1744162 - Expand FOG IPC to RDD process, to collect CPU and GPU time used there, r=chutten,jrmuizel.
Differential Revision: https://phabricator.services.mozilla.com/D132749
2021-12-10 12:20:10 +00:00
Jan-Erik Rediger
f7e7766bdb Bug 1744674 - Update to Glean v42.3.0 & glean_parser v4.3.1 r=chutten
Also updates the docs on how to update the glean_parser in-tree.
Also adds a `no_lint` exception to test pings to avoid breaking the
build.

Differential Revision: https://phabricator.services.mozilla.com/D133077
2021-12-09 09:30:20 +00:00
Chris H-C
1f48010242 Bug 1729026 - Add support for GPU-process Glean metrics via FOG r=Dexter,nical
Differential Revision: https://phabricator.services.mozilla.com/D124840
2021-12-01 14:35:08 +00:00
Jan-Erik Rediger
067634f6a6 Bug 1736239 - Handle time going backwards gracefully. r=chutten
Time's hard and it will inevitably go backwards at some point.
We should not panic, instead handle it gracefully.
For now we just don't record that value. In the future we should
properly record an error in Glean.

Differential Revision: https://phabricator.services.mozilla.com/D129495
2021-10-26 14:52:32 +00:00
Chris H-C
c09e695bae Bug 1735628 - Expose Glean Experiment Annotation Test APIs in FOG r=TravisLong
Depends on D128928

Differential Revision: https://phabricator.services.mozilla.com/D128929
2021-10-19 20:32:39 +00:00
Chris H-C
4c5b88c601 Bug 1735628 - Update Glean to v42.1.0 r=TravisLong
Depends on D128927

Differential Revision: https://phabricator.services.mozilla.com/D128928
2021-10-19 20:32:38 +00:00
Jan-Erik Rediger
ac10e466e7 Bug 1733757 - Update to Glean v42.0.1. r=Dexter
This includes a bugfix preventing a crash on Fenix,
a bugfix preventing a panic when trying to flush ping-lifetime data after shutdown,
as well as an API change to make `glean::persist_ping_lifetime_data` async.

Differential Revision: https://phabricator.services.mozilla.com/D128053
2021-10-11 10:35:04 +00:00
Chris H-C
c386e9b00a Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 21:09:07 +00:00
Iulian Moraru
caf4295618 Backed out changeset 1890b6a3b3d2 (bug 1731667) for causing frequent address sanitizer failures. 2021-09-28 19:13:19 +03:00
Chris H-C
7b138891b3 Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

While we're here, ensure we persist ping lifetime data _after_ flushing IPC
on idle to ensure we don't miss anything.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 13:01:16 +00:00
Chris H-C
ed3a754c6b Bug 1729723 - Upgrade Glean to v41.1.0 r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D125834
2021-09-20 13:49:31 +00:00
Chris H-C
5b9dc8f52b Bug 1729723 - Update Glean to 41.0.0 r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D125456
2021-09-20 13:49:30 +00:00
Cristian Tuns
3e9ec4016b Backed out 5 changesets (bug 1729723) for causing reftest failures with block_on_dispatcher(). CLOSED TREE
Backed out changeset 1cd9afe6d8fd (bug 1729723)
Backed out changeset 90faab13d8ca (bug 1729723)
Backed out changeset c977b9868082 (bug 1729723)
Backed out changeset 74b132e68ed0 (bug 1729723)
Backed out changeset 994d51619f15 (bug 1729723)
2021-09-17 11:44:48 -04:00
Chris H-C
0ff477f60c Bug 1729723 - Upgrade Glean to v41.1.0 r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D125834
2021-09-17 14:01:21 +00:00
Chris H-C
940ab3a071 Bug 1729723 - Update Glean to 41.0.0 r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D125456
2021-09-17 14:01:21 +00:00
Narcis Beleuzu
b4e993da9d Backed out 4 changesets (bug 1729723) for mochitest crashes on LateWriteChecks.cpp . CLOSED TREE
Backed out changeset 728ead24c5e8 (bug 1729723)
Backed out changeset 466be2d40e28 (bug 1729723)
Backed out changeset 7b67981c7531 (bug 1729723)
Backed out changeset 378b0f332427 (bug 1729723)
2021-09-16 22:23:31 +03:00
Chris H-C
589ae315ea Bug 1729723 - Upgrade Glean to v41.1.0 r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D125834
2021-09-16 18:03:52 +00:00
Chris H-C
f43e502ba7 Bug 1729723 - Update Glean to 41.0.0 r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D125456
2021-09-16 18:03:51 +00:00
Sandor Molnar
0e695add00 Backed out 4 changesets (bug 1729723) for causing build bustages. CLOSED TREE
Backed out changeset d99b451638d8 (bug 1729723)
Backed out changeset 151dcec458a3 (bug 1729723)
Backed out changeset 444336616b77 (bug 1729723)
Backed out changeset 0522676f94c3 (bug 1729723)
2021-09-16 18:48:13 +03:00
Chris H-C
c526f34447 Bug 1729723 - Upgrade Glean to v41.1.0 r=janerik
Depends on D125456

Differential Revision: https://phabricator.services.mozilla.com/D125834
2021-09-16 14:34:52 +00:00
Chris H-C
6dffdd5e39 Bug 1729723 - Update Glean to 41.0.0 r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D125456
2021-09-16 14:34:51 +00:00
Sandor Molnar
46193db2bf Backed out 2 changesets (bug 1729723) for causing linux debug bustage. CLOSED TREE
Backed out changeset e52c90cdf117 (bug 1729723)
Backed out changeset b166c01d2010 (bug 1729723)
2021-09-13 23:46:51 +03:00
Chris H-C
30a4f0acc0 Bug 1729723 - Update Glean to 41.0.0 r=TravisLong
Depends on D124930

Differential Revision: https://phabricator.services.mozilla.com/D125456
2021-09-13 19:39:51 +00:00
Jan-Erik Rediger
22e7cd1a6e Bug 1727515 - Update to Glean v40.1.0 r=Dexter
Differential Revision: https://phabricator.services.mozilla.com/D123625
2021-09-01 11:17:04 +00:00
Csoregi Natalia
6154b404ce Backed out changeset 645e92e661ee (bug 1727515) for causing toolchains bustage. CLOSED TREE 2021-08-26 15:43:29 +03:00
Jan-Erik Rediger
0e46dca8ca Bug 1727515 - Update to Glean v40.1.0 r=Dexter
Differential Revision: https://phabricator.services.mozilla.com/D123625
2021-08-26 08:45:06 +00:00
Jan-Erik Rediger
871fecf8bf Bug 1670261 - Upgrade Glean, include glean-ffi and re-export its symbols. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D121084
2021-08-10 07:49:07 +00:00
Butkovits Atila
fd5e3b00a1 Backed out 6 changesets (bug 1670261) for causing perma android bustage. CLOSED TREE
Backed out changeset 58ab9d5d45b7 (bug 1670261)
Backed out changeset e68f58dd9c24 (bug 1670261)
Backed out changeset af093190c4f7 (bug 1670261)
Backed out changeset 150c73837e22 (bug 1670261)
Backed out changeset c42784eeccee (bug 1670261)
Backed out changeset 45ab05c0c371 (bug 1670261)
2021-08-03 15:11:22 +03:00
Jan-Erik Rediger
deafab95af Bug 1670261 - Upgrade Glean, include glean-ffi and re-export its symbols. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D121084
2021-08-02 16:22:45 +00:00
Chris H-C
6d1495c711 Bug 1694496 MLA FFI for rate metric type r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119786
2021-07-15 16:05:51 +00:00
Chris H-C
04ce2d7257 Bug 1694496 - Add 'rate' metric type to FOG (Rust) r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119785
2021-07-15 16:05:51 +00:00
Butkovits Atila
6f88f89160 Backed out 5 changesets (bug 1694496) for causing build bustages on GleanJSMetricsLookup.h. CLOSED TREE
Backed out changeset 86dc6a0fd554 (bug 1694496)
Backed out changeset 9ccad5fe13e7 (bug 1694496)
Backed out changeset 887eaee3ab5c (bug 1694496)
Backed out changeset 36421c124795 (bug 1694496)
Backed out changeset 9591dcd4369d (bug 1694496)
2021-07-14 19:46:38 +03:00
Chris H-C
e02af569d9 Bug 1694496 MLA FFI for rate metric type r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119786
2021-07-14 16:13:48 +00:00
Chris H-C
c6c1a463f4 Bug 1694496 - Add 'rate' metric type to FOG (Rust) r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119785
2021-07-14 16:13:48 +00:00
Chris H-C
e12172b8ea Bug 1683171 - JS/C++ FOG test APIs will now fail if there are errors r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D117923
2021-06-22 18:34:33 +00:00