Commit Graph

98 Commits

Author SHA1 Message Date
Neil Deakin
01890ce9a8 Bug 1608584, shouldn't pass true to browserLoaded to wait for the subframe to load, also fixes 1608497, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D60439
2020-01-22 14:56:36 +00:00
Neil Deakin
42613e3d69 Bug 1601301, modify browser_devices_get_user_media_in_frame.js to iterate twice, once performing the operation on two same-process frames, and a second time with frames that in fission mode would be in different processes, r=johannh
The observer listening is also modified to listen to notifications from all frames.

Differential Revision: https://phabricator.services.mozilla.com/D56571
2020-01-10 15:35:03 +00:00
Neil Deakin
05b7c143a8 Bug 1601301, rework webrtc permission granting UI around JSWindowActor, performing the work of determining the ultimate state for the tab icon and menu in the parent rather than the content process, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D56570
2020-01-10 15:09:59 +00:00
Neil Deakin
234871d70e Bug 1601301, add an 'include descendants' flag to mediaCaptureWindowState. With fission, need to handle each subframe separately, r=jib
The window will be supplied in the recording-device-events notification and mediaCaptureWindowState will be called on each window in turn.

Differential Revision: https://phabricator.services.mozilla.com/D56569
2020-01-10 15:29:08 +00:00
Kris Maglione
99c0b418ed Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-13 20:36:36 +00:00
Kris Maglione
7b2657b231 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-13 20:36:24 +00:00
Kris Maglione
8c0d38f33d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-13 20:36:16 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
shindli
0aa47af90e Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione
af77c00e7a Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-10 23:07:22 +00:00
Kris Maglione
eb68f8b548 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-10 23:07:21 +00:00
Kris Maglione
ad3537fc50 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-10 23:07:13 +00:00
Noemi Erli
21eec8658f Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
b442dbf855 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-07 18:44:34 +00:00
Kris Maglione
6fb2c35351 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-07 18:44:34 +00:00
Kris Maglione
88fbf261f8 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-07 19:11:58 +00:00
Daniel Varga
85f263a4c2 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
3850c6a060 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-06 22:15:25 +00:00
Kris Maglione
487c4fe9c7 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-06 22:14:22 +00:00
Kris Maglione
e59706f08a Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-06 22:14:14 +00:00
Thomas Nguyen
d6bcbfc5d6 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417
2019-12-04 15:39:14 +00:00
Gurzau Raul
8fcb9066e6 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE.
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
2019-12-03 21:57:55 +02:00
Thomas Nguyen
b176e3a1a6 Bug 1483631 - Restrict nested permission requests in webrtc with permission delegate r=jib
Differential Revision: https://phabricator.services.mozilla.com/D47417
2019-12-03 16:25:31 +00:00
Neil Deakin
4e1fe9a035 Bug 1589664, adapt the webrtc tests to work with fission enabled. Remove the webrtc framescript in favour of calling BrowserTestUtils methods or SpecialPowers.spawn instead, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D49736
2019-10-29 00:32:04 +00:00
Johann Hofmann
6d7ae86d5d Bug 1580319 - Clear PopupNotifications UI state when no checkbox is present. r=prathiksha
In getUserMedia we didn't use to have prompts without a checkbox, thus this bug couldn't manifest.
Now we do hide the checkbox for iframes, so this code path is triggered and doesn't properly
reset the UI state between prompts.

Differential Revision: https://phabricator.services.mozilla.com/D45911
2019-09-16 09:44:07 +00:00
Paul Zuehlcke
368d5d5647 Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029
2019-08-15 14:32:48 +00:00
Ciure Andrei
087fb2a215 Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
2019-08-14 13:07:55 +03:00
Paul Zuehlcke
0b3621645a Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029
2019-08-14 08:31:23 +00:00
Paul Zuehlcke
064380bb16 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428
2019-07-30 08:28:31 +00:00
Csoregi Natalia
16534798cd Backed out changeset 3855d35999dd (bug 630614) for causing failures on browser_ext_tabs_sharingState.js. CLOSED TREE 2019-07-29 14:32:05 +03:00
Paul Zuehlcke
2ba3aac2e1 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428
2019-07-29 08:37:55 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Carolina Jimenez Gomez
49ff21e576 Bug 1530183 - Change promiseWaitForCondition for TestUtils.waitForCondition r=johannh
however, in the file head.js other functions use BrowserTestUtils instead of TestUtils, so I wasn't sure which of those is the
correct one, so I used the one suggested in the issue.

Differential Revision: https://phabricator.services.mozilla.com/D21011
2019-02-25 14:46:22 +00:00
Brian Grinstead
c8a487965d Bug 1487065 - Implement popup-notification as a Custom Element r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D17699
2019-02-07 22:16:26 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Mark Banner
4d21b8103b Bug 1521707 - Move promisePopupEvent to BrowserTestUtils.jsm. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17259
2019-01-23 14:04:46 +00:00
Andreas Pehrson
73bcbc1d5c Bug 1421724 - Steal back focus from global webrtc indicator when doing second gUM requests. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D15711
2019-01-04 14:43:46 +00:00
Brian Grinstead
e7d558ba62 Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs
This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting
the webidl calls to these methods and dumping JS stack when they are called in browser.xul.

Differential Revision: https://phabricator.services.mozilla.com/D5185
2018-09-07 15:31:38 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Boris Zbarsky
0d70093660 Bug 1476142 part 2. Remove some unnecessary QIs in browser. r=gijs 2018-08-02 15:26:47 -04:00
Dan Minor
620ef0b8ac Bug 1450658 - Add preference to disable focusing source; r=pehrsons
Focusing a source during a test run can cause Firefox to lose focus and
subsequent tests to timeout. This adds a preference which defaults to true
that allows the source to be focused. It is then set to false for tests that
involve screen sharing.

MozReview-Commit-ID: CNq2c87y8Ho
2018-05-29 16:14:38 -04:00
Johann Hofmann
9ff3826f2f Bug 1456899 - Consider the page URI when checking WebRTC permissions in webrtcUI.jsm. r=nhnt11
While we already do a permission check in native webrtc code, the one
in webrtcUI is needed to provide extra protection against permission spam
by checking if there's a temporarily denied permission on the tab.

Since we introduced custom default permission values it is necessary to
also pass the URI to make sure we catch exceptions added by the user.

MozReview-Commit-ID: C8r6ymbKE3a
2018-05-08 15:31:49 +02:00
Bryce Van Dyk
efba5c5948 Bug 1436523 - Make sure webrtc chrome mochitests don't use loopback devices. r=achronop
Before this changeset, mochitests in browser/base/content/test/webrtc will pick
up loopback devices due to the changes made earlier in this patch chain to
device enumeration. This results in test bustages (for unknown reasons).

This changeset updates the setup JS for these tests to make sure loopback
devices prefs are unset. A comment has been added noting that if the tests
can be made to work with loopback devices that would be ideal.

MozReview-Commit-ID: KG0io8s5r86
2018-03-15 10:41:36 -04:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Johann Hofmann
4efad2b1a0 Bug 1442294 - Downgrade global streaming indicator when a higher priority device has been disabled. r=florian
MozReview-Commit-ID: 6GxXNsB6xYy
2018-03-08 14:08:21 +01:00
Johann Hofmann
f3095a274b Bug 1333468 - Part 2 - Add tests for paused/disabled sharing state indicators. r=florian
MozReview-Commit-ID: G1CTAefOPNB
2018-02-13 10:09:07 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00