- Hooked the RustSharedRemoteSettingsService code to the Region module.
The new system updates the app context as the home region changes.
- Updated `RemoteSettingsService.updateConfig` to be sync rather than
async wrapped. It should execute quickly and I want to have
confidence that the config is actually updated when that function
returns.
- Updated/Simplified the SuggestBackendRust.sys.mjs testing code. Now
we just need to track if we should disable the Rust backend for the
tests or not.
- Updated `QuickSuggest._test_reinit` to wait for any unfinished
ingestion from `SuggestBackendRust`. This is needed now because
changing the remote settings service affects all active clients. If
there are unfinished ingestion tasks, then this creates a race
between those task finishing and the test finishing and uninitializing
the remote settings mock server.
Differential Revision: https://phabricator.services.mozilla.com/D248467
The browser_quicksuggest_ping_deletionRequest.js test now runs two separate set of tasks,
depending on whether or not context ID rotation is enabled.
The rotation set of tasks can be tested by calling ./mach test with `--setpref browser.contextual-services.contextId.rust-component.enabled=true --setpref browser.contextual-services.contextId.rotation-in-days=1`
Differential Revision: https://phabricator.services.mozilla.com/D248975
Rather than introducing a new pref, keep using the existing one. The
idea is that semantic history search will be part of the normal history
search functionality, so it doesn't need a separate pref.
Also add some checks to avoid unnecessary work in unrelated search modes.
Differential Revision: https://phabricator.services.mozilla.com/D248925
Rather than introducing a new pref, keep using the existing one. The
idea is that semantic history search will be part of the normal history
search functionality, so it doesn't need a separate pref.
Also add some checks to avoid unnecessary work in unrelated search modes.
Differential Revision: https://phabricator.services.mozilla.com/D248925
- Hooked the RustSharedRemoteSettingsService code to the Region module.
The new system updates the app context as the home region changes.
- Updated `RemoteSettingsService.updateConfig` to be sync rather than
async wrapped. It should execute quickly and I want to have
confidence that the config is actually updated when that function
returns.
- Updated/Simplified the SuggestBackendRust.sys.mjs testing code. Now
we just need to track if we should disable the Rust backend for the
tests or not.
- Updated `QuickSuggest._test_reinit` to wait for any unfinished
ingestion from `SuggestBackendRust`. This is needed now because
changing the remote settings service affects all active clients. If
there are unfinished ingestion tasks, then this creates a race
between those task finishing and the test finishing and uninitializing
the remote settings mock server.
Differential Revision: https://phabricator.services.mozilla.com/D248467
In bug 1933744 we prevented SessionStore from reopening a saved tab group into a private window. In bug 1946761 we prevented users from saving tab groups from a private window. The general design principle has been to prevent tab group information leaking between private and non-private windows.
ActionsProviderTabGroups already respected privacy through the implementation of `Tabbrowser.getAllTabGroups`, but `SessionStore.getSavedTabGroups` doesn't respect privacy. Perhaps it should. But in any case, this patch ensures that search results in private windows don't include saved tab groups.
Differential Revision: https://phabricator.services.mozilla.com/D248351
As part of this bug, the global ExperimentManager will no longer be
exported from ExperimentManager.sys.mjs and will only be available as a
property on the ExperimentAPI.
Differential Revision: https://phabricator.services.mozilla.com/D248317
Defines and/or updates JSDoc types on all ActionsResult properties.
The pre-existing property `ActionsResult.providerName` never gets set. `Query.add` sets a `providerName` on UrlbarResult objects, so to follow that pattern, I made `ProviderGlobalActions.startQuery` responsible for setting `providerName` on already constructed `ActionsResult` instances. Having the provider name available for actions results will make it easier for tests to find relevant actions results within search results.
Differential Revision: https://phabricator.services.mozilla.com/D248373
