Commit Graph

184 Commits

Author SHA1 Message Date
Ciure Andrei
ea1e3cbe28 Backed out 10 changesets (bug 1614462) for causing xpcshell failures CLOSED TREE
Backed out changeset 34d4a86530b4 (bug 1614462)
Backed out changeset dbc2e2556d08 (bug 1614462)
Backed out changeset 512bbab4730c (bug 1614462)
Backed out changeset cd6b8d630f4c (bug 1614462)
Backed out changeset e4ad5037658f (bug 1614462)
Backed out changeset 0ffed1dc4296 (bug 1614462)
Backed out changeset 90ed81cbfe34 (bug 1614462)
Backed out changeset 6d2137eb1d52 (bug 1614462)
Backed out changeset b4819c99e16e (bug 1614462)
Backed out changeset b7deaed376ed (bug 1614462)
2020-04-17 02:26:14 +03:00
Kris Maglione
14ee8f4119 Bug 1614462: Part 3b - Remove moribund DocShell FrameType/IsMozBrowser/IsInMozBrowser fields. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D70749
2020-04-16 17:25:06 +00:00
Christoph Kerschbaumer
a923c367b1 Bug 1621987: Implement Sec-Fetch-User. r=baku,edgar,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69392
2020-04-16 08:04:26 +00:00
Tooru Fujisawa
78b7a8908c Bug 1624150 - Collect telemetry for outerWidth/outerHeight features of window.open in web content. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67765
2020-04-14 06:00:26 +00:00
Tooru Fujisawa
748fd470d3 Bug 1432749 - Part 2: Introduce WindowFeature class with spec-compliant tokenization, and use it both in nsGlobalWindowOuter and nsWindowWatcher. r=smaug
WindowFeature provides the tokenization and access to the map.
This changes the following behavior:
  * "*" value is removed, given it's unused.
    * Default width and default height handling is removed,
      given there's no callsites
  * Some chrome-priv feature handling becomes stricter:
    * All substring match is removed and directly checks the item in the map

Also, fixed noopener=0 and noreferrer=0 options to be handled properly.

Differential Revision: https://phabricator.services.mozilla.com/D67725
2020-04-14 06:27:47 +00:00
Narcis Beleuzu
8f3be16cf1 Backed out 3 changesets (bug 1624150, bug 1432749) for wpt failures at open-features-tokenization-top-left.html. CLOSED TREE
Backed out changeset ff061c8d9da9 (bug 1624150)
Backed out changeset 7e96d4acf317 (bug 1432749)
Backed out changeset a95f77732a1c (bug 1432749)
2020-04-13 22:51:48 +03:00
Tooru Fujisawa
0fcb8d5eb4 Bug 1624150 - Collect telemetry for outerWidth/outerHeight features of window.open in web content. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67765
2020-04-13 15:42:26 +00:00
Tooru Fujisawa
e84e39b64e Bug 1432749 - Part 2: Introduce WindowFeature class with spec-compliant tokenization, and use it both in nsGlobalWindowOuter and nsWindowWatcher. r=smaug
WindowFeature provides the tokenization and access to the map.
This changes the following behavior:
  * "*" value is removed, given it's unused.
    * Default width and default height handling is removed,
      given there's no callsites
  * Some chrome-priv feature handling becomes stricter:
    * All substring match is removed and directly checks the item in the map

Also, fixed noopener=0 and noreferrer=0 options to be handled properly.

Differential Revision: https://phabricator.services.mozilla.com/D67725
2020-04-13 15:42:19 +00:00
Kris Maglione
40be55160b Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69421
2020-04-08 19:04:47 +00:00
Kris Maglione
f0e8681c10 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69417
2020-04-04 02:42:30 +00:00
Kris Maglione
61f180fc68 Bug 1626404: Follow-up: Fix missing source BC in some window.open calls.
Differential Revision: https://phabricator.services.mozilla.com/D70253
2020-04-08 21:10:10 +00:00
Bogdan Tara
0e4f143a63 Backed out changeset 5349e5225018 (bug 1626404) frequent timeouts on test_postMessage_onOther.html CLOSED TREE 2020-04-09 11:35:45 +03:00
Bogdan Tara
9f2284c826 Backed out 6 changesets (bug 1626404) for frequent timeouts on test_postMessage_onOther.html CLOSED TREE
Backed out changeset 453b858f4462 (bug 1626404)
Backed out changeset f54ce6a36c75 (bug 1626404)
Backed out changeset ec63b18da4b9 (bug 1626404)
Backed out changeset b0d4b213b819 (bug 1626404)
Backed out changeset af763de00e9d (bug 1626404)
Backed out changeset 45b68d43bdbb (bug 1626404)
2020-04-09 11:07:40 +03:00
Kris Maglione
496dd4cf93 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69421
2020-04-08 19:04:47 +00:00
Kris Maglione
35503e3f6f Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D69417
2020-04-04 02:42:30 +00:00
Kris Maglione
02aab86542 Bug 1626404: Follow-up: Fix missing source BC in some window.open calls.
Differential Revision: https://phabricator.services.mozilla.com/D70253
2020-04-08 21:10:10 +00:00
Oana Pop Rus
2e479d6d2e Backed out 6 changesets (bug 1626404) for mochitest failures in BrowsingContext.cpp on a CLOSED TREE
Backed out changeset 4a3b391e08c4 (bug 1626404)
Backed out changeset 1a5a559ec6d5 (bug 1626404)
Backed out changeset 2ffdab0072e7 (bug 1626404)
Backed out changeset 6fb384961b99 (bug 1626404)
Backed out changeset c0c2e85e33da (bug 1626404)
Backed out changeset bf32b30efa49 (bug 1626404)
2020-04-09 00:22:49 +03:00
Kris Maglione
1465a5be2f Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421
2020-04-08 19:04:47 +00:00
Kris Maglione
90013ea51d Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417
2020-04-04 02:42:30 +00:00
Nika Layzell
13956309e2 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058
2020-04-07 21:39:47 +00:00
Nika Layzell
825152748c Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag
This patch builds on top of part 7.1 by creating this object within
nsWindowWatcher and ContentParent to carry the relevant information through
provider interfaces when creating new content windows. The nsOpenWindowInfo
object is not created for new chrome windows.

This patch does not propagate these flags all of the way through to the
nsFrameLoader. That change is performed in later parts to keep each part
smaller.

Differential Revision: https://phabricator.services.mozilla.com/D67051
2020-04-07 21:39:32 +00:00
Nika Layzell
45e39dffc7 Bug 1616353 - Part 6.5: Assert nsILoadContext attributes are correctly set when opening windows, r=smaug
This is necessary as, by this point, the BrowsingContext has already been
attached, and can no longer have its nsILoadContext flags updated.

Differential Revision: https://phabricator.services.mozilla.com/D67049
2020-04-07 21:39:22 +00:00
Nika Layzell
954f423cb9 Bug 1616353 - Part 6.3: Replace many nsILoadContext mutators with assertions, r=smaug
Many of these setters are redundant, and duplicate work done elsewhere. As it is
no longer correct to set nsILoadContext attributes at these times, they're being
replaced with assertions.

Differential Revision: https://phabricator.services.mozilla.com/D67047
2020-04-07 21:39:16 +00:00
Nika Layzell
59af925389 Bug 1616353 - Part 5: Always set the opener for chrome windows late, r=kmag
This is OK, as all chrome BrowsingContext instances are always in the same
BrowsingContextGroup, so we don't need to have the initial opener avaliable when
creating the BrowsingContext to determine its BrowsingContextGroup.

This is used in part 7.2 to avoid propagating the opener window around when
creating chrome windows.

Differential Revision: https://phabricator.services.mozilla.com/D67044
2020-04-07 21:39:09 +00:00
Nika Layzell
f521b4a02c Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag
This could cause issues, as we could incorrectly override the decision made by
nsWindowWatcher, and then override the decision again after the method returns.
This could cause the initial content browser to be configured incorrectly.

Differential Revision: https://phabricator.services.mozilla.com/D67043
2020-04-07 21:39:07 +00:00
Andreas Farre
9509fc894a Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.

DocGroups have also been moved to BrowsingContextGroup.

Depends on D67636

Differential Revision: https://phabricator.services.mozilla.com/D65936
2020-04-07 15:17:47 +00:00
Cosmin Sabou
357a0887a1 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell
e235a0fdee Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058
2020-04-06 14:30:22 +00:00
Nika Layzell
17fdb0cd39 Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag
This patch builds on top of part 7.1 by creating this object within
nsWindowWatcher and ContentParent to carry the relevant information through
provider interfaces when creating new content windows. The nsOpenWindowInfo
object is not created for new chrome windows.

This patch does not propagate these flags all of the way through to the
nsFrameLoader. That change is performed in later parts to keep each part
smaller.

Differential Revision: https://phabricator.services.mozilla.com/D67051
2020-04-06 14:30:02 +00:00
Nika Layzell
c5e37a220e Bug 1616353 - Part 6.5: Assert nsILoadContext attributes are correctly set when opening windows, r=smaug
This is necessary as, by this point, the BrowsingContext has already been
attached, and can no longer have its nsILoadContext flags updated.

Differential Revision: https://phabricator.services.mozilla.com/D67049
2020-04-06 14:29:57 +00:00
Nika Layzell
a262f4881c Bug 1616353 - Part 6.3: Replace many nsILoadContext mutators with assertions, r=smaug
Many of these setters are redundant, and duplicate work done elsewhere. As it is
no longer correct to set nsILoadContext attributes at these times, they're being
replaced with assertions.

Differential Revision: https://phabricator.services.mozilla.com/D67047
2020-04-06 14:29:52 +00:00
Nika Layzell
c4799a218b Bug 1616353 - Part 5: Always set the opener for chrome windows late, r=kmag
This is OK, as all chrome BrowsingContext instances are always in the same
BrowsingContextGroup, so we don't need to have the initial opener avaliable when
creating the BrowsingContext to determine its BrowsingContextGroup.

This is used in part 7.2 to avoid propagating the opener window around when
creating chrome windows.

Differential Revision: https://phabricator.services.mozilla.com/D67044
2020-04-06 14:29:45 +00:00
Nika Layzell
f95485b324 Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag
This could cause issues, as we could incorrectly override the decision made by
nsWindowWatcher, and then override the decision again after the method returns.
This could cause the initial content browser to be configured incorrectly.

Differential Revision: https://phabricator.services.mozilla.com/D67043
2020-04-06 14:29:43 +00:00
Narcis Beleuzu
0668c5ab4c Backed out 6 changesets (bug 1626404) for assertion failures on BrowsingContext.cpp . CLOSED TREE
Backed out changeset aed006ab4c20 (bug 1626404)
Backed out changeset ad87dcb98637 (bug 1626404)
Backed out changeset c065bd4594b4 (bug 1626404)
Backed out changeset a248fc78ab0c (bug 1626404)
Backed out changeset 52892d053ff1 (bug 1626404)
Backed out changeset 440b9193338a (bug 1626404)
2020-04-04 05:29:30 +03:00
Kris Maglione
98bd7e4124 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421
2020-04-04 00:36:30 +00:00
Kris Maglione
99164ee547 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417
2020-04-04 00:13:04 +00:00
Narcis Beleuzu
518dd9a134 Backed out 6 changesets (bug 1626404) for bustages on LocationBase.cpp . CLOSED TREE
Backed out changeset a399dfff2725 (bug 1626404)
Backed out changeset ad3272abd830 (bug 1626404)
Backed out changeset 322c170e8301 (bug 1626404)
Backed out changeset df37f57cfa1d (bug 1626404)
Backed out changeset e255e4c9e665 (bug 1626404)
Backed out changeset 51120d617459 (bug 1626404)
2020-04-04 02:42:18 +03:00
Kris Maglione
6d933b2e13 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421
2020-04-03 22:42:25 +00:00
Kris Maglione
a5d565da2f Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417
2020-04-03 22:41:26 +00:00
Tooru Fujisawa
5d9a6a7b95 Bug 1507375 - Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug
Make the features parameter of window.open just a condition for whether to open
a popup or a new tab.
Also remove dom.disable_window_open_feature.* prefs.

Differential Revision: https://phabricator.services.mozilla.com/D65926
2020-03-19 09:13:12 +00:00
Noemi Erli
8a3c00f099 Backed out changeset 6fe5ce050c0d (bug 1507375) for failures in test_transformed_scrolling_repaints_3.html CLOSED TREE 2020-03-19 08:56:17 +02:00
Tooru Fujisawa
85724a833d Bug 1507375 - Restrict the controllability of UI parts visibility with features parameter of window.open. r=smaug
Make the features parameter of window.open just a condition for whether to open
a popup or a new tab.
Also remove dom.disable_window_open_feature.* prefs.

Differential Revision: https://phabricator.services.mozilla.com/D65926
2020-03-19 03:50:25 +00:00
Simon Giesecke
99b166167f Bug 1613985 - Use default for equivalent-to-default constructors/destructors in toolkit. r=mossop
Depends on D66008

Differential Revision: https://phabricator.services.mozilla.com/D66010
2020-03-10 08:48:24 +00:00
Simon Van Accoleyen
0e6e13f54d Bug 1619619 - DeCOMtaminate accesses to nsFocusManager r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D65884
2020-03-09 09:51:46 +00:00
shindli
93011711a1 Backed out changeset 3da713367dfd (bug 1589299) for causing mochitest permafailures in layout/base/tests/test_transformed_scrolling_repaints_3.html CLOSED TREE 2020-03-03 20:43:03 +02:00
Alphan Chen
8e9fe5b4c1 Bug 1589299 - Force scrollbars flag to be always enabled for new windows. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D64126
2020-03-03 16:07:09 +00:00
Henri Sivonen
27d35d1cb6 Bug 1618133 - Remove nsWindowWatcher::SetActiveWindow as dead code. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D64330
2020-02-27 18:24:07 +00:00
Coroiu Cristina
93eb9720ea Backed out changeset 4dfd98d37804 (bug 1589299) for Wr failures at css/css-writing-modes/wm-propagation-svg-root-scrollbar.svg on a CLOSED TREE 2020-02-26 18:12:29 +02:00
Alphan Chen
f401ce2145 Bug 1589299 - Force scrollbars flag to be always enabled for new windows. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D64126
2020-02-26 14:15:57 +00:00
pbz
a7ba1df9c0 Bug 1432856 - Added console logging for DOM fullscreen leave on window raise. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D55813
2020-01-16 14:39:02 +00:00