Commit Graph

203 Commits

Author SHA1 Message Date
Gijs Kruitbosch
0045b2ec32 Bug 1625500 - fix use of .then(x, x) in the tree, r=marionette-reviewers,Standard8,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D68614
2020-04-17 11:41:49 +00:00
Julian Descottes
4040da2ea8 Bug 1625209 - Remove keyboard shortcuts when destroying the DevTools MarkupView r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D68410
2020-03-27 13:07:27 +00:00
Jason Laster
3694ec93d0 Bug 1622996 - Refactor devtools codebase to use optional chaining (automated changes). r=jdescottes
Depends on D67084

Differential Revision: https://phabricator.services.mozilla.com/D67537
2020-03-19 21:13:38 +00:00
Daisuke Akatsuka
f822c319ca Bug 1589178: Use TargetList api for markup view. r=jdescottes,rcaliman
Depends on D54872

Differential Revision: https://phabricator.services.mozilla.com/D55616
2019-12-05 09:19:52 +00:00
Emilio Cobos Álvarez
b2d8637998 Bug 1600084 - Allow to edit a ShadowRoot's html, by modifying its inner, not outerHTML. r=jdescottes
Turns out this was pretty easy to support, and I think it is useful.

Differential Revision: https://phabricator.services.mozilla.com/D55131
2019-11-28 23:08:51 +00:00
Emilio Cobos Álvarez
03da5f20b4 Bug 1598944 - Don't enable the "Delete" context menu for fragments. r=jdescottes
Right now it's enable but it throws with "remove() is not a function".

Depends on D55096

Differential Revision: https://phabricator.services.mozilla.com/D55097
2019-11-28 13:54:03 +00:00
Alexandre Poirot
2bda961085 Bug 1578242 - Make the inspector use the TargetList. r=gl,pbro
Differential Revision: https://phabricator.services.mozilla.com/D48859
2019-11-18 15:06:02 +00:00
Gabriel Luong
ec45dbc365 Bug 1588728 - Add a check for this._highlightedNodeFront in _hideBoxModel. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D49632
2019-10-18 18:43:49 +00:00
Gabriel Luong
4fe452af37 Bug 1568126 - Part 3: Use the contextual WalkerFront in the markup view event handlers. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D49346
2019-10-16 18:19:02 +00:00
Gabriel Luong
c8293b7f02 Bug 1586804 - Use the contextual WalkerFront in the markup hide shortcut handler. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D48445
2019-10-08 07:07:29 +00:00
David Walsh
beae03d5f1 Bug 1550030 - Show breakpoint icon in inspector for DOM Mutation Breakpoints r=gl
Differential Revision: https://phabricator.services.mozilla.com/D45036
2019-09-18 21:32:42 +00:00
yulia
91cca5dadb Bug 1579052 - use relative nodeFront walker in markup view; r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D44822
2019-09-09 15:23:55 +00:00
Gabriel Luong
20052248e9 Bug 1568157 - Part 3: Replace toolbox.highlighter with the contextual HighlighterFront. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D40316
2019-08-27 19:13:45 +00:00
Patrick Brosset
48b55ed972 Bug 1568825 - 2 - Moving the nodePicker singleton to the toolbox r=gl
Differential Revision: https://phabricator.services.mozilla.com/D41597
2019-08-16 04:48:27 +00:00
yulia
1eb63569c7 Bug 1560200 - Implement very basic markup view support traversing remote frames via resource api. r=ochameau,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D39525
2019-08-13 11:54:06 +00:00
Logan Smyth
ea893bf80a Bug 1550031 - Part 4: Manage DOM Mutation breakpoints in the toolbox. r=jlast,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D39898
2019-08-09 01:28:21 +00:00
Arun Kumar Mohan
150d88ce4b Bug 1554875 - Refactor _onShortcut method to remove disabled complexity eslint rule. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D39602
2019-07-31 12:52:39 +00:00
Alexandre Poirot
c33d8f6e29 Bug 1567860 - Make the markup view destroy codepath synchronous. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D39300
2019-07-25 11:54:11 +00:00
Gabriel Luong
12587ec458 Bug 1567276 - Refactor inspector to inspectorFront. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D38554
2019-07-18 15:33:55 -04:00
Victor Porof
b7732ae890 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884
2019-07-05 11:24:38 +02:00
Gabriel Luong
904f583885 Bug 1550030 - Part 1: Implement the DOM mutation breakpoint context menu items in the markup view. r=loganfsmyth,jdescottes
This implements the context menu items for the DOM mutation breakpoint.
In addition, there were some server changes to:
- Update the mutationBreakpoints form for the NodeActor
- Expose the mutationBreakpoints form
- Moved the setMutationBreakpoints method from the Node spec to Walker spec
since the Node spec only consisted of getter methods. It made more sense
that the setter went into the Walker spec to be more consistent with how
the Walker and Node spec have been arranged.

Unit tests will be followed up in Part 2 immediately.

Differential Revision: https://phabricator.services.mozilla.com/D36074
2019-06-26 15:16:22 -04:00
Patrick Brosset
d93842478f Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 09:06:16 +00:00
Mihai Alexandru Michis
c358baf0c3 Backed out changeset 0f9626b48a66 (bug 1553451) for linting failures. CLOSED TREE 2019-05-23 10:58:22 +03:00
Patrick Brosset
18bd75fb8c Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 07:07:49 +00:00
Brian Hackett
698f58f226 Bug 1497393 Part 8 - Client side changes for inspector support while replaying, r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D22864
2019-03-09 16:46:16 -10:00
Ian Moody
d2303e15be Bug 1539265 - Handle ::marker pseudos during drag & drop of nodes in the markup view. r=jdescottes
Prior to this the tab would crash with signature [@ nsINode::InsertChildBefore ]
if trying to insert before the ::marker.

Differential Revision: https://phabricator.services.mozilla.com/D25106
2019-04-02 07:45:45 +00:00
arthur.iakab
215148fa05 Backed out 11 changesets (bug 1539265) for causing debugger failures CLOSED TREE
Backed out changeset 8206b880f9ec (bug 1539265)
Backed out changeset be9f5f73bdfe (bug 1539265)
Backed out changeset f78146b8aa17 (bug 1539265)
Backed out changeset 18fa7e971a0d (bug 1539265)
Backed out changeset 6eaf5bdd945c (bug 1539265)
Backed out changeset 3add7d4d4853 (bug 1539265)
Backed out changeset 8015aeb5279d (bug 1539265)
Backed out changeset 19c8e404ac5f (bug 1539265)
Backed out changeset 637a9d6af0f3 (bug 1539265)
Backed out changeset 72bbb4b28932 (bug 1539265)
Backed out changeset 931e98129878 (bug 1539265)
2019-04-02 02:44:43 +03:00
Ian Moody
7374533d2a Bug 1539265 - Handle ::marker pseudos during drag & drop of nodes in the markup view. r=jdescottes
Prior to this the tab would crash with signature [@ nsINode::InsertChildBefore ]
if trying to insert before the ::marker.

Differential Revision: https://phabricator.services.mozilla.com/D25106
2019-04-01 21:45:46 +00:00
Patrick Brosset
c662005f08 Bug 1363990 - New pref to beautify HTML code when copying from the inspector; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D21030
2019-02-26 09:33:52 +00:00
Gabriel Luong
4df0394110 Bug 1529845 - Add a destroy for the MarkupContextMenu. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D20783
2019-02-22 00:38:30 -05:00
Gabriel Luong
1c21f54278 Bug 1529364 - Move the markup context menu into a separate module. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D20554
2019-02-20 15:03:38 -05:00
Patrick Brosset
ee3f1a9335 Bug 1528181 - Enable the scrollable badge for good; r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D19909
2019-02-15 16:22:55 +00:00
Patrick Brosset
e91c7dfa97 Bug 1521776 - Add new scrollable markup badges; r=gl
Detect when nodes are scrollable on the actor side, and use this
information to display new [scrollable] markup-badges in the inspector.
Also track this dynimically so badges are added/removed when necessary.
Hide this behind a pref for now, until this gets tested by users and
validated.

Differential Revision: https://phabricator.services.mozilla.com/D17246
2019-01-23 14:07:47 +00:00
yulia
7b207363de Bug 1508656 - migrate picker-node-hovered to nodePicker; r=ochameau
Depends on D12290

Differential Revision: https://phabricator.services.mozilla.com/D12738
2018-12-18 08:42:10 +00:00
yulia
c9ef6e934f Bug 1508656 - migrate cancel picker to nodePicker; r=ochameau
Depends on D12126

Differential Revision: https://phabricator.services.mozilla.com/D12290
2018-12-18 08:45:16 +00:00
Ciure Andrei
3e1f01f806 Backed out 14 changesets (bug 1508660, bug 1508656, bug 1504185) for browser_target_cached-front.js perma failures CLOSED TREE
Backed out changeset 08e5ae4312b3 (bug 1508660)
Backed out changeset 01b687bb0b75 (bug 1504185)
Backed out changeset 140374b098aa (bug 1504185)
Backed out changeset caafdc0ea4c7 (bug 1508656)
Backed out changeset 8b98b777aec2 (bug 1508656)
Backed out changeset f1905a2f9b6c (bug 1508656)
Backed out changeset 8b01632f9e3d (bug 1508656)
Backed out changeset eb4c893d451e (bug 1508656)
Backed out changeset 70db61618160 (bug 1508656)
Backed out changeset dff79b73c7fe (bug 1508660)
Backed out changeset b3518d5285be (bug 1508660)
Backed out changeset 94a957b9ba90 (bug 1508660)
Backed out changeset 773938f18269 (bug 1508660)
Backed out changeset 4eca8fce0a47 (bug 1508660)
2018-12-17 17:15:23 +02:00
yulia
33f610f4fa Bug 1508656 - migrate picker-node-hovered to nodePicker; r=ochameau
Depends on D12290

Differential Revision: https://phabricator.services.mozilla.com/D12738
2018-12-17 12:18:45 +00:00
yulia
c278487f3d Bug 1508656 - migrate cancel picker to nodePicker; r=ochameau
Depends on D12126

Differential Revision: https://phabricator.services.mozilla.com/D12290
2018-12-17 12:51:35 +00:00
yulia
595fd05e97 Bug 1508655 - BoxModel highlighter move nodeHighlighter to highlighterFront; r=ochameau
Depends on D12319

Differential Revision: https://phabricator.services.mozilla.com/D12320
2018-11-23 10:50:21 +00:00
Julian Descottes
deb498a8cc Bug 1500936 - Run eslint --fix on devtools/client/inspector for comma-dangle;r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D9409
2018-10-23 07:08:24 +00:00
Gabriel Luong
ac7c7854b3 Bug 1497905 - Avoid destroying the markup iframe on navigation. r=pbro 2018-10-14 22:26:05 -04:00
Gabriel Luong
7cc495e326 Bug 1494162 - Part 57: Set the node front before the components are initialized to unblock it from waiting until the markup is loaded before initializing. r=pbro
Currently, we block the markup and all other sidebar panels from rendering their
content until the markup iframe is loaded. So, we prevent this by setting the
default node front at the beginning.

We also move all the remaining event handlers to prevent unnecessary events
since this is the first time the inspector is being constructed. In particular,
we move the "new-node-front" event handler and manually call the actions that
are performed in onNewSelection to prevent these updates from taking place
until all the components are initialized.
2018-10-05 12:44:39 -04:00
Gabriel Luong
fbc0617e65 Bug 1494162 - Part 10: Lazy initialize the event details and image tooltip in the markup view. r=pbro 2018-09-28 12:45:16 -04:00
Noemi Erli
3ebb8480ac Backed out 16 changesets (bug 1494162, bug 1464192) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset 0d5a593adfda (bug 1494162)
Backed out changeset ea5d67d3c2ae (bug 1494162)
Backed out changeset 98c531e6f8d4 (bug 1494162)
Backed out changeset 973fbb5bbadc (bug 1464192)
Backed out changeset bbbf97a5802e (bug 1494162)
Backed out changeset c1dac4bffc06 (bug 1494162)
Backed out changeset c90d929f87f2 (bug 1494162)
Backed out changeset f90da1a0201b (bug 1494162)
Backed out changeset ee129a8c5e00 (bug 1494162)
Backed out changeset 10143ae649e5 (bug 1494162)
Backed out changeset f700e44ea63f (bug 1494162)
Backed out changeset cb2b02dc4b47 (bug 1494162)
Backed out changeset 4880d9571aa7 (bug 1494162)
Backed out changeset b9e187182a0f (bug 1494162)
Backed out changeset f077ffe76ca5 (bug 1494162)
Backed out changeset ef609de4cd5c (bug 1494162)
2018-09-28 21:57:12 +03:00
Gabriel Luong
bdc34d8307 Bug 1494162 - Part 10: Lazy initialize the event details and image tooltip in the markup view. r=pbro 2018-09-28 12:45:16 -04:00
Gabriel Luong
a972c318ea Bug 1494162 - Part 3: Lazy load the SlottedNodeContainer in the markup view. r=pbro
The assumption is that there aren't many webpages that are currently using web
components yet so we may want to take advantage of lazily loading the
SlottedNodeContainer.
2018-09-28 12:33:17 -04:00
Gabriel Luong
84a9b96890 Bug 1494162 - Part 2: Lazy load the UndoStack in the markup view. r=pbro 2018-09-28 12:32:12 -04:00
Michael Ratcliffe
81596860ae Bug 1491879 - Fix telemetry support for multiple tabs / windows r=nchevobbe
- Various telemetry methods now need an object to be passed in in order to keep them seperate e.g. if the inspector is opened in tab 1 a timer is started. If an inspector is opened in tab 2 the same timer is restarted. Closing tab 2 would then erase the timing event invalidating the timer in tab 1.
- We no longer need to preface telemetry calls with category "devtools.main" because this is the only category we will be using.
- There are some changes to `devtools/client/debugger/new/dist/vendors.js` and `devtools/client/debugger/new/src/utils/telemetry.js` that need to be ported to the debugger at the same time as landing this.

Differential Revision: https://phabricator.services.mozilla.com/D6137
2018-09-25 12:57:13 +00:00
Belén Albeza
08c4a0e542 Bug 1460862 - Smooth scrolling when clicking on 'reveal' in slotted elements. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D3509
2018-08-22 08:35:40 +00:00
Julian Descottes
de5cde2836 Bug 1480384 - Remove unused theme option for autocomplete-popup;r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D2666
2018-08-02 15:05:50 +00:00