corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,699 Commits 1 Branch 0 Tags
current
Commit Graph

1292 Commits

Author SHA1 Message Date
Release Engineering Landoscript
7556d2bab9 No Bug - Import translations from main 2025-06-14 02:17:13 +00:00
mcarare
f24bc66006 Bug 1966455 - Extract the manufacturer checking logic into a ManufacturerChecker interface and a BuildManufacturerChecker implementation. r=android-reviewers,pollymce 
This allows for easier testing and dependency injection of manufacturer checks.

Differential Revision: https://phabricator.services.mozilla.com/D249515
 2025-05-19 09:51:29 +00:00
Nick Alexander
18d81b0b1b Bug 1960103 - Make more Android builds use MOZ_SOURCE_*. r=adhingra,tcampbell,android-reviewers, 
Right now Fenix and a-c end up calling `git rev-parse` for every
project.  None of this cruft is needed in the monorepo.

When the hg-to-git migration is complete, we can update the SCM URLs
to refer to git.

Differential Revision: https://phabricator.services.mozilla.com/D247418
 2025-05-12 22:33:05 +00:00
Mugurell
bf2545f1a6 Bug 1962168 - part 7 - Upstream ClipboardHandler to AC r=android-reviewers,tchoh 
To then use it in both Fenix and other AC modules.

Differential Revision: https://phabricator.services.mozilla.com/D247909
 2025-05-12 10:43:04 +00:00
Release Engineering Landoscript
7e5922c806 No Bug - Import translations from https://github.com/mozilla-l10n/android-l10n CLOSED TREE 2025-05-11 00:10:35 +00:00
Alexandru Marc
a42b1cd269 Revert "No Bug - Import translations from https://github.com/mozilla-l10n/android-l10n CLOSED TREE" for causing fenix lint failures 
This reverts commit f80793ca33.
 2025-05-10 00:43:47 +00:00
Release Engineering Landoscript
f80793ca33 No Bug - Import translations from https://github.com/mozilla-l10n/android-l10n CLOSED TREE 2025-05-10 00:11:21 +00:00
mcarare
1bb42cdd27 Bug 1964352 - Enable standard:no-single-line-block-comment rule. r=android-reviewers,nalexander 
Replace single line block comments with EOL comments

Differential Revision: https://phabricator.services.mozilla.com/D248513
 2025-05-09 13:56:39 +00:00
mcarare
30ee0f3ef3 Bug 1964352 - Enable standard:no-wildcard-imports rule and fix errors. r=android-reviewers,nalexander 
Kotlin style guide: Wildcard imports (of any type) are not allowed.
Also remove exception from detekt for java.util package.

Differential Revision: https://phabricator.services.mozilla.com/D248512
 2025-05-09 13:56:35 +00:00
mcarare
38b4f898e0 Bug 1964352 - Enable standard:function-literal rule and fix errors. r=android-reviewers,nalexander 
Kotlin style guide: No newline expected before parameter.

Differential Revision: https://phabricator.services.mozilla.com/D248509
 2025-05-09 13:56:28 +00:00
mcarare
19c245a5cb Bug 1964352 - Enable standard:property-naming ktlint rule and fix errors. r=android-reviewers,nalexander,pollymce 
Kotlin style guide: Constant names use UPPER_SNAKE_CASE, Non-constant names are written in camelCase.

Differential Revision: https://phabricator.services.mozilla.com/D248507
 2025-05-09 13:56:20 +00:00
mcarare
7bef90d659 Bug 1964352 - Enable standard:try-catch-finally-spacing ktlint rule and fix errors. r=android-reviewers,nalexander 
Kotlin style guide: Consistent spacing in try { .. } catch { .. } finally { .. }.

Differential Revision: https://phabricator.services.mozilla.com/D248506
 2025-05-09 13:56:17 +00:00
Aaditya
435f34d647 Bug 1956870 - Adding gradlew lint to android-{fenix|focus|ac} linters and reporting lint errors on phabricator. r=android-reviewers,nalexander 
Currently CI runs gradlew lint for android projects using build-fat-aar which is not needed now that we can run lint from root project. Current setup also doesn't update mozlint.json so phabricator doesn't recognize the lint failures. This bug adds gradlew lint to mach lint through the android-{fenix|focus|ac} linters in addition of ktlint and detekt which were added in D216999

This patch changes android lint configuration to generate JSON report of errors and then reads these errors in lints.py to report in the same format as other linters.

Creating new treeherder task for each of `android-{fenix|focus|ac}` linter as android-fenix can take up to 20 minutes ot run now with the addition of gradlew lint, which is almost the same as the existing mozlint-android-lints task takes, so doing this in parallel will be nice.

Follow up work would include removing all the original detekt, ktlint and lint tasks from treeherder which will make creating these new tasks more justified.

Differential Revision: https://phabricator.services.mozilla.com/D243832
 2025-05-08 05:54:24 +00:00
Harrison Oglesby
a0d57be908 Bug 1963954 - Remove dependency for application-services search from Fenix. r=android-reviewers,jonalmeida 
Differential Revision: https://phabricator.services.mozilla.com/D247811
 2025-05-07 01:53:12 +00:00
Mugurell
2f93f47729 Bug 1948655 - part 1 - Add a new AnimatedProgressBar composable r=android-reviewers,android-l10n-reviewers,delphine,tchoh 
This is a close implementation of the one described in
https://medium.com/@kappdev/creating-a-smooth-animated-progress-bar-in-jetpack-compose-canvas-drawing-and-gradient-animation-ddf07f77bb56

This progress bar has extra support for:
- automatic LTR or RTL orientation
- using multiple colors for a gradient background
- defining a glow radius that matches the same colors
- defining how the progress bar should terminate
- defining an animation for showing the new progress
- automatic accessibility events for progress changes

Differential Revision: https://phabricator.services.mozilla.com/D245718
 2025-04-21 20:40:43 +00:00
Harrison Oglesby
44366c0b44 Bug 1947538 - Add Remote Settings sync periodic work r=android-reviewers,jonalmeida 
Differential Revision: https://phabricator.services.mozilla.com/D245192
 2025-04-16 21:00:21 +00:00
Ryan VanderMeulen
0733327453 Bug 1960898 - Update AndroidX Core to version 1.16.0. r=android-reviewers,sfamisa 
Differential Revision: https://phabricator.services.mozilla.com/D245729
 2025-04-16 14:43:50 +00:00
mcarare
c1b3cedcea Bug 1947424 - Replace deprecated Thread.id with threadId r=android-reviewers,avirvara 
Differential Revision: https://phabricator.services.mozilla.com/D241950
 2025-04-15 17:17:36 +00:00
Jonathan Almeida
80aeec1aa7 Bug 1872229 - Fix minor lint check failures in android-components r=android-reviewers,mcarare,webcompat-reviewers,twisniewski 
We have moved more lint checks upstream to AC and these failures are
trivial to solve, rather than try to suppress.

Differential Revision: https://phabricator.services.mozilla.com/D236392
 2025-04-11 04:37:30 +00:00
smolnar
aaed8aeb2c Backed out 2 changesets (bug 1872229) for causing toolchain failures CLOSED TREE 
Backed out changeset 2fd0c027ec2c (bug 1872229)
Backed out changeset 7efbd8e4381d (bug 1872229)
 2025-04-10 03:38:28 +03:00
Jonathan Almeida
9956a54ab3 Bug 1872229 - Fix minor lint check failures in android-components r=android-reviewers,mcarare,webcompat-reviewers,twisniewski 
We have moved more lint checks upstream to AC and these failures are
trivial to solve, rather than try to suppress.

Differential Revision: https://phabricator.services.mozilla.com/D236392
 2025-04-09 22:32:23 +00:00
Ryan VanderMeulen
ca5f1bf351 Bug 1958578 - Utilize Kotlin extension functions in more places. r=geckoview-reviewers,android-reviewers,mcarare,calu 
Differential Revision: https://phabricator.services.mozilla.com/D244492
 2025-04-07 21:03:50 +00:00
Ryan VanderMeulen
0f1c9fe7f0 Bug 1958437 - Replace getPixel with Bitmap.get(). r=geckoview-reviewers,android-reviewers,ohall 
Differential Revision: https://phabricator.services.mozilla.com/D244460
 2025-04-04 11:41:11 +00:00
Ben Dean-Kawamura
002beb1476 Bug 1955266 - Update RemoteSettingsContext construction, r=boek,android-reviewers 
The constructor signature was updated in
https://github.com/mozilla/application-services/pull/6663/, this fixes
the breakage.

Differential Revision: https://phabricator.services.mozilla.com/D243720
 2025-04-01 18:12:09 +00:00
Michel Le Bihan
390b1dd093 Bug 1956447 - Correct getRepresentativeSnippet ktx Android component doc. r=tthibaud,android-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D243122
 2025-04-01 17:45:14 +00:00
Hubert Boma Manilla
6e90ce0ab2 Bug 1953851 - [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,shtrom,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud 
Differential Revision: https://phabricator.services.mozilla.com/D241589
 2025-04-01 17:12:54 +00:00
Issam Mani
6555214583 Bug 1957152 - Update form_factor to formFactor in RS attributes. r=android-reviewers,gmalekpour 
This fixes broken firefox suggest. See [[ https://mozilla.slack.com/archives/C05C9RET70F/p1743191471955339  | this thread ]] for context

Differential Revision: https://phabricator.services.mozilla.com/D243570
 2025-03-30 18:15:51 +00:00
Ryan VanderMeulen
38c662db60 Bug 1956673 - Replace more Uri.parse() usage with String.toUri(). r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D243236
 2025-03-27 12:13:06 +00:00
Titouan Thibaud
b3732a8a56 Bug 1945705 - Fix malformed download filename extracted from contentDisposition r=android-reviewers,rsainani 
Differential Revision: https://phabricator.services.mozilla.com/D241072
 2025-03-27 11:07:08 +00:00
Cosmin Sabou
fae9e9d8b6 Backed out changeset 9f2903340566 (bug 1945705) for causing lint failures on GeckoEngineSession.kt. CLOSED TREE 2025-03-26 23:18:19 +02:00
Titouan Thibaud
6d0da711d7 Bug 1945705 - Fix malformed download filename extracted from contentDisposition r=android-reviewers,rsainani 
Differential Revision: https://phabricator.services.mozilla.com/D241072
 2025-03-26 16:45:33 +00:00
Ryan VanderMeulen
88fe50b6d9 Bug 1956344 - Remove redundant lint {} blocks and apply android-lints.gradle where applicable. r=android-reviewers,adhingra 
Differential Revision: https://phabricator.services.mozilla.com/D243001
 2025-03-25 21:16:26 +00:00
Ryan VanderMeulen
d3355ce130 Bug 1956344 - Re-enable linting for AC support-test and fix existing failures. r=android-reviewers,adhingra 
Differential Revision: https://phabricator.services.mozilla.com/D243000
 2025-03-25 21:16:25 +00:00
Ryan VanderMeulen
826c53eaed Bug 1956344 - Clean up some unnecessary AC lint.xml files and rules. r=android-reviewers,adhingra 
Differential Revision: https://phabricator.services.mozilla.com/D242999
 2025-03-25 21:16:25 +00:00
Sandor Molnar
a839d26316 Backed out changeset 376442637e13 (bug 1953851) for causing build bustages. CLOSED TREE 2025-03-25 21:28:09 +02:00
Hubert Boma Manilla
b6ef2193f9 Bug 1953851 - [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud 
Differential Revision: https://phabricator.services.mozilla.com/D241589
 2025-03-25 15:57:37 +00:00
Ryan VanderMeulen
d4312b4ad4 Bug 1955985 - Remove space-assignment usage in Gradle files. r=geckoview-reviewers,android-reviewers,webcompat-reviewers,twisniewski,adhingra,ohall 
Differential Revision: https://phabricator.services.mozilla.com/D242727
 2025-03-24 15:55:48 +00:00
Michel Le Bihan
1f4e9c462d Bug 1954340 - Remove unnecessary String conversions in URLStringUtils toDisplayUrl Android component. r=tthibaud,android-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241745
 2025-03-24 13:46:03 +00:00
Michel Le Bihan
5be82240d9 Bug 1954077 - Add trimmed method to CharSequence in ktx component. r=android-reviewers,tthibaud 
Differential Revision: https://phabricator.services.mozilla.com/D241621
 2025-03-24 13:46:03 +00:00
Ryan VanderMeulen
24ed37846d Bug 1955462 - Replace Bitmap.createBitmap() with createBitmap(). r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D242441
 2025-03-21 16:03:07 +00:00
Ryan VanderMeulen
56919cdfab Bug 1955461 - Replace Color.parseColor() with toColorInt(). r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D242440
 2025-03-21 16:03:06 +00:00
Ryan VanderMeulen
131dc7b0c4 Bug 1955458 - Replace Uri.parse() with String.toUri(). r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D242439
 2025-03-21 16:03:06 +00:00
Ryan VanderMeulen
139e2258e3 Bug 1955456 - Refactor SharedIds.kt to use SharedPreferences.edit() KTX extension. r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D242438
 2025-03-21 16:03:06 +00:00
Ryan VanderMeulen
e335a8767e Bug 1955456 - Use SharedPreferences.edit() KTX extension. r=android-reviewers,mcarare 
Differential Revision: https://phabricator.services.mozilla.com/D242437
 2025-03-21 16:03:06 +00:00
Ben Dean-Kawamura
f208aee2dc Bug 1953166 - Send AppContext to RemoteSettingsService, r=skhan,adw,android-reviewers,bgruber 
Differential Revision: https://phabricator.services.mozilla.com/D241066
 2025-03-17 14:50:42 +00:00
Jeff Boek
d936edbce8 Bug 1954228 - Make a copy of the observers list to avoid a race condition that triggers a CME r=android-reviewers,matt-tighe 
Differential Revision: https://phabricator.services.mozilla.com/D241706
 2025-03-17 13:57:35 +00:00
Mugurell
5fd37ea3f0 Bug 1934443 - Don't animate keyboard dependent View if keyboard animation ended r=android-reviewers,mcarare 
Seen while debugging that it is possible (as a framework bug) to get notified
about keyboard animation progress after the animation has actually ended.
In these situations we need to synchronize not acting on the animation progress
data ourselves.

Differential Revision: https://phabricator.services.mozilla.com/D240296
 2025-03-17 10:32:22 +00:00
Mugurell
84e3bfc743 Bug 1946404 - Have system insets handling APIs supporting only Android 13+ r=android-reviewers,mcarare 
Using these APIs on lower versions of Android on devices from some
manufacturers was shown to lead to bugs in the application from the
inconsistencies of the insets framework of those devices.

Differential Revision: https://phabricator.services.mozilla.com/D241780
 2025-03-17 10:32:20 +00:00
William Durand
98efe435bd Bug 1948634 - Correctly uninstall the webcompat-reporter extension in Fenix. r=007,android-reviewers,webcompat-reviewers,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D240605
 2025-03-12 12:40:48 +00:00
Ben Dean-Kawamura
72b09f21a1 Bug 1950392 - Prepare for Suggest/Relevancy Remote Settings changes, r=skhan,android-reviewers,zmckenney 
* Construct an app-wide RemoteSettingsService instance
* Pass it to the SuggestStoreBuilder.  Currently this method is a no-op,
  but by doing this ahead of time we can switch Suggest to depending on
  it without a breaking change.

Differential Revision: https://phabricator.services.mozilla.com/D239603
 2025-03-10 16:42:45 +00:00