Jonathan Almeida
80aeec1aa7
Bug 1872229 - Fix minor lint check failures in android-components r=android-reviewers,mcarare,webcompat-reviewers,twisniewski
...
We have moved more lint checks upstream to AC and these failures are
trivial to solve, rather than try to suppress.
Differential Revision: https://phabricator.services.mozilla.com/D236392
2025-04-11 04:37:30 +00:00
smolnar
aaed8aeb2c
Backed out 2 changesets (bug 1872229) for causing toolchain failures CLOSED TREE
...
Backed out changeset 2fd0c027ec2c (bug 1872229)
Backed out changeset 7efbd8e4381d (bug 1872229)
2025-04-10 03:38:28 +03:00
Jonathan Almeida
9956a54ab3
Bug 1872229 - Fix minor lint check failures in android-components r=android-reviewers,mcarare,webcompat-reviewers,twisniewski
...
We have moved more lint checks upstream to AC and these failures are
trivial to solve, rather than try to suppress.
Differential Revision: https://phabricator.services.mozilla.com/D236392
2025-04-09 22:32:23 +00:00
Ryan VanderMeulen
d4312b4ad4
Bug 1955985 - Remove space-assignment usage in Gradle files. r=geckoview-reviewers,android-reviewers,webcompat-reviewers,twisniewski,adhingra,ohall
...
Differential Revision: https://phabricator.services.mozilla.com/D242727
2025-03-24 15:55:48 +00:00
Ryan VanderMeulen
e335a8767e
Bug 1955456 - Use SharedPreferences.edit() KTX extension. r=android-reviewers,mcarare
...
Differential Revision: https://phabricator.services.mozilla.com/D242437
2025-03-21 16:03:06 +00:00
Aaditya Dhingra
5f9d749a96
Bug 1949260 - Part 2 - Replace DependenciesPlugin with gradle version catalog. r=geckoview-reviewers,android-reviewers,webcompat-reviewers,nalexander,twisniewski,owlish,jonalmeida,tthibaud
...
Differential Revision: https://phabricator.services.mozilla.com/D238804
2025-03-03 17:12:25 +00:00
Ryan VanderMeulen
0cb4659021
Bug 1929236 - Run Robolectric tests on SDK 35. r=android-reviewers,mcarare
...
Differential Revision: https://phabricator.services.mozilla.com/D227988
2024-11-18 13:21:34 +00:00
Aaditya Dhingra
d71d64edff
Bug 1880848 - Fix warning: org.gradle.api.plugins.BasePluginConvention type has been deprecated. r=android-reviewers,webcompat-reviewers,twisniewski,pollymce,nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D223166
2024-10-08 09:08:07 +00:00
mcarare
1070e28db0
Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
...
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 13:00:48 +00:00
acseh
3f4b08c594
Backed out changeset 9976b7730dbd (bug 1893120) for causing lint failures CLOSED TREE
2024-05-14 12:57:36 +03:00
mcarare
4a11afeae1
Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
...
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 08:02:38 +00:00
mcarare
063c553913
Bug 1849833 - Replace deprecated compileSdkVersion.
...
This is replaced by defaultConfig compileSdk.
2023-09-11 06:36:20 +00:00
Geoff Brown
6561b2de2b
Bug 1825116 - Resolve many black, isort, and file-whitespace lint issues
2023-04-12 14:04:29 +00:00
Ryan VanderMeulen
0e5e70291c
Bug 1820233 - Remove unneeded kotlin_stdlib inclusions and re-enable Werror in detekt build.gradle
2023-03-07 00:12:18 +00:00
mcarare
1f589a2e0b
Bug 1802817 - Set namespace via DSL in gradle build files.
...
See https://developer.android.com/studio/build/configure-app-module#set-namespace
and https://issuetracker.google.com/issues/172361895
2023-03-02 17:13:09 +00:00
mcarare
922b5f6643
Bug 1802817 - Rename AC Dependencies to ComponentsDependencies.
...
This change is needed in order to avoid clashes with Dependencies class introduced
in Gradle from 7.6 version.
2023-03-02 17:13:09 +00:00
Mugurell
29325133df
Bug 1800268 - Refactor ToolbarAutocompleteFeature to allow easily changing providers
...
This class drives the autocomplete feature and previously only allowed for
adding a history or domains autocomplete provider.
With the new changes it will support adding and removing any autocomplete
provider individually or in bulk.
2023-01-31 11:15:37 +00:00
Christian Sadilek
4091b14a33
Fix android lint in composite builds
2022-11-21 13:40:53 -05:00
Gabriel Luong
d9d783b698
[components] Issue https://github.com/mozilla-mobile/android-components/issues/12939 : Address all ktlint issues
2022-10-17 17:07:40 -04:00
Mugurell
d78b06b6bf
[components] For https://github.com/mozilla-mobile/android-components/pull/11175 - Migrate runBlocking and runBlockingTest to runTest in unit tests
...
Used `runTestOnMain` where `MainCoroutineRule` was used or needed to be used,
`runTest` elsewhere.
Extra effort for removing all `runBlocking` occurrences in unit tests.
`kotlinx.coroutines.test.runTest` is a test specific API that seems like a more
appropriate way for running tests in a coroutine than the general
`kotlinx.coroutines.runBlocking` api.
2022-05-10 13:45:03 +00:00
mcarare
33d5df7988
[components] For https://github.com/mozilla-mobile/android-components/issues/11670 : Use shadowOf(getMainLooper()).idle() to execute all posted tasks.
...
This is needed due to the new default Looper Mode - PAUSED in Robolectric.
2022-03-18 12:43:16 +00:00
Sebastian Kaspari
ce323400dd
[components] Run ktlintFormat to fix new ktlint errors.
2021-07-28 12:03:23 +00:00
Sebastian Kaspari
28a76101be
[components] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0 and Room to 2.3.0).
2021-07-19 09:32:44 +00:00
Emilio Cobos Álvarez
41d375b7d9
[components] ktlint: Add missing newlines.
...
Running ./gradlew ktlint locally reports a lot of stuff like:
/home/emilio/src/moz/android-components/components/support/migration/src/test/java/mozilla/components/support/migration/MigrationIntentProcessorTest.kt:1:1: File must end with a newline (\n)
This fixes it with:
for f in $(cat files | cut -d : -f 1); do echo "" >> $f; done
Making ./gradlew ktlint pass.
2020-12-03 17:24:44 +00:00
Jonathan Almeida
b86fa6dfb5
[components] Close https://github.com/mozilla-mobile/android-components/issues/6601 : Update targetSdkVersion to 29
2020-04-28 03:16:54 -04:00
Denys M
b95c932f81
[components] For https://github.com/mozilla-mobile/android-components/issues/4460 . Fix detekt warning about license in project files.
2019-09-24 01:01:03 +04:00
Tiger Oakes
203cd628a1
[components] Issue https://github.com/mozilla-mobile/android-components/issues/3481 - Support Q in browser components
2019-07-08 10:50:29 +02:00
Tiger Oakes
b248451666
[components] Issue https://github.com/mozilla-mobile/android-components/issues/3481 - Fix null checks before Android Q
2019-06-25 10:38:03 +02:00
Denys M
1f8fc3fa5b
[components] For https://github.com/mozilla-mobile/android-components/issues/1481 . Enable unit test binary resources globally.
...
Excluded few modules.
2019-06-13 09:29:52 +02:00
Denys M
b6629cd6fc
[components] For https://github.com/mozilla-mobile/android-components/issues/1481 . Use androidx runner in browser-domains.
2019-06-11 17:48:41 +02:00
Denys M
e0cc1b4c6a
[components] For https://github.com/mozilla-mobile/android-components/issues/2346 . Enable kotlin warningsAsErrors for browser-domains module.
...
- Refactor `ShippedDomainsProvider` and `CustomDomainsProvider`. Using
composition instead of inheritance.
- Add tests for `BaseDomainAutocompleteProvider`.
2019-06-05 12:10:59 +02:00
Sebastian Kaspari
5c54ec453d
[components] Closes https://github.com/mozilla-mobile/android-components/issues/842 : Migrate from support libraries to AndroidX.
2019-05-02 16:08:55 +02:00
Michael Comella
8027f64272
[components] Closes https://github.com/mozilla-mobile/android-components/issues/54 : Fix nullable receiver in CustomDomains.
...
This is the one error I fixed.
2019-03-15 17:47:08 +01:00
Cassidy James Blaede
00a339891d
[components] Remove emgn.com
...
It's erroring out.
2019-02-26 18:07:47 +01:00
Cassidy James Blaede
dd8d664d54
[components] Remove ijreview.com from domains
...
It's dead
2019-02-26 18:07:36 +01:00
Cassidy James Blaede
975ba320b5
[components] Remove toysrus.com from domains
...
They've gone bankrupt and no longer offer a store online; the current site is a placeholder
2019-02-26 18:07:17 +01:00
Cassidy James Blaede
618499db73
[components] Remove likes.com from domains
...
Server is erroring out
2019-02-26 18:07:08 +01:00
Cassidy James Blaede
d3557d2021
[components] Remove fatwallet.com from domains
...
They've shut down
2019-02-26 18:06:55 +01:00
Cassidy James Blaede
2663721b83
[components] Remove regnok.com from domains
...
Looks like a dead website
2019-02-25 18:23:44 +01:00
Cassidy James Blaede
932afb2187
[components] Remove conservativetribune
...
According to [NewsGuard](https://api.newsguardtech.com/6E0FA7E2CF73DA94AB47BB2FCA2F31FEADEFDA6504DAB9BD10FE6EE11958D35751CF3DEEA2E6D8F66DFE9688C3562CB8EF46C880D400F511?cid=6437f3cb-6332-46e6-9000-309663a9e9c8 ):
>has published misleading headlines, debunked conspiracy theories, and poorly vetted content.
2019-02-25 17:45:08 +01:00
Cassidy James Blaede
f9416d3c58
[components] Remove backpage.com from domains
...
It was seized by the US government due to soliciting child prostitution.
>The Justice Department today announced the seizure of Backpage.com, the Internet’s leading forum for prostitution ads, including ads depicting the prostitution of children.
–https://www.justice.gov/opa/pr/justice-department-leads-effort-seize-backpagecom-internet-s-leading-forum-prostitution-ads
2019-02-25 17:44:29 +01:00
Grisha Kruglov
8260324a9b
[components] Perform browser-toolbar autocompletion off the UI thread
...
At this point in the stack, we're not in control over what our
autocomplete providers are, what actions they'll do in order to
field our queries, etc. For example, some providers may hit the disk
and perform expensive DB queries internally. Some may even hit the
network, in theory!
In order to keep things perceptively speedy, let's run the actual work
off the main thread. This patch sets up a new pool thread to process
autocomplete requests. More than one thread is selected so that we maintain
liveliness during quick user input. Background tasks are cancelled as new
queries come in, and stale results are discarded.
2019-02-08 12:22:13 -08:00
Mitchell Hentges
8fd19cdf3a
[components] Moves description to be part of project.ext
2019-01-11 10:08:32 +01:00
Mitchell Hentges
3ee4d96a84
[components] Reads componentsVersion from .buildconfig.yml
2019-01-11 10:08:32 +01:00
Sebastian Kaspari
4c18208bcd
[components] Closes https://github.com/mozilla-mobile/android-components/issues/1485 : browser-domains: Move new classes to "autocomplete" sub package.
2018-11-27 20:37:12 -05:00
Grisha Kruglov
c506ab7082
[components] Refactor 'browser-domains', splitting a single provider into two
2018-11-26 18:51:31 +01:00
ali-abdullah
89f3263d12
[components] included buildSrc in ktlint and detekt checks
2018-11-16 12:40:04 +01:00
Sebastian Kaspari
4fcc11ef9b
[components] Issue https://github.com/mozilla-mobile/android-components/issues/404 : Build with and target SDK 28 (+ update support libraries)
...
* Build with and target SDK 28.
* Use Robolectric 4.0-alpha-3.
* Update support libraries to 28.0.0.
* .travis.yml: Update platform version.
2018-11-15 18:12:42 +01:00
Christian Sadilek
e34c22f81b
[components] Closes https://github.com/mozilla-mobile/android-components/issues/1305 : Upgrade to Kotlin 1.3.0 and Coroutines 1.0.1
2018-11-09 09:26:47 +01:00
Grisha Kruglov
782980355f
[components] Stop using deprecated versions of async, launch, etc
...
This switching to using explicit CoroutineScopes and Dispatchers,
trying to inherit context when appropriate.
2018-11-07 13:04:17 -08:00