29914 Commits

Author SHA1 Message Date
Ryan VanderMeulen
0af041b429 Bug 1986142 - Fix lint warnings. a=me DONTBUILD 2025-10-02 00:29:20 +00:00
Hubert Boma Manilla
c8e6b3801c Bug 1986142 - [devtools] Properly escape all new lines characters (make sure no carraige returns) a=RyanVM
While reverting all the work related to cross platform escaping of curl (See  Bug 1976589), i tried to cleanup the
escaping of new line characters, but introduced carriage returns (\r).

This patch reverts back to the original fix from Bug 1968414

Original Revision: https://phabricator.services.mozilla.com/D265397

Differential Revision: https://phabricator.services.mozilla.com/D267045
2025-10-01 23:58:04 +00:00
Hubert Boma Manilla
4d9d5d34cb Bug 1976589 - [devtools] Stop escaping for other platforms when using Copy As Curl(Windows) r=devtools-reviewers,ochameau a=RyanVM
This patch reverts important parts of D243110 related to Bug 1950001
This goal is for the Copy As Curl(Windows) to work properly on just the windows CMD

Differential Revision: https://phabricator.services.mozilla.com/D255793
2025-10-01 23:58:01 +00:00
Hubert Boma Manilla
0497f73908 Bug 1974973 - [devtools] Stop escaping for other platforms when selecting Copy as curl (POSIX) r=devtools-reviewers,ochameau a=RyanVM
- This patch should revert the fixes from Bug 1960198, Bug 1949994 and Bug 1962301.
- The goal of this patch is Copy as curl (POSIX) should only work on Linux.

Differential Revision: https://phabricator.services.mozilla.com/D255784
2025-10-01 23:57:58 +00:00
Nicolas Chevobbe
7c55e1efc2 Bug 1979591 - [devtools] Properly focus Markup view when Inspector is opened via Inspect context menu. a=RyanVM.
If the inspector was opened from the Inspect context menu, the node gets selected
in the MarkupView constructor, but the Toolbox focuses the Inspector iframe once
the tool is loaded (and the iframe is actually visible), so we need to focus
the selected node after the inspector was properly selected and focused.

Original Revision: https://phabricator.services.mozilla.com/D259039

Differential Revision: https://phabricator.services.mozilla.com/D260236
2025-08-08 19:32:26 +00:00
Nicolas Chevobbe
8a33ca95a6 Bug 1980892 - [devtools] Remove use of InspectorUtils.isCustomElementName on WalkerSearch#_searchSelectors. a=RyanVM.
We used to check if the passed query looked like a tag name so we could
bail out early, as we'd get those results from _searchIndex.
But InspectorUtils.isCustomElementName does match some legitimate
selectors, like div.a-b.
Let's remove the check on custom element and trigger the search in such case.

Original Revision: https://phabricator.services.mozilla.com/D259783

Differential Revision: https://phabricator.services.mozilla.com/D260238
2025-08-07 15:20:26 +00:00
Alexandre Poirot
1f0cb9a0b9 Bug 1976551 - [devtools] Fix selecting original source from the Source Tree. a=RyanVM
We should ignore the "show original source location by default" selecting
from selecting a source from the source tree.

Original Revision: https://phabricator.services.mozilla.com/D256694

Differential Revision: https://phabricator.services.mozilla.com/D260237
2025-08-07 15:20:23 +00:00
Nicolas Chevobbe
72aedb1d83 Bug 1973246 - [devtools] Expose browserLoaderRequire in Debugger panel global. a=RyanVM.
Original Revision: https://phabricator.services.mozilla.com/D254813

Differential Revision: https://phabricator.services.mozilla.com/D257646
2025-07-22 15:37:38 +00:00
Hubert Boma Manilla
690430599d Bug 1971094 - [devtools] Update search results when the selected source changes a=dmeehan
Original Revision: https://phabricator.services.mozilla.com/D253015

Differential Revision: https://phabricator.services.mozilla.com/D254167
2025-07-08 17:47:24 +00:00
Hubert Boma Manilla
021fdf21d9 Bug 1968414 - [devtools] Escape carriage return character properly r=devtools-reviewers,nchevobbe a=pascalc
Differential Revision: https://phabricator.services.mozilla.com/D254323
2025-07-08 13:14:52 +00:00
Nicolas Chevobbe
e348ab993b Bug 1970654 - [devtools] Fix new request params sync for parameters with same name. a=dmeehan. DONTBUILD
Original Revision: https://phabricator.services.mozilla.com/D253126

Differential Revision: https://phabricator.services.mozilla.com/D253309
2025-06-11 17:03:50 +00:00
Nicolas Chevobbe
1787ad1b44 Bug 1970248 - [devtools] Don't use getUrl to build input value in onUpdateQueryParams. a=dmeehan.
Since the url string we get in the function is the input value, it may not be a valid URL,
and in such case the getUrl function would return a null object, causing a crash of the panel.
We revert to a more cautious approach by adding the computed params after the last ? char
we see in the input value.
Test cases are added to cover the fix (and more scenarios around resend panel param synchronization)

Original Revision: https://phabricator.services.mozilla.com/D252450

Differential Revision: https://phabricator.services.mozilla.com/D252625
2025-06-05 12:59:53 +00:00
Nicolas Chevobbe
bc8ea6d91e Bug 1968257 - [devtools] Fix Netmonitor response panel crash on null JSON response. a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D251555

Differential Revision: https://phabricator.services.mozilla.com/D252033
2025-06-03 03:03:20 +00:00
Nicolas Chevobbe
294861d1cd Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D250613
2025-05-25 10:56:48 +00:00
Cristian Tuns
2c393cf579 Revert "Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes" for causing failures with "1 not in success codes: [0] "
This reverts commit f73f8eabd8.
2025-05-25 10:25:19 +00:00
Nicolas Chevobbe
f73f8eabd8 Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D250613
2025-05-25 09:30:55 +00:00
Mark Banner
8bf730ccd9 Bug 1881701 - Move ESLint ignores and test paths to be module files as well. r=frontend-codestyle-reviewers,devtools-reviewers,Gijs,nchevobbe
This completes the moving of all the top-level configuration files to be ES modules, and named similarily.

Differential Revision: https://phabricator.services.mozilla.com/D250403
2025-05-24 17:11:39 +00:00
Mark Banner
b20fbf2ba1 Bug 1881701 - Fix remainder of newly raised devtools issues after switching to the ESLint flat config. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D249957
2025-05-24 17:11:32 +00:00
Mark Banner
ee9933d77b Bug 1881701 - Automatically fix new issues raised in devtools. r=devtools-reviewers,frontend-codestyle-reviewers,mossop,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D249956
2025-05-24 17:11:28 +00:00
Mark Banner
3cc3379c8f Bug 1881701 - Change the devtools configurations to work with the ESLint flat configuration.r=devtools-reviewers,profiler-reviewers,julienw,nchevobbe
This consolidates the jest environment definition, and the xpcshell globals into the devtools/.eslintrc.mjs file, for easier configurations.
It also changes the restart of the configurations to work with flat config.

Differential Revision: https://phabricator.services.mozilla.com/D249948
2025-05-24 17:10:59 +00:00
Mark Banner
d7c7c5369b Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
This is separate to help preserve history of the files.

Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00
Emilio Cobos Álvarez
7c0d4089c5 Bug 1968202 - Generalize GlobalStyleSheetCache to support author stylesheets. r=smaug
In bug 1967507 I changed the timing of AnonymousContent stylesheet
loading in a way that it perturbed a css cache test because of
accessiblecaret.css

  https://hg.mozilla.org/mozilla-central/rev/a6a294ae1d18

However that made me realize that accessiblecaret.css is loaded
virtually in all processes, and it should be using the same mechanism we
use for UA sheets, rather than using all the CSS loader machinery
in-content. Same goes for details.css.

Expand GlobalStyleSheetCache to allow UA and Author sheets, and allow
ShadowRoot to get built-in stylesheets appended.

This allows accessiblecaret.css and details.css not to be marked as
content-accessible.

We could do the same at the document level for plaintext.css and co, but
that seems a bit less common, so maybe fine.

Differential Revision: https://phabricator.services.mozilla.com/D250909
2025-05-24 11:27:14 +00:00
Emilio Cobos Álvarez
abfb41e00a Bug 1967931 - Avoid blocking rendering for devtools pauses. r=smaug,devtools-reviewers,nchevobbe
This regresses browser_dbg-scroll-run-to-completion.js, but I think we
should either suppress rendering or not suppress it, not doing some
weird in-between thing. So for now given the discussion on the bug it's
probably acceptable.

Differential Revision: https://phabricator.services.mozilla.com/D250772
2025-05-24 10:14:39 +00:00
Nicolas Chevobbe
76957c0da0 Bug 1542277 - [devtools] Fix Inspector search autocomplete when using selector search with pseudo selectors. r=devtools-reviewers,jdescottes.
This patch adds support for the "pseudo" selector state in the inspector search,
which is already handled in the server (in WalkerActor#getSuggestionsForQuery).

Differential Revision: https://phabricator.services.mozilla.com/D250896
2025-05-24 08:30:56 +00:00
Nicolas Chevobbe
2ce6dfa245 Bug 1327973 - [devtools] Remove count/score sort in markup/style editor autocomplete suggestions. r=devtools-reviewers,jdescottes.
The suggestions were sorted by the number of element matching the item, which could
be confusing and get in the way of the user when they wanted to search for the
least used version.
We now sort the suggestions by "type" (id, class, tag, …), and then, within those
groups, alphabetically.

Differential Revision: https://phabricator.services.mozilla.com/D249768
2025-05-24 08:30:53 +00:00
Serban Stanca
4c663869d9 Revert "Bug 1968202 - Generalize GlobalStyleSheetCache to support author stylesheets. r=smaug" for causing wpt failures in prefetch-transfer-size-executor.html.
This reverts commit e2ac38c2a8.
2025-05-24 01:53:53 +00:00
Joel Maher
7e69b821f2 Bug 1967293 - Update mochitest manifest annotations to support Ubuntu 24.04. r=aryx,webcompat-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,profiler-reviewers,dom-storage-reviewers,twisniewski,asuth,accessibility-frontend-reviewers,julienw,dimi,morgan,mconley,ochameau,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D250070
2025-05-23 20:13:29 +00:00
Hubert Boma Manilla
829de4d0df Bug 1943909 - [devtools] Remove codemirror next preference r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250367
2025-05-23 15:53:53 +00:00
Alexandru Marc
f8a43a4811 Revert "Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes" by dev request
This reverts commit 4fe1cbf23e.
2025-05-23 14:51:27 +00:00
Nicolas Chevobbe
4fe1cbf23e Bug 1967673 - [devtools] Don't omit valid safe getter undefined values in _findSafeGetterValues. r=devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D250613
2025-05-23 14:37:42 +00:00
Emilio Cobos Álvarez
e2ac38c2a8 Bug 1968202 - Generalize GlobalStyleSheetCache to support author stylesheets. r=smaug
In bug 1967507 I changed the timing of AnonymousContent stylesheet
loading in a way that it perturbed a css cache test because of
accessiblecaret.css

  https://hg.mozilla.org/mozilla-central/rev/a6a294ae1d18

However that made me realize that accessiblecaret.css is loaded
virtually in all processes, and it should be using the same mechanism we
use for UA sheets, rather than using all the CSS loader machinery
in-content. Same goes for details.css.

Expand GlobalStyleSheetCache to allow UA and Author sheets, and allow
ShadowRoot to get built-in stylesheets appended.

This allows accessiblecaret.css and details.css not to be marked as
content-accessible.

We could do the same at the document level for plaintext.css and co, but
that seems a bit less common, so maybe fine.

Differential Revision: https://phabricator.services.mozilla.com/D250909
2025-05-23 13:30:13 +00:00
Hubert Boma Manilla
93686f2a43 Bug 1953415 - [devtools] Remove CM5 support code from debugger mochitests r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250365
2025-05-23 11:16:51 +00:00
Hubert Boma Manilla
2104c41c7b Bug 1953415 - [devtools] Remove CM5 code related to the Editor Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250300
2025-05-23 11:16:47 +00:00
Hubert Boma Manilla
6dd0a283e3 Bug 1953415 - [devtools] Remove CM5 code related to the Conditional panel Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250299
2025-05-23 11:16:43 +00:00
Hubert Boma Manilla
97f0138e7d Bug 1953415 - [devtools] Remove CM5 code related to the Search Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250298
2025-05-23 11:16:40 +00:00
Hubert Boma Manilla
b0656d8c19 Bug 1953415 - [devtools] Remove CM5 code related to the Preview Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250297
2025-05-23 11:16:36 +00:00
Hubert Boma Manilla
f609387556 Bug 1953415 - [devtools] Remove CM5 code related to the Inline Preview Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250296
2025-05-23 11:16:32 +00:00
Hubert Boma Manilla
21a092e0d6 Bug 1953415 - [devtools] Remove CM5 code related to the Highlight Line Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250295
2025-05-23 10:41:18 +00:00
Hubert Boma Manilla
f9f60e8571 Bug 1953415 - [devtools] Remove CM5 code related to the Highlight Lines Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250294
2025-05-23 10:41:14 +00:00
Hubert Boma Manilla
792d117b92 Bug 1953415 - [devtools] Remove CM5 code related to the Debug Line Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250292
2025-05-23 10:41:11 +00:00
Hubert Boma Manilla
62ee3a82be Bug 1953415 - [devtools] Remove CM5 code related to the Column Breakpoints r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250291
2025-05-23 10:41:07 +00:00
Hubert Boma Manilla
cd08e9afd6 Bug 1953415 - [devtools] Remove CM5 code related to the Gutter Breakpoints r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250290
2025-05-23 10:41:03 +00:00
Hubert Boma Manilla
77323b45e2 Bug 1953415 - [devtools] Remove CM5 code for the Exceptions Component r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250289
2025-05-23 10:40:59 +00:00
Julian Descottes
620f57d836 Bug 1966826 - [devtools] Pass waitForLoad=false to navigateTo from DebugTargetInfo r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D250788
2025-05-23 08:29:01 +00:00
Julian Descottes
07d6425b55 Bug 1961617 - [devtools] Filter out the unblock request in test browser_net_duration-sort.js r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D250797
2025-05-23 07:16:45 +00:00
Julien Wajsberg
b65e26de56 Bug 1581963 - [devtools] Add copyFromBuffer and copyToBuffer to the bulk packet r=ochameau,devtools-reviewers,profiler-reviewers,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D250276
2025-05-22 18:02:32 +00:00
Julien Wajsberg
29c9a8dba5 Bug 1581963 - [devtools] Handle errors properly when capturing a profile r=profiler-reviewers,mstange
Differential Revision: https://phabricator.services.mozilla.com/D245886
2025-05-22 18:02:28 +00:00
Julien Wajsberg
2417113533 Bug 1581963 - [devtools] Implement a new remote function to gather the profile data, using the bulk api r=devtools-backward-compat-reviewers,profiler-reviewers,ochameau,mstange
The devtools protocol's bulk API is much more efficient, as we're
transfering the protocol data in a binary form instead of serializing it
using the devtools protocol.
In addition to that, the profile data is now gzipped before sending it.

Differential Revision: https://phabricator.services.mozilla.com/D244341
2025-05-22 18:02:25 +00:00
Julien Wajsberg
8c7ecb613b Bug 1581963 - [devtools] Add a new trait to control the use of the bulk API for the performance panel r=devtools-reviewers,devtools-backward-compat-reviewers,profiler-reviewers,nchevobbe,mstange
Differential Revision: https://phabricator.services.mozilla.com/D245460
2025-05-22 18:02:20 +00:00
Julien Wajsberg
859d407b2b Bug 1581963 - [profiler] Remove an unused feature from the default list of features r=canaltinova,devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D246768
2025-05-22 18:02:17 +00:00