Sam Foster
b3bd13a136
Bug 1721741 - Remove unused screenshots icons. r=niklas
...
- These are files housed in the components/screenshot directory but only previously referenced by
the extension - which has now been removed.
Differential Revision: https://phabricator.services.mozilla.com/D244044
2025-04-02 15:12:52 +00:00
Niklas Baumgardner
286abf76a1
Bug 1892125 - Refactor screenshots preview. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D207884
2024-04-30 23:55:55 +00:00
Hanna Jones
21849b1def
Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf
Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE
2024-04-24 03:14:45 +03:00
Hanna Jones
9413513b0d
Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Aron Cseh
08943f7f60
Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE
2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238
Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Niklas Baumgardner
130b81463b
Bug 1889797 - Remove screenshots-component-cancel-mac-button reference. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D206775
2024-04-07 12:26:48 +00:00
Niklas Baumgardner
1abddd1c95
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-03 23:51:56 +00:00
Cristian Tuns
83896edc65
Backed out changeset d41d18cecc78 (bug 1864038) for causing bc failures in browser_screenshots_drag_scroll_test.js CLOSED TREE
2024-04-02 12:41:01 -04:00
Niklas Baumgardner
c7874fdeb6
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-02 15:53:57 +00:00
Norisz Fay
61257b3d08
Backed out changeset 13111643fbf4 (bug 1864038) for causing bc failures on browser_screenshots_drag_scroll_test.js CLOSED TREE
2024-04-02 05:04:20 +03:00
Niklas Baumgardner
70450dd2d1
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 22:33:12 +00:00
Narcis Beleuzu
8e1286070a
Backed out changeset 4bcd94d558a6 (bug 1864038) for bc failure on browser_screenshots_drag_scroll_test.js
2024-04-01 17:29:08 +03:00
Niklas Baumgardner
9be70cc492
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 13:51:16 +00:00
Niklas Baumgardner
9b5daf0abd
Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419
Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE
2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910
Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Natalia Csoregi
eb2e3cf8cb
Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE
2024-01-19 03:46:03 +02:00
Niklas Baumgardner
729c5b4066
Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 00:07:46 +00:00
Iulian Moraru
e1d66150c9
Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE
2024-01-18 22:14:11 +02:00
Niklas Baumgardner
6dd5c4f60b
Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-18 17:47:54 +00:00
Sam Foster
e1e878dc76
Bug 1820015 - Make the screenshots UI keyboard accessible. r=niklas
...
* Move the chrome panel buttons into a `box` which is inserted into #navigator-toolbox
* Adjust what open/closed means using hidden instead
* Capture a weak ref to the focused element on open, and attempt to put focus back on exit
* Add some restore-focus tests
* Fix a bug where cancel via overlay "X" button wasn't exiting properly
* Place initial focus in the preview dialog button on the download button
Differential Revision: https://phabricator.services.mozilla.com/D181184
2023-12-18 19:01:44 +00:00
Niklas Baumgardner
59a1e1e591
Bug 1842037 - Update screenshots telemetry. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D191679
2023-11-14 15:57:46 +00:00
Norisz Fay
1b95461566
Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE
2023-11-14 04:06:58 +02:00
Niklas Baumgardner
80c28a9bea
Bug 1842037 - Update screenshots telemetry. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D191679
2023-11-13 23:57:17 +00:00
Sam Foster
c20c018e69
Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas
...
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
- Separate out getting the panel from creating it
- closePanel only closes the buttons panel
- Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)
Differential Revision: https://phabricator.services.mozilla.com/D185379
2023-09-19 00:14:27 +00:00
Niklas Baumgardner
655e4f5c79
Bug 1832667 - Add ConfirmationHint when screenshot is copied. r=sfoster,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D178674
2023-05-25 14:27:24 +00:00
Mark Banner
b61a6a6502
Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Sam Foster
c3066d257e
Bug 1832171 - Link the packaged platform-specific common stylesheets in Screenshots. r=niklas,desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D177569
2023-05-10 15:55:46 +00:00
Niklas Baumgardner
9bb496859e
Bug 1805984 - Update save visible and save full page screenshot buttons. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D176081
2023-05-03 17:53:15 +00:00
Niklas Baumgardner
f0190facaa
Bug 1824430 - Update screenshots buttons styling. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 15:30:21 +00:00
Niklas Baumgardner
b418549f7e
Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 15:30:21 +00:00
Iulian Moraru
7237840464
Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE
...
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
2023-03-30 04:44:53 +03:00
Niklas Baumgardner
5ea1b4a087
Bug 1824430 - Update screenshots buttons styling. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 00:36:32 +00:00
Niklas Baumgardner
28fe1e62b1
Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 00:36:31 +00:00
Niklas Baumgardner
8d87e40736
Bug 1801019 - Add telemetry for screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-25 17:26:34 +00:00
Marian-Vasile Laza
ac8ed92c6a
Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE
2023-02-23 21:11:16 +02:00
Niklas Baumgardner
4a2f7b7309
Bug 1801019 - Add telemetry for screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-23 17:37:01 +00:00
Butkovits Atila
0cf8d92417
Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE
2023-02-21 23:04:05 +02:00
Niklas Baumgardner
3b1f991f19
Bug 1801019 - Add telemetry for screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-21 19:59:09 +00:00
Niklas Baumgardner
ad90b95338
Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D158678
2022-12-06 00:06:20 +00:00
Stanca Serban
7d855ec985
Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE
2022-12-02 16:39:01 +02:00
Niklas Baumgardner
47288cb256
Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D158678
2022-12-02 13:45:57 +00:00
Marian-Vasile Laza
56aa734c69
Backed out changeset 1fdf3fc76d06 (bug 1785293) for causing bc failures on browser_screenshots_drag_test.js. CLOSED TREE
2022-11-30 22:53:47 +02:00
Niklas Baumgardner
0dab83bc6a
Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D158678
2022-11-30 15:00:33 +00:00
Cieara Meador
a1f865ad77
Bug 1794142 - Screenshots module buttom HCM r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D162044
2022-11-17 22:50:18 +00:00
Cristian Tuns
640cc43739
Backed out changeset 57d19e70e34c (bug 1794142) for causing mochitest failures in browser_parsable_css.js CLOSED TREE
2022-11-16 16:11:06 -05:00
Cieara Meador
baf02dc8ab
Bug 1794142 - Screenshots module buttom HCM r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D162044
2022-11-16 19:31:49 +00:00
Marian-Vasile Laza
6b363505f3
Backed out changeset 7c0eb6e89712 (bug 1785293) for causing bc failures on browser_screenshots_test_downloads.js. CLOSED TREE
2022-11-11 02:36:29 +02:00