376 Commits

Author SHA1 Message Date
Gregory Pappas
2f3aa191a9 Bug 1966792 - Add keyboard shortcut to screenshots tooltip r=sfoster,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D249931
2025-05-22 05:47:47 +00:00
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
baa5d72bbd Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D249182
2025-05-21 03:55:13 +00:00
Niklas Baumgardner
934819c080 Bug 1948366 - Remove extensions.screenshots.disabled pref. r=sfoster,webdriver-reviewers,firefox-desktop-core-reviewers ,whimboo,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D248324
2025-05-20 23:49:14 +00:00
agoloman
be704121b6 Bug 1879673 - disable browser_iframe_test.js for frequent failures on windows opt. r=aryx DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D248577
2025-05-09 10:23:09 +00:00
Joel Maher
2bb6ea02c5 Bug 1804441 - disable browser_screenshots_drag_scroll_test.js on macosx 15. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D248463
2025-05-08 21:38:29 +00:00
Niklas Baumgardner
a9afc3e1a0 Bug 1908205 - Switch to OffscreenCanvas and blobs for screenshots. r=sfoster,dimi
Differential Revision: https://phabricator.services.mozilla.com/D247483
2025-05-06 20:48:20 +00:00
Sam Foster
b3bd13a136 Bug 1721741 - Remove unused screenshots icons. r=niklas
- These are files housed in the components/screenshot directory but only previously referenced by
  the extension - which has now been removed.

Differential Revision: https://phabricator.services.mozilla.com/D244044
2025-04-02 15:12:52 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt
Differential Revision: https://phabricator.services.mozilla.com/D239937
2025-03-19 15:07:53 +00:00
Julian Gaibler
cfe48d85b9 Bug 1889754 - Standardize recurring user interface shadows as design tokens r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,reusable-components-reviewers,mtigley,credential-management-reviewers,sidebar-reviewers,hjones,willdurand,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D236008
2025-03-13 21:21:34 +00:00
Luca Greco
9b62e7c434 Bug 1948364 - part 3: Adjust BrowserGlue _monitorScreenshotsPref. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D238315
2025-03-06 16:24:02 +00:00
Gregory Pappas
408fd9c57f Bug 1925823 - Stop disabling screenshots component in mochitest r=urlbar-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D226241
2025-02-17 22:39:54 +00:00
Emilio Cobos Álvarez
76faa035d1 Bug 581863 - Fix screenshot test resize function when starting maximized.
When starting maximized the original target might not include
decorations or what not.
2025-02-03 23:06:07 +02:00
Emilio Cobos Álvarez
4eaad99f2b Bug 581863 - Fix nsWindow coordinates to make sense. r=stransky,win-reviewers,rkraesig,devtools-reviewers,ochameau
I stumbled upon this bug while realizing that some of the math I'm doing
for PiP windows doesn't work at all on Linux (bug 1934760), because
screenX != mozInnerScreenX, even though outerWidth == innerWidth.

I've tested this on X11 and Wayland (plasma and Gnome) with CSD and SSD,
and in general, this is the same thing Windows does, so should be fine.

The basic idea is:

 * Keep mBounds being frame manager bounds (so, outer* and screen*),
   relative to mShell.

 * Keep mClientMargin to translate from mBounds to client bounds.

This is both simpler and makes the math consistent.

Differential Revision: https://phabricator.services.mozilla.com/D230981
2025-02-03 17:08:44 +00:00
Alexandru Marc
ff52370de6 Backed out changeset 3b0d32c48d6b (bug 1925823) for causing mochitest failures @ browser.toml 2025-02-03 18:06:06 +02:00
Gregory Pappas
bb9537bfca Bug 1925823 - Stop disabling screenshots component in mochitest r=urlbar-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D226241
2025-02-03 14:55:59 +00:00
Sandor Molnar
c6d29a320f Bug 1917223 - Adjust skip-if annotations for linux asan failures @ 'browser_screenshots_focus_test.js'. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D234756
2025-01-17 22:34:27 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D233026
2025-01-07 19:51:49 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Sebastian Hengst
8424c52dc1 Bug 1922355 - macOS 14.70: adjust expectations for mochitests and xpcshell tests. r=jmaher,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228118
2024-11-19 17:19:24 +00:00
Gijs Kruitbosch
a17f03ba3d Bug 1926378 - put screenshots panel in the tabbox instead of the toolbox, r=niklas,mconley
Differential Revision: https://phabricator.services.mozilla.com/D226676
2024-10-24 16:35:08 +00:00
Jonathan Sudiaman
9e5735c395 Bug 1926647 - With new sidebar enabled, opening private windows always have the sidebar expanded. r=sidebar-reviewers,sclements
- Ensure that we don't load the backup state if a private window was spawned from a non-private one.
- Ensure that undefined values (i.e. missing backup state properties) are not used to set UI state.
- Remove setup functions that "pushed" existing tests to pass, as these concealed a real issue.

Differential Revision: https://phabricator.services.mozilla.com/D226716
2024-10-24 14:24:41 +00:00
Alexandru Marc
48d42baa5d Backed out changeset 8275003e3b48 (bug 1926378) for causing bc failures @ browser_keyboard_tests.js . CLOSED TREE 2024-10-24 15:18:50 +03:00
Gijs Kruitbosch
70013575ad Bug 1926378 - put screenshots panel in the browser stack instead of the toolbox, r=niklas,mconley
Differential Revision: https://phabricator.services.mozilla.com/D226676
2024-10-24 11:15:40 +00:00
Jonathan Sudiaman
b15a6918fd Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
2024-10-21 14:52:00 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Iulian Moraru
3ad5c1b803 Bug 1879673 - disable browser_iframe_test.js on windows 11 opt for causing frequent failures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D224580
2024-10-04 12:10:42 +00:00
Hanna Jones
53da99d2a0 Bug 1838298 - Part 2: fix color token usage in line with new Stylelint rule r=desktop-theme-reviewers,settings-reviewers,reusable-components-reviewers,home-newtab-reviewers,dao,thecount
Differential Revision: https://phabricator.services.mozilla.com/D222698
2024-09-27 14:58:41 +00:00
Sandor Molnar
5b461ba013 Bug 1894797 - Disable browser_test_moving_tab_to_new_window.js on win for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D222909
2024-09-25 13:01:51 +00:00
Florian Quèze
cd093f0a88 Bug 1918702 - Migrate telemetry events to use Glean APIs for screenshots, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D222607
2024-09-20 13:58:19 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D222841
2024-09-20 13:15:23 +00:00
Joel Maher
04cf186cea Bug 1917223 - re-enable many tests on browser/components/[pri*-urlbar]/**/browser.toml. r=aryx,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,urlbar-reviewers,dao,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D221309
2024-09-18 23:37:52 +00:00
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D221286
2024-09-06 10:08:18 +00:00
Emilio Cobos Álvarez
f8a088017c Bug 1916004 - Use a box shadow for chrome/content separator. r=dao,desktop-theme-reviewers,tabbrowser-reviewers
This makes it work in fullscreen and regardless of whether the sidebar
(or the toolbox for that matter) is shown.

Differential Revision: https://phabricator.services.mozilla.com/D220770
2024-09-02 17:30:03 +00:00
Emilio Cobos Álvarez
f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
2024-09-02 13:47:45 +00:00
Noemi Erli
90b5fb50ca Backed out changeset 10ac3f66133d (bug 1896232) for causing bug 1915806 CLOSED TREE 2024-08-30 16:33:37 +03:00
Niklas Baumgardner
0fc89881f5 Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216083
2024-08-29 03:21:44 +00:00
Nikki Sharpley
23a3a4bedd Bug 1910733 - Update content area and sidebar panel to have a border and box shadow. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sclements
In Bug 1886847, there was a discussion on how best to separate chrome from content
from chrome whilst remaining true to the new look. We landed on usiong both a box
shadow and border.

Differential Revision: https://phabricator.services.mozilla.com/D218126
2024-08-27 17:30:45 +00:00
Iulian Moraru
6faba7e3b9 Backed out 2 changesets (bug 1908205, bug 1896232) for causing bc assertion failures on nsUrlClassifierDBService.cpp. CLOSED TREE
Backed out changeset 859b4c639883 (bug 1908205)
Backed out changeset 519e88d21955 (bug 1896232)
2024-08-22 22:20:42 +03:00
Niklas Baumgardner
ae2879abd5 Bug 1908205 - Switch to OffscreenCanvas and blobs for screenshots. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216723
2024-08-22 18:36:48 +00:00
Niklas Baumgardner
b0381f7136 Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216083
2024-08-22 18:36:48 +00:00
Narcis Beleuzu
073a988929 Backed out 2 changesets (bug 1908205, bug 1896232) for causing mochitests failures . CLOSED TREE
Backed out changeset 873bbe70aa8c (bug 1908205)
Backed out changeset 0385fdac5693 (bug 1896232)
2024-08-19 19:04:38 +03:00
Niklas Baumgardner
10850a95fb Bug 1908205 - Switch to OffscreenCanvas and blobs for screenshots. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216723
2024-08-19 14:40:42 +00:00
Niklas Baumgardner
ee55b5699a Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216083
2024-08-19 14:40:42 +00:00
Niklas Baumgardner
8c2c80147f Bug 1910920 - Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D218244
2024-08-01 20:23:54 +00:00
Iulian Moraru
41bf68834e Backed out changeset d8c20788de55 (bug 1910920) for causing bc failures on browser_shadowRoot_test.js. CLOSED TREE 2024-08-01 18:44:01 +03:00
Niklas Baumgardner
1165a2d4ad Bug 1910920 - Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D218244
2024-08-01 14:01:16 +00:00