1169 Commits

Author SHA1 Message Date
Greg Stoll
b48f6f4035 Bug 1972786 - show various DLP agent errors for download operations a=diannaS
Show these errors in the download panel, etc.

Original Revision: https://phabricator.services.mozilla.com/D254295

Differential Revision: https://phabricator.services.mozilla.com/D258587
2025-07-24 20:20:47 +00:00
Greg Stoll
5a1af9a0bb Bug 1973005 - don't open about:blank when double-clicking on blocked download a=diannaS
I looked into using gInitialPages instead of hard-coding "about:blank",
but:
- there's no convenient window or browser here to access gInitialPages
- We hard-code "about:blank" many other places in source, so its
  "specialness" is already pretty well established.

Original Revision: https://phabricator.services.mozilla.com/D254871

Differential Revision: https://phabricator.services.mozilla.com/D258221
2025-07-23 17:33:51 +00:00
Greg Stoll
0c41490ff1 Bug 1965504 part 7 - add tests for Content Analysis Downloads a=diannaS
There are more things we could test in the future (like clicking
buttons on the Downloads panel to block/unblock for WARN responses) but
this is a good first step.

Original Revision: https://phabricator.services.mozilla.com/D251883

Differential Revision: https://phabricator.services.mozilla.com/D258209
2025-07-23 17:33:18 +00:00
Greg Stoll
099ed944b9 Bug 1965504 part 5 - integrate Content Analysis into Downloads a=diannaS
The actual call to content analysis is in DownloadCore.sys.mjs's
_checkReputationAndMove() method.

Original Revision: https://phabricator.services.mozilla.com/D251881

Differential Revision: https://phabricator.services.mozilla.com/D258207
2025-07-23 17:33:12 +00:00
Alexandru Marc
43acd12a3b Revert "Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau" for causing multiple failures
This reverts commit 585626d8fc.

Revert "Bug 1955685 - Improve cookie validation - part 6 - CookieValidation for web-ext, r=robwu,cookie-reviewers,valentin"

This reverts commit b38d308433.

Revert "Bug 1955685 - Improve cookie validation - part 5 - 0x20 as invalid chars for cookie names and values r=valentin,cookie-reviewers"

This reverts commit 3578880f65.

Revert "Bug 1955685 - Improve cookie validation - part 4 - expiry validation, r=edgul,cookie-reviewers,valentin"

This reverts commit 26e16d402f.

Revert "Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu"

This reverts commit 433a4d736d.

Revert "Bug 1955685 - Improve cookie validation - part 2 - nsICookieValidation in cookieManager.addNative, r=edgul,cookie-reviewers,geckoview-reviewers,nalexander,glandium"

This reverts commit 818c2c1769.

Revert "Bug 1955685 - Improve cookie validation - part 1 - nsICookieValidation, r=edgul,cookie-reviewers"

This reverts commit 55ad680779.
2025-05-20 09:31:40 +00:00
Andrea Marchesini
585626d8fc Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D248600
2025-05-20 08:02:18 +00:00
Andrea Marchesini
433a4d736d Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu
Differential Revision: https://phabricator.services.mozilla.com/D244897
2025-05-20 08:02:03 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
shaneziegler
37f81a03af Bug 1954799 - Move new tab, new window, home button drag/drop handlers out of browser.js into ToolbarDropHandler.sys.mjs r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D242203
2025-03-21 14:37:32 +00:00
Gijs Kruitbosch
379c415ab8 Bug 1871624 - improve download panel mouse handling, r=emz
Differential Revision: https://phabricator.services.mozilla.com/D241213
2025-03-19 16:50:43 +00:00
Travis Long
7d3108f1a9 Bug 1947604 - Part 1: Glam Experiment temporary metric instrumentation (browser module). r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D241250
2025-03-13 13:17:25 +00:00
Tom Schuster
f81d16e706 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 16:13:13 +00:00
Sandor Molnar
bc9b3e4b97 Backed out 2 changesets (bug 1941365) for causing CSP related dt failures. CLOSED TREE
Backed out changeset b022efa3b9e7 (bug 1941365)
Backed out changeset 90c5b60c6163 (bug 1941365)
2025-02-26 17:28:48 +02:00
Tom Schuster
07c8930ba5 Bug 1941365 - Use a <?csp ?> processing instructions instead of a csp attribute. r=Gijs,settings-reviewers,devtools-reviewers,places-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D238474
2025-02-26 14:36:42 +00:00
Alexandru Marc
018ab1d1b6 Bug 1929561 - Disable browser_downloads_jsonview.js on linux1804 x64 for frequent failures r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D236434
2025-01-31 23:35:21 +00:00
Florian Quèze
0b414b3183 Bug 1935420 - Migrate histograms to use Glean APIs for DOWNLOADS_USER_ACTION_ON_BLOCKED_DOWNLOAD, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D234181
2025-01-27 13:47:10 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Tooru Fujisawa
eb9e7374aa Bug 1941792 - Stop using weak ref in DownloadsCommon.sys.mjs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234334
2025-01-16 03:22:47 +00:00
Cosmin Sabou
7f982d2b28 Bug 1775779 - Disable browser_download_spam_protection.js on linux ASan and win ccov for frequent failures. a=test-only 2025-01-11 02:38:12 +02:00
Simon Friedberger
f5a1121c40 Bug 1935974. Remove inline event handlers from downloadsPanel.inc.xhtml r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D231524
2024-12-09 13:42:59 +00:00
Sandor Molnar
4e7c322e35 Bug 1775779 - Adjust skip-if on win & linux platforms. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D227774
2024-11-05 18:11:02 +00:00
Marco Bonardo
2529872051 Bug 1909996 - Intermittent failure in browser_downloads_jsonview.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D227331
2024-11-04 13:14:02 +00:00
Tom Schuster
a58c9d67ad Bug 1924971 - Remove inline event handlers from downloadsSummary. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D226901
2024-10-31 08:20:07 +00:00
Tom Schuster
ee3e9f5452 Bug 1924971 - Remove inline event handlers from downloads richListBox. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D226617
2024-10-29 13:54:53 +00:00
Tom Schuster
1ca2b39adc Bug 1924971 - Remove inline popup handlers from the downloads panel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D225768
2024-10-29 13:54:52 +00:00
Tom Schuster
f72c8a0393 Bug 1924971 - Remove inline command handlers from the downloads panel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D225767
2024-10-29 13:54:52 +00:00
Florian Quèze
479cbfaa5e Bug 1923028 - Migrate scalars to use Glean APIs for downloads.*, r=chutten.
Depends on D225371

Differential Revision: https://phabricator.services.mozilla.com/D225372
2024-10-16 20:46:09 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D221307
2024-09-19 02:52:04 +00:00
Joel Maher
02bf7c92f9 Bug 1917073 - adjust skip-if -> run-if for browser/components/.../browser.toml. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,places-reviewers,mtigley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D221247
2024-09-16 06:12:31 +00:00
Emilio Cobos Álvarez
1456e6c370 Bug 1914223 - Don't manually import eventutils in browser tests. r=Gijs
It causes this line not to work:

  https://searchfox.org/mozilla-central/rev/cb5faf5dd5176494302068c553da97b4d08aa339/testing/mochitest/tests/SimpleTest/EventUtils.js#3254

And is just not needed. In fact in most of these it was just unused.

Differential Revision: https://phabricator.services.mozilla.com/D220727
2024-09-01 11:51:19 +00:00
Kagami Sascha Rosylight
ba7187147c Bug 1908729 - Part 6: Wait for inner-window-destroyed in iframe deletion test r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D217826
2024-07-30 13:54:01 +00:00
Benjamin VanderSloot
777a4c108a Bug 1908629 - Download request for JSON viewer documents was partitioned - r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D217106
2024-07-24 18:18:14 +00:00
Marco Bonardo
6991a17d39 Bug 1904022 - Create the check file in the initial download folder when checking for executable bits. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D217385
2024-07-24 14:03:44 +00:00
Marco Bonardo
52222550c7 Bug 1904023 - Provide the onStatusChange error message on the download when the failure is in nsExternalHelperAppService. r=Gijs
We can pass over the localized error message from nsExternalHelperAppService to
the downloads UI and show it to the user. That may help the user figuring out
why the download failed.
For now long messages are delegated to the tooltip.

Differential Revision: https://phabricator.services.mozilla.com/D217317
2024-07-24 14:03:14 +00:00
Tom Schuster
103f2cc65c Bug 1897477 - Remove inline event handlers from <command> for downloads. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D211191
2024-05-29 12:53:32 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
Hanna Jones
21849b1def Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
9413513b0d Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Sebastian Hengst
ec02da26f3 Backed out changeset 20b5e4b2f448 (bug 1877195) for breaking HTTP downloads (bug 1892069) 2024-04-18 17:20:00 +02:00
Yi Xiong Wong
f2407af717 Bug 1880914 - Move BrowserDownloadsUI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D206201
2024-04-15 10:22:45 +00:00
Gregory Pappas
9d134e22f7 Bug 1878629 - part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/) r=tabbrowser-reviewers,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D201043
2024-03-06 19:27:10 +00:00
Christoph Kerschbaumer
2bc2cff698 Bug 1877195: Expand mixed-content download protection to all http downloads, r=freddyb,Gijs,anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D200267
2024-03-04 15:18:23 +00:00
Cosmin Sabou
f9ff487c03 Backed out changeset a89ec49d7645 (bug 1877195) for causing wpt failures on iframe_sandbox_window_open_download_allow_downloads. CLOSED TREE 2024-03-04 16:24:27 +02:00
Christoph Kerschbaumer
967443a323 Bug 1877195: Expand mixed-content download protection to all http downloads, r=freddyb,Gijs,anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D200267
2024-03-04 10:03:18 +00:00
Dave Townsend
a03a40ae9a Bug 1864896: Autofix unused function arguments (downloads). r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D202963
2024-03-03 09:09:10 +00:00