168 Commits

Author SHA1 Message Date
Alexandru Marc
43acd12a3b Revert "Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau" for causing multiple failures
This reverts commit 585626d8fc.

Revert "Bug 1955685 - Improve cookie validation - part 6 - CookieValidation for web-ext, r=robwu,cookie-reviewers,valentin"

This reverts commit b38d308433.

Revert "Bug 1955685 - Improve cookie validation - part 5 - 0x20 as invalid chars for cookie names and values r=valentin,cookie-reviewers"

This reverts commit 3578880f65.

Revert "Bug 1955685 - Improve cookie validation - part 4 - expiry validation, r=edgul,cookie-reviewers,valentin"

This reverts commit 26e16d402f.

Revert "Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu"

This reverts commit 433a4d736d.

Revert "Bug 1955685 - Improve cookie validation - part 2 - nsICookieValidation in cookieManager.addNative, r=edgul,cookie-reviewers,geckoview-reviewers,nalexander,glandium"

This reverts commit 818c2c1769.

Revert "Bug 1955685 - Improve cookie validation - part 1 - nsICookieValidation, r=edgul,cookie-reviewers"

This reverts commit 55ad680779.
2025-05-20 09:31:40 +00:00
Andrea Marchesini
585626d8fc Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D248600
2025-05-20 08:02:18 +00:00
Andrea Marchesini
433a4d736d Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu
Differential Revision: https://phabricator.services.mozilla.com/D244897
2025-05-20 08:02:03 +00:00
Mark Banner
8a3c99b9cb Bug 1966662 - Migrate most of toolkit/components/search to moz-src uris. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D249563
2025-05-17 17:38:49 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D234113
2025-01-22 05:59:40 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Mike Conley
3bb69687fc Bug 1924095 - Don't regenerate backups when cookies are removed by the site. r=backup-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D227865
2024-11-06 21:18:18 +00:00
Mike Conley
091ca7e7af Bug 1908732 - Add event probes for the backup component. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221660
2024-11-06 15:26:54 +00:00
Mike Conley
5504e6700c Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-11-05 18:49:00 +00:00
Stanca Serban
708727fac6 Backed out changeset 334773fe02f0 (bug 1908727) for causing codecs failures. 2024-11-04 23:49:46 +02:00
Mike Conley
69ffa598ec Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-11-04 20:22:54 +00:00
Sandor Molnar
8e1180f323 Backed out changeset 1d68ad927ddb (bug 1908727) for causing bc failures @ browser_startup_mainthreadio.js CLOSED TREE 2024-10-17 21:16:17 +03:00
Mike Conley
a28d8661d3 Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-10-17 16:29:47 +00:00
Mike Conley
69fe481887 Bug 1890427 - Part 11: Avoid regenerating when scheduled backups disabled, and deleting non-existant backup destination folder. r=backup-reviewers,kpatenio
We don't want to regenerate a backup if scheduled backups are disabled, so
we now do a check inside of the DeferredTask for the scheduling pref before
attempting a regeneration.

The prior patches in this stack cause us to attempt to delete any known
backups when doing certain clearing operations. If a backup destination
folder was not configured or is pointing at a non-existant directory,
this can cause us to throw. This is non-fatal but annoying.

This patch is some belt-and-suspenders which changes the behaviour so that:

1. Deletion is not attempted if scheduled backups are not enabled.
2. The backup destination pref is checked for non-empty values before
   attempting to check its existence.
3. The existence check is wrapped in a try/catch in the event that
   the destination pref is set to an invalid path for the OS.

Differential Revision: https://phabricator.services.mozilla.com/D221478
2024-09-18 13:32:12 +00:00
Mike Conley
b7bcb4dc52 Bug 1890427 - Part 10: Use an observer to regenerate backups on newtab links being blocked. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218880
2024-09-18 13:32:11 +00:00
Mike Conley
5d294d5f3d Bug 1890427 - Part 9: Use an observer to regenerate backups on cookie removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218879
2024-09-18 13:32:11 +00:00
Mike Conley
c38ff72c4c Bug 1890427 - Part 8: Use an observer to regenerate backups on permission removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218878
2024-09-18 13:32:10 +00:00
Mike Conley
1e876ebf64 Bug 1890427 - Part 7: Use an observer to regenerate backups on data sanitization. r=backup-reviewers,kpatenio
This also reorganizes things a bit in BackupService so that uninitBackupScheduler
also disarms the debouncer and any queued debounced jobs end up being inert.

Differential Revision: https://phabricator.services.mozilla.com/D218877
2024-09-18 13:32:10 +00:00
Mike Conley
d811f82945 Bug 1890427 - Part 6: Use an observer to regenerate backups when an address is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218876
2024-09-18 13:32:10 +00:00
Mike Conley
051850805e Bug 1890427 - Part 5: Use an observer to regenerate backups when a payment method is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218875
2024-09-18 13:32:09 +00:00
Mike Conley
89ce1cb51b Bug 1890427 - Part 4: Use an AddonListener to regenerate backups when an addon is uninstalled. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218874
2024-09-18 13:32:09 +00:00
Mike Conley
5e0572f68f Bug 1890427 - Part 3: Use a PlacesObserver to regenerate backups when a bookmark is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218886
2024-09-18 13:32:08 +00:00
Mike Conley
67293d208f Bug 1890427 - Part 2: Use an observer to regenerate backups when a password is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218873
2024-09-18 13:32:08 +00:00
Mike Conley
9570092c28 Bug 1890427 - Part 1: Use a PlacesObserver to regenerate backups when pages are removed or history is cleared. r=backup-reviewers,kpatenio
This debounces backup regenerations using a DeferredTask.

Differential Revision: https://phabricator.services.mozilla.com/D218872
2024-09-18 13:32:07 +00:00
Mike Conley
154be6716d Bug 1914940 - Do not back up permissions or content prefs databases if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221552
2024-09-17 13:54:28 +00:00
Mike Conley
b4e120a34f Bug 1914936 - Do not back up cookies if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221551
2024-09-17 13:54:27 +00:00
Mike Conley
c052d17afd Bug 1914926 - Do not back up form history if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,places-reviewers,mak,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221550
2024-09-17 13:54:27 +00:00
Butkovits Atila
9095b72df7 Backed out 10 changesets (bug 1890427) for causing failures at LateWriteChecks.cpp. CLOSED TREE
Backed out changeset b3ea334a7968 (bug 1890427)
Backed out changeset 8534805fac67 (bug 1890427)
Backed out changeset 2b31d978a116 (bug 1890427)
Backed out changeset f1db7acebebe (bug 1890427)
Backed out changeset 57b90c2b57be (bug 1890427)
Backed out changeset c72168ca8f99 (bug 1890427)
Backed out changeset 6ccf8483a0c1 (bug 1890427)
Backed out changeset 76ac3e81db91 (bug 1890427)
Backed out changeset 6599f4c9d1cb (bug 1890427)
Backed out changeset 054da7263696 (bug 1890427)
2024-09-05 01:05:36 +03:00
Mike Conley
7e5dab7371 Bug 1910968 - Make sure unverified search engines stay unverified during backup recovery. r=Standard8,backup-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218656
2024-09-04 18:04:49 +00:00
Mike Conley
51225be16e Bug 1890427 - Part 10: Use an observer to regenerate backups on newtab links being blocked. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218880
2024-09-04 17:56:59 +00:00
Mike Conley
4887d56637 Bug 1890427 - Part 9: Use an observer to regenerate backups on cookie removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218879
2024-09-04 17:56:59 +00:00
Mike Conley
b9636f86f1 Bug 1890427 - Part 8: Use an observer to regenerate backups on permission removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218878
2024-09-04 17:56:58 +00:00
Mike Conley
7ca5c1c77a Bug 1890427 - Part 7: Use an observer to regenerate backups on data sanitization. r=backup-reviewers,kpatenio
This also reorganizes things a bit in BackupService so that uninitBackupScheduler
also disarms the debouncer and any queued debounced jobs end up being inert.

Differential Revision: https://phabricator.services.mozilla.com/D218877
2024-09-04 17:56:58 +00:00
Mike Conley
2d3cbfc487 Bug 1890427 - Part 6: Use an observer to regenerate backups when an address is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218876
2024-09-04 17:56:57 +00:00
Mike Conley
01d75928e9 Bug 1890427 - Part 5: Use an observer to regenerate backups when a payment method is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218875
2024-09-04 17:56:57 +00:00
Mike Conley
a0f2bc1d52 Bug 1890427 - Part 4: Use an AddonListener to regenerate backups when an addon is uninstalled. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218874
2024-09-04 17:56:57 +00:00
Mike Conley
b54ccf35a1 Bug 1890427 - Part 3: Use a PlacesObserver to regenerate backups when a bookmark is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218886
2024-09-04 17:56:56 +00:00
Mike Conley
a534022f9b Bug 1890427 - Part 2: Use an observer to regenerate backups when a password is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218873
2024-09-04 17:56:56 +00:00
Mike Conley
5c50c56a5d Bug 1890427 - Part 1: Use a PlacesObserver to regenerate backups when pages are removed or history is cleared. r=backup-reviewers,kpatenio
This debounces backup regenerations using a DeferredTask.

Differential Revision: https://phabricator.services.mozilla.com/D218872
2024-09-04 17:56:55 +00:00
Mike Conley
d23cddd9e6 Bug 1893485 - Add the profileGroupID to the backup manifest. r=backup-reviewers,kpatenio
This is a BackupManifest schema change that will break recovering from
any backups created before this change. However, considering that we
haven't released this feature yet, I figured it wasn't worth the
effort of doing a schema version bump or handling of the prior
version.

I'm making the field optional in the BackupManifest because in the
event that we decide to backport the backup component to ESR 115,
we need to handle the fact that ESR 115 has no notion of a profile
group ID (and is unlikely to ever have such a notion).

Differential Revision: https://phabricator.services.mozilla.com/D218976
2024-09-04 17:39:33 +00:00
Mark Banner
93484bda6a Bug 1911981 - Replace use of SearchTestUtils.useTestEngines with setRemoteSettingsConfig in non-search test code. r=mbeier,backup-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219894
2024-08-27 16:01:45 +00:00
Mike Conley
99a19484ba Bug 1896449 - Recompute verification hashes for non-default engines during backup recovery. r=backup-reviewers,search-reviewers,Standard8,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D215963
2024-07-31 19:38:20 +00:00
Stephen Thompson
98746465d5 Bug 1907625 - Measure final backup archive size r=backup-reviewers,mconley
Measure final backup archive size to nearest mebibyte in order to understand how much disk space we are using on users' computers in order to back up their data

Differential Revision: https://phabricator.services.mozilla.com/D216708
2024-07-22 16:00:16 +00:00
Mike Conley
65f281083c Bug 1906912 - Make parseArchiveHeader resilient to partial Unicode characters in the buffer. r=mconley,backup-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216849
2024-07-18 15:59:46 +00:00
Mike Conley
0bb93129cd Bug 1902336 - Make sure to properly re-encrypt payment methods with the local OSKeyStore after backup recovery. r=backup-reviewers,sthompson
This also adds a fake nsIOSKeyStore implementation for our xpcshell tests. This
should allow us to run these tests on apple_silicon in automation.

Differential Revision: https://phabricator.services.mozilla.com/D215707
2024-07-12 17:48:04 +00:00
Stephen Thompson
323750a60a Bug 1891146 - Measure places, favicons, and total profile backup time r=places-reviewers,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214983
2024-07-11 16:48:15 +00:00
Mike Conley
fb791f4457 Bug 1907136 - Don't forget to clear the last backup filename / timestamp preference caches when deleting the last backup. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D216201
2024-07-11 14:11:47 +00:00
Norisz Fay
3ef4a25161 Backed out changeset da52483d6274 (bug 1891146) for causing xpcshell failures on test_BackupService.js CLOSED TREE 2024-07-11 00:54:17 +03:00
Stephen Thompson
5afc105b07 Bug 1891146 - Measure places, favicons, and total profile backup time r=places-reviewers,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214983
2024-07-10 20:25:10 +00:00