corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,699 Commits 1 Branch 0 Tags
current
Commit Graph

251 Commits

Author SHA1 Message Date
Iulian Moraru
7fadac62f4 Backed out changeset 8faf0e38aae6 (bug 1918745) for causing xpcshell failures on test_NimbusRolloutMessageProvider.js. 2024-09-16 22:08:37 +03:00
negin
0dd29c39bf Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya 
Adds `FOX_DOODLE_SET_DEFAULT` and `FAKESPOT_CALLOUT_` and removes `Q4_DEVICE_MIGRATION` and `ADDONS_STAFF_PICK` as part of live rollouts.


```
Processing rollout: 1-click-set-to-default-existing-profiles-rollout
  Processing branch: treatment-b
    Importing message: FOX_DOODLE_SET_DEFAULT
Processing rollout: us-review-checker-rollout-v2
  Processing branch: treatment-a
    Importing message 1 of 4: FAKESPOT_CALLOUT_NO_OP_DUMMY
    Importing message 2 of 4: FAKESPOT_CALLOUT_CLOSED_NOT_OPTED_IN_AUTO_OPEN
    Importing message 3 of 4: FAKESPOT_CALLOUT_PDP_NOT_OPTED_IN_REMINDER
    Importing message 4 of 4: FAKESPOT_CALLOUT_OPTED_OUT_SURVEY
Processing rollout: recommend-add-ons-staff-pick-relaunch-treatment-a-rollout
```

Differential Revision: https://phabricator.services.mozilla.com/D222151
 2024-09-16 17:17:01 +00:00
hanna alemu
8bb0544d31 Bug 1915019 - Include hidden and isBuiltin in addonsInfo targeting values r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D222174
 2024-09-16 13:12:02 +00:00
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky 
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
 2024-09-16 09:13:30 +00:00
Sebastian Hengst
2cc2b0108b Bug 1892548 - disable browser_asrouter_infobar.js on Linux debug for frequent intermittent failures. r=intermittent-reviewers,omc-reviewers,ahal,hanna_a DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D221794
 2024-09-12 21:25:30 +00:00
Jason Prickett
6d13ee8ae8 Bug 1912351 - Create onSearch trigger and targeting r=mviar,omc-reviewers,urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D219519
 2024-08-27 16:46:02 +00:00
hanna alemu
698a6834b4 Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 15:09:21 +00:00
Tamas Szentpeteri
03b8b4ec2d Backed out changeset 8e5aa4b063cc (bug 1901261) for causing py3 failures on make-schemas.py. CLOSED TREE 2024-07-31 17:13:20 +03:00
hanna alemu
f04c2799bc Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 13:21:47 +00:00
Nipun Shukla
415fe6c69b Bug 1905090 - Update strings to reflect MSIX pin to start functionality r=fluent-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mak,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D216709
 2024-07-24 21:13:36 +00:00
Nipun Shukla
8d8dd02d0f Bug 1901621 - Use start menu pinning as targeting for messages r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers ,pdahiya,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D213158
 2024-07-24 21:13:35 +00:00
Alex Cottner
998694aa4b Bug 1889617 - Enabling the new attachment bundling capability for IntermediatePreloads. r=leplatrem,gbeckley,keeler,omc-reviewers,emcminn 
Depends on D216814.
This patch enables the new attachment bundling/extraction logic for the intermediate certificate downloads.

In my local testing, this gives a significant improvement in the time it takes to download and unpack all the intermediate attachments.

Testing on my laptop (linux laptop on good wifi and gigiabit).
Before: 3.2-4.1 seconds to download and unpack
After: 0.75-0.95 seconds to download and unpack

Would love to pull before/after data for a variety of devices.

Differential Revision: https://phabricator.services.mozilla.com/D216815
 2024-07-23 16:16:10 +00:00
Cristina Horotan
77f34279ed Backed out changeset 3cd5c74698b5 (bug 1899747) for causing bc failures at browser_feature_callout.js CLOSED TREE 2024-07-03 03:34:37 +03:00
hanna alemu
6e75b37b22 Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D213239
 2024-07-02 23:44:49 +00:00
Shane Hughes
dea4e0688d Bug 1903684 - Fix browser_spotlight_default_messages accessible failure. r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D214350
 2024-06-26 19:06:45 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D214240
 2024-06-26 16:03:23 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
17ca553f9d Bug 1899030 - Part 5: Remove miscellaneous unused asrouter code from newtab. r=mconley,omc-reviewers,frontend-codestyle-reviewers,pdahiya 
Also update nimbus rollout message provider.

Differential Revision: https://phabricator.services.mozilla.com/D211673
 2024-06-19 19:45:02 +00:00
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211670
 2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Meg Viar
82932a56de Bug 1897804 - Fox Doodle Spotlight and Fox Doodle Set Default enrollment targeting should exclude First Run r=omc-reviewers,pdahiya 
This patch updates the targeting for two in-tree messages that include “source == ‘startup’” in their targeting and are triggered on default browser check. There are currently edge cases where these messages can collide with about:welcome. See [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1897804#c4 | this comment ]] for steps to replicate an example.

By adding additional targeting that ensures this isn’t the user’s first session, we can avoid about:welcome collisions.

Differential Revision: https://phabricator.services.mozilla.com/D213456
 2024-06-18 11:32:42 +00:00
Shane Hughes
b7111cb1ca Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-18 10:42:27 +00:00
Stanca Serban
47ba18b7d7 Backed out changeset f6ca02568bef (bug 1899439) for causing xcpshell failures in xpcshell/test_PanelTestProvider.js. CLOSED TREE 2024-06-18 05:14:28 +03:00
Shane Hughes
91acd11433 Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-17 17:52:59 +00:00
Shane Hughes
039ba4cf7a Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 23:05:10 +00:00
Aron Cseh
f28964fa3c Backed out changeset 98c3d77b4330 (bug 1899757) for causing multiple failures CLOSED TREE 2024-06-16 23:21:14 +03:00
Shane Hughes
6ef1ca7a31 Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 19:11:41 +00:00
hanna alemu
d7c67f44bd Bug 1828508 - Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209404
 2024-06-11 18:24:35 +00:00
Shane Hughes
8dd336f8c5 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D208941
 2024-05-02 20:54:51 +00:00
Punam Dahiya
77134726ce Bug 1775847 - Fix intermittent milestone message and accessibility cfr test failure r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D208761
 2024-04-26 16:38:10 +00:00
Barret Rennie
0633e0cca7 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-24 20:15:19 +00:00
gravyant
e950fb5069 Bug 1869065 - Re-visit some of the element property names used in moz-message-bar. r=hjones,reusable-components-reviewers,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207897
 2024-04-23 21:27:46 +00:00
Nipun Shukla
87498965b0 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207595
 2024-04-23 14:08:52 +00:00
Iulian Moraru
b2f394db04 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
b288396795 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-22 17:57:31 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D190612
 2024-04-22 16:24:30 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-28 16:26:14 +00:00
Punam Dahiya
6a384e0ba4 Bug 1859302 - NimbusRolloutMessageProvider should be listed as a generated file r=omc-reviewers,aminomancer 
Patch invokes `import-rollouts` script that import Nimbus Rollout messages into NimbusRolloutMessageProvider.sys.mjs when running test using ` ./mach npm run test --prefix browser/components/asrouter`

Differential Revision: https://phabricator.services.mozilla.com/D205777
 2024-03-27 22:12:31 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D204843
 2024-03-19 22:08:29 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
 2024-03-19 17:01:38 +00:00
Mark Banner
d534b7b6ee Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D204441
 2024-03-13 17:38:28 +00:00
Shane Hughes
1a451ad5bc Bug 1775847 - Fix Glean timeout in browser_asrouter_cfr.js. r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D202078
 2024-03-07 19:03:28 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203330
 2024-03-02 02:36:24 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE 
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
 2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE 
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
 2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-01 10:10:08 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D202255
 2024-02-27 18:52:20 +00:00