237 Commits

Author SHA1 Message Date
Mark Banner
8bf730ccd9 Bug 1881701 - Move ESLint ignores and test paths to be module files as well. r=frontend-codestyle-reviewers,devtools-reviewers,Gijs,nchevobbe
This completes the moving of all the top-level configuration files to be ES modules, and named similarily.

Differential Revision: https://phabricator.services.mozilla.com/D250403
2025-05-24 17:11:39 +00:00
Mark Banner
ce1e9e39d2 Bug 1881701 - Add toolkit/modules/third_party to ThirdPartyPaths.txt. r=frontend-codestyle-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D249955
2025-05-24 17:11:25 +00:00
Mark Banner
1ffc73325a Bug 1881701 - Switch the main ESLint configuration to use the flat configuration. r=frontend-codestyle-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D249952
2025-05-24 17:11:14 +00:00
agoloman
636d57b8c0 Revert (Bug 1965313, Bug 1955298) - for causing xpc and bc failures.
This reverts commit d810bb578e.

Revert "Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers"

This reverts commit fe3e643fee.
2025-05-23 15:52:35 +00:00
Ben Dean-Kawamura
fe3e643fee Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers
Updated the uniffi-bindgen-gecko-js code to use two things I've been
experimenting with:

* Use the IR pipeline code to generate the structs used to render the
  templates.
* A new test fixture for bindings generators.  This one targets bindings
  generators specifically, it doesn't try test the scaffolding code and
  it's not based on real-world example code.  I originally thought it
  would be a single crate, but I ended up needed 2 in order to test
  external types. (https://bugzilla.mozilla.org/show_bug.cgi?id=1948961)

Differential Revision: https://phabricator.services.mozilla.com/D242385
2025-05-23 14:21:55 +00:00
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
ec5fa1d4c0 Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D248105
2025-05-21 03:55:17 +00:00
hannajones
c05f675ddf Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D249174
2025-05-21 03:54:40 +00:00
Alexandru Marc
13387e6e59 Revert "Bug 1965313 - Reimplement enum discriminents, r=bgruber" for causing py3 failures
This reverts commit bcf4989b84.

Revert "Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers"

This reverts commit 6e1a647b81.
2025-05-20 16:15:02 +00:00
Ben Dean-Kawamura
6e1a647b81 Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers
Updated the uniffi-bindgen-gecko-js code to use two things I've been
experimenting with:

* Use the IR pipeline code to generate the structs used to render the
  templates.
* A new test fixture for bindings generators.  This one targets bindings
  generators specifically, it doesn't try test the scaffolding code and
  it's not based on real-world example code.  I originally thought it
  would be a single crate, but I ended up needed 2 in order to test
  external types. (https://bugzilla.mozilla.org/show_bug.cgi?id=1948961)

Differential Revision: https://phabricator.services.mozilla.com/D242385
2025-05-20 14:51:59 +00:00
Sandor Molnar
54f63424a1 Revert "Bug 1965313 - Reimplement enum discriminents, r=bgruber"
This reverts commit 02d50105b9.

Revert "Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers"

This reverts commit 90368cc237.
2025-05-14 22:15:45 +00:00
Ben Dean-Kawamura
90368cc237 Bug 1955298 - uniffi-bindgen-gecko-js: start using the IR pipeline, r=markh,frontend-codestyle-reviewers
Updated the uniffi-bindgen-gecko-js code to use two things I've been
experimenting with:

* Use the IR pipeline code to generate the structs used to render the
  templates.
* A new test fixture for bindings generators.  This one targets bindings
  generators specifically, it doesn't try test the scaffolding code and
  it's not based on real-world example code.  I originally thought it
  would be a single crate, but I ended up needed 2 in order to test
  external types. (https://bugzilla.mozilla.org/show_bug.cgi?id=1948961)

Differential Revision: https://phabricator.services.mozilla.com/D242385
2025-05-14 21:15:20 +00:00
Alexandre Poirot
833ef8762c Bug 1958081 - [devtools] Introduce a test framework to ease testing all possible JavaScript types against various codebases. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D244246
2025-05-13 12:34:02 +00:00
Serban Stanca
1dac11cfa9 Revert "Bug 1958081 - [devtools] Cover JS Tracer stringification with the new JS Objects test framework. r=devtools-reviewers,nchevobbe" for causing devtools failures in browser_webconsole_reverse_search.js.
This reverts commit a07e576742.

This reverts commit f0b5190845.

This reverts commit 1761d4c3dd.
2025-05-08 23:00:24 +00:00
Alexandre Poirot
1761d4c3dd Bug 1958081 - [devtools] Introduce a test framework to ease testing all possible JavaScript types against various codebases. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D244246
2025-05-08 20:04:57 +00:00
Cristina Horotan
539746f658 Revert "Bug 1958081 - [devtools] Cover JS Tracer stringification with the new JS Objects test framework. r=devtools-reviewers,nchevobbe" for xpcshell failures at test_javascript_logging.js
This reverts commit 6056567c3e.

Revert "Bug 1958081 - [devtools] Migrate object inspector to the new JS objects test framework. r=devtools-reviewers,nchevobbe"

This reverts commit 8cbc65e7b5.

Revert "Bug 1958081 - [devtools] Introduce a test framework to ease testing all possible JavaScript types against various codebases. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,Standard8" for causing xpc failures at test_javascript_logging.js

This reverts commit ddcbf73cd8.
2025-05-08 05:42:19 +00:00
Alexandre Poirot
ddcbf73cd8 Bug 1958081 - [devtools] Introduce a test framework to ease testing all possible JavaScript types against various codebases. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D244246
2025-05-08 04:05:01 +00:00
Mark Banner
3cbf9cd24d Bug 1962375 - Enable Prettier and file-perm linters for .ts files. r=zombie,linter-reviewers,profiler-reviewers,translations-reviewers,frontend-codestyle-reviewers,ahal,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D246622
2025-04-29 16:21:01 +00:00
Mark Banner
212ad7ecdf Bug 1962375 - Move generated typescript files to a generated/ sub-directory and add to Generated.txt. r=zombie,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D246621
2025-04-29 16:21:01 +00:00
Mark Banner
489c038ca6 Bug 1962375 - Move builtin-newtab.js to a better place in .prettierignore. r=frontend-codestyle-reviewers
This matches the position that it is in within .eslintrc-ignore.js

Differential Revision: https://phabricator.services.mozilla.com/D246620
2025-04-29 16:21:00 +00:00
mark
b985885680 Bug 1962273 - Make Code Connect Figma files Prettier r=reusable-components-reviewers,frontend-codestyle-reviewers,mstriemer,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D246514
2025-04-29 16:21:00 +00:00
Mark Striemer
2a25593516 Bug 1953327 - Part 2: Tests for setting-group r=reusable-components-reviewers,settings-reviewers,mossop,hjones,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D245480
2025-04-24 21:17:29 +00:00
Mark Striemer
ec66fa8068 Bug 1953327 - Part 1: Test Setting from preferencesBindings.js r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D245479
2025-04-24 21:17:29 +00:00
Rob Wu
dd530bf594 Bug 1960285 - Add details to "Extension is invalid" error r=rpl,devtools-reviewers,frontend-codestyle-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D245391
2025-04-16 21:52:02 +00:00
Mike Conley
93b678639e Bug 1949519 - Part 2: Load locales from XPI when newtab is running from that XPI. r=willdurand,eemeli,home-newtab-reviewers,frontend-codestyle-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D244596
2025-04-15 21:07:49 +00:00
Mike Conley
13c783bbce Bug 1949519 - Part 1: Add mach command to pull in latest newtab strings for built-in addon and generate a report. r=ahal,eemeli,home-newtab-reviewers,frontend-codestyle-reviewers,mossop,nbarrett
This also includes the first report and a recent pull of the newtab
strings using the supplied command.

Differential Revision: https://phabricator.services.mozilla.com/D244249
2025-04-15 21:07:49 +00:00
Ben Dean-Kawamura
c7d555e585 Bug 1951241 - Refactor ScaffoldingConverter.h, r=markh,nika,frontend-codestyle-reviewers
Replaced `ScaffoldingConverter` with a set of `FfiValue*` classes.  The
differences are:

* The new classes better match other `uniffi-bindgen-gecko-js` names,
  and also use familiar UniFFI terms like `Lift` and `Lower`.
* Object handles are now freed if there's an error.
* The new classes store the FFI value internal rather than defining an
  `IntermediateType` associated type.
* Moved header files into `mozilla/uniffi/` and removed the `UniFFI`
  prefix from the filename.  This avoids weird filenames like
  `UniFFIFfiValue.h`

Differential Revision: https://phabricator.services.mozilla.com/D240696
2025-04-11 16:49:50 +00:00
Narcis Beleuzu
2dbc8ca1dc Backed out 2 changesets (bug 1951243, bug 1951241) for causing bustages on GeneratedScaffolding.cpp . CLOSED TREE
Backed out changeset 944bac64c3db (bug 1951243)
Backed out changeset c79b66ed7283 (bug 1951241)
2025-04-11 17:13:02 +03:00
Ben Dean-Kawamura
02e1f4d5fd Bug 1951241 - Refactor ScaffoldingConverter.h, r=markh,nika,frontend-codestyle-reviewers
Replaced `ScaffoldingConverter` with a set of `FfiValue*` classes.  The
differences are:

* The new classes better match other `uniffi-bindgen-gecko-js` names,
  and also use familiar UniFFI terms like `Lift` and `Lower`.
* Object handles are now freed if there's an error.
* The new classes store the FFI value internal rather than defining an
  `IntermediateType` associated type.
* Moved header files into `mozilla/uniffi/` and removed the `UniFFI`
  prefix from the filename.  This avoids weird filenames like
  `UniFFIFfiValue.h`

Differential Revision: https://phabricator.services.mozilla.com/D240696
2025-04-11 12:58:06 +00:00
Maxx Crawford
30348e7a64 Bug 1956978 - Add newtab prerendered HTML directory to Generated.txt and .prettierignore r=home-newtab-reviewers,frontend-codestyle-reviewers,mossop,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D244419
2025-04-07 14:08:04 +00:00
zombie
9f087f1523 Bug 1954369 - Produce mapping of module paths and lazy module types r=Standard8
The simplest possible way to produce the mapping,
which works correctly for 99% of imported modules,
and the remaining few dozen can be mapped manually
in config/fixed_paths.js.

Differential Revision: https://phabricator.services.mozilla.com/D241762
2025-03-26 12:20:39 +00:00
Tom Schuster
27fc8656f4 Bug 1950605 - Sanitizer: Generate a default config based on the JSON files. r=emilio,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240044
2025-03-11 11:36:10 +00:00
Julian Descottes
31df1015da Bug 1952482 - Enable prettier for devtools/shared/commands/target r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe
The "target/" rule matches all folders named target regardless of the depth.
Removing redundant entries and adding an exclusion for the devtools folder.

Differential Revision: https://phabricator.services.mozilla.com/D240728
2025-03-10 10:20:40 +00:00
mark
66321019ff Bug 1945831 - Enable Prettier for chrome tests in toolkit/content/tests/widgets r=reusable-components-reviewers,frontend-codestyle-reviewers,Standard8,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D239743
2025-03-06 18:25:12 +00:00
Denis Palmeiro
d90d79d603 Bug 1951431: Add newssite-nuxt content to the mobile-startup performance testing location. r=aglavic,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240266
2025-03-06 17:41:43 +00:00
Cristian Tuns
6b3a67f292 Backed out 4 changesets (bug 1945831) for causing lint failures in test_moz_input_folder.html CLOSED TREE
Backed out changeset 996551e7d122 (bug 1945831)
Backed out changeset 0d0ae655f1ec (bug 1945831)
Backed out changeset 098b19084809 (bug 1945831)
Backed out changeset 12a7e1e91200 (bug 1945831)
2025-03-06 12:37:56 -05:00
mark
1d9768da1f Bug 1945831 - Enable Prettier for chrome tests in toolkit/content/tests/widgets r=reusable-components-reviewers,frontend-codestyle-reviewers,Standard8,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D239743
2025-03-06 14:13:15 +00:00
Greg Tatum
121327c607 Bug 1859081 - Move cld2 from toolkit/component/translation to translations; r=translations-reviewers,zeid,frontend-codestyle-reviewers,nordzilla
We developed the new translations codebase using an "s" at the end, and
retained the old translations code under "translation". At this point
I'm unifying it so that it's all under "translations", which involves a
rename of the existing code. This way we will be consistent in our
naming practice.

Differential Revision: https://phabricator.services.mozilla.com/D239047
2025-02-26 20:06:25 +00:00
Thomas Wisniewski
cc280c7bfa Bug 1945258 - Merge the webcompat addon's similar UA overrides and injections libraries to simplify the codebase; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236423
2025-02-05 15:03:23 +00:00
Mark Banner
8c04fee4da Bug 1942999 - Update .prettierignore exclusion lists, copying from Generated.txt and ThirdPartyPaths.txt. r=frontend-codestyle-reviewers,Gijs
The only significant change here is the re-arrangement of where PdfJsOverridePrefs.js is ignored - moving the main ignore to Generated.txt (it was already excluded from prettier, but not other linters).
The .prettierignore additions are copy/paste updates from the other files to help keep the lists in sync.

Differential Revision: https://phabricator.services.mozilla.com/D236675
2025-02-04 18:06:40 +00:00
Mark Banner
53e1386e3a Bug 1942999 - Improve newtab linter exclusions for generated files and tippytop images. r=mconley,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236674
2025-02-04 18:06:39 +00:00
Mike Conley
0cab9e0390 Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
2025-02-03 16:45:33 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
2025-02-03 18:28:59 +02:00
Mike Conley
5cc1e5190e Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
2025-02-03 15:07:10 +00:00
Thomas Wisniewski
5e0c1d2e01 Bug 1936031 - Move webcompat intervention configurations into a JSON file; r=jgraham,denschub,webcompat-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D231551
2025-01-30 16:23:13 +00:00
Andrew Osmond
71fe8eb9b8 Bug 1944456 - Update Chromium CDM headers to revision 06395a2863cb1ebdb47617a995b73f95c14fe120. r=media-playback-reviewers,frontend-codestyle-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D235875
2025-01-29 15:53:48 +00:00
Tooru Fujisawa
94bba12a39 Bug 1936051 - Part 15: Remove JSM handling from eslint config. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D233741
2025-01-23 12:09:37 +00:00
Punam Dahiya
cf58fbd5e3 Bug 1618001 - Move React vendored libraries to the toolkit to prevent multiple instances r=sylvestre,omc-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,firefox-ai-ml-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232431
2025-01-08 21:08:16 +00:00
Kagami Sascha Rosylight
b065b59406 Bug 1938086 - Remove exclusion of dom/push in eslintrc/prettierignore r=asuth,frontend-codestyle-reviewers
The changes are mostly about using console API directly and un-shadowing variable names.

Differential Revision: https://phabricator.services.mozilla.com/D232496
2024-12-19 18:49:38 +00:00
Beth Rennie
6875c7671d Bug 1929116 - Vendor schemas from mozilla-nimbus-schemas instead of mozilla-nimbus-shared r=chumphreys,frontend-codestyle-reviewers,Standard8
We're publishing updated schemas only to the mozilla-nimbus-schemas
package now, so we need to vendor them from there instead of
mozilla-nimbus-shared. Additionally, since the
github.com/mozilla/experimenter repo vendors the actual JSONSchema
files, we don't have to side-step the vendoring process with a custom
script and can use it how it was intended.

This updates us to mozilla-nimbus-schemas v2024.11.5.

Differential Revision: https://phabricator.services.mozilla.com/D227867
2024-11-19 22:18:43 +00:00