corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1478225 - Always propagate repaint change hint from html/body element to viewport frame. r=heycam

Browse Source 
Generally there isn't really much difference for painting on html/body
element vs. viewport, so it's probably not worth finer grained control
over when we should propagate and when not.

MozReview-Commit-ID: HK7DsQdz41D
This commit is contained in:
Xidorn Quan
2018-07-26 15:37:10 +10:00
parent 165ec76b10
commit ffceaf7bb9
5 changed files with 82 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
layout/base/RestyleManager.cpp
View File

@@ -18,6 +18,7 @@
#include "mozilla/ViewportFrame.h"
#include "mozilla/dom/ChildIterator.h"
#include "mozilla/dom/ElementInlines.h"
#include "mozilla/dom/HTMLBodyElement.h"
#include "Layers.h"
#include "LayerAnimationInfo.h" // For LayerAnimationInfo::sRecords
@@ -27,6 +28,7 @@
#include "nsContentUtils.h"
#include "nsCSSFrameConstructor.h"
#include "nsCSSRendering.h"
#include "nsIDocumentInlines.h"
#include "nsIFrame.h"
#include "nsIFrameInlines.h"
#include "nsImageFrame.h"
@@ -1129,6 +1131,42 @@ SyncViewsAndInvalidateDescendants(nsIFrame* aFrame, nsChangeHint aChange)
}
}
static bool
IsPrimaryFrameOfRootOrBodyElement(nsIFrame* aFrame)
{
nsIContent* content = aFrame->GetContent();
if (!content) {
return false;
}
nsIDocument* document = content->OwnerDoc();
Element* root = document->GetRootElement();
if (!root) {
return false;
}
nsIFrame* rootFrame = root->GetPrimaryFrame();
if (!rootFrame) {
return false;
}
if (aFrame == rootFrame) {
return true;
}
Element* body = document->GetBodyElement();
if (!body) {
return false;
}
nsIFrame* bodyFrame = body->GetPrimaryFrame();
if (!bodyFrame) {
return false;
}
if (aFrame == bodyFrame) {
return true;
}
return false;
}
static void
ApplyRenderingChangeToTree(nsIPresShell* aPresShell,
nsIFrame* aFrame,
@@ -1156,17 +1194,15 @@ ApplyRenderingChangeToTree(nsIPresShell* aPresShell,
gInApplyRenderingChangeToTree = true;
#endif
if (aChange & nsChangeHint_RepaintFrame) {
// If the frame's background is propagated to an ancestor, walk up to
// that ancestor and apply the RepaintFrame change hint to it.
ComputedStyle* bgSC;
nsIFrame* propagatedFrame = aFrame;
while (!nsCSSRendering::FindBackground(propagatedFrame, &bgSC)) {
propagatedFrame = propagatedFrame->GetParent();
NS_ASSERTION(aFrame, "root frame must paint");
}
if (propagatedFrame != aFrame) {
DoApplyRenderingChangeToTree(propagatedFrame, nsChangeHint_RepaintFrame);
// If the frame is the primary frame of either the body element or
// the html element, we propagate the repaint change hint to the
// viewport. This is necessary for background and scrollbar colors
// propagation.
if (IsPrimaryFrameOfRootOrBodyElement(aFrame)) {
nsIFrame* rootFrame = aFrame->
PresShell()->FrameConstructor()->GetRootFrame();
MOZ_ASSERT(rootFrame, "No root frame?");
DoApplyRenderingChangeToTree(rootFrame, nsChangeHint_RepaintFrame);
aChange &= ~nsChangeHint_RepaintFrame;
if (!aChange) {
return;