corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 371814 - undo-ing an item move in the organizer fails. r=dietrich.

Browse Source
This commit is contained in:
mozilla.mano@sent.com
2007-03-07 01:29:27 +00:00
parent 8005baedad
commit fe3fef7310
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
browser/components/places/content/controller.js
View File

@@ -78,10 +78,6 @@ const NEWLINE= "\n";
const NEWLINE = "\r\n"; const NEWLINE = "\r\n";
#endif #endif
// The minimum amount of transactions we should tell our observers to begin
// batching (rather than letting them do incremental drawing).
const MIN_TRANSACTIONS_FOR_BATCH = 5;
/** /**
* Represents an insertion point within a container where we can insert * Represents an insertion point within a container where we can insert
* items. * items.
@@ -1604,6 +1600,10 @@ PlacesBaseTransaction.prototype = {
return this._livemarks; return this._livemarks;
}, },
// The minimum amount of transactions we should tell our observers to begin
// batching (rather than letting them do incremental drawing).
MIN_TRANSACTIONS_FOR_BATCH: 5,
LOG: LOG, LOG: LOG,
redoTransaction: function PIT_redoTransaction() { redoTransaction: function PIT_redoTransaction() {
throw Cr.NS_ERROR_NOT_IMPLEMENTED; throw Cr.NS_ERROR_NOT_IMPLEMENTED;
@@ -1632,7 +1632,7 @@ PlacesAggregateTransaction.prototype = {
doTransaction: function() { doTransaction: function() {
this.LOG("== " + this._name + " (Aggregate) =============="); this.LOG("== " + this._name + " (Aggregate) ==============");
if (this._transactions.length >= MIN_TRANSACTIONS_FOR_BATCH) if (this._transactions.length >= this.MIN_TRANSACTIONS_FOR_BATCH)
this.bookmarks.beginUpdateBatch(); this.bookmarks.beginUpdateBatch();
for (var i = 0; i < this._transactions.length; ++i) { for (var i = 0; i < this._transactions.length; ++i) {
var txn = this._transactions[i]; var txn = this._transactions[i];
@@ -1640,14 +1640,14 @@ PlacesAggregateTransaction.prototype = {
txn.container = this.container; txn.container = this.container;
txn.doTransaction(); txn.doTransaction();
} }
if (this._transactions.length >= MIN_TRANSACTIONS_FOR_BATCH) if (this._transactions.length >= this.MIN_TRANSACTIONS_FOR_BATCH)
this.bookmarks.endUpdateBatch(); this.bookmarks.endUpdateBatch();
this.LOG("== " + this._name + " (Aggregate Ends) ========="); this.LOG("== " + this._name + " (Aggregate Ends) =========");
}, },
undoTransaction: function() { undoTransaction: function() {
this.LOG("== UN" + this._name + " (UNAggregate) ============"); this.LOG("== UN" + this._name + " (UNAggregate) ============");
if (this._transactions.length >= MIN_TRANSACTIONS_FOR_BATCH) if (this._transactions.length >= this.MIN_TRANSACTIONS_FOR_BATCH)
this.bookmarks.beginUpdateBatch(); this.bookmarks.beginUpdateBatch();
for (var i = this._transactions.length - 1; i >= 0; --i) { for (var i = this._transactions.length - 1; i >= 0; --i) {
var txn = this._transactions[i]; var txn = this._transactions[i];
@@ -1655,7 +1655,7 @@ PlacesAggregateTransaction.prototype = {
txn.container = this.container; txn.container = this.container;
txn.undoTransaction(); txn.undoTransaction();
} }
if (this._transactions.length >= MIN_TRANSACTIONS_FOR_BATCH) if (this._transactions.length >= this.MIN_TRANSACTIONS_FOR_BATCH)
this.bookmarks.endUpdateBatch(); this.bookmarks.endUpdateBatch();
this.LOG("== UN" + this._name + " (UNAggregate Ends) ======="); this.LOG("== UN" + this._name + " (UNAggregate Ends) =======");
} }