Bug 1473974 - Fix opening all tabs panel with cycle recent tabs r=dao

MozReview-Commit-ID: EGYJo8AAF2K

browser/base/content/browser-allTabsMenu.js

@@ -18,11 +18,15 @@ var gTabsPanel = {
     hiddenTabsView: "allTabsMenu-hiddenTabsView",
   },
   _initialized: false,
+  _initializedElements: false,
 
   initElements() {
+    if (this._initializedElements) return;
+
     for (let [name, id] of Object.entries(this.kElements)) {
       this[name] = document.getElementById(id);
     }
+    this._initializedElements = true;
   },
 
   init() {
@@ -124,9 +128,16 @@ var gTabsPanel = {
     this._initialized = true;
   },
 
+  get canOpen() {
+    this.initElements();
+    return isElementVisible(this.allTabsButton);
+  },
+
   showAllTabsPanel() {
     this.init();
-    PanelUI.showSubView(this.kElements.allTabsView, this.allTabsButton);
+    if (this.canOpen) {
+      PanelUI.showSubView(this.kElements.allTabsView, this.allTabsButton);
+    }
   },
 
   hideAllTabsPanel() {
@@ -136,6 +147,9 @@ var gTabsPanel = {
 
   showHiddenTabsPanel() {
     this.init();
+    if (!this.canOpen) {
+      return;
+    }
     this.allTabsView.addEventListener("ViewShown", (e) => {
       PanelUI.showSubView(this.kElements.hiddenTabsView, this.hiddenTabsButton);
     }, {once: true});

browser/base/content/browser-ctrlTab.js

@@ -294,7 +294,7 @@ var ctrlTab = {
     var showAllLabel = gNavigatorBundle.getString("ctrlTab.listAllTabs.label");
     this.showAllButton._label.setAttribute("value",
       PluralForm.get(this.tabCount, showAllLabel).replace("#1", this.tabCount));
-    this.showAllButton.hidden = !allTabs.canOpen;
+    this.showAllButton.hidden = !gTabsPanel.canOpen;
   },
 
   updatePreview: function ctrlTab_updatePreview(aPreview, aTab) {
@@ -570,7 +570,7 @@ var ctrlTab = {
         break;
       case "popupshowing":
         if (event.target.id == "menu_viewPopup")
-          document.getElementById("menu_showAllTabs").hidden = !allTabs.canOpen;
+          document.getElementById("menu_showAllTabs").hidden = !gTabsPanel.canOpen;
         break;
     }
   },
@@ -628,27 +628,3 @@ var ctrlTab = {
       key_showAllTabs.setAttribute("disabled", "true");
   }
 };
-
-
-/**
- * All Tabs menu
- */
-var allTabs = {
-  get toolbarButton() {
-    return document.getElementById("alltabs-button");
-  },
-
-  get canOpen() {
-    return isElementVisible(this.toolbarButton);
-  },
-
-  open: function allTabs_open() {
-    if (this.canOpen) {
-      // Without setTimeout, the menupopup won't stay open when invoking
-      // "View > Show All Tabs" and the menu bar auto-hides.
-      setTimeout(() => {
-        this.toolbarButton.open = true;
-      }, 0);
-    }
-  }
-};

browser/base/content/browser-sets.inc

@@ -81,7 +81,7 @@
     </command>
     <command id="Browser:NextTab" oncommand="gBrowser.tabContainer.advanceSelectedTab(1, true);"/>
     <command id="Browser:PrevTab" oncommand="gBrowser.tabContainer.advanceSelectedTab(-1, true);"/>
-    <command id="Browser:ShowAllTabs" oncommand="allTabs.open();"/>
+    <command id="Browser:ShowAllTabs" oncommand="gTabsPanel.showAllTabsPanel();"/>
     <command id="cmd_fullZoomReduce"  oncommand="FullZoom.reduce()"/>
     <command id="cmd_fullZoomEnlarge" oncommand="FullZoom.enlarge()"/>
     <command id="cmd_fullZoomReset"   oncommand="FullZoom.reset()"/>